Re: svn commit: r353732 - head/sys/net

> On Oct 18, 2019, at 08:20, Gleb Smirnoff wrote: > > Author: glebius > Date: Fri Oct 18 15:20:24 2019 > New Revision: 353732 > URL: https://svnweb.freebsd.org/changeset/base/353732 > > Log: > Make rt_getifa_fib() static. Why should it be made static? The answer to this question is missing f

Re: svn commit: r353732 - head/sys/net

> On Oct 22, 2019, at 08:26, Gleb Smirnoff wrote: > > On Tue, Oct 22, 2019 at 07:53:31AM -0700, Enji Cooper wrote: > E> > Author: glebius > E> > Date: Fri Oct 18 15:20:24 2019 > E> > New Revision: 353732 > E> > URL: https://svnweb.freebsd.org/

Re: svn commit: r353888 - head/sys/vm

> On Oct 22, 2019, at 08:59, Konstantin Belousov wrote: > > Author: kib > Date: Tue Oct 22 15:59:16 2019 > New Revision: 353888 > URL: https://svnweb.freebsd.org/changeset/base/353888 > > Log: > vm_fault(): extract code to lock the vnode into a helper > vn_fault_lock_vnode(). From an ex

Re: svn commit: r353937 - in head/share: man/man5 mk

> On Oct 23, 2019, at 10:02, Dimitry Andric wrote: > > Author: dim > Date: Wed Oct 23 17:02:45 2019 > New Revision: 353937 > URL: https://svnweb.freebsd.org/changeset/base/353937 > > Log: > Build toolchain components as dynamically linked executables by default > > Summary: > Historically,

svn commit: r354361 - head

Author: ngie Date: Tue Nov 5 17:33:27 2019 New Revision: 354361 URL: https://svnweb.freebsd.org/changeset/base/354361 Log: Remove picobsd(8) via `make delete-old` This completes the commit that removed picobsd(8) (r354346). MFC after:never Modified: head/ObsoleteFiles.inc Modi

Re: svn commit: r355164 - in head: . share/man/man4 sys/amd64/conf sys/conf sys/dev/trm sys/i386/conf sys/modules sys/modules/trm

> On Nov 27, 2019, at 6:32 PM, Scott Long wrote: > > Author: scottl > Date: Thu Nov 28 02:32:17 2019 > New Revision: 355164 > URL: https://svnweb.freebsd.org/changeset/base/355164 > > Log: > Remove the trm(4) driver > > Differential Revision: https://reviews.freebsd.org/D22575 Hi Scot

Re: svn commit: r355164 - in head: . share/man/man4 sys/amd64/conf sys/conf sys/dev/trm sys/i386/conf sys/modules sys/modules/trm

> On Nov 30, 2019, at 10:03 AM, Warner Losh wrote: > > > > On Sat, Nov 30, 2019 at 10:47 AM Enji Cooper <mailto:yaneurab...@gmail.com>> wrote: > > > On Nov 27, 2019, at 6:32 PM, Scott Long wrote: > > > > Author: scottl > > Date: Thu No

Re: svn commit: r355164 - in head: . share/man/man4 sys/amd64/conf sys/conf sys/dev/trm sys/i386/conf sys/modules sys/modules/trm

> On Nov 30, 2019, at 11:01 AM, Warner Losh wrote: > > On Sat, Nov 30, 2019 at 11:58 AM Enji Cooper <mailto:yaneurab...@gmail.com>> wrote: > >> On Nov 30, 2019, at 10:03 AM, Warner Losh > <mailto:i...@bsdimp.com>> wrote: >> >>

Re: svn commit: r351429 - head/sys/conf

> On Aug 23, 2019, at 09:42, Warner Losh wrote: > > Author: imp > Date: Fri Aug 23 16:42:04 2019 > New Revision: 351429 > URL: https://svnweb.freebsd.org/changeset/base/351429 > > Log: > Turn off -Werror for gcc 4.2.1 > > As part of marching gcc 4.2.1 out of the tree, turn off -Werror on gc

Re: svn commit: r351429 - head/sys/conf

> On Aug 23, 2019, at 09:45, Enji Cooper wrote: > > >> On Aug 23, 2019, at 09:42, Warner Losh wrote: >> >> Author: imp >> Date: Fri Aug 23 16:42:04 2019 >> New Revision: 351429 >> URL: https://svnweb.freebsd.org/changeset/base/351429 >>

Re: svn commit: r351643 - in head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common: dtraceUtil speculation

> On Aug 31, 2019, at 16:29, Warner Losh wrote: > > > >> On Sat, Aug 31, 2019 at 5:29 PM Conrad Meyer wrote: >> Thanks Li-Wen! Might it be less fragile to have the test fixture >> create a file, if the test(s) will expect one to be present to read? > > Or just use the realpath $0, which you

svn commit: r345645 - head/share/mk

Author: ngie Date: Thu Mar 28 17:22:31 2019 New Revision: 345645 URL: https://svnweb.freebsd.org/changeset/base/345645 Log: Spam CXXFLAGS with `-I${DESTDIR}/usr/include/private`, instead of GTEST_CXXFLAGS This makes it easier for googletest users to leverage googletest, instead of forcin

svn commit: r345704 - in head: lib/clang lib/libc++ lib/libc++experimental lib/libc++fs lib/libc/tests/stdlib lib/libclang_rt lib/libcxxrt lib/libgcc_eh lib/libomp lib/ofed/libibnetdisc share/mk us...

Author: ngie Date: Fri Mar 29 18:13:44 2019 New Revision: 345704 URL: https://svnweb.freebsd.org/changeset/base/345704 Log: CXXSTD is the C++ analogue to CSTD. CXXSTD defaults to `-std=c++11` with supporting compilers; `-std=gnu++98`, otherwise for older versions of g++. This change

svn commit: r345709 - in head: lib/libc/tests/stdlib share/mk

Author: ngie Date: Fri Mar 29 18:49:08 2019 New Revision: 345709 URL: https://svnweb.freebsd.org/changeset/base/345709 Log: Allow users to override CSTD/CXXSTD on a per-prog basis The current logic for CSTD/CXXSTD requires homogenity as far as the supported C/C++ standards, which is a sen

Re: svn commit: r345706 - in head: lib/clang lib/libc++ lib/libc++experimental lib/libc++fs lib/libc/tests/stdlib lib/libclang_rt lib/libcxxrt lib/libgcc_eh lib/libomp lib/ofed/libibnetdisc share/mk u

> On Mar 29, 2019, at 11:31 AM, Enji Cooper wrote: > > Author: ngie > Date: Fri Mar 29 18:31:48 2019 > New Revision: 345706 > URL: https://svnweb.freebsd.org/changeset/base/345706 > <https://svnweb.freebsd.org/changeset/base/345706> *grumbles* I downloaded

svn commit: r345705 - in head: lib/clang lib/libc++ lib/libc++experimental lib/libc++fs lib/libc/tests/stdlib lib/libclang_rt lib/libcxxrt lib/libgcc_eh lib/libomp lib/ofed/libibnetdisc share/mk us...

Author: ngie Date: Fri Mar 29 18:16:33 2019 New Revision: 345705 URL: https://svnweb.freebsd.org/changeset/base/345705 Log: Revert r345704 I accidentally committed code from two reviews. I will reintroduce the code to bsd.progs.mk as part of a separate commit from r345704. Approved b

svn commit: r345708 - in head: lib/clang lib/libc++ lib/libc++experimental lib/libc++fs lib/libclang_rt lib/libcxxrt lib/libgcc_eh lib/libomp lib/ofed/libibnetdisc share/mk usr.bin/dtc usr.sbin/pmc

Author: ngie Date: Fri Mar 29 18:45:27 2019 New Revision: 345708 URL: https://svnweb.freebsd.org/changeset/base/345708 Log: Standardize `-std=c++* as `CXXSTD` CXXSTD was added as the C++ analogue to CSTD. CXXSTD defaults to `-std=c++11` with supporting compilers; `-std=gnu++98`, othe

svn commit: r345707 - in head: lib/clang lib/libc++ lib/libc++experimental lib/libc++fs lib/libc/tests/stdlib lib/libclang_rt lib/libcxxrt lib/libgcc_eh lib/libomp lib/ofed/libibnetdisc share/mk us...

Author: ngie Date: Fri Mar 29 18:43:46 2019 New Revision: 345707 URL: https://svnweb.freebsd.org/changeset/base/345707 Log: Revert r345706: the third time will be the charm When a review is closed via Phabricator it updates the patch attached to the review. I downloaded the raw patch from

Re: svn commit: r345707 - in head: lib/clang lib/libc++ lib/libc++experimental lib/libc++fs lib/libc/tests/stdlib lib/libclang_rt lib/libcxxrt lib/libgcc_eh lib/libomp lib/ofed/libibnetdisc share/mk u

> On Mar 29, 2019, at 8:09 PM, Rodney W. Grimes > wrote: > >> Author: ngie >> Date: Fri Mar 29 18:43:46 2019 >> New Revision: 345707 >> URL: https://svnweb.freebsd.org/changeset/base/345707 >> >> Log: >> Revert r345706: the third time will be the charm >> >> When a review is closed via Phab

svn commit: r345723 - head/share/mk

Author: ngie Date: Sat Mar 30 00:57:33 2019 New Revision: 345723 URL: https://svnweb.freebsd.org/changeset/base/345723 Log: PROG_OVERRIDE_VARS should override default values if specified The behavior prior to this change would not override default values if set in `bsd.own.mk`, or (in the

svn commit: r345706 - in head: lib/clang lib/libc++ lib/libc++experimental lib/libc++fs lib/libc/tests/stdlib lib/libclang_rt lib/libcxxrt lib/libgcc_eh lib/libomp lib/ofed/libibnetdisc share/mk us...

Author: ngie Date: Fri Mar 29 18:31:48 2019 New Revision: 345706 URL: https://svnweb.freebsd.org/changeset/base/345706 Log: Standardize `-std=c++* as `CXXSTD` CXXSTD was added as the C++ analogue to CSTD. CXXSTD defaults to `-std=c++11` with supporting compilers; `-std=gnu++98`, othe

svn commit: r345770 - in head: contrib/googletest/googletest contrib/googletest/googletest/docs contrib/googletest/googletest/src contrib/googletest/googletest/test lib/googletest/gtest_main/tests

change addresses #2189. Signed-off-by: Enji Cooper ``` The goal with my merging in this change is to avoid requiring extensive refactoring/retesting of test suites when ensuring prerequisites are met, e.g., checking for a CAPABILITIES-enabled kernel before running capsicum-test

svn commit: r345735 - head/share/mk

Author: ngie Date: Sat Mar 30 17:23:15 2019 New Revision: 345735 URL: https://svnweb.freebsd.org/changeset/base/345735 Log: Allow programs to set `NO_SHARED` on a per-PROG basis This is particularly useful when installing programs for tests that need to be linked statically, e.g., mini-me

svn commit: r345783 - in head: contrib/capsicum-test tests/sys/capsicum

Author: ngie Date: Mon Apr 1 21:24:50 2019 New Revision: 345783 URL: https://svnweb.freebsd.org/changeset/base/345783 Log: Integrate capsicum-test into the FreeBSD test suite This change takes capsicum-test from upstream and applies some local changes to make the tests work on FreeBSD w

Re: svn commit: r345805 - head/sys/cam

Hi Alexander, > On Apr 2, 2019, at 07:46, Alexander Motin wrote: > > Author: mav > Date: Tue Apr 2 14:46:10 2019 > New Revision: 345805 > URL: https://svnweb.freebsd.org/changeset/base/345805 > > Log: > Unify SCSI_STATUS_BUSY retry handling with other cases. > > - Do not retry if periph wa

Re: svn commit: r345853 - head/usr.bin/rctl

> On Apr 3, 2019, at 1:37 PM, Mateusz Guzik wrote: > > Author: mjg > Date: Wed Apr 3 20:37:14 2019 > New Revision: 345853 > URL: https://svnweb.freebsd.org/changeset/base/345853 > > Log: > rctl: fix sysctl kern.racct.enable use after r341182 > > The value was changed from int to bool. Sinc

Re: svn commit: r345689 - head/sys/fs/fuse

> On Mar 29, 2019, at 7:07 AM, Alan Somers wrote: > > Author: asomers > Date: Fri Mar 29 14:07:30 2019 > New Revision: 345689 > URL: https://svnweb.freebsd.org/changeset/base/345689 > > Log: > fix the GENERIC-NODEBUG build after r345675 Could you please merge this change in to your branch? T

Re: svn commit: r345967 - head/contrib/libxo/libxo

> On Apr 5, 2019, at 12:42, Phil Shafer wrote: > > Author: phil > Date: Fri Apr 5 19:42:54 2019 > New Revision: 345967 > URL: https://svnweb.freebsd.org/changeset/base/345967 > > Log: > Emergency fix for NULL deref in xo_xml_leader_len Could you please add a test for this as well upstream?

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

On Apr 5, 2019, at 13:22, Rodney W. Grimes wrote: >>> On Fri, Apr 5, 2019 at 6:49 AM Ed Maste wrote: >>> On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: >>> > +static const u_char dot_name[] = { > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > +stati

svn commit: r346056 - head

Author: ngie Date: Tue Apr 9 16:17:31 2019 New Revision: 346056 URL: https://svnweb.freebsd.org/changeset/base/346056 Log: Fix a typo when sanity checking in the bootstrap-tools target The path is incorrect for the linker in the error message. It should have been /usr/bin/ld, not /usr/bi

svn commit: r346061 - head/tests/sys/netmap

Author: ngie Date: Tue Apr 9 17:52:11 2019 New Revision: 346061 URL: https://svnweb.freebsd.org/changeset/base/346061 Log: Polish netmap(4) testcases a bit 1. Not all kernels have netmap(4) support. Check for netmap(4) support before attempting to run the tests via the `PLAIN_REQUIRE_

svn commit: r346057 - head/tests/sys/geom/class/eli

Author: ngie Date: Tue Apr 9 16:20:36 2019 New Revision: 346057 URL: https://svnweb.freebsd.org/changeset/base/346057 Log: Fix geli device cleanup Final cleanup routines shouldn't be called from testcases; it should be called from the testcase cleanup routine. Furthermore, `geli_tes

Re: svn commit: r345708 - in head: lib/clang lib/libc++ lib/libc++experimental lib/libc++fs lib/libclang_rt lib/libcxxrt lib/libgcc_eh lib/libomp lib/ofed/libibnetdisc share/mk usr.bin/dtc usr.sbin/pm

Hi Jan, Your approach is much more refined than my approach in this commit (I was being myopic, focusing on src). Thank you! I’ll need to unwind my removal of -std=c++11 from several Makefiles in base and I want to doublecheck some things. I’ll get back to you later on today about your patch

Re: svn commit: r346081 - head/cddl/usr.sbin/zfsd

> On Apr 10, 2019, at 08:55, Konstantin Belousov wrote: > >> On Wed, Apr 10, 2019 at 01:42:37PM +, Edward Tomasz Napierala wrote: >> Author: trasz >> Date: Wed Apr 10 13:42:37 2019 >> New Revision: 346081 >> URL: https://svnweb.freebsd.org/changeset/base/346081 >> >> Log: >> Make zfsd(8) b

svn commit: r346196 - in head/lib/libpmc: . pmu-events

Author: ngie Date: Sun Apr 14 00:06:49 2019 New Revision: 346196 URL: https://svnweb.freebsd.org/changeset/base/346196 Log: Fix warnings with lib/libpmc * Use `MIN` instead of similar hand rolled macro. * Sort headers. * Use `errno.h` instead of `sys/errno.h`. * Wrap the argument to s

Re: svn commit: r346150 - head/sys/vm

> On Apr 12, 2019, at 5:46 AM, Tycho Nightingale wrote: > > Author: tychon > Date: Fri Apr 12 12:46:25 2019 > New Revision: 346150 > URL: https://svnweb.freebsd.org/changeset/base/346150 > > Log: > for a cache-only zone the destructor tries to destroy a non-existent keg > > Reviewed by: mar

Re: svn commit: r346160 - head/usr.bin/mandoc

> On Apr 12, 2019, at 11:35 AM, Li-Wen Hsu wrote: > > Author: lwhsu > Date: Fri Apr 12 18:35:14 2019 > New Revision: 346160 > URL: https://svnweb.freebsd.org/changeset/base/346160 > > Log: > Suppress old gcc warning about null format string > > This is workaround to make head build on gcc us

Re: svn commit: r346358 - in head: . sys/dev/random sys/libkern sys/mips/conf sys/sys

> On Apr 18, 2019, at 13:48, Conrad Meyer wrote: > > Author: cem > Date: Thu Apr 18 20:48:54 2019 > New Revision: 346358 > URL: https://svnweb.freebsd.org/changeset/base/346358 > > Log: > random(4): Restore availability tradeoff prior to r346250 > > As discussed in that commit message, it i

svn commit: r346443 - head/tests/sys/opencrypto

Author: ngie Date: Sat Apr 20 15:43:28 2019 New Revision: 346443 URL: https://svnweb.freebsd.org/changeset/base/346443 Log: tests/sys/opencrypto: fix whitespace per PEP8 Replace hard tabs with four-character indentations, per PEP8. This is being done to separate stylistic changes from

svn commit: r346542 - head/tests/sys/kern

Author: ngie Date: Mon Apr 22 11:21:20 2019 New Revision: 346542 URL: https://svnweb.freebsd.org/changeset/base/346542 Log: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386 The zero-padding when printing out the Size field is on 32-bit architectures is 5, not 15. Adjust the regula

Re: svn commit: r346399 - head/share/man/man4

> On Apr 19, 2019, at 10:15, Conrad Meyer wrote: > > Author: cem > Date: Fri Apr 19 17:15:58 2019 > New Revision: 346399 > URL: https://svnweb.freebsd.org/changeset/base/346399 > > Log: > random.4: Include description of knobs added in r346358 > > Reported by:ngie > Sponsored by:Del

Re: svn commit: r346390 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

> On Apr 19, 2019, at 11:29, Alexander Motin wrote: > > On 19.04.2019 14:09, Enji Cooper wrote: >>> On Apr 19, 2019, at 08:44, Alexander Motin wrote: >>> >>> Author: mav >>> Date: Fri Apr 19 15:44:45 2019 >>> New Revision: 346390 >

Re: svn commit: r346390 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

> On Apr 19, 2019, at 08:44, Alexander Motin wrote: > > Author: mav > Date: Fri Apr 19 15:44:45 2019 > New Revision: 346390 > URL: https://svnweb.freebsd.org/changeset/base/346390 > > Log: > Change the way FreeBSD GID inheritance is hacked. > > I believe previous ifdef caused NULL dereferen

Re: svn commit: r346443 - head/tests/sys/opencrypto

> On Apr 20, 2019, at 9:38 AM, John Baldwin wrote: > > On 4/20/19 9:32 AM, Enji Cooper wrote: >> >>> On Apr 20, 2019, at 9:31 AM, Enji Cooper wrote: >>> >>> >>>> On Apr 20, 2019, at 9:30 AM, John Baldwin >>> <mailto:j...@fre

Panic with r346530 [Re: svn commit: r346530 - in head/sys: netinet netinet6]

Hi Hans, > On Apr 22, 2019, at 1:32 AM, Hans Petter Selasky wrote: > > On 4/22/19 10:10 AM, Hans Petter Selasky wrote: >> On 4/22/19 9:52 AM, Enji Cooper wrote: >>> >>>> On Apr 22, 2019, at 12:27 AM, Hans Petter Selasky >>>> wrote: >>&g

Re: svn commit: r346443 - head/tests/sys/opencrypto

> On Apr 20, 2019, at 9:54 AM, John Baldwin wrote: … > To be clear, I prefer the _new_ indentation. I kept having to go back and > manually > use tabify in emacs to work with the current scripts, so once my pending > stuff is > drained I will appreciate having it converted. I figured as muc

Re: svn commit: r346443 - head/tests/sys/opencrypto

> On Apr 20, 2019, at 9:30 AM, John Baldwin wrote: > > On 4/20/19 8:43 AM, Enji Cooper wrote: >> Author: ngie >> Date: Sat Apr 20 15:43:28 2019 >> New Revision: 346443 >> URL: https://svnweb.freebsd.org/changeset/base/346443 >> >> Log: >

svn commit: r346571 - in head: share/examples/tests/tests/tap share/man/man4 share/man/man5 share/zoneinfo/tests usr.bin/calendar/calendars usr.bin/du/tests usr.bin/getconf/tests usr.bin/procstat/t...

#!/bin/sh # -# Copyright (c) 2017 Ngie Cooper -# All rights reserved. +# Copyright (c) 2017 Enji Cooper # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions Modified: head

svn commit: r346574 - in head: lib/libc++ lib/libc++experimental lib/libc++fs lib/libcxxrt lib/libgcc_eh lib/ofed/libibnetdisc usr.bin/dtc

Author: ngie Date: Mon Apr 22 18:38:54 2019 New Revision: 346574 URL: https://svnweb.freebsd.org/changeset/base/346574 Log: Rework CXXSTD setting via r345708 This change allows the user to once again override the C++ standard, restoring high-level pre-r345708 behavior. This also unbr

Re: svn commit: r346441 - in head/sys/modules: em fusefs iavf

> On Apr 20, 2019, at 9:44 AM, John Baldwin wrote: > > On 4/20/19 6:23 AM, Justin Hibbits wrote: >> On Sat, Apr 20, 2019, 08:21 Alan Somers wrote: >> >>> On Sat, Apr 20, 2019 at 6:58 AM Justin Hibbits >>> wrote: On Sat, Apr 20, 2019, 07:51 Alan Somers wrote: > >

svn commit: r346452 - head/tests/sys/opencrypto

Author: ngie Date: Sat Apr 20 16:37:28 2019 New Revision: 346452 URL: https://svnweb.freebsd.org/changeset/base/346452 Log: Revert r346443 My wide sweeping stylistic change (while well intended) is impeding others from working on `tests/sys/opencrypto`. The plan is to revert the cha

Re: svn commit: r346530 - in head/sys: netinet netinet6

> On Apr 22, 2019, at 12:27 AM, Hans Petter Selasky > wrote: > > Author: hselasky > Date: Mon Apr 22 07:27:24 2019 > New Revision: 346530 > URL: https://svnweb.freebsd.org/changeset/base/346530 > > Log: > Fix panic in network stack due to memory use after free in relation to > fragmented pac

Re: svn commit: r346443 - head/tests/sys/opencrypto

> On Apr 20, 2019, at 9:31 AM, Enji Cooper wrote: > > >> On Apr 20, 2019, at 9:30 AM, John Baldwin > <mailto:j...@freebsd.org>> wrote: >> >> On 4/20/19 8:43 AM, Enji Cooper wrote: >>> Author: ngie >>> Date: Sat Apr 20 15:43:28 2019 >

svn commit: r346539 - head/lib/libc/tests/sys

Author: ngie Date: Mon Apr 22 11:09:24 2019 New Revision: 346539 URL: https://svnweb.freebsd.org/changeset/base/346539 Log: Fix `get_int_via_sysctlbyname(..)` on Jenkins Initialize `oldlen` to the size of the value, instead of leaving the value unitialized. Leaving it unitialized seems to

svn commit: r346572 - in head/lib: libcam/tests libkvm/tests libsbuf/tests

* Copyright (c) 2017 Ngie Cooper - * All rights reserved. + * Copyright (c) 2017 Enji Cooper * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions Modified: head/lib/libk

svn commit: r346623 - head/tests/sys/opencrypto

Author: ngie Date: Wed Apr 24 04:50:03 2019 New Revision: 346623 URL: https://svnweb.freebsd.org/changeset/base/346623 Log: Chase PEP-3110 Replace `except Environment, e:` with `except Environment as e` for compatibility between python 2.x and python 3.x. While here, fix a bad indent

svn commit: r346578 - head/lib/libclang_rt

Author: ngie Date: Mon Apr 22 19:21:35 2019 New Revision: 346578 URL: https://svnweb.freebsd.org/changeset/base/346578 Log: Build libclang_rt/profile on all clang-supported architectures There's no reason why a special case needs to be added specifically for amd64, arm, and i386, as the c

svn commit: r346627 - head/tests/sys/opencrypto

Author: ngie Date: Wed Apr 24 05:52:24 2019 New Revision: 346627 URL: https://svnweb.freebsd.org/changeset/base/346627 Log: Use `range` instead of `xrange` `xrange` is a pre-python 2.x compatible idiom. Use `range` instead. The values being iterated over are sufficiently small that using

svn commit: r346576 - head/share/mk

Author: ngie Date: Mon Apr 22 18:40:46 2019 New Revision: 346576 URL: https://svnweb.freebsd.org/changeset/base/346576 Log: Fix up CXXSTD support originally added in r345708 r345708 worked for the base system, but unfortunately, caused a lot of disruption for third-party packages that rel

Re: svn commit: r346571 - in head: share/examples/tests/tests/tap share/man/man4 share/man/man5 share/zoneinfo/tests usr.bin/calendar/calendars usr.bin/du/tests usr.bin/getconf/tests usr.bin/procstat/

> On Apr 22, 2019, at 1:50 PM, Rodney W. Grimes > wrote: … > It still does not dis-associate mav's copyright with the All rights reserved > clause, > as it appears as if he did an insert of copyright bewteen the 2, thus giving > grey assertion by him of that clause. > > Again, please get mav

svn commit: r346625 - head/tests/sys/opencrypto

Author: ngie Date: Wed Apr 24 05:47:09 2019 New Revision: 346625 URL: https://svnweb.freebsd.org/changeset/base/346625 Log: Don't leak `fd` when manipulating the device via `_getdev()` Close the file descriptor when done calling ioctl with a try-finally block so it doesn't get leaked.

svn commit: r346626 - head/tests/sys/opencrypto

Author: ngie Date: Wed Apr 24 05:49:48 2019 New Revision: 346626 URL: https://svnweb.freebsd.org/changeset/base/346626 Log: Fix typo: `Plen` should be `plen` MFC after:1 month MFC with: r346617 Reported by: pylint -E Modified: head/tests/sys/opencrypto/cryptotest.py Modifie

svn commit: r346620 - head/tests/sys/opencrypto

Author: ngie Date: Wed Apr 24 04:40:24 2019 New Revision: 346620 URL: https://svnweb.freebsd.org/changeset/base/346620 Log: Reapply whitespace style changes from r346443 after recent changes to tests/sys/opencrypto From r346443: """ Replace hard tabs with four-character indentations, p

Re: svn commit: r346619 - head/sys/powerpc/aim

> On Apr 23, 2019, at 19:51, Justin Hibbits wrote: > > Author: jhibbits > Date: Wed Apr 24 02:51:58 2019 > New Revision: 346619 > URL: https://svnweb.freebsd.org/changeset/base/346619 > > Log: > powerpc: Add a couple missing isyncs > > mtmsr and mtsr require context synchronizing instruction

Re: svn commit: r352465 - head/share/mk

> On Sep 17, 2019, at 18:58, Kyle Evans wrote: > > Author: kevans > Date: Wed Sep 18 01:58:56 2019 > New Revision: 352465 > URL: https://svnweb.freebsd.org/changeset/base/352465 > > Log: > googletest: default-disable on all of MIPS for now > > Parts of the fusefs tests trigger a bug in curr

Re: svn commit: r352465 - head/share/mk

> On Sep 18, 2019, at 05:40, Kyle Evans wrote: > >> On Wed, Sep 18, 2019 at 7:34 AM Enji Cooper wrote: >> >> >>> On Sep 17, 2019, at 18:58, Kyle Evans wrote: >>> >>> Author: kevans >>> Date: Wed Sep 18 01:58:56 2019 >>&g

Re: svn commit: r352465 - head/share/mk

> On Sep 18, 2019, at 07:33, Enji Cooper wrote: > > >>> On Sep 18, 2019, at 05:40, Kyle Evans wrote: >>> >>> On Wed, Sep 18, 2019 at 7:34 AM Enji Cooper wrote: >>> >>> >>>> On Sep 17, 2019, at 18:58, Kyle Evans wrote: >

Re: svn commit: r352465 - head/share/mk

> On Sep 18, 2019, at 06:53, Warner Losh wrote: > > > >> On Wed, Sep 18, 2019, 1:41 PM Kyle Evans wrote: >> On Wed, Sep 18, 2019 at 7:34 AM Enji Cooper wrote: >> > >> > >> > > On Sep 17, 2019, at 18:58, Kyle Evans wrote: >> >

Re: svn commit: r352465 - head/share/mk

> On Sep 18, 2019, at 07:58, Kyle Evans wrote: > >> On Wed, Sep 18, 2019 at 9:46 AM Enji Cooper wrote: >> >> >>> On Sep 18, 2019, at 07:33, Enji Cooper wrote: >>> >>> >>>>> On Sep 18, 2019, at 05:40, Kyle Evans wrot

Re: svn commit: r348286 - in head/sys/dev: ctau cxgbe

> On May 26, 2019, at 05:41, Alexey Dokuchaev wrote: > > Author: danfe (ports committer) > Date: Sun May 26 12:41:03 2019 > New Revision: 348286 > URL: https://svnweb.freebsd.org/changeset/base/348286 > > Log: > Fix two errors reported by PVS Studio: V646 Consider inspecting the > applicatio

Re: svn commit: r348521 - in head: . etc sys/conf sys/modules usr.bin/login usr.sbin/services_mkdb

Hi Maxim, > On Jun 2, 2019, at 16:38, Maxim Sobolev wrote: > > Author: sobomax > Date: Sun Jun 2 23:38:19 2019 > New Revision: 348521 > URL: https://svnweb.freebsd.org/changeset/base/348521 > > Log: > Fix several places where tool name has been hardcoded: > > install -> ${INSTALL} >

Re: svn commit: r348611 - in head/sys: conf kern

> On Jun 4, 2019, at 6:07 AM, Ed Maste wrote: > > Author: emaste > Date: Tue Jun 4 13:07:10 2019 > New Revision: 348611 > URL: https://svnweb.freebsd.org/changeset/base/348611 > > Log: > Expose the kernel's build-ID through sysctl > > After our migration (of certain architectures) to lld th

Re: svn commit: r348609 - head

> On Jun 4, 2019, at 5:56 AM, Ed Maste wrote: > > Author: emaste > Date: Tue Jun 4 12:56:20 2019 > New Revision: 348609 > URL: https://svnweb.freebsd.org/changeset/base/348609 > > Log: > Makefile.inc1: clean up stale dependency hacks > > Carrying on from r339607, remove ad-hoc dependency c

Re: svn commit: r348611 - in head/sys: conf kern

> On Jun 4, 2019, at 11:48 AM, Ed Maste wrote: > > On Tue, 4 Jun 2019 at 13:44, Enji Cooper wrote: >> >> This is awesome! One minor critique is that I would have mentioned that the >> sysctl is `kern.build_id`. > > You mean including the sysctl name in th

Re: svn commit: r348540 - head

hed r348521. Re-work would be posted to >> reviews. Sorry. >> >> Reported by:Enji Cooper >> >> Modified: >> head/Makefile.inc1 >> >> Modified: head/Makefile.inc1 >> ===

Re: svn commit: r348810 - head/sys/x86/x86

Hi! > On Jun 8, 2019, at 11:26, Jonathan T. Looney wrote: > > Author: jtl > Date: Sat Jun 8 18:26:48 2019 > New Revision: 348810 > URL: https://svnweb.freebsd.org/changeset/base/348810 > > Log: > Currently, MCA entries remain on an every-growing linked list. This means > that it becomes incr

Re: svn commit: r349256 - head/libexec/rc/rc.d

> On Jun 21, 2019, at 12:32, Xin LI wrote: > > >> On Thu, Jun 20, 2019 at 7:38 PM Conrad Meyer wrote: >> Author: cem >> Date: Fri Jun 21 02:37:54 2019 >> New Revision: 349256 >> URL: https://svnweb.freebsd.org/changeset/base/349256 >> >> Log: >> rc.d/motd: Update motd more robustly >> >>

Re: svn commit: r349896 - head/contrib/telnet/telnet

> On Jul 10, 2019, at 3:36 PM, Philip Paeps wrote: > > Author: philip > Date: Wed Jul 10 22:36:14 2019 > New Revision: 349896 > URL: https://svnweb.freebsd.org/changeset/base/349896 > > Log: > telnet: fix minor style violation > > While here also fix a very unlikely NULL pointer dereference

Re: svn commit: r349907 - head/sys/netinet/tcp_stacks

> On Jul 10, 2019, at 9:38 PM, Randall Stewart wrote: > > Author: rrs > Date: Thu Jul 11 04:38:33 2019 > New Revision: 349907 > URL: https://svnweb.freebsd.org/changeset/base/349907 > > Log: > Update copyright per JBH's suggestions.. thanks. > > Modified: > head/sys/netinet/tcp_stacks/rack.

Re: svn commit: r350505 - in head: contrib/binutils/binutils/doc gnu/usr.bin/binutils/objdump

> On Jul 31, 2019, at 19:58, Ed Maste wrote: > >> On Thu, 1 Aug 2019 at 12:35, Ian Lepore wrote: >> >> Why would we provide no objdump? I use it quite frequently; it seems >> like an essential part of the toolchain to me. > > I don't want us to provide no objdump, but providing GNU objdump >

Re: svn commit: r350512 - head/tests/sys/kern

> On Aug 7, 2019, at 2:04 PM, Li-Wen Hsu wrote: > > On Thu, Aug 8, 2019 at 4:27 AM Mark Johnston > wrote: >> >> On Thu, Aug 01, 2019 at 06:19:16PM +, Li-Wen Hsu wrote: >>> Author: lwhsu >>> Date: Thu Aug 1 18:19:16 2019 >>> New Revision: 350512 >>> URL: https://

svn commit: r350837 - head/tests/sys/opencrypto

Author: ngie Date: Sat Aug 10 15:53:42 2019 New Revision: 350837 URL: https://svnweb.freebsd.org/changeset/base/350837 Log: tests/sys/opencrypto: enable armv8crypto on aarch64 This change makes required modifications in runtests to also only require the aesni module on Intel (i386/amd64)

Re: svn commit: r350843 - head

> On Aug 10, 2019, at 11:22 AM, Conrad Meyer wrote: > > Author: cem > Date: Sat Aug 10 18:22:22 2019 > New Revision: 350843 > URL: https://svnweb.freebsd.org/changeset/base/350843 > > Log: > .gitignore: Add LINT kernel configurations generated into SRCDIR Thank you for doing this Conrad :).

svn commit: r362591 - head/sys/kern

Author: ngie Date: Wed Jun 24 18:51:01 2020 New Revision: 362591 URL: https://svnweb.freebsd.org/changeset/base/362591 Log: Add `kern.features.witness` Adding `kern.features.witness` helps expose whether or not the kernel has `options WITNESS` enabled, so the `feature_present(3)` API can

Re: svn commit: r362667 - head/sys/cddl/contrib/opensolaris/uts/common/dtrace

> On Jun 26, 2020, at 6:02 PM, Alexey Dokuchaev wrote: > > On Sat, Jun 27, 2020 at 12:57:48AM +, Matt Macy wrote: >> New Revision: 362667 >> URL: https://svnweb.freebsd.org/changeset/base/362667 >> >> Log: >> Fix "current" variable name conflict with openzfs >> >> The variable "current"

Re: svn commit: r363088 - head/usr.bin/xinstall/tests

> On Jul 10, 2020, at 3:59 PM, Eugene Grosbein wrote: > > Author: eugen > Date: Fri Jul 10 22:59:26 2020 > New Revision: 363088 > URL: https://svnweb.freebsd.org/changeset/base/363088 > > Log: > Fix the tests for install(1): add support for STRIPBIN's -o option. Is this feature now c

svn commit: r363132 - head/tests/sys/audit

Author: ngie Date: Sun Jul 12 17:16:57 2020 New Revision: 363132 URL: https://svnweb.freebsd.org/changeset/base/363132 Log: Don't leave `path` behind when executing `:chflags_success` Prior to this change a `SF_IMMUTABLE` chflagsat(2)'ed file (`path`) was left behind, which sabotaged kyua

Re: svn commit: r363103 - head/usr.sbin/bsdinstall/scripts

> On Jul 11, 2020, at 10:20 AM, Allan Jude wrote: > > Author: allanjude > Date: Sat Jul 11 17:20:17 2020 > New Revision: 363103 > URL: https://svnweb.freebsd.org/changeset/base/363103 > > Log: > bsdinstall: only kill the dhclient for the interface we are restarting > > PR: 205821 >

Re: svn commit: r363088 - head/usr.bin/xinstall/tests

> On Jul 10, 2020, at 6:13 PM, Eugene Grosbein wrote: > > 11.07.2020 8:07, Eugene Grosbein wrote: > Fix the tests for install(1): add support for STRIPBIN's -o option. >>> Is this feature now completely gone? Are binaries being stripped >>> properly in ports, etc? > > Support for ST

Re: svn commit: r366697 - head/usr.bin/xinstall

> On Oct 14, 2020, at 5:28 AM, Alex Richardson wrote: > > Author: arichardson > Date: Wed Oct 14 12:28:41 2020 > New Revision: 366697 > URL: https://svnweb.freebsd.org/changeset/base/366697 > > Log: > install(1): Avoid unncessary fstatfs() calls and use mmap() based on size > > According to

svn commit: r367399 - head/contrib/bsnmp/snmpd

Author: ngie Date: Thu Nov 5 21:37:24 2020 New Revision: 367399 URL: https://svnweb.freebsd.org/changeset/base/367399 Log: snmpmod(3): fix typo under the COMMUNITIES section "recipte" should be spelled like "receipt". .Dd is intentionally not being bumped for the change. MFC afte

svn commit: r368431 - head/lib/libc/sys

Author: ngie Date: Tue Dec 8 03:43:00 2020 New Revision: 368431 URL: https://svnweb.freebsd.org/changeset/base/368431 Log: extattr_get_fd(2): fix manlint errors - The CAVEATS section was misspelled as "CAVEAT". - The CAVEATS section should come before the "BUGS" section and after oth

svn commit: r368432 - head/lib/libc/sys

Author: ngie Date: Tue Dec 8 03:48:05 2020 New Revision: 368432 URL: https://svnweb.freebsd.org/changeset/base/368432 Log: lio_listio(2): fix manlint error The date with .Dd prior to this change isn't canonically spelled out: it should have been "December", not "Dec". MFC after:

svn commit: r368433 - head/lib/libc/sys

Author: ngie Date: Tue Dec 8 04:01:03 2020 New Revision: 368433 URL: https://svnweb.freebsd.org/changeset/base/368433 Log: extattr_get_file(2): sort syscalls alphabetically Although some sections of the manpage sort the syscalls alphabetically, many core areas of the manpage do not. Sort

svn commit: r368434 - head/lib/libc/sys

Author: ngie Date: Tue Dec 8 04:05:19 2020 New Revision: 368434 URL: https://svnweb.freebsd.org/changeset/base/368434 Log: extattr_get_file(2): fix more formatting - Remove an unnecessary trailing comma separating a two-item clause. - Sort more function calls alphabetically (in the same

svn commit: r368435 - head/lib/libc/sys

Author: ngie Date: Tue Dec 8 04:16:05 2020 New Revision: 368435 URL: https://svnweb.freebsd.org/changeset/base/368435 Log: extattr_get_file(2): clarify RETURN VALUES While some of the syscalls' behavior were documented and implied in the RETURN VALUES section by earlier, e.g., the DESCRI

svn commit: r368436 - head/lib/libc/sys

Author: ngie Date: Tue Dec 8 04:18:16 2020 New Revision: 368436 URL: https://svnweb.freebsd.org/changeset/base/368436 Log: extattr_get_file(20: bump .Dd This is being done for the formatting and context changes. While the net content hasn't been changed, the content/context changes were

svn commit: r368532 - head/lib/libc/gen

Author: ngie Date: Fri Dec 11 00:13:39 2020 New Revision: 368532 URL: https://svnweb.freebsd.org/changeset/base/368532 Log: arc4random(3): fix .Xr issues - pthreads(3) should actually be pthread(3). - getentropy(2) should actually be getentropy(3). This makes the manpage `make manlin

svn commit: r368533 - head/lib/libc/gen

Author: ngie Date: Fri Dec 11 00:15:57 2020 New Revision: 368533 URL: https://svnweb.freebsd.org/changeset/base/368533 Log: getentropy(3): sort SEE ALSO sections Sorting order should be done by manpage section (2 vs 3), then alphabetically. This change fixes the order to sort by the manpa

svn commit: r368534 - head/lib/libc/gen

Author: ngie Date: Fri Dec 11 00:20:04 2020 New Revision: 368534 URL: https://svnweb.freebsd.org/changeset/base/368534 Log: posix_spawn(3): fix section that references `vfork` `vfork(2)` should be referenced in paragraphs as `.Fn vfork`, not `vfork()`. This change switches the reference t

  1   2   3   >