Re: svn commit: r334543 - head/usr.bin/top

2018-06-03 Thread Don Lewis
On 2 Jun, Rodney W. Grimes wrote: >> Author: eadler >> Date: Sat Jun 2 22:06:27 2018 >> New Revision: 334543 >> URL: https://svnweb.freebsd.org/changeset/base/334543 >> >> Log: >> top(1): chdir to / as init; remove unneeded comment >> >> - chdir to / to allow unmounting of wd >> - remov

Re: svn commit: r326376 - head/sys/kern

2017-11-29 Thread Don Lewis
On 29 Nov, Cy Schubert wrote: > In message <201711292328.vatnseom046...@repo.freebsd.org>, Hans Petter > Selasky > writes: >> Author: hselasky >> Date: Wed Nov 29 23:28:40 2017 >> New Revision: 326376 >> URL: https://svnweb.freebsd.org/changeset/base/326376 >> >> Log: >> The sched_add() function

Re: svn commit: r326758 - in head/sys/i386: conf include

2017-12-11 Thread Don Lewis
On 12 Dec, Eugene Grosbein wrote: > Now I run FreeBSD 11/i386 as my home router with IPSEC and torrent > client, and I run several virtualized routers with IPSEC tunnels, > jabber and mail server, squid and ZFS for src/obj/ports compression > and they all easily crash unless kern.kstack_pages rais

Re: svn commit: r328159 - head/sys/modules

2018-01-19 Thread Don Lewis
On 19 Jan, David Chisnall wrote: > On 19 Jan 2018, at 05:07, Conrad Meyer wrote: >> >> The spec says the behavior is undefined; not that the compiler has to >> produce a warning or error message. The compiler *does* get to >> arbitrarily decide what it wants to do when it encounters UB. It is >

Re: svn commit: r328159 - head/sys/modules

2018-01-19 Thread Don Lewis
On 19 Jan, Conrad Meyer wrote: > On Fri, Jan 19, 2018 at 9:37 AM, Rodney W. Grimes > wrote: >> If you think in assembler it is easy to understand why this is UB, >> most (all) architectures Right Logic or Arithmetic Shift only accept an >> operand that is a size that can hold log2(wordsize). > >

svn commit: r318511 - head/sys/netpfil/ipfw

2017-05-18 Thread Don Lewis
Author: truckman Date: Fri May 19 01:23:06 2017 New Revision: 318511 URL: https://svnweb.freebsd.org/changeset/base/318511 Log: The result of right shifting a negative signed value is implementation defined. On machines without arithmetic shift instructions, zero bits may be shifted in from

svn commit: r318527 - head/sys/netpfil/ipfw

2017-05-19 Thread Don Lewis
Author: truckman Date: Fri May 19 08:38:03 2017 New Revision: 318527 URL: https://svnweb.freebsd.org/changeset/base/318527 Log: Fix the queue delay estimation in PIE/FQ-PIE when the timestamp (TS) method is used. When packet timestamp is used, the "current_qdelay" keeps storing the last que

Re: svn commit: r318441 - in head/etc: . cron.d

2017-06-05 Thread Don Lewis
On 3 Jun, Rodney W. Grimes wrote: > As far as fixing the builds for optional stuff that is rather > easily done in the Makefile with some if's to build a list of > files that can then be catted to conf.foo, using m4 or even > cpp to pre process conf.foo.src, etc, several very easy ways > to solv

Re: svn commit: r349256 - head/libexec/rc/rc.d

2019-06-21 Thread Don Lewis
On 21 Jun, Xin LI wrote: > But ultimately, I think the real design question here that needs to be > solved would probably be "Why are piling up multiple layers of workarounds > around motd? Does it even need to be located in /etc?" The contents is > meant to be updated every time when there is a

Re: svn commit: r363891 - head/sys/kern

2020-08-05 Thread Don Lewis
On 5 Aug, Mateusz Guzik wrote: > Author: mjg > Date: Wed Aug 5 09:24:38 2020 > New Revision: 363891 > URL: https://svnweb.freebsd.org/changeset/base/363891 > > Log: > cache: reduce zone alignment to 8 bytes > > It used to be sizeof of the given struct to accomodate for 32 bit mips > doi

svn commit: r355553 - head/sbin/swapon

2019-12-08 Thread Don Lewis
Author: truckman Date: Mon Dec 9 07:18:40 2019 New Revision: 33 URL: https://svnweb.freebsd.org/changeset/base/33 Log: Fix a logic bug in error handling code. It is an error if p == NULL. The linelen tests are only meaningful when p != NULL. Reported by: Coverity Coverity CID

Re: svn commit: r357407 - head

2020-02-04 Thread Don Lewis
On 2 Feb, Warner Losh wrote: > Author: imp > Date: Sun Feb 2 11:37:27 2020 > New Revision: 357407 > URL: https://svnweb.freebsd.org/changeset/base/357407 > > Log: > Per the firm plan, start to remove sparc64 > > The sparc64 architecture is being removed from FreeBSD 13, starting > now.

Re: svn commit: r324313 - head/sys/amd64/amd64

2017-10-07 Thread Don Lewis
On 5 Oct, Konstantin Belousov wrote: > Author: kib > Date: Thu Oct 5 12:50:03 2017 > New Revision: 324313 > URL: https://svnweb.freebsd.org/changeset/base/324313 > > Log: > Avoid a race betweem freeing LDT and context switches. > > cpu_switch.S uses curproc->p_md.md_ldt value as the flag

Re: svn commit: r324313 - head/sys/amd64/amd64

2017-10-07 Thread Don Lewis
On 7 Oct, Konstantin Belousov wrote: > On Sat, Oct 07, 2017 at 01:04:09PM -0700, Don Lewis wrote: >> On 5 Oct, Konstantin Belousov wrote: >> > Author: kib >> > Date: Thu Oct 5 12:50:03 2017 >> > New Revision: 324313 >> > URL: https://svnweb.fre

Re: svn commit: r324313 - head/sys/amd64/amd64

2017-10-08 Thread Don Lewis
On 8 Oct, Konstantin Belousov wrote: > On Sat, Oct 07, 2017 at 01:54:05PM -0700, Don Lewis wrote: >> On 7 Oct, Konstantin Belousov wrote: >> > On Sat, Oct 07, 2017 at 01:04:09PM -0700, Don Lewis wrote: >> >> On 5 Oct, Konstantin Belousov wrote: >> >> &g

svn commit: r325008 - head/sys/netpfil/ipfw

2017-10-26 Thread Don Lewis
Author: truckman Date: Thu Oct 26 10:11:35 2017 New Revision: 325008 URL: https://svnweb.freebsd.org/changeset/base/325008 Log: Fix Dummynet AQM packet marking function ecn_mark() and fq_codel / fq_pie schedulers packet classification functions in layer2 (bridge mode). Dummynet AQM packet

Re: svn commit: r325404 - head/share/mk

2017-11-04 Thread Don Lewis
On 4 Nov, Bryan Drewery wrote: > On 11/4/2017 3:30 PM, Cy Schubert wrote: >> In message <0fc7e918-dcf8-0197-6b50-5936dee23...@freebsd.org>, Bryan >> Drewery wr >> ites: >>> This is an OpenPGP/MIME signed message (RFC 4880 and 3156) >>> --dokLDw6wDnv1gUfKm3uwMSMnWeibN2RaD >>> Content-Type: multipa

svn commit: r229984 - head/sys/dev/pst

2012-01-11 Thread Don Lewis
Author: truckman Date: Wed Jan 11 21:38:05 2012 New Revision: 229984 URL: http://svn.freebsd.org/changeset/base/229984 Log: Pass the arguments to mtx_init() in the correct order. There should be no change to the binary because the value of MTX_DEF is zero and there is a visible function pro

svn commit: r230064 - head/sys/geom/part

2012-01-13 Thread Don Lewis
Author: truckman Date: Fri Jan 13 18:32:56 2012 New Revision: 230064 URL: http://svn.freebsd.org/changeset/base/230064 Log: Allow an MBR primary or extended Linux swap partition to be specified as the system dump device. This was already allowed for GPT. The Linux swap metadata at the begi

Re: svn commit: r336025 - in head/sys: amd64/include i386/include

2018-07-06 Thread Don Lewis
On 6 Jul, Warner Losh wrote: > On Fri, Jul 6, 2018 at 9:32 AM, Rodney W. Grimes < > free...@pdx.rh.cn85.dnsmgr.net> wrote: > >> > Author: hselasky >> > Date: Fri Jul 6 10:13:42 2018 >> > New Revision: 336025 >> > URL: https://svnweb.freebsd.org/changeset/base/336025 >> > >> > Log: >> > Make su

Re: svn commit: r336025 - in head/sys: amd64/include i386/include

2018-07-06 Thread Don Lewis
On 6 Jul, Warner Losh wrote: > On Fri, Jul 6, 2018 at 6:06 PM, Don Lewis wrote: > >> On 6 Jul, Warner Losh wrote: >> > On Fri, Jul 6, 2018 at 9:32 AM, Rodney W. Grimes < >> > free...@pdx.rh.cn85.dnsmgr.net> wrote: >> > >> >> > Author:

Re: svn commit: r336025 - in head/sys: amd64/include i386/include

2018-07-06 Thread Don Lewis
On 7 Jul, Alexey Dokuchaev wrote: > On Fri, Jul 06, 2018 at 05:06:03PM -0700, Don Lewis wrote: >> The other machine is my Pentium-M laptop, which is mostly used for light >> browsing and as a VNC client when I'm on the road. Performance is >> acceptable for thos

svn commit: r336855 - head/sys/kern

2018-07-28 Thread Don Lewis
Author: truckman Date: Sun Jul 29 00:30:06 2018 New Revision: 336855 URL: https://svnweb.freebsd.org/changeset/base/336855 Log: Fix the long term ULE load balancer so that it actually works. The initial call to sched_balance() during startup is meant to initialize balance_ticks, but does no

r336845

2018-07-28 Thread Don Lewis
I just upgraded a machine from r336438 to r336855. When I ran mergemaster, it asked to delete a bunch of the /etc/rc.d scripts. Answering yes results in the machine being unbootable. I think that the rc.d-related changes in r336845 are the likely culprit. The following rc.d scripts are some of th

Re: r336845

2018-07-28 Thread Don Lewis
On 28 Jul, Brad Davis wrote: > On Sat, Jul 28, 2018, at 9:10 PM, Brad Davis wrote: >> On Sat, Jul 28, 2018, at 8:21 PM, Don Lewis wrote: >> > I just upgraded a machine from r336438 to r336855. When I ran >> > mergemaster, it asked to delete a bunch of the /etc/rc.d

Re: r336845

2018-07-28 Thread Don Lewis
On 28 Jul, Don Lewis wrote: > On 28 Jul, Brad Davis wrote: >> On Sat, Jul 28, 2018, at 9:10 PM, Brad Davis wrote: >>> On Sat, Jul 28, 2018, at 8:21 PM, Don Lewis wrote: >>> > I just upgraded a machine from r336438 to r336855. When I ran >>> > mergemast

svn commit: r336859 - head/sbin/init/rc.d

2018-07-28 Thread Don Lewis
Author: truckman Date: Sun Jul 29 05:42:07 2018 New Revision: 336859 URL: https://svnweb.freebsd.org/changeset/base/336859 Log: Fix a variable name typo in r336845 that prevented the rc.d scripts from being installed in the correct directory. Resurrect a few rc.d scripts that were prematu

Re: r336845

2018-07-28 Thread Don Lewis
On 28 Jul, Brad Davis wrote: > On Sat, Jul 28, 2018, at 10:56 PM, Don Lewis wrote: >> On 28 Jul, Don Lewis wrote: >> > On 28 Jul, Brad Davis wrote: >> >> On Sat, Jul 28, 2018, at 9:10 PM, Brad Davis wrote: >> >>> On Sat, Jul 28, 2018, at 8:21 PM, Don Le

Re: svn commit: r336859 - head/sbin/init/rc.d

2018-07-29 Thread Don Lewis
On 29 Jul, Ian Lepore wrote: > On Sun, 2018-07-29 at 05:42 +0000, Don Lewis wrote: >> Author: truckman >> Date: Sun Jul 29 05:42:07 2018 >> New Revision: 336859 >> URL: https://svnweb.freebsd.org/changeset/base/336859 >> >> Log: >>   Fix a variable

Re: svn commit: r336859 - head/sbin/init/rc.d

2018-07-29 Thread Don Lewis
On 29 Jul, Ian Lepore wrote: > On Sun, 2018-07-29 at 09:59 -0700, Don Lewis wrote: >> On 29 Jul, Ian Lepore wrote: >> > On Sun, 2018-07-29 at 05:42 +, Don Lewis wrote: >> >> Author: truckman >> >> Date: Sun Jul 29 05:42:07 2018 >> >> New

svn commit: r315516 - head/sys/netpfil/ipfw

2017-03-18 Thread Don Lewis
Author: truckman Date: Sat Mar 18 23:00:13 2017 New Revision: 315516 URL: https://svnweb.freebsd.org/changeset/base/315516 Log: Change several constants used by the PIE algorithm from unsigned to signed. - PIE_MAX_PROB is compared to variable of int64_t and the type promotion rules ca

svn commit: r329844 - head/sys/kern

2018-02-22 Thread Don Lewis
Author: truckman Date: Fri Feb 23 00:12:51 2018 New Revision: 329844 URL: https://svnweb.freebsd.org/changeset/base/329844 Log: Decrease latency by not wrapping the idle loop's potentially lengthy search for a thread to steal inside a critical section. Since this allows the search to be pre

Re: svn commit: r329875 - head/sys/kern

2018-02-23 Thread Don Lewis
On 23 Feb, Rick Macklem wrote: > Konstantin Belousov wrote: >>Author: kib >>Date: Fri Feb 23 18:26:31 2018 >>New Revision: 329875 >>URL: https://svnweb.freebsd.org/changeset/base/329875 >> >>Log: >> Restore UP build. >> >> Reviewed by: truckman >> Sponsored by: The FreeBSD Foundation >> >>Modif

Re: svn commit: r285050 - in head: lib/libutil usr.sbin/pwd_mkdb

2016-10-13 Thread Don Lewis
On 13 Oct, Alan Somers wrote: > On Thu, Jul 2, 2015 at 11:31 AM, Renato Botelho wrote: >> Author: garga (ports committer) >> Date: Thu Jul 2 17:30:59 2015 >> New Revision: 285050 >> URL: https://svnweb.freebsd.org/changeset/base/285050 >> >> Log: >> When passwd or group information is changed (

svn commit: r321899 - in head/sys/amd64: amd64 include linux

2017-08-01 Thread Don Lewis
Author: truckman Date: Wed Aug 2 01:43:35 2017 New Revision: 321899 URL: https://svnweb.freebsd.org/changeset/base/321899 Log: Lower the amd64 shared page, which contains the signal trampoline, from the top of user memory to one page lower on machines with the Ryzen (AMD Family 17h) CPU. T

svn commit: r268373 - head/sys/kern

2014-07-07 Thread Don Lewis
Author: truckman Date: Mon Jul 7 22:02:39 2014 New Revision: 268373 URL: http://svnweb.freebsd.org/changeset/base/268373 Log: Declaration whitespace changes for style(9). MFC after:1 week Modified: head/sys/kern/subr_rman.c Modified: head/sys/kern/subr_rman.c ==

svn commit: r268780 - in head: share/man/man9 sys/kern sys/sys

2014-07-16 Thread Don Lewis
Author: truckman Date: Wed Jul 16 22:18:19 2014 New Revision: 268780 URL: http://svnweb.freebsd.org/changeset/base/268780 Log: Nuke the never-used RF_TIMESHARE feature, reducing the complexity of the code. The consensus on arch@ is that this feature might have been useful in the distant pas

Re: svn commit: r269656 - in head: bin/ps sys/kern sys/sys

2014-08-07 Thread Don Lewis
On 7 Aug, Konstantin Belousov wrote: > Author: kib > Date: Thu Aug 7 05:47:53 2014 > New Revision: 269656 > URL: http://svnweb.freebsd.org/changeset/base/269656 > > Log: > Correct the problems with the ptrace(2) making the debuggee an orphan. > One problem is inferior(9) looping due to the p

Re: svn commit: r251512 - in head: . etc etc/mtree gnu/usr.bin/gdb gnu/usr.bin/gdb/arch/amd64 gnu/usr.bin/gdb/arch/arm gnu/usr.bin/gdb/arch/i386 gnu/usr.bin/gdb/arch/ia64 gnu/usr.bin/gdb/arch/mips gnu

2013-06-07 Thread Don Lewis
On 7 Jun, Ed Maste wrote: > Author: emaste > Date: Fri Jun 7 21:40:02 2013 > New Revision: 251512 > URL: http://svnweb.freebsd.org/changeset/base/251512 > > Log: > Add a new knob WITH_DEBUG_FILES to control the building of standalone > debug files for userland programs and libraries. The "-

Re: svn commit: r251512 - in head: . etc etc/mtree gnu/usr.bin/gdb gnu/usr.bin/gdb/arch/amd64 gnu/usr.bin/gdb/arch/arm gnu/usr.bin/gdb/arch/i386 gnu/usr.bin/gdb/arch/ia64 gnu/usr.bin/gdb/arch/mips gnu

2013-06-07 Thread Don Lewis
On 7 Jun, Glen Barber wrote: > On Fri, Jun 07, 2013 at 04:35:23PM -0700, Don Lewis wrote: >> On 7 Jun, Ed Maste wrote: >> > Author: emaste >> > Date: Fri Jun 7 21:40:02 2013 >> > New Revision: 251512 >> > URL: http://svnweb.freebsd.org/changeset/base

Re: svn commit: r251886 - in head: contrib/apr contrib/apr-util contrib/serf contrib/sqlite3 contrib/subversion share/mk usr.bin usr.bin/svn usr.bin/svn/lib usr.bin/svn/lib/libapr usr.bin/svn/lib/liba

2013-06-18 Thread Don Lewis
On 18 Jun, Peter Wemm wrote: > Added: head/usr.bin/svn/Makefile.inc > == > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/usr.bin/svn/Makefile.inc Tue Jun 18 02:53:45 2013 > (r251

svn commit: r252003 - head/usr.bin/svn

2013-06-19 Thread Don Lewis
Author: truckman Date: Wed Jun 19 19:44:57 2013 New Revision: 252003 URL: http://svnweb.freebsd.org/changeset/base/252003 Log: Fix a couple of typos that broke buildworld for me. Reviewed by: peter Modified: head/usr.bin/svn/Makefile.inc Modified: head/usr.bin/svn/Makefile.inc

Re: svn commit: r263379 - in head/sys: amd64/amd64 i386/i386 i386/xen isa pc98/cbus x86/isa x86/x86

2014-03-19 Thread Don Lewis
On 19 Mar, Warner Losh wrote: > Author: imp > Date: Wed Mar 19 21:03:04 2014 > New Revision: 263379 > URL: http://svnweb.freebsd.org/changeset/base/263379 > > Log: > Remove vestiges of knowing the ISA bus, which we gave up on around 20 > years ago. Remove redunant copy of isaregs.h. It hasn't

Re: svn commit: r263755 - head/sys/kern

2014-03-27 Thread Don Lewis
On 27 Mar, Konstantin Belousov wrote: > On Thu, Mar 27, 2014 at 04:05:12PM +0100, Mateusz Guzik wrote: >> On Thu, Mar 27, 2014 at 03:58:19PM +0100, Mateusz Guzik wrote: >> > On Thu, Mar 27, 2014 at 04:46:57PM +0800, David Xu wrote: >> > > On 2014/03/27 16:37, Mateusz Guzik wrote: >> > > >On Thu, Ma

Re: svn commit: r263755 - head/sys/kern

2014-03-28 Thread Don Lewis
On 28 Mar, David Xu wrote: > On 2014/03/28 06:31, Don Lewis wrote: >> On 27 Mar, Konstantin Belousov wrote: >>> On Thu, Mar 27, 2014 at 04:05:12PM +0100, Mateusz Guzik wrote: >>>> On Thu, Mar 27, 2014 at 03:58:19PM +0100, Mateusz Guzik wrote: >>>>> On

Re: svn commit: r263755 - head/sys/kern

2014-03-29 Thread Don Lewis
On 29 Mar, Mateusz Guzik wrote: > On Sat, Mar 29, 2014 at 11:52:09AM +0800, David Xu wrote: >> >If fsetown handling like this is insecure this would bite us in that >> >scenario (and few others). In short, if we can avoid giving another way >> >to corrupt stuff in the kernel to userspace, we should

Re: svn commit: r264907 - in head/release: amd64 i386

2014-04-24 Thread Don Lewis
On 24 Apr, Glen Barber wrote: > On Thu, Apr 24, 2014 at 07:12:10PM -0700, Nathan Whitehorn wrote: >> On 04/24/14 18:38, Glen Barber wrote: >> >Author: gjb >> >Date: Fri Apr 25 01:38:57 2014 >> >New Revision: 264907 >> >URL: http://svnweb.freebsd.org/changeset/base/264907 >> > >> >Log: >> > Refact

svn commit: r265363 - head/sys/kern

2014-05-05 Thread Don Lewis
Author: truckman Date: Mon May 5 15:59:31 2014 New Revision: 265363 URL: http://svnweb.freebsd.org/changeset/base/265363 Log: Avoid unsigned integer overflow which can cause rman_reserve_resource_bound() to return incorrect results. Continue the initial search until the first viable regi

svn commit: r265923 - head/sys/kern

2014-05-12 Thread Don Lewis
Author: truckman Date: Mon May 12 17:56:52 2014 New Revision: 265923 URL: http://svnweb.freebsd.org/changeset/base/265923 Log: Nuke a couple of unnecessary assigments. Nothing uses the values of rstart and rend after this point. MFC after:1 week Modified: head/sys/kern/subr_rman.c

svn commit: r265931 - head/sys/kern

2014-05-12 Thread Don Lewis
Author: truckman Date: Mon May 12 20:22:42 2014 New Revision: 265931 URL: http://svnweb.freebsd.org/changeset/base/265931 Log: Be even more paranoid about overflow. Requested by: ache Modified: head/sys/kern/subr_rman.c Modified: head/sys/kern/subr_rman.c ===

Re: svn commit: r265931 - head/sys/kern

2014-05-12 Thread Don Lewis
On 12 May, To: src-committ...@freebsd.org wrote: > Author: truckman > Date: Mon May 12 20:22:42 2014 > New Revision: 265931 > URL: http://svnweb.freebsd.org/changeset/base/265931 > > Log: > Be even more paranoid about overflow. > > Requested by: ache > > Modified: > head/sys/kern/s

Re: svn commit: r265408 - in head: sys/netinet usr.bin/netstat

2014-05-14 Thread Don Lewis
On 6 May, Gleb Smirnoff wrote: > Author: glebius > Date: Tue May 6 00:00:07 2014 > New Revision: 265408 > URL: http://svnweb.freebsd.org/changeset/base/265408 > > Log: > - Remove net.inet.tcp.reass.overflows sysctl. It counts exactly > same events that tcpstat's tcps_rcvmemdrop counter cou

svn commit: r266426 - head/sys/kern

2014-05-18 Thread Don Lewis
Author: truckman Date: Mon May 19 04:44:27 2014 New Revision: 266426 URL: http://svnweb.freebsd.org/changeset/base/266426 Log: Slightly restructure the final loop in rman_reserve_resource_bound(). Replace with the existing loop termination test with a similar condition from the nested "if" t

Re: svn commit: r266534 - head

2014-05-21 Thread Don Lewis
On 22 May, Xin LI wrote: > Author: delphij > Date: Thu May 22 05:33:50 2014 > New Revision: 266534 > URL: http://svnweb.freebsd.org/changeset/base/266534 > > Log: > Fix build: Build libavl as prebuild-lib. Thanks! ___ svn-src-head@freebsd.org mailing

svn commit: r266547 - head

2014-05-22 Thread Don Lewis
Author: truckman Date: Thu May 22 16:30:32 2014 New Revision: 266547 URL: http://svnweb.freebsd.org/changeset/base/266547 Log: Don't delete our new vt(4) man page. X-MFC-With: r265798 Modified: head/ObsoleteFiles.inc Modified: head/ObsoleteFiles.inc ===

Re: svn commit: r266587 - head/share/mk

2014-05-23 Thread Don Lewis
On 23 May, Warner Losh wrote: > Author: imp > Date: Fri May 23 14:34:22 2014 > New Revision: 266587 > URL: http://svnweb.freebsd.org/changeset/base/266587 > > Log: > Allow CC to not actually exist. During the ports INDEX run, all the > Makefiles are evaluated without building things. In a norm

svn commit: r266814 - head/sys/kern

2014-05-28 Thread Don Lewis
Author: truckman Date: Wed May 28 16:57:17 2014 New Revision: 266814 URL: http://svnweb.freebsd.org/changeset/base/266814 Log: Initialize r_flags the same way in all cases using a sanitized copy of flags that has several bits cleared. The RF_WANTED and RF_FIRSTSHARE bits are invalid in this

svn commit: r258363 - in head/sys/dev/usb: . serial

2013-11-19 Thread Don Lewis
Author: truckman Date: Wed Nov 20 02:16:47 2013 New Revision: 258363 URL: http://svnweb.freebsd.org/changeset/base/258363 Log: Add alternate ID for Novatel MiFi 2200 CDMA, which is used by my Virgin Mobile branded device. It needs the U3GINIT_SCSIEJECT quirk. Reviewed by: hselasky MFC

svn commit: r258364 - head/etc/devd

2013-11-19 Thread Don Lewis
Author: truckman Date: Wed Nov 20 02:20:27 2013 New Revision: 258364 URL: http://svnweb.freebsd.org/changeset/base/258364 Log: Regenerate after r258363 (alternate ID for Novatel MiFi 2200) and r258333 (bus_autoconf.sh tweak). Modified: head/etc/devd/usb.conf Modified: head/etc/devd/usb.con

svn commit: r258629 - head/share/man/man4

2013-11-26 Thread Don Lewis
Author: truckman Date: Tue Nov 26 09:14:39 2013 New Revision: 258629 URL: http://svnweb.freebsd.org/changeset/base/258629 Log: Mention that devd will kldload the driver when the device is connected. Mention that the automatic mode switch from umass to u3g needed by some devices does not w

svn commit: r259675 - in head/sys/dev/usb: . quirk

2013-12-20 Thread Don Lewis
Author: truckman Date: Sat Dec 21 03:05:13 2013 New Revision: 259675 URL: http://svnweb.freebsd.org/changeset/base/259675 Log: Add quirks to make my old SanDisk Cruzer Mini 128MB happy. MFC after:1 week Modified: head/sys/dev/usb/quirk/usb_quirk.c head/sys/dev/usb/usbdevs Modified

Re: svn commit: r277828 - in head/sys: fs/tmpfs vm

2015-01-28 Thread Don Lewis
On 28 Jan, Konstantin Belousov wrote: > Author: kib > Date: Wed Jan 28 10:37:23 2015 > New Revision: 277828 > URL: https://svnweb.freebsd.org/changeset/base/277828 > > Log: > Update mtime for tmpfs files modified through memory mapping. Similar > to UFS, perform updates during syncer scans, w

Re: svn commit: r277828 - in head/sys: fs/tmpfs vm

2015-01-28 Thread Don Lewis
On 28 Jan, Konstantin Belousov wrote: > On Wed, Jan 28, 2015 at 09:41:06AM -0800, Don Lewis wrote: >> On 28 Jan, Konstantin Belousov wrote: >> > Author: kib >> > Date: Wed Jan 28 10:37:23 2015 >> > New Revision: 277828 >> > URL: https://svnweb.fre

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-09 Thread Don Lewis
On 10 Feb, Mateusz Guzik wrote: > On Mon, Feb 09, 2015 at 11:13:51PM +, Rui Paulo wrote: >> +notify 10 { >> +match "system" "kernel"; >> +match "subsystem" "signal"; >> +match "type""coredump"; >> +action "logger $comm $core"; >> +}; >> + >> */ >> >

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-09 Thread Don Lewis
On 9 Feb, Don Lewis wrote: > On 10 Feb, Mateusz Guzik wrote: >> On Mon, Feb 09, 2015 at 11:13:51PM +, Rui Paulo wrote: >>> +notify 10 { >>> + match "system" "kernel"; >>> + match "subsystem" "signal&quo

Re: svn commit: r280308 - head/sys/fs/devfs

2015-03-22 Thread Don Lewis
On 22 Mar, Konstantin Belousov wrote: > On Sun, Mar 22, 2015 at 02:37:09PM +0100, Jilles Tjoelker wrote: >> On Sat, Mar 21, 2015 at 08:49:00PM +1100, Bruce Evans wrote: >> > On Sat, 21 Mar 2015, Xin LI wrote: >> >> > > Log: >> > > Disable timestamping on devfs read/write operations by default. >>

Re: svn commit: r280327 - in head/sys: kern vm

2015-03-27 Thread Don Lewis
On 21 Mar, Alan Cox wrote: > Author: alc > Date: Sat Mar 21 17:56:55 2015 > New Revision: 280327 > URL: https://svnweb.freebsd.org/changeset/base/280327 > > Log: > Introduce vm_object_color() and use it in mmap(2) to set the color of > named objects to zero before the virtual address is select

Re: svn commit: r280327 - in head/sys: kern vm

2015-03-28 Thread Don Lewis
On 28 Mar, Bryan Drewery wrote: > On 3/27/2015 9:41 PM, Don Lewis wrote: >> On 21 Mar, Alan Cox wrote: >>> Author: alc >>> Date: Sat Mar 21 17:56:55 2015 >>> New Revision: 280327 >>> URL: https://svnweb.freebsd.org/changeset/base/280327 >>> &g

Re: svn commit: r280327 - in head/sys: kern vm

2015-03-28 Thread Don Lewis
On 28 Mar, Alan Cox wrote: > On 03/28/2015 12:29, Bryan Drewery wrote: >> On 3/27/2015 9:41 PM, Don Lewis wrote: >>> I was not seeing this problem on my older package builder running >>> 10.1-STABLE. Since this problem has not shown up on the FreeBSD package

Re: svn commit: r280327 - in head/sys: kern vm

2015-03-28 Thread Don Lewis
On 28 Mar, Bryan Drewery wrote: > On 3/27/2015 9:41 PM, Don Lewis wrote: >> ../generated/adfiles/ad_x86_64_clone.cpp:1: fatal error: had to relocate PCH >> compilation terminated. >> /wrkdirs/usr/ports/java/openjdk7/work/openjdk/hotspot/make/bsd/makefiles/rules.make:149:

Re: svn commit: r280308 - head/sys/fs/devfs

2015-03-29 Thread Don Lewis
On 29 Mar, Jilles Tjoelker wrote: > On Sun, Mar 22, 2015 at 11:25:07AM -0700, Don Lewis wrote: >> It's not totally worthless. I think the mtime on tty devices is used to >> calculate the idle time that is printed by the w command. We just don't >> need nanosecond a

Re: svn commit: r280327 - in head/sys: kern vm

2015-03-29 Thread Don Lewis
On 28 Mar, Alan Cox wrote: > On 03/28/2015 12:29, Bryan Drewery wrote: >> On 3/27/2015 9:41 PM, Don Lewis wrote: >>> On 21 Mar, Alan Cox wrote: >>>> Author: alc >>>> Date: Sat Mar 21 17:56:55 2015 >>>> New Revision: 280327 >>>> U

Re: svn commit: r280327 - in head/sys: kern vm

2015-03-30 Thread Don Lewis
On 30 Mar, Konstantin Belousov wrote: > On Sun, Mar 29, 2015 at 11:25:14PM -0700, Don Lewis wrote: >> On amd64, with an amd64 jail, and kernel rev r280326, I observe the >> following: >> One gcc process calls mmap() with addr=0 and len=0x657a000, and >>

svn commit: r270510 - head

2014-08-24 Thread Don Lewis
Author: truckman Date: Sun Aug 24 21:21:54 2014 New Revision: 270510 URL: http://svnweb.freebsd.org/changeset/base/270510 Log: Catch up to gcc 3.3 -> 3.4 upgrade. MFC after:3 days Modified: head/ObsoleteFiles.inc Modified: head/ObsoleteFiles.inc =

Re: svn commit: r270510 - head

2014-08-24 Thread Don Lewis
On 24 Aug, Peter Wemm wrote: > On Sunday 24 August 2014 21:21:54 Don Lewis wrote: >> Author: truckman >> Date: Sun Aug 24 21:21:54 2014 >> New Revision: 270510 >> URL: http://svnweb.freebsd.org/changeset/base/270510 >> >> Log: >> Catch up to gcc 3

Re: svn commit: r270510 - head

2014-08-24 Thread Don Lewis
On 24 Aug, Rui Paulo wrote: > On Aug 24, 2014, at 14:44, Peter Wemm wrote: >> >> On Sunday 24 August 2014 21:21:54 Don Lewis wrote: >>> Author: truckman >>> Date: Sun Aug 24 21:21:54 2014 >>> New Revision: 270510 >>> URL: http://svnweb.freebsd

Re: svn commit: r271076 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include pc98/pc98

2014-09-03 Thread Don Lewis
On 4 Sep, John Baldwin wrote: > Author: jhb > Date: Thu Sep 4 01:46:06 2014 > New Revision: 271076 > URL: http://svnweb.freebsd.org/changeset/base/271076 > > Log: > - Move the declaration of has_f00f_hack out of identcpu.c to machdep.c. That certainly brings back memories ... __

Re: svn commit: r271076 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include pc98/pc98

2014-09-04 Thread Don Lewis
On 4 Sep, John Baldwin wrote: > On Wednesday, September 03, 2014 07:37:21 PM Don Lewis wrote: >> On 4 Sep, John Baldwin wrote: >> > Author: jhb >> > Date: Thu Sep 4 01:46:06 2014 >> > New Revision: 271076 >> > URL: http://svnweb.freebsd.org/change

Re: svn commit: r271076 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include pc98/pc98

2014-09-04 Thread Don Lewis
On 4 Sep, Alexey Dokuchaev wrote: > On Thu, Sep 04, 2014 at 09:22:48AM -0700, Don Lewis wrote: >> I've still got the old hardware and am often tempted to see if it will >> run a recent version of FreeBSD. I don't think I want to know how long >> it would ta

Re: svn commit: r271076 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include pc98/pc98

2014-09-04 Thread Don Lewis
On 4 Sep, John-Mark Gurney wrote: > Don Lewis wrote this message on Thu, Sep 04, 2014 at 09:22 -0700: >> On 4 Sep, John Baldwin wrote: >> > On Wednesday, September 03, 2014 07:37:21 PM Don Lewis wrote: >> >> On 4 Sep, John Baldwin wrote: >> >> >

svn commit: r302338 - head/sys/netpfil/ipfw

2016-07-04 Thread Don Lewis
Author: truckman Date: Tue Jul 5 00:53:01 2016 New Revision: 302338 URL: https://svnweb.freebsd.org/changeset/base/302338 Log: Fix a race condition between the main thread in aqm_pie_cleanup() and the callout thread that can cause a kernel panic. Always do the final cleanup in the callout

svn commit: r302667 - head/sys/netpfil/ipfw

2016-07-12 Thread Don Lewis
Author: truckman Date: Tue Jul 12 17:32:40 2016 New Revision: 302667 URL: https://svnweb.freebsd.org/changeset/base/302667 Log: Fix problems in the FQ-PIE AQM cleanup code that could leak memory or cause a crash. Because dummynet calls pie_cleanup() while holding a mutex, pie_cleanup()

Re: svn commit: r285829 - head/sys/kern

2015-07-23 Thread Don Lewis
On 23 Jul, Sergey Kandaurov wrote: > Author: pluknet > Date: Thu Jul 23 23:18:03 2015 > New Revision: 285829 > URL: https://svnweb.freebsd.org/changeset/base/285829 > > Log: > Call ksem_get() with initialized 'rights'. > > ksem_get() consumes fget(), and it's mandatory there. > > Repor

Re: svn commit: r294444 - in head/sys/modules: ix ixlv ixv

2016-01-20 Thread Don Lewis
On 20 Jan, Bryan Drewery wrote: > On 1/20/2016 1:59 PM, Warner Losh wrote: >> It would work built part of buildkernel since pci_iov_if.h would exist >> there. It would fail when built by hand since the kernel config didn’t save >> us. >> > > I don't understand. The problem was seen in buildkern

Re: svn commit: r295465 - head/usr.sbin/services_mkdb

2016-02-10 Thread Don Lewis
On 10 Feb, Stefan Esser wrote: > Author: se > Date: Wed Feb 10 09:40:45 2016 > New Revision: 295465 > URL: https://svnweb.freebsd.org/changeset/base/295465 > > Log: > Remove O_SYNC from the options passed to dbmopen(). > > The services db is created as a temporary file that is moved over th

svn commit: r299865 - head/sys/net

2016-05-15 Thread Don Lewis
Author: truckman Date: Sun May 15 21:37:36 2016 New Revision: 299865 URL: https://svnweb.freebsd.org/changeset/base/299865 Log: When handling SIOCSIFNAME ensure that the new interface name is NUL terminated. Reject the rename attempt if the name is too long. MFC after:1 week Modifie

svn commit: r299866 - head/usr.sbin/lmcconfig

2016-05-15 Thread Don Lewis
Author: truckman Date: Sun May 15 21:45:04 2016 New Revision: 299866 URL: https://svnweb.freebsd.org/changeset/base/299866 Log: Use strlcpy() instead of strncpy() when copying ifname to ensure that it is NUL terminated. Additional NUL padding is not required for short names. Reported b

svn commit: r299867 - head/usr.sbin/rtadvd

2016-05-15 Thread Don Lewis
Author: truckman Date: Sun May 15 22:06:21 2016 New Revision: 299867 URL: https://svnweb.freebsd.org/changeset/base/299867 Log: Use strlcpy() instead of strncpy() when copying ifname to ensure that it is NUL terminated. Additional NUL padding is not required for short names. MFC after:

Re: svn commit: r299867 - head/usr.sbin/rtadvd

2016-05-15 Thread Don Lewis
On 15 May, To: src-committ...@freebsd.org wrote: > Author: truckman > Date: Sun May 15 22:06:21 2016 > New Revision: 299867 > URL: https://svnweb.freebsd.org/changeset/base/299867 > > Log: > Use strlcpy() instead of strncpy() when copying ifname to ensure > that it is NUL terminated. Addition

svn commit: r299868 - head/usr.sbin/rtsold

2016-05-15 Thread Don Lewis
Author: truckman Date: Sun May 15 22:17:41 2016 New Revision: 299868 URL: https://svnweb.freebsd.org/changeset/base/299868 Log: Use strlcpy() instead of strncpy() when copying ifname to ensure that it is NUL terminated. Additional NUL padding is not required for short names. Reported b

Re: svn commit: r299867 - head/usr.sbin/rtadvd

2016-05-15 Thread Don Lewis
On 15 May, To: src-committ...@freebsd.org wrote: > On 15 May, To: src-committ...@freebsd.org wrote: >> Author: truckman >> Date: Sun May 15 22:06:21 2016 >> New Revision: 299867 >> URL: https://svnweb.freebsd.org/changeset/base/299867 >> >> Log: >> Use strlcpy() instead of strncpy() when copying

svn commit: r299869 - head/usr.sbin/route6d

2016-05-15 Thread Don Lewis
Author: truckman Date: Sun May 15 22:31:03 2016 New Revision: 299869 URL: https://svnweb.freebsd.org/changeset/base/299869 Log: Use strlcpy() instead of strncpy() when copying ifname to ensure that it is NUL terminated. Additional NUL padding is not required for short names. Reported b

svn commit: r299873 - head/sbin/ifconfig

2016-05-15 Thread Don Lewis
Author: truckman Date: Mon May 16 00:25:24 2016 New Revision: 299873 URL: https://svnweb.freebsd.org/changeset/base/299873 Log: Use strlcpy() instead of strncpy() when copying ifname to ensure that it is NUL terminated. Additional NUL padding is not required for short names. Use sizeof

svn commit: r299879 - head/lib/libc/resolv

2016-05-15 Thread Don Lewis
Author: truckman Date: Mon May 16 01:30:32 2016 New Revision: 299879 URL: https://svnweb.freebsd.org/changeset/base/299879 Log: Likely a false positive ... but make sure that -1 can't be used as an array index by splitting up a test. Reported by: Coverity CID: 603941 MFC aft

svn commit: r299880 - head/lib/libc/resolv

2016-05-15 Thread Don Lewis
Author: truckman Date: Mon May 16 01:38:24 2016 New Revision: 299880 URL: https://svnweb.freebsd.org/changeset/base/299880 Log: Since rdata is only used as an argument to the immediately following call to res_nopt_rdata(), revert r299879 and fix CID 603941 by moving rdata = &buf[n];

svn commit: r299893 - head/usr.sbin/config

2016-05-15 Thread Don Lewis
Author: truckman Date: Mon May 16 04:39:16 2016 New Revision: 299893 URL: https://svnweb.freebsd.org/changeset/base/299893 Log: Don't free fnamebuf before we calling cfgfile_add(). This changes a use-after-free error into a minor memory leak. Reported by: Coverity CID: 100608

svn commit: r299894 - head/usr.sbin/ctld

2016-05-15 Thread Don Lewis
Author: truckman Date: Mon May 16 04:43:47 2016 New Revision: 299894 URL: https://svnweb.freebsd.org/changeset/base/299894 Log: pdu_delete(request) frees request, so move the call after login_new_response(request) to avoid a use-after-free error Reported by: Coverity Reviewed by: 1331

Re: svn commit: r299893 - head/usr.sbin/config

2016-05-15 Thread Don Lewis
On 16 May, To: src-committ...@freebsd.org wrote: > Author: truckman > Date: Mon May 16 04:39:16 2016 > New Revision: 299893 > URL: https://svnweb.freebsd.org/changeset/base/299893 > > Log: > Don't free fnamebuf before we calling cfgfile_add(). This changes a > use-after-free error into a mino

Re: svn commit: r299894 - head/usr.sbin/ctld

2016-05-15 Thread Don Lewis
On 16 May, To: src-committ...@freebsd.org wrote: > Author: truckman > Date: Mon May 16 04:43:47 2016 > New Revision: 299894 > URL: https://svnweb.freebsd.org/changeset/base/299894 > > Log: > pdu_delete(request) frees request, so move the call after > login_new_response(request) to avoid a use-

svn commit: r299897 - head/usr.sbin/rpc.lockd

2016-05-15 Thread Don Lewis
Author: truckman Date: Mon May 16 05:17:43 2016 New Revision: 299897 URL: https://svnweb.freebsd.org/changeset/base/299897 Log: NULL releasedfl after calling deallocate_file_lock() which frees it to avoid a use-after-free error in the debuglog() call at the top of the loop. Reported by:

  1   2   >