svn commit: r267851 - in head/sys/cddl: contrib/opensolaris/uts/common/dtrace dev/dtrace

2014-06-24 Thread Davide Italiano
Author: davide Date: Wed Jun 25 03:54:02 2014 New Revision: 267851 URL: http://svnweb.freebsd.org/changeset/base/267851 Log: Continue the crusade towards a dev_clone()-free kernel, removing its usage from dtrace. The dtrace code already uses cdevpriv(9) since FreeBSD 8, so this change should

svn commit: r267896 - head/sys/sys

2014-06-25 Thread Davide Italiano
Author: davide Date: Thu Jun 26 05:23:48 2014 New Revision: 267896 URL: http://svnweb.freebsd.org/changeset/base/267896 Log: Improve r264388 removing namespace pollution previously introduced in . INT64_MAX actually requires __INT64_C() hack to get the type right on exotic architectures (e.g

svn commit: r269502 - head/sys/kern

2014-08-03 Thread Davide Italiano
Author: davide Date: Mon Aug 4 05:40:51 2014 New Revision: 269502 URL: http://svnweb.freebsd.org/changeset/base/269502 Log: Fix an overflow in getsockopt(). optval isn't big enough to hold sbintime_t. Re-introduce r255030 behaviour capping socket timeouts to INT_32 if they're too large.

svn commit: r270221 - head/sys/security/audit

2014-08-20 Thread Davide Italiano
Author: davide Date: Wed Aug 20 16:04:30 2014 New Revision: 270221 URL: http://svnweb.freebsd.org/changeset/base/270221 Log: Replace dev_clone with cdevpriv(9) KPI in audit_pipe code. This is (yet another) step towards the removal of device cloning from our kernel. CR: https://reviews

svn commit: r270227 - head/sys/sys

2014-08-20 Thread Davide Italiano
Author: davide Date: Wed Aug 20 16:32:02 2014 New Revision: 270227 URL: http://svnweb.freebsd.org/changeset/base/270227 Log: Make Bruce happy removing the "LL abomination" from time.h It's not necessary in all the three instances because they already have the correct type on all the supporte

Re: svn commit: r270227 - head/sys/sys

2014-08-20 Thread Davide Italiano
On Wed, Aug 20, 2014 at 9:32 AM, Davide Italiano wrote: > Author: davide > Date: Wed Aug 20 16:32:02 2014 > New Revision: 270227 > URL: http://svnweb.freebsd.org/changeset/base/270227 > > Log: > Make Bruce happy removing the "LL abomination" from time.h > I

Re: svn commit: r270227 - head/sys/sys

2014-08-20 Thread Davide Italiano
On Wed, Aug 20, 2014 at 12:42 PM, Xin Li wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > On 08/20/14 09:32, Davide Italiano wrote: >> Author: davide Date: Wed Aug 20 16:32:02 2014 New Revision: 270227 >> URL: http://svnweb.freebsd.org/changeset/base/2702

svn commit: r270261 - head/sys/sys

2014-08-21 Thread Davide Italiano
Author: davide Date: Thu Aug 21 09:01:42 2014 New Revision: 270261 URL: http://svnweb.freebsd.org/changeset/base/270261 Log: Revert r270227. GCC doesn't like the lack of LL suffix, so this makes powerpc build failing. Modified: head/sys/sys/time.h Modified: head/sys/sys/time.h

svn commit: r250096 - head/sys/dev/hwpmc

2013-04-30 Thread Davide Italiano
Author: davide Date: Tue Apr 30 08:18:08 2013 New Revision: 250096 URL: http://svnweb.freebsd.org/changeset/base/250096 Log: Fixup Westmere hwpmc(4) support: add missing CPU flag so that intrucion-retired, llc-misses and llc-reference events can now be allocated. Reviewed by: jimharris

svn commit: r250097 - head/sys/dev/hwpmc

2013-04-30 Thread Davide Italiano
Author: davide Date: Tue Apr 30 08:33:38 2013 New Revision: 250097 URL: http://svnweb.freebsd.org/changeset/base/250097 Log: When hwpmc(4) module is unloaded it reports a double leakage. This happens at least if FreeBSD is ran under VirtualBox. In order to avoid the leakage, properly dealloc

svn commit: r250101 - head/sys/dev/hwpmc

2013-04-30 Thread Davide Italiano
Author: davide Date: Tue Apr 30 14:56:41 2013 New Revision: 250101 URL: http://svnweb.freebsd.org/changeset/base/250101 Log: Complete r250097: Do not change the initialization order in pmc_intel_initialize(). Modified: head/sys/dev/hwpmc/hwpmc_intel.c Modified: head/sys/dev/hwpmc/hwpmc_int

svn commit: r250103 - head/sys/dev/hwpmc

2013-04-30 Thread Davide Italiano
Author: davide Date: Tue Apr 30 15:31:45 2013 New Revision: 250103 URL: http://svnweb.freebsd.org/changeset/base/250103 Log: The Intel PMC architectural events have encodings which are identical to those of some non-architectural core events. This is not a problem in the general case as long

svn commit: r250105 - head/sys/dev/hwpmc

2013-04-30 Thread Davide Italiano
Author: davide Date: Tue Apr 30 15:59:22 2013 New Revision: 250105 URL: http://svnweb.freebsd.org/changeset/base/250105 Log: malloc(9) cannot return NULL if M_WAITOK flag is specified. Modified: head/sys/dev/hwpmc/hwpmc_mod.c head/sys/dev/hwpmc/hwpmc_soft.c Modified: head/sys/dev/hwpmc/hwp

svn commit: r250149 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-05-01 Thread Davide Italiano
Author: davide Date: Wed May 1 17:34:44 2013 New Revision: 250149 URL: http://svnweb.freebsd.org/changeset/base/250149 Log: In case ZFS doesn't use UMA for buffers there's no need to waste memory creating zones that will remain empty. Reviewed by: pjd Modified: head/sys/cddl/contrib/

svn commit: r250182 - head/sys/dev/hwpmc

2013-05-02 Thread Davide Italiano
Author: davide Date: Thu May 2 14:55:21 2013 New Revision: 250182 URL: http://svnweb.freebsd.org/changeset/base/250182 Log: Suppress a GCC warning. This warning is actually bogus and newer GCC versions than the one in base (dim@ mentioned he tried on 4.7.3 and 4.8.1) do not whine about it,

svn commit: r250236 - in head: contrib/smbfs/lib/smb contrib/smbfs/mount_smbfs sys/fs/smbfs sys/netsmb

2013-05-04 Thread Davide Italiano
Author: davide Date: Sat May 4 14:03:18 2013 New Revision: 250236 URL: http://svnweb.freebsd.org/changeset/base/250236 Log: Completely rewrite the interface to smbdev switching from dev_clone to cdevpriv(9). This commit changes the semantic of mount_smbfs in userland as well, which now pass

svn commit: r250237 - in head/sys: fs/smbfs netsmb

2013-05-04 Thread Davide Italiano
Author: davide Date: Sat May 4 14:18:10 2013 New Revision: 250237 URL: http://svnweb.freebsd.org/changeset/base/250237 Log: Overhaul locking in netsmb, getting rid of the obsolete lockmgr() primitive. This solves a long standing LOR between smb_conn and smb_vc. Tested by:martymac, ph

svn commit: r250238 - head/sys/fs/smbfs

2013-05-04 Thread Davide Italiano
Author: davide Date: Sat May 4 14:27:28 2013 New Revision: 250238 URL: http://svnweb.freebsd.org/changeset/base/250238 Log: Change VM_OBJECT_LOCK/UNLOCK() -> VM_OBJECT_WLOCK/WUNLOCK() to reflect the recent switch of the vm object lock to a rwlock. Reported by: attilio Modified: head/

svn commit: r250243 - head/sys/netsmb

2013-05-04 Thread Davide Italiano
Author: davide Date: Sat May 4 16:55:48 2013 New Revision: 250243 URL: http://svnweb.freebsd.org/changeset/base/250243 Log: If the kernel is compiled with VMIMAGE support, the first attempt of mounting smbfs share will cause a panic. Fix setting setting/restoring vnet context when needed.

svn commit: r252352 - head/sys/fs/smbfs

2013-06-28 Thread Davide Italiano
Author: davide Date: Fri Jun 28 20:07:24 2013 New Revision: 252352 URL: http://svnweb.freebsd.org/changeset/base/252352 Log: Plug a couple of leakages in smbfs_lookup(). Modified: head/sys/fs/smbfs/smbfs_vnops.c Modified: head/sys/fs/smbfs/smbfs_vnops.c ==

svn commit: r252353 - head/sys/fs/smbfs

2013-06-28 Thread Davide Italiano
Author: davide Date: Fri Jun 28 20:14:30 2013 New Revision: 252353 URL: http://svnweb.freebsd.org/changeset/base/252353 Log: Garbage collect an useless check. smp should be never NULL. Modified: head/sys/fs/smbfs/smbfs_vfsops.c Modified: head/sys/fs/smbfs/smbfs_vfsops.c =

svn commit: r252354 - head/sys/netsmb

2013-06-28 Thread Davide Italiano
Author: davide Date: Fri Jun 28 20:21:13 2013 New Revision: 252354 URL: http://svnweb.freebsd.org/changeset/base/252354 Log: Remove a reference to LK_DRAIN now that lockmgr(9) is gone from this piece of code. Reported by: attilio Modified: head/sys/netsmb/smb_conn.c Modified: head/sy

svn commit: r252355 - head/sys/fs/smbfs

2013-06-28 Thread Davide Italiano
Author: davide Date: Fri Jun 28 20:32:48 2013 New Revision: 252355 URL: http://svnweb.freebsd.org/changeset/base/252355 Log: Properly use v_data field. This magically worked (even if wrong) until now because v_data is the first field of the structure, but it's not something we should rely on

svn commit: r252356 - in head: contrib/smbfs/mount_smbfs etc/defaults etc/mtree include lib lib/libprocstat rescue/rescue sbin/mount share/examples share/examples/etc share/mk sys/conf sys/kern sys...

2013-06-28 Thread Davide Italiano
Author: davide Date: Fri Jun 28 21:00:08 2013 New Revision: 252356 URL: http://svnweb.freebsd.org/changeset/base/252356 Log: - Trim an unused and bogus Makefile for mount_smbfs. - Reconnect with some minor modifications, in particular now selsocket() internals are adapted to use sbintime uni

svn commit: r252357 - head/sys/kern

2013-06-28 Thread Davide Italiano
Author: davide Date: Fri Jun 28 21:04:15 2013 New Revision: 252357 URL: http://svnweb.freebsd.org/changeset/base/252357 Log: Correct the comment above _sleep() function which still mentions 'timo' instead of 'sbintime_t'. Reported by: kan Modified: head/sys/kern/kern_synch.c Modified

svn commit: r252358 - head/sys/vm

2013-06-28 Thread Davide Italiano
Author: davide Date: Fri Jun 28 21:13:19 2013 New Revision: 252358 URL: http://svnweb.freebsd.org/changeset/base/252358 Log: Remove a spurious keg lock acquisition. Modified: head/sys/vm/uma_core.c Modified: head/sys/vm/uma_core.c =

svn commit: r273174 - in head/sys: amd64/amd64 amd64/vmm arm/arm cam/ata cddl/contrib/opensolaris/uts/common/dtrace dev/acpica dev/asmc dev/cfi dev/drm2 dev/hatm dev/mii dev/nfe dev/patm dev/pci de...

2014-10-16 Thread Davide Italiano
Author: davide Date: Thu Oct 16 18:04:43 2014 New Revision: 273174 URL: https://svnweb.freebsd.org/changeset/base/273174 Log: Follow up to r225617. In order to maximize the re-usability of kernel code in userland rename in-kernel getenv()/setenv() to kern_setenv()/kern_getenv(). This fixes a

Re: svn commit: r273174 - in head/sys: amd64/amd64 amd64/vmm arm/arm cam/ata cddl/contrib/opensolaris/uts/common/dtrace dev/acpica dev/asmc dev/cfi dev/drm2 dev/hatm dev/mii dev/nfe dev/patm dev/pci d

2014-10-16 Thread Davide Italiano
On Thu, Oct 16, 2014 at 4:44 PM, Bjoern A. Zeeb wrote: > > On 16 Oct 2014, at 18:04 , Davide Italiano wrote: > >> Author: davide >> Date: Thu Oct 16 18:04:43 2014 >> New Revision: 273174 >> URL: https://svnweb.freebsd.org/changeset/base/273174 >> >&g

Re: svn commit: r273174 - in head/sys: amd64/amd64 amd64/vmm arm/arm cam/ata cddl/contrib/opensolaris/uts/common/dtrace dev/acpica dev/asmc dev/cfi dev/drm2 dev/hatm dev/mii dev/nfe dev/patm dev/pci d

2014-10-16 Thread Davide Italiano
On Thu, Oct 16, 2014 at 8:30 PM, Garrett Cooper wrote: > >> BTW, it would be cool if universe will put logs of successful builds >> and logs of failed builds in different directories for easier >> inspection. >> If there's already something like this and you can point me to that, >> it would be ap

Re: svn commit: r273174 - in head/sys: amd64/amd64 amd64/vmm arm/arm cam/ata cddl/contrib/opensolaris/uts/common/dtrace dev/acpica dev/asmc dev/cfi dev/drm2 dev/hatm dev/mii dev/nfe dev/patm dev/pci d

2014-10-17 Thread Davide Italiano
On Thu, Oct 16, 2014 at 9:07 PM, Davide Italiano wrote: > On Thu, Oct 16, 2014 at 8:30 PM, Garrett Cooper wrote: >> >> I think you want make tinderbox instead of make universe (make universe >> doesn't display builds errors whereas make tinderbox does). &g

svn commit: r273234 - in head/sys: dev/cfe dev/nvram2env mips/beri mips/rmi mips/rt305x

2014-10-17 Thread Davide Italiano
Author: davide Date: Fri Oct 17 17:34:05 2014 New Revision: 273234 URL: https://svnweb.freebsd.org/changeset/base/273234 Log: Convert remaining {g,s}etenv->kern_{g,s}etenv left over from r273174. Reported by:bz Modified: head/sys/dev/cfe/cfe_env.c head/sys/dev/nvram2env/nvram2env

svn commit: r274834 - head/sys/ufs/ufs

2014-11-21 Thread Davide Italiano
Author: davide Date: Sat Nov 22 00:37:37 2014 New Revision: 274834 URL: https://svnweb.freebsd.org/changeset/base/274834 Log: Make ufs_dirhashreclaimperc a percentage for real and rename it to ufs_dirhashreclaimpercent, as suggested by jhb@. As an added bonus this avoids divide-by-zero err

svn commit: r274835 - head/sys/ufs/ufs

2014-11-21 Thread Davide Italiano
Author: davide Date: Sat Nov 22 00:42:30 2014 New Revision: 274835 URL: https://svnweb.freebsd.org/changeset/base/274835 Log: Use the correct variable name. Modified: head/sys/ufs/ufs/ufs_dirhash.c Modified: head/sys/ufs/ufs/ufs_dirhash.c =

Re: svn commit: r282250 - head/sys/sys

2015-04-29 Thread Davide Italiano
On Wed, Apr 29, 2015 at 3:00 PM, Mariusz Zaborski wrote: > Author: oshogbo > Date: Wed Apr 29 22:00:26 2015 > New Revision: 282250 > URL: https://svnweb.freebsd.org/changeset/base/282250 > > Log: > Nvlist functionality is not used within interrupt context, so we should > use M_WAITOK to alloca

Re: svn commit: r282250 - head/sys/sys

2015-04-29 Thread Davide Italiano
On Wed, Apr 29, 2015 at 3:30 PM, Mariusz Zaborski wrote: > On 30 April 2015 at 00:28, Davide Italiano wrote: >> >> On Wed, Apr 29, 2015 at 3:00 PM, Mariusz Zaborski >> wrote: >> > Author: oshogbo >> > Date: Wed Apr 29 22:00:26 2015 >> > New Revis

Re: svn commit: r282250 - head/sys/sys

2015-04-29 Thread Davide Italiano
On Wed, Apr 29, 2015 at 3:38 PM, Mariusz Zaborski wrote: >> I'm talking about sys/kern/subr_nvlist.c. > > Yes. lib/libnv is compiling sys/kern/subr_nvlist.c. > This is the reason why we have nv_malloc. > One nv_malloc is for kernel: > > #define nv_malloc(size)malloc((size), M_NVLIST, M_WAITOK)

svn commit: r264388 - in head/sys: kern sys

2014-04-12 Thread Davide Italiano
Author: davide Date: Sat Apr 12 23:29:29 2014 New Revision: 264388 URL: http://svnweb.freebsd.org/changeset/base/264388 Log: Hide internal details of sbintime_t implementation wrapping INT64_MAX into SBT_MAX, to make it more robust in case internal type representation will change in the futu

svn commit: r264392 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2014-04-12 Thread Davide Italiano
Author: davide Date: Sun Apr 13 01:15:37 2014 New Revision: 264392 URL: http://svnweb.freebsd.org/changeset/base/264392 Log: Fix a panic in zfs_rename(). this is due to a wrong dereference of a vnode when it's not locked and can be (potentially) recycled. 'sdvp' cannot be locked on zfs_renam

Re: svn commit: r264392 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2014-04-12 Thread Davide Italiano
On Sat, Apr 12, 2014 at 6:43 PM, Steven Hartland wrote: > Interesting, I'd be curious to know what the panic for this looks like? > It's more like a 'trap 12: page fault while in kernel mode'. Post-mortem analysis with kgdb shows the vnode fields filled with garbage (e.g. 0xdeadc0de), if you're l

svn commit: r267092 - head/sys/kern

2014-06-04 Thread Davide Italiano
Author: davide Date: Thu Jun 5 03:46:46 2014 New Revision: 267092 URL: http://svnweb.freebsd.org/changeset/base/267092 Log: Convert functions to the new-style format. Submitted by: Vijay Singh via -hackers Modified: head/sys/kern/kern_timeout.c Modified: head/sys/kern/kern_timeout.c =

Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys

2015-01-15 Thread Davide Italiano
On Thu, Jan 15, 2015 at 7:32 AM, Hans Petter Selasky wrote: > Author: hselasky > Date: Thu Jan 15 15:32:30 2015 > New Revision: 277213 > URL: https://svnweb.freebsd.org/changeset/base/277213 > > Log: > Major callout subsystem cleanup and rewrite: I plan to review this as well -- although I didn

Re: svn commit: r277570 - head/usr.bin/vmstat

2015-01-23 Thread Davide Italiano
On Fri, Jan 23, 2015 at 8:18 AM, Will Andrews wrote: > Author: will > Date: Fri Jan 23 16:18:39 2015 > New Revision: 277570 > URL: https://svnweb.freebsd.org/changeset/base/277570 > > Log: > Use CLOCK_UPTIME to get the uptime instead of CLOCK_MONOTONIC. > > Submitted by: asomers > MFC after:

Re: svn commit: r277570 - head/usr.bin/vmstat

2015-01-23 Thread Davide Italiano
On Fri, Jan 23, 2015 at 12:56 PM, Will Andrews wrote: > On Fri, Jan 23, 2015 at 11:23:57AM -0800, Davide Italiano wrote: >> What's the rationale behind this change? > > The rationale was to match the clock used to the name (and implied intent) > of the variables used to st

Re: svn commit: r277877 - head/lib/libc/mips/gen

2015-01-29 Thread Davide Italiano
On Thu, Jan 29, 2015 at 7:30 AM, Ed Maste wrote: > Author: emaste > Date: Thu Jan 29 15:30:04 2015 > New Revision: 277877 > URL: https://svnweb.freebsd.org/changeset/base/277877 > > Log: > Use zero register instead of immediate 0x0 in MIPS assembly > > It seems GAS makes the substitution autom

Re: svn commit: r278040 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-02-01 Thread Davide Italiano
On Mon, Feb 2, 2015 at 1:17 AM, Steven Hartland wrote: > Author: smh > Date: Mon Feb 2 00:17:36 2015 > New Revision: 278040 > URL: https://svnweb.freebsd.org/changeset/base/278040 > > Log: > Prevent inlining txg_quiesce > > This allows dtrace to monitor the calls to txg_quiesce which can be r

svn commit: r278306 - head/sys/conf

2015-02-05 Thread Davide Italiano
Author: davide Date: Fri Feb 6 03:49:31 2015 New Revision: 278306 URL: https://svnweb.freebsd.org/changeset/base/278306 Log: Always prefer double dashes for GNU LD long options. I discovered this while working on llvm/lld and realized export-dynamic only supported --. Although upstream w

svn commit: r278780 - head/sys/kern

2015-02-14 Thread Davide Italiano
Author: davide Date: Sat Feb 14 20:00:57 2015 New Revision: 278780 URL: https://svnweb.freebsd.org/changeset/base/278780 Log: Don't access sockbuf fields directly, use accessor functions instead. It is safe to move the call to socantsendmore_locked() after sbdrop_locked() as long as we hold

Re: svn commit: r279539 - head/sys/sys

2015-03-02 Thread Davide Italiano
On Mon, Mar 2, 2015 at 12:05 PM, John-Mark Gurney wrote: > Author: jmg > Date: Mon Mar 2 20:05:16 2015 > New Revision: 279539 > URL: https://svnweb.freebsd.org/changeset/base/279539 > > Log: > give others fair warning that _SPARE2 isn't just cxgb, but used by large > number of other subsystem

Re: svn commit: r279539 - head/sys/sys

2015-03-03 Thread Davide Italiano
On Mar 3, 2015 9:27 AM, "John-Mark Gurney" wrote: > > Julian Elischer wrote this message on Tue, Mar 03, 2015 at 01:20 -0800: > > On 3/2/15 4:55 PM, Neel Natu wrote: > > > Hi Davide, > > > > > > On Mon, Mar 2, 2015 at 12:26 PM, Davide Italiano wr

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-28 Thread Davide Italiano
On Sat, Mar 28, 2015 at 5:50 AM, Randall Stewart wrote: > Author: rrs > Date: Sat Mar 28 12:50:24 2015 > New Revision: 280785 > URL: https://svnweb.freebsd.org/changeset/base/280785 > > Log: > Change the callout to supply -1 to indicate we are not changing > CPU, also add protection against in

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-28 Thread Davide Italiano
On Sat, Mar 28, 2015 at 12:04 PM, Randall Stewart wrote: > Hmm does the KPI include the size of the callout structure (which is > private)? > It's KBI, not KPI. > If so I suppose we could change the c_flags/c_iflags to > ushort … > I'm not familiar with your changes enough to suggest/propose a

svn commit: r270588 - head/sys/ufs/ufs

2014-08-25 Thread Davide Italiano
Author: davide Date: Mon Aug 25 17:06:18 2014 New Revision: 270588 URL: http://svnweb.freebsd.org/changeset/base/270588 Log: Rather than using an hardcoded reclaim age, rely on an LRU-like approach for dirhash cache, setting a target percent to reclaim (exposed via SYSCTL). This allows to al

Re: svn commit: r270710 - in head/sys: contrib/rdma/krping dev/cxgb dev/cxgbe/iw_cxgbe modules/mlx4 modules/mlx4ib modules/mlxen ofed/drivers/infiniband/core ofed/drivers/infiniband/hw/mlx4 ofed/drive

2014-08-27 Thread Davide Italiano
On Wed, Aug 27, 2014 at 11:59 AM, Hans Petter Selasky wrote: >> Removing those files may make it more annoying to port some other >> linux code in the future, as some future linux driver code may include >> those files. >> > On a (somewhat) related note, I would like to see sema(9) replaced by sx

Re: svn commit: r270261 - head/sys/sys

2014-09-07 Thread Davide Italiano
On Sun, Sep 7, 2014 at 1:14 PM, Rui Paulo wrote: > On Aug 21, 2014, at 02:01, Davide Italiano wrote: >> >> Author: davide >> Date: Thu Aug 21 09:01:42 2014 >> New Revision: 270261 >> URL: http://svnweb.freebsd.org/changeset/base/270261 >> >> Log: >

svn commit: r271736 - head/usr.sbin/makefs

2014-09-17 Thread Davide Italiano
Author: davide Date: Thu Sep 18 03:11:59 2014 New Revision: 271736 URL: http://svnweb.freebsd.org/changeset/base/271736 Log: r258695 introduces a sanity check for makefs in order to verify that the minimum image size specified is always less than the maximum image size. If makefs(1) is invok

Re: svn commit: r272366 - head/sys/kern

2014-10-01 Thread Davide Italiano
On Wed, Oct 1, 2014 at 8:32 AM, Will Andrews wrote: > Author: will > Date: Wed Oct 1 15:32:28 2014 > New Revision: 272366 > URL: https://svnweb.freebsd.org/changeset/base/272366 > > Log: > In the syncer, drop the sync mutex while patting the watchdog. > > Some watchdog drivers (like ipmi) nee

Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys

2015-09-18 Thread Davide Italiano
On Thu, Sep 17, 2015 at 12:20 AM, Hans Petter Selasky wrote: > On 09/17/15 00:05, Gleb Smirnoff wrote: >> >> Weren't you explicitly asked not to touch this system without a proper >> review and discussion? > > > Adding a new function is not touching code. > > --HPS > I tried to stay away from thi

svn commit: r234302 - in head/sys: conf kern

2012-04-14 Thread Davide Italiano
Author: davide Date: Sat Apr 14 23:53:31 2012 New Revision: 234302 URL: http://svn.freebsd.org/changeset/base/234302 Log: Fix some style bugs introduced in a previous commit (r233045) Reported by: glebius, jmallet Reviewed by: jmallet Approved by: gnn (mentor) MFC after:2 days

svn commit: r234303 - head/sys/kern

2012-04-14 Thread Davide Italiano
Author: davide Date: Sat Apr 14 23:59:58 2012 New Revision: 234303 URL: http://svn.freebsd.org/changeset/base/234303 Log: Fix a typo. Approved by: gnn (mentor) MFC after:2 days Modified: head/sys/kern/subr_turnstile.c Modified: head/sys/kern/subr_turnstile.c =

svn commit: r237195 - head/sys/kern

2012-06-17 Thread Davide Italiano
Author: davide Date: Sun Jun 17 13:03:50 2012 New Revision: 237195 URL: http://svn.freebsd.org/changeset/base/237195 Log: The variable 'error' in sys_poll() is initialized in declaration to value zero but in any case is overwritten by successive copyin(), making the previous initialization u

svn commit: r237196 - head/sys/dev/hwpmc

2012-06-17 Thread Davide Italiano
Author: davide Date: Sun Jun 17 13:48:39 2012 New Revision: 237196 URL: http://svn.freebsd.org/changeset/base/237196 Log: Disable hwpmc(4) support for Intel Xeon Sandy Bridge (Model 0x2D). Due to some differences in MSRs between Xeon Sandy Bridge and Core Sandy Bridge (Model 0x2A), wrmsr() m

Re: svn commit: r238539 - head/sys/fs/smbfs

2012-10-10 Thread Davide Italiano
On Wed, Jul 18, 2012 at 2:11 PM, Christian Brueffer wrote: > On 7/17/12 0:10 , Attilio Rao wrote: >> 2012/7/16 Christian Brueffer : >>> Author: brueffer >>> Date: Mon Jul 16 22:07:29 2012 >>> New Revision: 238539 >>> URL: http://svn.freebsd.org/changeset/base/238539 >>> >>> Log: >>> Simply error

svn commit: r242092 - head/sys/fs/smbfs

2012-10-25 Thread Davide Italiano
Author: davide Date: Thu Oct 25 20:23:04 2012 New Revision: 242092 URL: http://svn.freebsd.org/changeset/base/242092 Log: - Remove the references to the deprecated zalloc kernel interface - Use M_ZERO flag in malloc() rather than bzero() - malloc() with M_NOWAIT can't return NULL so there's

svn commit: r242097 - head/sys/fs/smbfs

2012-10-25 Thread Davide Italiano
Author: davide Date: Thu Oct 25 21:08:02 2012 New Revision: 242097 URL: http://svn.freebsd.org/changeset/base/242097 Log: Fix build in case we have SMBVDEBUG turned on. Reviewed by: gnn Approved by: gnn Sponsored by: iXsystems inc. Modified: head/sys/fs/smbfs/smbfs_io.c head/sys/

svn commit: r242202 - head/sys/kern

2012-10-27 Thread Davide Italiano
Author: davide Date: Sat Oct 27 23:42:41 2012 New Revision: 242202 URL: http://svn.freebsd.org/changeset/base/242202 Log: The fields of struct timespec32 should be int32_t and not uint32_t. Make this change. Reviewed by: bde, davidxu Tested by:pho MFC after:1 week Modified:

svn commit: r242384 - head/sys/fs/smbfs

2012-10-30 Thread Davide Italiano
Author: davide Date: Wed Oct 31 02:54:44 2012 New Revision: 242384 URL: http://svn.freebsd.org/changeset/base/242384 Log: Change the code to use %jd as printf() placeholder for uio_offset and cast to intmax_t. Suggested by: pjd Sponsored by: iXsystems inc. Modified: head/sys/fs/smbfs

svn commit: r242386 - in head/sys: fs/smbfs netsmb

2012-10-30 Thread Davide Italiano
Author: davide Date: Wed Oct 31 03:34:07 2012 New Revision: 242386 URL: http://svn.freebsd.org/changeset/base/242386 Log: Fix panic due to page faults while in kernel mode, under conditions of VM pressure. The reason is that in some codepaths pointers to stack variables were passed from one

svn commit: r242387 - head/sys/fs/smbfs

2012-10-30 Thread Davide Italiano
Author: davide Date: Wed Oct 31 03:55:33 2012 New Revision: 242387 URL: http://svn.freebsd.org/changeset/base/242387 Log: - Do not put in the mntqueue half-constructed vnodes. - Change the code so that it relies on vfs_hash rather than on a home-made hashtable. - There's no need to inlin

Re: svn commit: r242387 - head/sys/fs/smbfs

2012-10-30 Thread Davide Italiano
On Wed, Oct 31, 2012 at 4:55 AM, Davide Italiano wrote: > Author: davide > Date: Wed Oct 31 03:55:33 2012 > New Revision: 242387 > URL: http://svn.freebsd.org/changeset/base/242387 > > Log: > - Do not put in the mntqueue half-constructed vnodes. > - Change the c

Re: svn commit: r242387 - head/sys/fs/smbfs

2012-10-30 Thread Davide Italiano
On Wed, Oct 31, 2012 at 4:57 AM, Davide Italiano wrote: > On Wed, Oct 31, 2012 at 4:55 AM, Davide Italiano wrote: >> Author: davide >> Date: Wed Oct 31 03:55:33 2012 >> New Revision: 242387 >> URL: http://svn.freebsd.org/changeset/base/242387 >> >> Log:

svn commit: r243033 - head/sys/fs/smbfs

2012-11-14 Thread Davide Italiano
Author: davide Date: Wed Nov 14 18:43:58 2012 New Revision: 243033 URL: http://svnweb.freebsd.org/changeset/base/243033 Log: Fix the lookup in the DOTDOT case in the same way as other filesystems do, i.e. inlining the vn_vget_ino() algorithm. Sponsored by: iXsystems inc. Modified: head

svn commit: r243038 - head/sys/fs/smbfs

2012-11-14 Thread Davide Italiano
Author: davide Date: Wed Nov 14 19:10:50 2012 New Revision: 243038 URL: http://svnweb.freebsd.org/changeset/base/243038 Log: Get rid of some old debug code. It provides checks similar to the one offered by RedZone so there's no need to keep it. Sponsored by: iXsystems inc. Modified: he

Re: svn commit: r243307 - head/sys/kern

2012-11-19 Thread Davide Italiano
On Mon, Nov 19, 2012 at 9:43 PM, Attilio Rao wrote: > Author: attilio > Date: Mon Nov 19 20:43:19 2012 > New Revision: 243307 > URL: http://svnweb.freebsd.org/changeset/base/243307 > > Log: > insmntque() is always called with the lock held in exclusive mode, > then: > - assume the lock is he

Re: svn commit: r243307 - head/sys/kern

2012-11-19 Thread Davide Italiano
On Mon, Nov 19, 2012 at 9:55 PM, Attilio Rao wrote: > On Mon, Nov 19, 2012 at 8:53 PM, Davide Italiano wrote: >> On Mon, Nov 19, 2012 at 9:43 PM, Attilio Rao wrote: >>> Author: attilio >>> Date: Mon Nov 19 20:43:19 2012 >>> New Revision: 243307 >>>

svn commit: r243396 - head/sys/fs/smbfs

2012-11-22 Thread Davide Italiano
Author: davide Date: Thu Nov 22 08:58:29 2012 New Revision: 243396 URL: http://svnweb.freebsd.org/changeset/base/243396 Log: Until now, smbfs_fullpath() computed the full path starting from the vnode and following back the chain of n_parent pointers up to the root, without acquiring the lock

svn commit: r243397 - head/sys/fs/smbfs

2012-11-22 Thread Davide Italiano
Author: davide Date: Thu Nov 22 09:13:45 2012 New Revision: 243397 URL: http://svnweb.freebsd.org/changeset/base/243397 Log: - Remove reset of vpp pointer in some places as long as it's not really useful and has the side effect of obfuscating the code a bit. - Remove spurious references to s

svn commit: r243548 - head/sys/fs/smbfs

2012-11-25 Thread Davide Italiano
Author: davide Date: Mon Nov 26 04:29:47 2012 New Revision: 243548 URL: http://svnweb.freebsd.org/changeset/base/243548 Log: - smbfs_rename() might return an error value without correctly upgrading the vnode use count, and this might cause the kernel to panic if compiled with WITNESS enable.

svn commit: r238925 - in head/sys: conf kern

2012-07-30 Thread Davide Italiano
Author: davide Date: Mon Jul 30 22:46:42 2012 New Revision: 238925 URL: http://svn.freebsd.org/changeset/base/238925 Log: Until now KTR_ENTRIES, which defines the size of circular buffer used in ktr(4), was constrained to be a power of two. Remove this constraint and update sys/conf/NOTES ac

Re: svn commit: r238925 - in head/sys: conf kern

2012-07-30 Thread Davide Italiano
On Tue, Jul 31, 2012 at 12:46 AM, Davide Italiano wrote: > Author: davide > Date: Mon Jul 30 22:46:42 2012 > New Revision: 238925 > URL: http://svn.freebsd.org/changeset/base/238925 > > Log: > Until now KTR_ENTRIES, which defines the size of circular buffer used in >

svn commit: r239110 - head/sys/dev/bce

2012-08-06 Thread Davide Italiano
Author: davide Date: Mon Aug 6 22:53:24 2012 New Revision: 239110 URL: http://svn.freebsd.org/changeset/base/239110 Log: Remove a spurious bace which cause build fail in case BCE_DEBUG option is turned on. Reviewed by: delphij Approved by: gnn (mentor) Sponsored by:

svn commit: r230876 - in head: share/misc usr.bin/calendar/calendars

2012-02-01 Thread Davide Italiano
+118,7 @@ cokane [label="Coleman Kane\ncokane@Free cperciva [label="Colin Percival\ncperc...@freebsd.org\n2004/01/20"] csjp [label="Christian S.J. Peron\nc...@freebsd.org\n2004/05/04"] das [label="David Schultz\n...@freebsd.org\n2003/02/21"] +davide [label="D

svn commit: r232353 - head/usr.bin/calendar/calendars

2012-03-01 Thread Davide Italiano
(r232353) @@ -217,7 +217,7 @@ 07/11 Jesus R. Camou born in Hermosillo, Sonora, Mexico, 1983 07/15 Gary Jennejohn born in Rochester, New York, United States, 1950 07/16 Suleiman Souhlal born in Roma, Italy, 1983 -07/16 Davide Italiano born in Milazzo, Italy, 1989 +07/16 Davide

svn commit: r232366 - in head: lib/libpmc sys/dev/hwpmc sys/sys

2012-03-01 Thread Davide Italiano
mc/pmc.sandybridge.3 == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/lib/libpmc/pmc.sandybridge.3 Thu Mar 1 21:23:26 2012 (r232366) @@ -0,0 +1,932 @@ +.\" Copyright (c) 2012 Davide Italiano

svn commit: r233045 - in head/sys: conf kern

2012-03-16 Thread Davide Italiano
Author: davide Date: Fri Mar 16 20:32:11 2012 New Revision: 233045 URL: http://svn.freebsd.org/changeset/base/233045 Log: Add rudimentary profiling of the hash table used in the in the umtx code to hold active lock queues. Reviewed by: attilio Approved by: davidxu, gnn (mentor) MFC

Re: svn commit: r233045 - in head/sys: conf kern

2012-03-19 Thread Davide Italiano
2012/3/19 Gleb Smirnoff : >  Davide, > > On Fri, Mar 16, 2012 at 08:32:11PM +0000, Davide Italiano wrote: > D> Author: davide > D> Date: Fri Mar 16 20:32:11 2012 > D> New Revision: 233045 > D> URL: http://svn.freebsd.org/changeset/base/233045 > D> > D>

Re: svn commit: r233045 - in head/sys: conf kern

2012-03-19 Thread Davide Italiano
On Mon, Mar 19, 2012 at 8:54 PM, Davide Italiano wrote: > 2012/3/19 Gleb Smirnoff : >>  Davide, >> >> On Fri, Mar 16, 2012 at 08:32:11PM +, Davide Italiano wrote: >> D> Author: davide >> D> Date: Fri Mar 16 20:32:11 2012 >> D> New Revision: 23

Re: svn commit: r233045 - in head/sys: conf kern

2012-03-20 Thread Davide Italiano
2012/3/20 Gleb Smirnoff : > On Mon, Mar 19, 2012 at 09:06:36PM +0100, Davide Italiano wrote: > D> >> These indented ifdefs look like a major violation of style used > throughout > D> >> the FreeBSD kernel code. Can you please keep with common style? > D> >

svn commit: r252558 - head/sys/fs/smbfs

2013-07-03 Thread Davide Italiano
Author: davide Date: Wed Jul 3 10:31:45 2013 New Revision: 252558 URL: http://svnweb.freebsd.org/changeset/base/252558 Log: - Fix double frees/user after free. - Allocate using smb_rq_alloc() instead of inlining it. Reported by: uqs Found with: Coverity Scan Modified: head/sys/fs

Re: svn commit: r252356 - in head: contrib/smbfs/mount_smbfs etc/defaults etc/mtree include lib lib/libprocstat rescue/rescue sbin/mount share/examples share/examples/etc share/mk sys/conf sys/kern sy

2013-07-03 Thread Davide Italiano
On Wed, Jul 3, 2013 at 11:28 AM, Ulrich Spörlein wrote: > On Fri, 2013-06-28 at 21:00:08 +0000, Davide Italiano wrote: >> Author: davide >> Date: Fri Jun 28 21:00:08 2013 >> New Revision: 252356 >> URL: http://svnweb.freebsd.org/changeset/base/252356 >> >&g

Re: svn commit: r254309 - in head: share/man/man9 sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/dev/dtrace sys/cddl/dev/sdt sys/kern sys/sys

2013-08-16 Thread Davide Italiano
[trim old mails] > diff --git a/sys/sys/pmckern.h b/sys/sys/pmckern.h > index e3e18a6..90585de 100644 > --- a/sys/sys/pmckern.h > +++ b/sys/sys/pmckern.h > @@ -51,13 +51,11 @@ > #definePMC_FN_CSW_IN 2 > #definePMC_FN_CSW_OUT 3 > #define

Re: svn commit: r254520 - in head/sys: kern sys

2013-08-19 Thread Davide Italiano
On Mon, Aug 19, 2013 at 1:16 PM, Andre Oppermann wrote: > Author: andre > Date: Mon Aug 19 11:16:53 2013 > New Revision: 254520 > URL: http://svnweb.freebsd.org/changeset/base/254520 > > Log: > Remove the unused M_NOFREE mbuf flag. It didn't have any in-tree users > for a very long time, if e

Re: svn commit: r254524 - head/sys/sys

2013-08-20 Thread Davide Italiano
On Tue, Aug 20, 2013 at 7:42 PM, Andre Oppermann wrote: > On 19.08.2013 19:37, Navdeep Parhar wrote: >> >> On 08/19/13 06:56, Andre Oppermann wrote: >>> >>> Author: andre >>> Date: Mon Aug 19 13:56:14 2013 >>> New Revision: 254524 >>> URL: http://svnweb.freebsd.org/changeset/base/254524 >>> >>> Lo

Re: svn commit: r254524 - head/sys/sys

2013-08-21 Thread Davide Italiano
On Wed, Aug 21, 2013 at 5:30 PM, Andre Oppermann wrote: > On 20.08.2013 20:13, Davide Italiano wrote: >> >> On Tue, Aug 20, 2013 at 7:42 PM, Andre Oppermann >> wrote: >>> >>> On 19.08.2013 19:37, Navdeep Parhar wrote: >>>> >>>> Why

Re: svn commit: r254524 - head/sys/sys

2013-08-21 Thread Davide Italiano
On Wed, Aug 21, 2013 at 6:18 PM, Andre Oppermann wrote: > On 21.08.2013 17:59, Davide Italiano wrote: >> >> On Wed, Aug 21, 2013 at 5:30 PM, Andre Oppermann >> wrote: >>> >>> On 20.08.2013 20:13, Davide Italiano wrote: >>>> >>>> &g

Re: svn commit: r254616 - head/sys/dev/hwpmc

2013-08-21 Thread Davide Italiano
On Wed, Aug 21, 2013 at 2:47 PM, Adrian Chadd wrote: > Author: adrian > Date: Wed Aug 21 21:47:56 2013 > New Revision: 254616 > URL: http://svnweb.freebsd.org/changeset/base/254616 > > Log: > Change the name of this particular event to reflect the name used in > Linux and Intel examples. > >

Re: svn commit: r254616 - head/sys/dev/hwpmc

2013-08-21 Thread Davide Italiano
On Wed, Aug 21, 2013 at 2:52 PM, Davide Italiano wrote: > On Wed, Aug 21, 2013 at 2:47 PM, Adrian Chadd wrote: >> Author: adrian >> Date: Wed Aug 21 21:47:56 2013 >> New Revision: 254616 >> URL: http://svnweb.freebsd.org/changeset/base/254616 >> >> Log:

svn commit: r254703 - in head: share/man/man9 sys/sys

2013-08-23 Thread Davide Italiano
Author: davide Date: Fri Aug 23 14:12:39 2013 New Revision: 254703 URL: http://svnweb.freebsd.org/changeset/base/254703 Log: Introduce callout_init_rm() so that callouts can be used in conjunction with rmlocks. This works only with non-sleepable rm because handlers run in SWI context. While

svn commit: r254710 - head/share/man/man9

2013-08-23 Thread Davide Italiano
Author: davide Date: Fri Aug 23 14:33:56 2013 New Revision: 254710 URL: http://svnweb.freebsd.org/changeset/base/254710 Log: - Bump date. - Small mdoc fix. Submitted by: pluknet Modified: head/share/man/man9/timeout.9 Modified: head/share/man/man9/timeout.9 ===

svn commit: r254712 - head/sys/sys

2013-08-23 Thread Davide Italiano
Author: davide Date: Fri Aug 23 14:40:17 2013 New Revision: 254712 URL: http://svnweb.freebsd.org/changeset/base/254712 Log: Fix the build and fix style. Pointy-hat to:davide Modified: head/sys/sys/callout.h Modified: head/sys/sys/callout.h ==

Re: svn commit: r254703 - in head: share/man/man9 sys/sys

2013-08-23 Thread Davide Italiano
On Fri, Aug 23, 2013 at 4:51 PM, John Baldwin wrote: > On Friday, August 23, 2013 10:12:39 am Davide Italiano wrote: >> Author: davide >> Date: Fri Aug 23 14:12:39 2013 >> New Revision: 254703 >> URL: http://svnweb.freebsd.org/changeset/base/254703 >> >> L

  1   2   >