Re: svn commit: r335765 - head/sys/sys

2018-06-28 Thread David A. Bright
On 06/28/2018 12:01 PM, David Bright wrote: > Author: dab > Date: Thu Jun 28 17:01:04 2018 > New Revision: 335765 > URL: https://svnweb.freebsd.org/changeset/base/335765 > > Log: > Remove potential identifier conflict in the EV_SET macro. > > > Differential Revision: > https://bugs.fr

Re: svn commit: r335765 - head/sys/sys

2018-06-28 Thread David A. Bright
On 06/28/2018 12:06 PM, David A. Bright wrote: > On 06/28/2018 12:01 PM, David Bright wrote: > >> Author: dab >> Date: Thu Jun 28 17:01:04 2018 >> New Revision: 335765 >> URL: https://svnweb.freebsd.org/changeset/base/335765 >> >> Log: >> Remove p

Re: svn commit: r335765 - head/sys/sys

2018-06-28 Thread David A. Bright
On 06/28/2018 02:04 PM, Bryan Drewery wrote: > On 6/28/2018 11:45 AM, Justin Hibbits wrote: >> Hi David, >> 18:02:13 /usr/src/bin/pwait/pwait.c:158: warning: initialized field >> overwritten >> 18:02:13 /usr/src/bin/pwait/pwait.c:158: warning: (near initialization >> for '(anonymous).ext') >> >>

Re: svn commit: r335765 - head/sys/sys

2018-06-28 Thread David A. Bright
On 06/28/2018 01:45 PM, Justin Hibbits wrote: >> Author: dab >> Date: Thu Jun 28 17:01:04 2018 >> New Revision: 335765 > > This breaks gcc builds, with the following errors: Fixed in r335776. Thanks to cem@ for a suggested fix (and to others that also suggested alternative fixes) and to jhibbi

Re: svn commit: r336802 - head/tests/sys/kqueue/libkqueue

2018-08-03 Thread David A. Bright
On 07/27/2018 09:53 PM, David Bright wrote: > Author: dab > Date: Sat Jul 28 02:53:36 2018 > New Revision: 336802 > URL: https://svnweb.freebsd.org/changeset/base/336802 > > Log: > Fix compilation error on some arches after r336761 & r336781. > > Another cast for printing an intmax_t was nee

Re: svn commit: r336905 - head/tests/sys/kqueue/libkqueue

2018-08-03 Thread David A. Bright
On 07/30/2018 09:21 AM, David Bright wrote: > Author: dab > Date: Mon Jul 30 14:21:49 2018 > New Revision: 336905 > URL: https://svnweb.freebsd.org/changeset/base/336905 > > Log: > Correct possible misleading error message in kqtest. > > ian@ pointed out that in the test_abstime() function t

Re: svn commit: r337814 - head/tests/sys/kqueue/libkqueue

2018-08-14 Thread David A. Bright
On 08/14/2018 02:58 PM, Renato Botelho wrote: > On 14/08/18 16:31, David Bright wrote: >> Author: dab >> Date: Tue Aug 14 19:31:06 2018 >> New Revision: 337814 >> URL: https://svnweb.freebsd.org/changeset/base/337814 >> +kev_str = kevent_to_str(kev); > > It seems that this line is indente

Re: svn commit: r341068 - head/tests/sys/kqueue/libkqueue

2018-11-27 Thread David A. Bright
On 11/27/18 12:34 PM, Conrad Meyer wrote: > As long as we were correcting indentation whitespace, it seems like it > would have been good to go to tabs, per style(9), instead of spaces. > Or are these considered contrib code from NetBSD? A fair question. I'm not sure whether they should be conside