svn commit: r333683 - head/sys/teken

2018-05-16 Thread Conrad Meyer
Author: cem Date: Wed May 16 18:12:49 2018 New Revision: 333683 URL: https://svnweb.freebsd.org/changeset/base/333683 Log: teken: Unbreak syscons' use of teken Only vt(4) initializes these callbacks non-NULL at this time, so invoke the function pointers conditionally. Broken in r3336

Re: svn commit: r333703 - head/sys/vm

2018-05-17 Thread Conrad Meyer
On Wed, May 16, 2018 at 9:27 PM, Mark Johnston wrote: > Author: markj > Date: Thu May 17 04:27:08 2018 > New Revision: 333703 > URL: https://svnweb.freebsd.org/changeset/base/333703 > > Log: > Fix a race in vm_page_pagequeue_lockptr(). > > The value of m->queue must be cached after comparing i

Re: svn commit: r333840 - head/sys/kern

2018-05-19 Thread Conrad Meyer
On Sat, May 19, 2018 at 2:33 AM, Konstantin Belousov wrote: > On Sat, May 19, 2018 at 04:07:00AM +, Matt Macy wrote: >> Author: mmacy >> Date: Sat May 19 04:07:00 2018 >> New Revision: 333840 >> URL: https://svnweb.freebsd.org/changeset/base/333840 >> >> Log: >> filt_timerdetach: only assign

Re: svn commit: r333885 - head/cddl/contrib/opensolaris/tools/ctf/cvt

2018-05-19 Thread Conrad Meyer
This is super nitpicky, and apologies, but: On Sat, May 19, 2018 at 11:50 AM, Matt Macy wrote: > Author: mmacy > Date: Sat May 19 18:50:58 2018 > New Revision: 333885 > URL: https://svnweb.freebsd.org/changeset/base/333885 > > Log: > ctf dwarf: don't report "no dwarf entry" as if it were an err

Re: svn commit: r334054 - in head: sys/kern sys/netipsec tools/tools/crypto usr.bin/netstat

2018-05-22 Thread Conrad Meyer
Can users control arbitrary key_allocsp() calls? If so, it seems concerning to expose hit/miss stats on cached security keys. On Tue, May 22, 2018 at 8:54 AM, Fabien Thomas wrote: > Author: fabient > Date: Tue May 22 15:54:25 2018 > New Revision: 334054 > URL: https://svnweb.freebsd.org/changese

Re: svn commit: r334054 - in head: sys/kern sys/netipsec tools/tools/crypto usr.bin/netstat

2018-05-23 Thread Conrad Meyer
On Wed, May 23, 2018 at 12:23 AM, Emeric POUPON wrote: >> From: "Conrad Meyer" > >> Can users control arbitrary key_allocsp() calls? If so, it seems >> concerning to expose hit/miss stats on cached security keys. > > I am not sure to understand, could you

Re: svn commit: r334120 - head/share/mk

2018-05-23 Thread Conrad Meyer
On Wed, May 23, 2018 at 6:28 PM, Eitan Adler wrote: > On 23 May 2018 at 14:26, Ed Maste wrote: >> Author: emaste >> Date: Wed May 23 21:26:33 2018 >> New Revision: 334120 >> URL: https://svnweb.freebsd.org/changeset/base/334120 >> >> Log: >> Revert r334081 (-Wmain) as it broke the build on gcc

Re: svn commit: r334054 - in head: sys/kern sys/netipsec tools/tools/crypto usr.bin/netstat

2018-05-24 Thread Conrad Meyer
On Thu, May 24, 2018 at 5:30 AM, Emeric POUPON wrote: > Actually we just store traffic profiles and the associated security policy > (SP). > A SP is basically just a bunch of traffic selectors, there is no key or other > sensitive information involved. Ok, thanks! Best, Conrad

svn commit: r334170 - in head/sys: arm/conf conf dev/asmc kern modules/asmc

2018-05-24 Thread Conrad Meyer
Author: cem Date: Thu May 24 17:06:00 2018 New Revision: 334170 URL: https://svnweb.freebsd.org/changeset/base/334170 Log: Yank crufty INTR_FILTER option It was introduced to the tree in r169320 and r169321 in May 2007. It never got much use and never became a kernel default. The code

Re: svn commit: r334375 - in head/sys: net netpfil/pf

2018-05-30 Thread Conrad Meyer
On Wed, May 30, 2018 at 5:41 AM, Kristof Provost wrote: > Odd. The other reports I got were mips only. I did test amd64. > Are you using gcc to build perhaps? > > r334379 should fix it. Hi Kristof, Oliver uses a non-GENERIC kernel, which often catches some oversights :-). I appreciate the promp

svn commit: r334443 - head/sbin/dhclient

2018-05-31 Thread Conrad Meyer
Author: cem Date: Thu May 31 19:36:24 2018 New Revision: 334443 URL: https://svnweb.freebsd.org/changeset/base/334443 Log: dhclient(8): allow to supersede interface-mtu option In some cases broken DHCP servers might send invalid MTU value, so allow to use 'supersede' in dhclient.conf to o

svn commit: r334501 - head/usr.bin/touch

2018-06-01 Thread Conrad Meyer
Author: cem Date: Fri Jun 1 22:34:59 2018 New Revision: 334501 URL: https://svnweb.freebsd.org/changeset/base/334501 Log: touch.1: Update to conform to POSIX 2004 POSIX borrowed the "double leap second" bug from C89. Double leap seconds can never happen. This mistake was present in at

svn commit: r334502 - in head: bin/date usr.bin/at usr.bin/last

2018-06-01 Thread Conrad Meyer
Author: cem Date: Fri Jun 1 22:37:59 2018 New Revision: 334502 URL: https://svnweb.freebsd.org/changeset/base/334502 Log: Update other man pages to match leap second reality Missed these in r334501; see justification there: https://svnweb.freebsd.org/base?view=revision&revision=334501

svn commit: r334503 - head/usr.bin/at

2018-06-01 Thread Conrad Meyer
Author: cem Date: Fri Jun 1 22:57:19 2018 New Revision: 334503 URL: https://svnweb.freebsd.org/changeset/base/334503 Log: at.man: Bump .Dd missed in r334502 Sponsored by: Dell EMC Isilon Modified: head/usr.bin/at/at.man Modified: head/usr.bin/at/at.man =

svn commit: r334624 - head/sys/libkern

2018-06-04 Thread Conrad Meyer
Author: cem Date: Mon Jun 4 18:47:14 2018 New Revision: 334624 URL: https://svnweb.freebsd.org/changeset/base/334624 Log: str(r)chr: Replace union abuse with __DECONST Writing one union member and reading another is technically illegal C, although we do it in many places in the tree. Us

svn commit: r334625 - head/sys/netipsec

2018-06-04 Thread Conrad Meyer
Author: cem Date: Mon Jun 4 18:51:06 2018 New Revision: 334625 URL: https://svnweb.freebsd.org/changeset/base/334625 Log: Correctly handle the padding for IPv6-AH, as specified by RFC4302 The RFC specifies that under IPv6 the complete AH header must be 64 bit aligned, and under IPv4, 32

svn commit: r334721 - head/lib/msun/man

2018-06-06 Thread Conrad Meyer
Author: cem Date: Wed Jun 6 16:25:00 2018 New Revision: 334721 URL: https://svnweb.freebsd.org/changeset/base/334721 Log: clog.3, complex.3: Fix typos and igor style issues PR: 228783 Reported by: Karsten Modified: head/lib/msun/man/clog.3 head/lib/msun/man/complex.3 Mo

svn commit: r334722 - head/sys/dev/puc

2018-06-06 Thread Conrad Meyer
Author: cem Date: Wed Jun 6 16:47:33 2018 New Revision: 334722 URL: https://svnweb.freebsd.org/changeset/base/334722 Log: puc(4): Add provisional support for Exar XR17V352 Reportedly, this is sufficient for 4800bps use, but maybe not any better. PR: 228781 Submitted by: pe

Re: svn commit: r334702 - head/sys/sys

2018-06-06 Thread Conrad Meyer
Hi Ben, Ravi, GCC/Clang are fine with the just curly braces, or just do/while(0). The core benefit of the ({ }) syntax is to allow multiple-statement macros to have expression syntax externally (i.e., yield a value) — which is not possible in standard C due to concession to simplistic parsers. B

svn commit: r334733 - head/lib/libc/string

2018-06-06 Thread Conrad Meyer
Author: cem Date: Wed Jun 6 20:09:21 2018 New Revision: 334733 URL: https://svnweb.freebsd.org/changeset/base/334733 Log: strcpy.3: Improve legibility and clarity In the DESCRIPTION, put the more commonly used functions first in the corresponding sentence, to help catch the eye. Pul

svn commit: r334738 - head/lib/libc/string

2018-06-06 Thread Conrad Meyer
Author: cem Date: Wed Jun 6 21:32:49 2018 New Revision: 334738 URL: https://svnweb.freebsd.org/changeset/base/334738 Log: strdup.3: Document standardization in POSIX Sponsored by: Dell EMC Isilon Modified: head/lib/libc/string/strdup.3 Modified: head/lib/libc/string/strdup.3 ==

Re: svn commit: r335010 - head/usr.sbin/cpucontrol

2018-06-12 Thread Conrad Meyer
On Tue, Jun 12, 2018 at 11:58 AM, Sean Bruno wrote: > Author: sbruno > Date: Tue Jun 12 18:58:56 2018 > New Revision: 335010 > URL: https://svnweb.freebsd.org/changeset/base/335010 > > Log: > cpucontrol: > - fix debugging for family on AMD cpus and add useful debugging for > which file is

svn commit: r335227 - head/sys/sys

2018-06-15 Thread Conrad Meyer
Author: cem Date: Fri Jun 15 19:02:53 2018 New Revision: 335227 URL: https://svnweb.freebsd.org/changeset/base/335227 Log: Retain offset compatibility with pre-12.0 dumps As a follow-up to r324965, which adds support for compressed kernel dumps, readjust dump header members slightly to mo

svn commit: r335237 - head/sys/sys

2018-06-15 Thread Conrad Meyer
Author: cem Date: Fri Jun 15 20:57:02 2018 New Revision: 335237 URL: https://svnweb.freebsd.org/changeset/base/335237 Log: Bump __FreeBSD_version after r335227 The kerneldumpheader ABI is used by at least the netdumpd port. Bump __FreeBSD_version to reflect the change. Reported by:

Re: svn commit: r335223 - head/sys/dev/cxgbe

2018-06-15 Thread Conrad Meyer
This seems generally useful, and nothing about the code is specific to cxgbe. Could it be adapted to be driver-agnostic? Thanks, Conrad On Fri, Jun 15, 2018 at 11:04 AM, Navdeep Parhar wrote: > Author: np > Date: Fri Jun 15 18:04:44 2018 > New Revision: 335223 > URL: https://svnweb.freebsd.org/

Re: svn commit: r334947 - head/sys/modules

2018-06-16 Thread Conrad Meyer
r255185 added _mm_aesenc(), etc, but not _mm_sha*(). That's probably where the report comes from. (If you feel it is worth your while adding sha intrinsics to a decade-old GCC, go ahead, but I think gcc 4.2 on x86 is pretty dead.) Best, Conrad On Sat, Jun 16, 2018 at 7:57 AM, Kurt Lidl wrote:

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-19 Thread Conrad Meyer
On Tue, Jun 19, 2018 at 6:08 PM, Stephen J. Kiernan wrote: > Author: stevek > Date: Wed Jun 20 01:08:54 2018 > New Revision: 335402 > URL: https://svnweb.freebsd.org/changeset/base/335402 > > Log: > This application (veriexecctl) handles reading a fingerprints file Hi, This patchset needed des

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-19 Thread Conrad Meyer
, Conrad Meyer wrote: > On Tue, Jun 19, 2018 at 6:08 PM, Stephen J. Kiernan > wrote: >> Author: stevek >> Date: Wed Jun 20 01:08:54 2018 >> New Revision: 335402 >> URL: https://svnweb.freebsd.org/changeset/base/335402 >> >> Log: >> This application (

Re: svn commit: r335437 - in head: share/man/man4 sys/kern

2018-06-20 Thread Conrad Meyer
Hi Bjoern, It might be nice to be explicit that the vnode was not in the namecache (in the ddb output) rather than failing silently. The name of the ddb method does not suggest that only entries in the namecache may be found, and users (developers :)) do not always read manual pages thoroughly.

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-20 Thread Conrad Meyer
You can keep these poor security modes in your downstream product if you want, but don't put them in the tree. On Wed, Jun 20, 2018 at 8:28 AM, Simon J. Gerraty wrote: > Benjamin Kaduk wrote: >> With all due respect, NIST is hardly the sole authority on this topic. > > True, unless of course you

Re: svn commit: r335437 - in head: share/man/man4 sys/kern

2018-06-20 Thread Conrad Meyer
On Wed, Jun 20, 2018 at 8:36 AM, Bjoern A. Zeeb wrote: > On 20 Jun 2018, at 15:05, Conrad Meyer wrote: > >> Hi Bjoern, >> >> It might be nice to be explicit that the vnode was not in the >> namecache (in the ddb output) rather than failing silently. The name >>

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-20 Thread Conrad Meyer
curity. On Tue, Jun 19, 2018 at 11:21 PM, Simon J. Gerraty wrote: > Conrad Meyer wrote: >> First and foremost: nothing is actually signed, anywhere. The > > The signing of manifests is external. The veriexecctl tool is I assume > a straight copy of what's in NetBSD (I

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-20 Thread Conrad Meyer
Ian, On Wed, Jun 20, 2018 at 8:58 AM, Ian Lepore wrote: > And I request exactly the opposite: reject the complaining of people > who think all the world is a 256-core 5ghz server First: no need to be so rude to other committers. The hyperbole doesn't help anyone and doesn't help communicate you

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-20 Thread Conrad Meyer
Hi Simon, Jonathan points out some of my comments were more acerbic than necessary. I apologize for that. I'd like to try to rephrase them in a more clear way. On Wed, Jun 20, 2018 at 8:43 AM, Conrad Meyer wrote: > On Tue, Jun 19, 2018 at 11:21 PM, Simon J. Gerraty wrote: >>

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-20 Thread Conrad Meyer
Hi Jon, On Wed, Jun 20, 2018 at 11:58 AM, Jonathan Anderson wrote: > On 20 Jun 2018, at 15:32, Jonathan T. Looney wrote: >> My reasoning >> was fairly simple: when a review has been open for over a year with no >> action, it seems like the submitter should be able to commit it without >> waiting

svn commit: r335498 - head/sys/libkern

2018-06-21 Thread Conrad Meyer
Author: cem Date: Thu Jun 21 17:35:13 2018 New Revision: 335498 URL: https://svnweb.freebsd.org/changeset/base/335498 Log: Sync strlcpy with userland version, again No functional change. Please remember to update libkern copies of libc functions when you update libc. Sponsored b

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-21 Thread Conrad Meyer
On Thu, Jun 21, 2018 at 9:51 AM, Stephen Kiernan wrote: > On Wed, Jun 20, 2018 at 10:36 PM, Eitan Adler wrote: >> >> On 19 June 2018 at 20:08, Eitan Adler wrote: >> > On 19 June 2018 at 18:08, Stephen J. Kiernan wrote: >> >> Added: head/sbin/veriexecctl/Makefile >> >> >> >>

svn commit: r335583 - head/sys/crypto/aesni

2018-06-23 Thread Conrad Meyer
Author: cem Date: Sat Jun 23 17:24:19 2018 New Revision: 335583 URL: https://svnweb.freebsd.org/changeset/base/335583 Log: aesni(4): Support CRD_F_KEY_EXPLICIT OCF mode PR: 227788 Reported by: eadler@ Modified: head/sys/crypto/aesni/aesni.c Modified: head/sys/crypto/aesni/a

svn commit: r335584 - head/sys/crypto/aesni

2018-06-23 Thread Conrad Meyer
Author: cem Date: Sat Jun 23 18:20:17 2018 New Revision: 335584 URL: https://svnweb.freebsd.org/changeset/base/335584 Log: aesni(4): Fix {de,en}crypt operations that allocated a buffer aesni(4) allocates a contiguous buffer for the data it processes if the provided input was not already v

Re: svn commit: r326394 - head/sys/fs/devfs

2017-11-30 Thread Conrad Meyer
This moves the M_WAITOK (sleepable) memory allocation under dirlist_mtx, which is an ordinary mutex. If you run this under WITNESS, it will (rightfully) complain. Please revert this change. One possible way to accomplish the goal you have in mind is a fallback path if the devfs_dir_findent_locke

Re: svn commit: r326383 - head/sys/x86/cpufreq

2017-11-30 Thread Conrad Meyer
Hi Jung-uk, I have some questions about this change. On Wed, Nov 29, 2017 at 5:40 PM, Jung-uk Kim wrote: > Author: jkim > Date: Thu Nov 30 01:40:07 2017 > New Revision: 326383 > URL: https://svnweb.freebsd.org/changeset/base/326383 > > Log: > Add a tunable "debug.hwpstate_verify" to check P-st

Re: svn commit: r326383 - head/sys/x86/cpufreq

2017-11-30 Thread Conrad Meyer
19213, and probably 218262. Best, Conrad On Thu, Nov 30, 2017 at 11:21 AM, Jung-uk Kim wrote: > On 11/30/2017 13:57, Conrad Meyer wrote: >> Hi Jung-uk, >> >> I have some questions about this change. >> >> On Wed, Nov 29, 2017 at 5:40 PM, Jung-uk Kim wrote: >>

Re: svn commit: r326383 - head/sys/x86/cpufreq

2017-11-30 Thread Conrad Meyer
On Thu, Nov 30, 2017 at 12:08 PM, Jung-uk Kim wrote: > On 11/30/2017 14:32, Conrad Meyer wrote: >> Hi, >> >> I don't think this answers the second question about the conditional. >> It seems like PCPU_GET() for the initial CPU should be pulled out of >>

Re: svn commit: r326554 - in head: . usr.bin/sponge usr.bin/sponge/tests usr.bin/tee

2017-12-04 Thread Conrad Meyer
On Mon, Dec 4, 2017 at 7:55 PM, Eitan Adler wrote: > Author: eadler > Date: Tue Dec 5 03:55:10 2017 > New Revision: 326554 > URL: https://svnweb.freebsd.org/changeset/base/326554 > > Log: > sponge(1): initial commit > > sponge(1) is a utility that reads input until > complete, then opens th

Re: svn commit: r326554 - in head: . usr.bin/sponge usr.bin/sponge/tests usr.bin/tee

2017-12-04 Thread Conrad Meyer
On Mon, Dec 4, 2017 at 8:30 PM, Conrad Meyer wrote: > On Mon, Dec 4, 2017 at 7:55 PM, Eitan Adler wrote: >> Author: eadler >> Date: Tue Dec 5 03:55:10 2017 >> New Revision: 326554 >> URL: https://svnweb.freebsd.org/changeset/base/326554 >> >> Log: >>

Re: svn commit: r326554 - in head: . usr.bin/sponge usr.bin/sponge/tests usr.bin/tee

2017-12-05 Thread Conrad Meyer
Please revert this change, along with r326555 and r326557. I am not opposed to the idea of a version of this utility in base. I am opposed to breaking the build, and functionally broken programs. Thanks, Conrad On Mon, Dec 4, 2017 at 7:55 PM, Eitan Adler wrote: > Author: eadler > Date: Tue Dec

svn commit: r326572 - head/sys/dev/ioat

2017-12-05 Thread Conrad Meyer
Author: cem Date: Tue Dec 5 18:48:58 2017 New Revision: 326572 URL: https://svnweb.freebsd.org/changeset/base/326572 Log: ioat(4): Add Skylake Xeon PCI-ID SKX IOAT is just another 3.2 version of the CBDMA engine. Submitted by: Deepak Veliath Sponsored by: Dell EMC Isilon Modified:

Re: svn commit: r326554 - in head: . usr.bin/sponge usr.bin/sponge/tests usr.bin/tee

2017-12-05 Thread Conrad Meyer
On Tue, Dec 5, 2017 at 12:16 PM, Cy Schubert wrote: > In message om> > , Eitan Adler writes: >> I'm not near my commit box right now so someone will have to revert >> it. What's funny is that I ran a complete 'make buildworld >> buildkernel' last night with this patch. >> >> Will respond to the r

Re: svn commit: r316980 - head/contrib/zstd/programs

2017-12-05 Thread Conrad Meyer
Ping. Please revert this change. If you want zstd to behave this way, pursue it upstream first. Thanks, Conrad On Wed, Nov 15, 2017 at 7:38 PM, Conrad Meyer wrote: > Please revert this change. > > First, it introduces the POLA-violating behavior that zstdcat deletes > its source

Re: svn commit: r326614 - in head: etc/mtree usr.bin usr.bin/sponge usr.bin/tee

2017-12-05 Thread Conrad Meyer
On Tue, Dec 5, 2017 at 7:10 PM, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> Author: eadler >> Date: Wed Dec 6 02:47:46 2017 >> New Revision: 326614 >> URL: https://svnweb.freebsd.org/changeset/base/326614 >> >> Log: >> sponge(1): revert >> >> I did a complete bui

svn commit: r326666 - in head/sys/dev/mlx4: mlx4_core mlx4_en

2017-12-07 Thread Conrad Meyer
Author: cem Date: Thu Dec 7 19:57:51 2017 New Revision: 32 URL: https://svnweb.freebsd.org/changeset/base/32 Log: mlx4: Remove redundant declarations to fix GCC build These were made redundant in r325841. Reviewed by: hselasky MFC after:1 week (hselasky will MFC) Spon

Re: svn commit: r326664 - head/sys/vm

2017-12-07 Thread Conrad Meyer
Read the phab review. On Thu, Dec 7, 2017 at 1:23 PM, Oliver Pinter wrote: > On 12/7/17, Mark Johnston wrote: >> Author: markj >> Date: Thu Dec 7 19:38:09 2017 >> New Revision: 326664 >> URL: https://svnweb.freebsd.org/changeset/base/326664 >> >> Log: >> Fix the UMA reclaim worker after r3263

Re: svn commit: r326614 - in head: etc/mtree usr.bin usr.bin/sponge usr.bin/tee

2017-12-08 Thread Conrad Meyer
On Fri, Dec 8, 2017 at 6:07 PM, Eitan Adler wrote: > On 8 December 2017 at 12:11, Rodney W. Grimes > wrote: > >> Ping, I have not seen this reverted and recommitted with a reasonable >> explination as to why this change is actually desired. > > Sorry, work has been busy and as the crux was revert

Re: svn commit: r326614 - in head: etc/mtree usr.bin usr.bin/sponge usr.bin/tee

2017-12-09 Thread Conrad Meyer
That isn't what was asked for. Conrad On Sat, Dec 9, 2017 at 12:22 AM, Eitan Adler wrote: > On 8 December 2017 at 20:23, Conrad Meyer wrote: >> On Fri, Dec 8, 2017 at 6:07 PM, Eitan Adler wrote: >> Great. Please re-apply the change with something like that in the >>

svn commit: r326736 - head/usr.bin/wc

2017-12-09 Thread Conrad Meyer
Author: cem Date: Sat Dec 9 21:55:19 2017 New Revision: 326736 URL: https://svnweb.freebsd.org/changeset/base/326736 Log: wc(1): Extend non-controversial optimizations to '-c' mode wc(1)'s slow path for counting words or multibyte characters requires conversion of the 8-bit input stream

svn commit: r326749 - head/usr.bin/wc

2017-12-10 Thread Conrad Meyer
Author: cem Date: Sun Dec 10 17:56:03 2017 New Revision: 326749 URL: https://svnweb.freebsd.org/changeset/base/326749 Log: wc(1): Restore regular file char count fast path fstat(2) is going to be a lot faster than reading all of the bytes in a file, if we just need a character count for a

svn commit: r326758 - in head/sys/i386: conf include

2017-12-10 Thread Conrad Meyer
Author: cem Date: Mon Dec 11 04:32:37 2017 New Revision: 326758 URL: https://svnweb.freebsd.org/changeset/base/326758 Log: i386: Bump KSTACK_PAGES default to match amd64 Logically, extend r286288 to cover all threads, by default. The world has largely moved on from i386. Most FreeBSD

svn commit: r326786 - head/usr.bin/gzip

2017-12-11 Thread Conrad Meyer
Author: cem Date: Tue Dec 12 01:19:08 2017 New Revision: 326786 URL: https://svnweb.freebsd.org/changeset/base/326786 Log: gzip(1): Remove duplicate close() CID: 1383560 Reported by: Coverity Sponsored by: Dell EMC Isilon Modified: head/usr.bin/gzip/gzip.c Modified: head/u

svn commit: r326832 - head/tools/tools/netmap

2017-12-13 Thread Conrad Meyer
Author: cem Date: Wed Dec 13 19:36:29 2017 New Revision: 326832 URL: https://svnweb.freebsd.org/changeset/base/326832 Log: netmap pkt-gen tool: Fix memset(3) argument order Submitted by: Michael McConville Sponsored by: Dell EMC Isilon Modified: head/tools/tools/netmap/pkt-gen.c Modi

Re: svn commit: r326729 - head

2017-12-15 Thread Conrad Meyer
Ping. This still hasn't happened despite repeated request. Someone else can do it if you want (or put another way, someone else may get sick of waiting and do it if you don't). Conrad On Sat, Dec 9, 2017 at 6:45 AM, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> Auth

svn commit: r326956 - head/sys/dev/acpica

2017-12-18 Thread Conrad Meyer
Author: cem Date: Tue Dec 19 02:49:11 2017 New Revision: 326956 URL: https://svnweb.freebsd.org/changeset/base/326956 Log: Implement ACPI CPU support when Processor object is not present By the ACPI standard (ACPI 5 chapter 8.4 Declaring Processors) Processors can be implemented in 2 dist

Re: svn commit: r326959 - head

2017-12-18 Thread Conrad Meyer
Thanks for fixing it. Conrad On Mon, Dec 18, 2017 at 7:38 PM Eitan Adler wrote: > Author: eadler > Date: Tue Dec 19 03:38:06 2017 > New Revision: 326959 > URL: https://svnweb.freebsd.org/changeset/base/326959 > > Log: > arc lint: ignore /tests/ in chmod > > shell scripts in scripts don't ne

Re: svn commit: r327084 - head/sys/dev/pccard

2017-12-23 Thread Conrad Meyer
On Fri, Dec 22, 2017 at 8:59 AM, Warner Losh wrote: > ... > New Revision: 327084 > > PC Card PNP tables are terminated by a NULL sentinel. This shouldn't > be recorded in the linker hints, so subtract one to omit it. > ===

Re: svn commit: r327094 - in head/sys/dev: ahci usb/controller

2017-12-23 Thread Conrad Meyer
I see similar devices on my AMD TR + X399 system that should be added as well. I don't have time to reboot/test a patch right now, but here are the device ids: pci1 ahci0 pnpinfo vendor=0x1022 device=0x43b6 subvendor=0x1b21 subdevice=0x1062 class=0x010601 at slot=0 function=

svn commit: r327362 - in head/usr.bin/find: . tests

2017-12-29 Thread Conrad Meyer
+ +ATF_TESTS_SH= find_test + +.include Added: head/usr.bin/find/tests/find_test.sh == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/usr.bin/find/tests/find_test.shFri Dec

svn commit: r327364 - in head/sys/dev: ahci usb/controller

2017-12-29 Thread Conrad Meyer
Author: cem Date: Fri Dec 29 22:24:41 2017 New Revision: 327364 URL: https://svnweb.freebsd.org/changeset/base/327364 Log: Add AHCI/XHCI device IDs found on AMD 1950X+X399 system A follow-up to r327094. Sponsored by: Dell EMC Isilon Modified: head/sys/dev/ahci/ahci_pci.c head/sys/

Re: svn commit: r327362 - in head/usr.bin/find: . tests

2017-12-29 Thread Conrad Meyer
On Fri, Dec 29, 2017 at 2:41 PM, Oliver Pinter wrote: > Why did you comment out these tests? I think unit tests are a good idea for this kind of change, which is why I wrote them. And I run them before commit. But I'm not interested in tilting at the test build infrastructure to actually enable

svn commit: r327483 - head/usr.sbin/rpcbind

2018-01-01 Thread Conrad Meyer
Author: cem Date: Tue Jan 2 01:48:11 2018 New Revision: 327483 URL: https://svnweb.freebsd.org/changeset/base/327483 Log: rpcbind: Fix build Add missed unistd.h include. Not sure where it was lost; I believe it compiled before I submitted the change. PR: 224503 Reported

svn commit: r327482 - head/usr.sbin/rpcbind

2018-01-01 Thread Conrad Meyer
Author: cem Date: Tue Jan 2 00:48:19 2018 New Revision: 327482 URL: https://svnweb.freebsd.org/changeset/base/327482 Log: rpcbind: Do not use signal-unsafe functions in SIGTERM handler syslog(3), routines used in write_warmstart(), and exit(3) are all signal-unsafe. Instead, set a signa

svn commit: r327495 - head/usr.sbin/rpcbind

2018-01-02 Thread Conrad Meyer
Author: cem Date: Tue Jan 2 17:25:13 2018 New Revision: 327495 URL: https://svnweb.freebsd.org/changeset/base/327495 Log: rpcbind: Fix race in signal termination If a signal was delivered while the main thread was not in poll(2) and after check was performed, we could reenter poll and ne

Re: svn commit: r327495 - head/usr.sbin/rpcbind

2018-01-02 Thread Conrad Meyer
On Tue, Jan 2, 2018 at 9:25 AM, Conrad Meyer wrote: > Author: cem > Date: Tue Jan 2 17:25:13 2018 > New Revision: 327495 > URL: https://svnweb.freebsd.org/changeset/base/327495 > > Log: > rpcbind: Fix race in signal termination > > If a signal was delivered while

Re: svn commit: r327697 - head/sys/sys

2018-01-08 Thread Conrad Meyer
Hi, Response inline. On Mon, Jan 8, 2018 at 7:41 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Mon Jan 8 15:41:48 2018 > New Revision: 327697 > URL: https://svnweb.freebsd.org/changeset/base/327697 > > Log: > malloc(9): drop the __result_use_check attribute for the kernel allocator. > >

svn commit: r327706 - in head/sys: conf contrib/zstd/lib/freebsd

2018-01-08 Thread Conrad Meyer
Author: cem Date: Mon Jan 8 20:14:16 2018 New Revision: 327706 URL: https://svnweb.freebsd.org/changeset/base/327706 Log: Integrate zstd into the kernel Mock userspace headers and include mocked headers first in compilation command to inject kernel headers and override e.g., malloc(3) wi

Re: svn commit: r327699 - head/sys/sys

2018-01-08 Thread Conrad Meyer
I'm (again, atypically) with rgrimes here. Revert has a specific meaning and shouldn't be used like this. Making a commit with the subject "Revert rXXX" that does more than just "svn revert rXXX" makes life harder for developers looking at code history after you. Making two separate commits for

Re: svn commit: r327699 - head/sys/sys

2018-01-08 Thread Conrad Meyer
On Mon, Jan 8, 2018 at 12:54 PM, Pedro Giffuni wrote: > Yeah, I understand where that comes from and I will take it into account for > future commits, but I think it should be *documented* and not assume that > everybody thinks that is the way version control is supposed to be used. If you want

svn commit: r327715 - head/sys/conf

2018-01-08 Thread Conrad Meyer
Author: cem Date: Tue Jan 9 03:28:24 2018 New Revision: 327715 URL: https://svnweb.freebsd.org/changeset/base/327715 Log: Fix Zstd kernel build with GCC 4.2 By disabling the -Winline warning. Fixes the powerpc and sparc64 build after r327706. Note: MIPS and RISCV builds still broke

svn commit: r327738 - head/sys/conf

2018-01-09 Thread Conrad Meyer
Author: cem Date: Tue Jan 9 20:53:30 2018 New Revision: 327738 URL: https://svnweb.freebsd.org/changeset/base/327738 Log: Fix Zstd x86 kernel build with -march= Disable Zstd experimental support for __BMI__ intrinsics, when built with -march=foo supporting such intrinsics, to avoid attem

svn commit: r327763 - in head/sys: conf contrib/zstd/lib/freebsd

2018-01-09 Thread Conrad Meyer
ib/zstd/lib/freebsd/zstd_kfreebsd.c == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/sys/contrib/zstd/lib/freebsd/zstd_kfreebsd.c Wed Jan 10 06:30:59 2018(r327763) @@ -0,0 +1,75 @@ +/*-

Re: svn commit: r327763 - in head/sys: conf contrib/zstd/lib/freebsd

2018-01-10 Thread Conrad Meyer
Thank you. On Wed, Jan 10, 2018 at 9:37 AM, John Baldwin wrote: > On Wednesday, January 10, 2018 08:51:27 AM Ravi Pokala wrote: >> Hi Conrad, >> >> Alas, this still doesn't look right on RISC-V: >> >> zstd_kfreebsd.o: In function `__ctzdi2': >> >> /usr/home/rpokala/freebsd/clean/base/hea

svn commit: r327796 - in head: share/man/man9 sys/kern sys/sys

2018-01-10 Thread Conrad Meyer
Author: cem Date: Wed Jan 10 21:49:45 2018 New Revision: 327796 URL: https://svnweb.freebsd.org/changeset/base/327796 Log: mallocarray(9): panic if the requested allocation would overflow Additionally, move the overflow check logic out to WOULD_OVERFLOW() for consumers to have a common me

svn commit: r327800 - head/share/man/man9

2018-01-10 Thread Conrad Meyer
Author: cem Date: Wed Jan 10 22:20:49 2018 New Revision: 327800 URL: https://svnweb.freebsd.org/changeset/base/327800 Log: malloc.9: Fix minor typo from rewording in r327796 Sponsored by: Dell EMC Isilon Modified: head/share/man/man9/malloc.9 Modified: head/share/man/man9/malloc.9 =

svn commit: r327801 - in head/sys: amd64/amd64 i386/i386

2018-01-10 Thread Conrad Meyer
Author: cem Date: Wed Jan 10 22:41:00 2018 New Revision: 327801 URL: https://svnweb.freebsd.org/changeset/base/327801 Log: x86: Document purpose of _safe variants of {rd,wr}msr() Sponsored by: Dell EMC Isilon Modified: head/sys/amd64/amd64/support.S head/sys/i386/i386/support.s Modifi

svn commit: r327802 - head/tools/tools/crypto

2018-01-10 Thread Conrad Meyer
Author: cem Date: Wed Jan 10 23:19:32 2018 New Revision: 327802 URL: https://svnweb.freebsd.org/changeset/base/327802 Log: Add encrypt+authenticate modes to cryptotest tool Like jhb's cryptocheck (uncommitted so far), express encrypt+authenticate modes as "-a +". Example use with aes

svn commit: r327807 - head/sys/contrib/zstd/lib/freebsd

2018-01-10 Thread Conrad Meyer
Author: cem Date: Thu Jan 11 06:30:50 2018 New Revision: 327807 URL: https://svnweb.freebsd.org/changeset/base/327807 Log: Zstd: Add bswap intrinsics for small MIPS systems (e.g., Onion Omega) Reported by: mizhka Sponsored by: Dell EMC Isilon Modified: head/sys/contrib/zstd/lib/freebs

svn commit: r327866 - head/sys/crypto/aesni

2018-01-11 Thread Conrad Meyer
Author: cem Date: Fri Jan 12 06:40:58 2018 New Revision: 327866 URL: https://svnweb.freebsd.org/changeset/base/327866 Log: aesni(4): Quiesce spurious GCC 6.3.0 -Wmaybe-uninitialized warnings Always initialize some variables GCC warns about. They are initialized in every path where they a

svn commit: r327932 - head/sys/x86/include

2018-01-13 Thread Conrad Meyer
Author: cem Date: Sat Jan 13 17:55:22 2018 New Revision: 327932 URL: https://svnweb.freebsd.org/changeset/base/327932 Log: amd64: Add a 48-bit MAXADDR constant Some devices (e.g., ccp(4) -- to be committed) can only access the low 48 bits of physical memory. Reviewed by: markj Spo

Re: svn commit: r327934 - head/sys/contrib/zstd/lib/freebsd

2018-01-13 Thread Conrad Meyer
On Sat, Jan 13, 2018 at 10:09 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Sat Jan 13 18:09:09 2018 > New Revision: 327934 > URL: https://svnweb.freebsd.org/changeset/base/327934 > > Log: > zstd: Use memalloc(9) for calloc macro. > > This is in contrib code but since we only have memalloc

Re: svn commit: r327940 - head/sys/contrib/zstd/lib/freebsd

2018-01-13 Thread Conrad Meyer
This is not in contrib code -- https://lists.freebsd.org/pipermail/svn-src-all/2018-January/156505.html . On Sat, Jan 13, 2018 at 11:02 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Sat Jan 13 19:02:51 2018 > New Revision: 327940 > URL: https://svnweb.freebsd.org/changeset/base/327940 > > Log

Re: svn commit: r327940 - head/sys/contrib/zstd/lib/freebsd

2018-01-13 Thread Conrad Meyer
On Sat, Jan 13, 2018 at 11:54 AM, Pedro Giffuni wrote: > On 01/13/18 14:24, Conrad Meyer wrote: > > This is not in contrib code -- > https://lists.freebsd.org/pipermail/svn-src-all/2018-January/156505.html > . > Thanks, I read it late... > > Shouldn't the local

svn commit: r328038 - in head/sys: dev/random sys

2018-01-15 Thread Conrad Meyer
Author: cem Date: Tue Jan 16 02:56:27 2018 New Revision: 328038 URL: https://svnweb.freebsd.org/changeset/base/328038 Log: random(4): Add CCP random source definitions The implementation will follow (D12723). For now, get the changes to commit-protected files out of the way. Approve

svn commit: r328100 - head/bin/ls

2018-01-17 Thread Conrad Meyer
Author: cem Date: Wed Jan 17 22:47:34 2018 New Revision: 328100 URL: https://svnweb.freebsd.org/changeset/base/328100 Log: Convert ls(1) to not use libxo(3) libxo imposes a large burden on system utilities. In the case of ls, that burden is difficult to justify -- any language that can in

Re: svn commit: r328083 - in head/sys: amd64/amd64 amd64/ia32 amd64/include amd64/vmm amd64/vmm/intel dev/hyperv/vmbus dev/hyperv/vmbus/amd64 dev/hyperv/vmbus/i386 i386/i386 x86/include x86/isa x86/x8

2018-01-17 Thread Conrad Meyer
On Wed, Jan 17, 2018 at 3:44 AM, Konstantin Belousov wrote: > Author: kib > Date: Wed Jan 17 11:44:21 2018 > New Revision: 328083 > URL: https://svnweb.freebsd.org/changeset/base/328083 > > Log: > PTI for amd64. This seems to break the xtoolchain GCC build: /usr/home/conrad/src/freebsd/sys/dev

Re: svn commit: r328083 - in head/sys: amd64/amd64 amd64/ia32 amd64/include amd64/vmm amd64/vmm/intel dev/hyperv/vmbus dev/hyperv/vmbus/amd64 dev/hyperv/vmbus/i386 i386/i386 x86/include x86/isa x86/x8

2018-01-18 Thread Conrad Meyer
On Thu, Jan 18, 2018 at 3:23 AM, Konstantin Belousov wrote: > On Wed, Jan 17, 2018 at 07:38:03PM -0800, Conrad Meyer wrote: >> On Wed, Jan 17, 2018 at 3:44 AM, Konstantin Belousov >> wrote: >> > Author: kib >> > Date: Wed Jan 17 11:44:21 2018 >>

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Conrad Meyer
On Thu, Jan 18, 2018 at 12:01 PM, Eric van Gyzen wrote: > On 01/17/2018 16:40, Gleb Smirnoff wrote: >> Yeah, style is sacred, but is there a single person on Earth who would >> not agree that moving variables from smaller blocks to function block >> reduces readability of the code? > > I agree tha

svn commit: r328137 - head/sys/sys

2018-01-18 Thread Conrad Meyer
Author: cem Date: Thu Jan 18 21:19:57 2018 New Revision: 328137 URL: https://svnweb.freebsd.org/changeset/base/328137 Log: Add Elf_Nhdr definition to match NetBSD, OpenBSD, Linux The mesa port started to use this type and fails to build without it. NetBSD: http://cvsweb.netbsd.org/bsd

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Conrad Meyer
On Thu, Jan 18, 2018 at 1:04 PM, Warner Losh wrote: > On Thu, Jan 18, 2018 at 1:32 PM, Conrad Meyer wrote: >> 1. Allowing local / block scoped variables >> 2. Allowing C99 for loop initial declarations > > Tell me again where #1/#2 are disallowed? I can't seem to find

svn commit: r328150 - in head: sys/crypto/ccp sys/modules sys/modules/ccp tests/sys/opencrypto

2018-01-18 Thread Conrad Meyer
p/ccp.c Thu Jan 18 22:01:30 2018(r328150) @@ -1,7 +1,10 @@ /*- + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD + * * Copyright (c) 2017 Chelsio Communications, Inc. + * Copyright (c) 2017 Conrad Meyer * All rights reserved. - * Written by: John Baldwin + * Largely borrowed from ccr(

svn commit: r328159 - head/sys/modules

2018-01-18 Thread Conrad Meyer
Author: cem Date: Fri Jan 19 04:34:06 2018 New Revision: 328159 URL: https://svnweb.freebsd.org/changeset/base/328159 Log: Unbreak i386 build The logical result of a right shift >= the width of a type is zero, but our compiler decides this is a warning (and thus, error). Just remove ccp(

Re: svn commit: r328159 - head/sys/modules

2018-01-18 Thread Conrad Meyer
No. It is the only logical result of a logical right shift larger than the left operand. The C standard may claim that is undefined, but that does not change the only logical result (zero). On Thu, Jan 18, 2018 at 8:38 PM, Benjamin Kaduk wrote: > On Thu, Jan 18, 2018 at 10:34 PM, Conrad Me

Re: svn commit: r328159 - head/sys/modules

2018-01-18 Thread Conrad Meyer
Thu, Jan 18, 2018 at 8:54 PM, Benjamin Kaduk wrote: > On Thu, Jan 18, 2018 at 10:49 PM, Conrad Meyer wrote: >> >> No. It is the only logical result of a logical right shift larger >> than the left operand. The C standard may claim that is undefined, >> but that does

  1   2   3   4   5   6   7   8   9   10   >