svn commit: r335553 - head/sys/kern

2018-06-22 Thread Colin Percival
Author: cperciva Date: Fri Jun 22 10:23:32 2018 New Revision: 335553 URL: https://svnweb.freebsd.org/changeset/base/335553 Log: Improve the accuracy of the POSIX "process CPU-time" clocks by adding the used portion of the current thread's time slice if the current thread belongs to the proce

svn commit: r326564 - head/release/tools

2017-12-05 Thread Colin Percival
Author: cperciva Date: Tue Dec 5 09:08:48 2017 New Revision: 326564 URL: https://svnweb.freebsd.org/changeset/base/326564 Log: Resurrect r321659: Turn off ChallengeResponseAuthentication for EC2 AMIs. EC2 instances are normally launched with an SSH public key specified, which is then use

svn commit: r326565 - head/release/tools

2017-12-05 Thread Colin Percival
Author: cperciva Date: Tue Dec 5 09:22:14 2017 New Revision: 326565 URL: https://svnweb.freebsd.org/changeset/base/326565 Log: Make EC2 instances use Amazon's NTP service for time synchronization. Since Amazon provides NTP servers within their network, this should be far superior to usin

Re: svn commit: r325841 - in head/sys: conf dev/mlx4 dev/mlx4/mlx4_core dev/mlx4/mlx4_en dev/mlx4/mlx4_ib modules/mlx4

2017-12-17 Thread Colin Percival
convinced that it's legal C. Also, it breaks some work I have in progress for instrumenting SYSINITs. Would you mind moving the DEFINE_MUTEX line to occur immediately prior to the set_port_type function, rather than being placed inside it? -- Colin Percival Security Officer Emeritus, FreeBSD | The

Re: svn commit: r325841 - in head/sys: conf dev/mlx4 dev/mlx4/mlx4_core dev/mlx4/mlx4_en dev/mlx4/mlx4_ib modules/mlx4

2017-12-18 Thread Colin Percival
On 12/18/17 00:15, Hans Petter Selasky wrote: > On 12/18/17 05:29, Colin Percival wrote: >> Also, it breaks some work I have in progress for instrumenting SYSINITs. >> Would you mind moving the DEFINE_MUTEX line to occur immediately prior to >> the set_port_type function, rat

Re: svn commit: r327120 - in head/sys: isa x86/isa

2017-12-24 Thread Colin Percival
t; + device_printf(child, > + "non-PNP ISA device will be removed from GENERIC in > FreeBSD 12."); Maybe worth making this strncmp(kern_ident, "GENERIC", 7) so that it will catch GENERIC-NODEBUG as well? -- Colin Percival Se

svn commit: r327424 - head/sys/conf

2017-12-31 Thread Colin Percival
Author: cperciva Date: Sun Dec 31 09:21:34 2017 New Revision: 327424 URL: https://svnweb.freebsd.org/changeset/base/327424 Log: Connect kern_tslog.c to the build and add TSLOG / TSLOGSIZE kernel options. These are intended for debugging purposes and should not be added to "generic" kernel co

svn commit: r327423 - in head/sys: kern sys

2017-12-31 Thread Colin Percival
== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/sys/kern/kern_tslog.c Sun Dec 31 09:21:01 2017(r327423) @@ -0,0 +1,118 @@ +/*- + * Copyright (c) 2017 Colin Percival + * All rights reserved. + * + * Redistribution and use in

svn commit: r327426 - head/sys/kern

2017-12-31 Thread Colin Percival
Author: cperciva Date: Sun Dec 31 09:22:31 2017 New Revision: 327426 URL: https://svnweb.freebsd.org/changeset/base/327426 Log: Use the TSLOG framework to record entry/exit timestamps for machine independent functions with important roles in the early boot process: mi_startup (with the "exit

svn commit: r327425 - head/sys/amd64/amd64

2017-12-31 Thread Colin Percival
Author: cperciva Date: Sun Dec 31 09:22:07 2017 New Revision: 327425 URL: https://svnweb.freebsd.org/changeset/base/327425 Log: Use the TSLOG framework to record entry/exit timestamps for hammer_time. The entry must be logged "manually" using TSRAW rather than TSENTER since PCPU data structu

svn commit: r327427 - head/sys/sys

2017-12-31 Thread Colin Percival
Author: cperciva Date: Sun Dec 31 09:23:02 2017 New Revision: 327427 URL: https://svnweb.freebsd.org/changeset/base/327427 Log: Use the TSLOG framework to record SYSINIT entry/exit timestamps. Modified: head/sys/sys/kernel.h Modified: head/sys/sys/kernel.h ===

svn commit: r327428 - in head/sys: kern tools

2017-12-31 Thread Colin Percival
Author: cperciva Date: Sun Dec 31 09:23:19 2017 New Revision: 327428 URL: https://svnweb.freebsd.org/changeset/base/327428 Log: Teach makeobjops.awk to accept PROLOG and EPILOG blocks before METHOD and STATICMETHOD declarations; that code will be inserted into the dispatch function before an

svn commit: r327429 - head/sys/sys

2017-12-31 Thread Colin Percival
Author: cperciva Date: Sun Dec 31 09:23:35 2017 New Revision: 327429 URL: https://svnweb.freebsd.org/changeset/base/327429 Log: Use the TSLOG framework to record entry/exit timestamps for VFS_MOUNT calls. Modified: head/sys/sys/mount.h Modified: head/sys/sys/mount.h =

svn commit: r327430 - in head/sys: geom kern

2017-12-31 Thread Colin Percival
Author: cperciva Date: Sun Dec 31 09:23:52 2017 New Revision: 327430 URL: https://svnweb.freebsd.org/changeset/base/327430 Log: Instrument "boot holds" for the benefit of the TSLOG framework. These are places where the "main thread" of the booting kernel (either the thread which later becom

svn commit: r327431 - head/sys/kern

2017-12-31 Thread Colin Percival
Author: cperciva Date: Sun Dec 31 09:24:11 2017 New Revision: 327431 URL: https://svnweb.freebsd.org/changeset/base/327431 Log: Instrument thread creations for the the benefit of the TSLOG framework. This assists in tracking time spent while the boot is being "held" waiting for something to

svn commit: r327432 - in head/sys: arm/amlogic/aml8726 arm/arm arm/at91 arm/cavium/cns11xx arm/lpc arm/mv arm/ralink arm/xscale/i8134x arm/xscale/ixp425 arm/xscale/pxa kern mips/ingenic mips/mips m...

2017-12-31 Thread Colin Percival
Author: cperciva Date: Sun Dec 31 09:24:41 2017 New Revision: 327432 URL: https://svnweb.freebsd.org/changeset/base/327432 Log: Use the TSLOG framework to record entry/exit timestamps for DELAY and _vprintf; these functions are called in many places and can contribute meaningfully to the tot

svn commit: r327447 - head/sys/sys

2017-12-31 Thread Colin Percival
Author: cperciva Date: Sun Dec 31 21:00:21 2017 New Revision: 327447 URL: https://svnweb.freebsd.org/changeset/base/327447 Log: Wrap includes in sys/tslog.h with #ifdef TSLOG. This is necessary because some non-kernel code #defines _KERNEL and then includes kernel headers; as a result, it

Re: svn commit: r327423 - in head/sys: kern sys

2018-01-17 Thread Colin Percival
On 01/17/18 15:09, Gleb Smirnoff wrote: > On Sun, Dec 31, 2017 at 09:21:01AM +0000, Colin Percival wrote: > C> Code for recording timestamps of events, especially function > entries/exits. > C> This is a very primitive system, intended for use in measuring > performa

svn commit: r332663 - head/release/tools

2018-04-17 Thread Colin Percival
Author: cperciva Date: Wed Apr 18 05:58:27 2018 New Revision: 332663 URL: https://svnweb.freebsd.org/changeset/base/332663 Log: Move debug.{trace,debugger}_on_panic and kern.panic_reboot_wait_time in EC2 instances from sysctl.conf to loader.conf; these can all be set as loader tunables, and

Re: svn commit: r318757 - head

2017-05-23 Thread Colin Percival
to use the values 0, 1, 2, 3... for files. In Amazon EFS for example every fileid is > 2^32 and there's no guarantee that two files won't map to the same 32-bit inode # (pre-ino64, we simply reduced the fileid mod 2^32 to generate an inode #). --

svn commit: r318894 - in head/release: . tools

2017-05-25 Thread Colin Percival
Author: cperciva Date: Thu May 25 19:02:54 2017 New Revision: 318894 URL: https://svnweb.freebsd.org/changeset/base/318894 Log: Turn on support for the Amazon "Elastic Network Adapter" in EC2 AMIs. X-MFC-after: 318647 + fixes for some lock ordering warnings Modified: head/release/Makefi

svn commit: r319491 - head/sys/dev/xen/netfront

2017-06-02 Thread Colin Percival
Author: cperciva Date: Fri Jun 2 07:03:31 2017 New Revision: 319491 URL: https://svnweb.freebsd.org/changeset/base/319491 Log: Skip setting the MTU in the netfront driver (xn# devices) if the new MTU is the same as the old MTU. In particular, on Amazon EC2 "T2" instances without this chang

Re: svn commit: r319491 - head/sys/dev/xen/netfront

2017-06-02 Thread Colin Percival
On 06/02/17 03:29, Roger Pau Monn� wrote: > On Fri, Jun 02, 2017 at 07:03:31AM +0000, Colin Percival wrote: >> Skip setting the MTU in the netfront driver (xn# devices) if the new MTU >> is the same as the old MTU. [...] >> Maintainers of other network interfac

svn commit: r319561 - head/usr.bin/primes

2017-06-03 Thread Colin Percival
Author: cperciva Date: Sun Jun 4 02:36:37 2017 New Revision: 319561 URL: https://svnweb.freebsd.org/changeset/base/319561 Log: Using results from J. Sorenson and J. Webster, Strong pseudoprimes to twelve prime bases, Math. Comp. 86(304):985-1003, 2017. teach primes(6) to enumerate

svn commit: r319562 - head/usr.bin/factor

2017-06-03 Thread Colin Percival
Author: cperciva Date: Sun Jun 4 02:45:18 2017 New Revision: 319562 URL: https://svnweb.freebsd.org/changeset/base/319562 Log: Delete obsolete paragraph; primes(6) is now able to list primes for the full range up to 2^64 - 1. MFC after:1 week Modified: head/usr.bin/factor/factor.6

Re: svn commit: r318441 - in head/etc: . cron.d

2017-06-03 Thread Colin Percival
On 06/03/17 21:39, Rodney W. Grimes wrote: > Are we going to end up with /etc/rc.conf.d? We've had this for over 15 years -- ever since NetBSD rc.d system was imported. -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online

svn commit: r308329 - head/usr.bin/ministat

2016-11-04 Thread Colin Percival
Author: cperciva Date: Sat Nov 5 06:33:39 2016 New Revision: 308329 URL: https://svnweb.freebsd.org/changeset/base/308329 Log: Reduce the bogosity of ministat's % difference calculations. The previous calculation used an approximation which was only valid in cases where the means being c

svn commit: r308708 - head/sys/fs/nfs

2016-11-15 Thread Colin Percival
Author: cperciva Date: Wed Nov 16 01:11:49 2016 New Revision: 308708 URL: https://svnweb.freebsd.org/changeset/base/308708 Log: Reduce NFS "NFSv4( mounted on)? fileid > 32bits" log spam. Rather than printing a warning for every time we receive a fileid > 2^32 from the NFS server, count wa

svn commit: r310013 - head/sys/dev/xen/blkfront

2016-12-12 Thread Colin Percival
Author: cperciva Date: Tue Dec 13 06:54:13 2016 New Revision: 310013 URL: https://svnweb.freebsd.org/changeset/base/310013 Log: Check that blkfront devices have a non-zero number of sectors and a non-zero sector size. Such a device would be a virtual disk of zero bytes; clearly not useful,

svn commit: r353022 - head/release/tools

2019-10-02 Thread Colin Percival
Author: cperciva Date: Wed Oct 2 21:35:39 2019 New Revision: 353022 URL: https://svnweb.freebsd.org/changeset/base/353022 Log: Switch EC2 AMIs from using the dual-dhclient script to using the new dual-dhclient-daemon daemon. This makes it possible to stop/restart the dhclients. MFC af

Re: svn commit: r354482 - head/sys/x86/x86

2019-11-07 Thread Colin Percival
rly to other platforms without NMI. > [...] > +#ifdef XENHVM I'm not sure this does what you intended. XENHVM simply adds *support* for running under Xen/HVM, and it's part of the GENERIC kernel. -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsna

Re: svn commit: r354482 - head/sys/x86/x86

2019-11-07 Thread Colin Percival
On 2019-11-07 13:34, Andriy Gapon wrote: > On 07/11/2019 23:19, Colin Percival wrote: >> On 2019-11-07 13:14, Andriy Gapon wrote: >>> x86 stack_save_td_running() can work safely only if IPI_TRACE is a >>> non-maskable interrupt. But at the moment FreeBSD/Xen does no

svn commit: r345858 - in head/release: . tools

2019-09-03 Thread Colin Percival
Author: cperciva Date: Wed Apr 3 21:54:47 2019 New Revision: 345858 URL: https://svnweb.freebsd.org/changeset/base/345858 Log: Add support for cross-building cloudware images. If MACHINE_ARCH doesn't match TARGET_ARCH, and we're not in the special case of building i386 images on an amd64

svn commit: r346628 - head/usr.sbin/pkg

2019-09-03 Thread Colin Percival
Author: cperciva Date: Wed Apr 24 06:25:21 2019 New Revision: 346628 URL: https://svnweb.freebsd.org/changeset/base/346628 Log: Keep two versions of the FreeBSD.conf pkg configuration file; one which points at the "latest" branch and one which points at the "quarterly" branch. Install the "

svn commit: r348681 - head/sys/dev/pci

2019-06-04 Thread Colin Percival
Author: cperciva Date: Wed Jun 5 04:58:42 2019 New Revision: 348681 URL: https://svnweb.freebsd.org/changeset/base/348681 Log: Only respond to the PCIe Attention Button if a device is already plugged in. Prior to this commit, if PCIEM_SLOT_STA_ABP and PCIEM_SLOT_STA_PDC are asserted simu

Re: svn commit: r362444 - head/sbin/dump

2020-06-20 Thread Colin Percival
To avoid causing any further issues: If anyone objects to the word "worker" please let me know in the next ~48 hours. I think there's enough people reading svn-src-all that I can anticipate feedback now if anyone will care deeply about that word. Colin Percival On 2020-06-20 13:06, W

Re: svn commit: r362444 - head/sbin/dump

2020-06-20 Thread Colin Percival
... never mind, it looks like Conrad got here first with r362447. On 2020-06-20 13:12, Colin Percival wrote: > Thanks for backing this out, Warner. > > I'd like to change "slave" to "worker" here (which I think is a reasonably > neutral and entirely inoffens

svn commit: r362557 - head/sbin/dump

2020-06-23 Thread Colin Percival
Author: cperciva Date: Tue Jun 23 21:11:40 2020 New Revision: 362557 URL: https://svnweb.freebsd.org/changeset/base/362557 Log: Clean up some function and variable names. The change from "slave" processes to "minion" processes to "worker" processes left some less-than-coherent names: 1.

svn commit: r362791 - head/release/tools

2020-06-29 Thread Colin Percival
Author: cperciva Date: Tue Jun 30 06:14:34 2020 New Revision: 362791 URL: https://svnweb.freebsd.org/changeset/base/362791 Log: Make EC2 AMIs use portsnap and freebsd-update mirrors hosted in AWS This adjusts freebsd-update.conf and portsnap.conf files in EC2 AMIs to point at the new AWS-

Please include benchmarks in commit messages (was Re: svn commit: r363450 - in head: share/man/man3 sys/sys)

2020-07-23 Thread Colin Percival
bserved". Again, this is a general request -- this is just the latest in a long series of commits I've seen by many people which have sounded like they could have performance impacts but have not included any quantitative results. -- Colin Percival Security Officer Emeritus,

svn commit: r364831 - head/usr.bin/lockf

2020-08-26 Thread Colin Percival
Author: cperciva Date: Wed Aug 26 19:26:48 2020 New Revision: 364831 URL: https://svnweb.freebsd.org/changeset/base/364831 Log: Add -w option to lockf(1). By default, lockf(1) opens its lock file O_RDONLY|O_EXLOCK. On NFS, if the file already exists, this is split into opening the file r

svn commit: r364832 - head/usr.bin/lockf

2020-08-26 Thread Colin Percival
Author: cperciva Date: Wed Aug 26 19:28:30 2020 New Revision: 364832 URL: https://svnweb.freebsd.org/changeset/base/364832 Log: Remove whitespace which accidentaly snuck into r364831. Modified: head/usr.bin/lockf/lockf.1 Modified: head/usr.bin/lockf/lockf.1 ==

svn commit: r367195 - head

2020-10-30 Thread Colin Percival
Author: cperciva Date: Sat Oct 31 03:36:31 2020 New Revision: 367195 URL: https://svnweb.freebsd.org/changeset/base/367195 Log: Attempt to defuse a land mine before anyone else steps on it: The freebsd-boot partition is not always the first one. Following the instructions in UPDATING resu

Re: svn commit: r356207 - in head/sys/arm64: arm64 include

2019-12-30 Thread Colin Percival
ess flag and dirty state, and enable this feature when it's > available. Am I right in thinking that this should result in improved performance under load? (I'm wondering if it's time to redo my amd64 vs arm64 EC2 benchmarks.) -- Colin Percival Security Officer Emeritus

Re: svn commit: r356758 - in head/usr.sbin/bsdinstall: . scripts

2020-01-16 Thread Colin Percival
new feature. Nobody will trip over new features by mistake, but there's probably someone out there who is used to holding down the Enter key in the installer and expects to get UFS. -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Found

svn commit: r360025 - head/sys/dev/acpica

2020-04-16 Thread Colin Percival
Author: cperciva Date: Thu Apr 16 21:56:52 2020 New Revision: 360025 URL: https://svnweb.freebsd.org/changeset/base/360025 Log: Alert devd when acpi_video brightness changes On my Dell Latitude 7390 laptop, the brightness hotkeys (Fn+) send ACPI notifications which acpi_video handles by

Re: svn commit: r360025 - head/sys/dev/acpica

2020-04-16 Thread Colin Percival
On 2020-04-16 15:05, Oliver Pinter wrote: > On Thursday, April 16, 2020, Colin Percival <mailto:cperc...@freebsd.org>> wrote: > Log: >   Alert devd when acpi_video brightness changes > > Please add this to release notes! I considered that, but so far I don't

Re: svn commit: r360025 - head/sys/dev/acpica

2020-04-17 Thread Colin Percival
On 2020-04-16 23:26, Alexey Dokuchaev wrote: > On Thu, Apr 16, 2020 at 03:12:15PM -0700, Colin Percival wrote: >> On 2020-04-16 15:05, Oliver Pinter wrote: >>> On Thursday, April 16, 2020, Colin Percival >> <mailto:cperc...@freebsd.org>> wrote: >>>

svn commit: r360396 - head/release/tools

2020-04-27 Thread Colin Percival
Author: cperciva Date: Mon Apr 27 21:44:02 2020 New Revision: 360396 URL: https://svnweb.freebsd.org/changeset/base/360396 Log: Set use_nvd=0 in EC2 AMIs. FreeBSD is in the process of switching from nvd(4) to nda(4) as the disk device front-end to NVMe. Changing the default in the kernel

Re: svn commit: r360508 - head/sys/cam/nvme

2020-05-02 Thread Colin Percival
0xfe00d82434e0 __mtx_assert() at __mtx_assert+0xb0/frame 0xfe00d82434f0 xpt_release_ccb() at xpt_release_ccb+0x30/frame 0xfe00d8243520 ndaioctl() at ndaioctl+0x241/frame 0xfe00d8243730 -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | w

svn commit: r361097 - head/sys/dev/acpica

2020-05-15 Thread Colin Percival
Author: cperciva Date: Sat May 16 01:50:28 2020 New Revision: 361097 URL: https://svnweb.freebsd.org/changeset/base/361097 Log: Send Lid status notification via devd from acpi_lid_status_update. Some laptops don't send ACPI "lid status changed" notifications upon opening the lid if the sy

svn commit: r361114 - head/libexec/rc/rc.d

2020-05-16 Thread Colin Percival
Author: cperciva Date: Sat May 16 18:37:48 2020 New Revision: 361114 URL: https://svnweb.freebsd.org/changeset/base/361114 Log: Move the devmatch rc.d script before netif in the boot process. Prior to this change, using lagg to aggregate wired and wireless networks was broken in the (rela

Re: svn commit: r361114 - head/libexec/rc/rc.d

2020-05-16 Thread Colin Percival
On 2020-05-16 11:37, Colin Percival wrote: > Author: cperciva > Date: Sat May 16 18:37:48 2020 > New Revision: 361114 > URL: https://svnweb.freebsd.org/changeset/base/361114 > > Log: > Move the devmatch rc.d script before netif in the boot process. > > Prior to

svn commit: r361143 - head/release/tools

2020-05-17 Thread Colin Percival
Author: cperciva Date: Sun May 17 21:54:59 2020 New Revision: 361143 URL: https://svnweb.freebsd.org/changeset/base/361143 Log: Add /etc/autofs/special_efs to EC2 AMIs Since Amazon Elastic File System is only available within AWS, it seems more appropriate to have this added only in EC2 A

Re: svn commit: r361143 - head/release/tools

2020-05-17 Thread Colin Percival
On 2020-05-17 16:48, Oliver Pinter wrote: > On Sunday, May 17, 2020, Colin Percival <mailto:cperc...@freebsd.org>> wrote: > +REGION=`fetch -qo- > http://169.254.169.254/latest/meta-data/placement/availability-zone > <http://169.254.169.254/latest/meta-data/pla

svn commit: r361150 - head/release/tools

2020-05-17 Thread Colin Percival
Author: cperciva Date: Mon May 18 02:14:25 2020 New Revision: 361150 URL: https://svnweb.freebsd.org/changeset/base/361150 Log: Add ebsnvme-id to EC2 AMIs and enable /dev/aws/disk The ebsnvme-id utility exposes information about EC2 disks -- for Elastic Block Store volumes, their volume I

svn commit: r325254 - head/release/tools

2017-10-31 Thread Colin Percival
Author: cperciva Date: Wed Nov 1 00:33:54 2017 New Revision: 325254 URL: https://svnweb.freebsd.org/changeset/base/325254 Log: Add the amazon-ssm-agent package to EC2 AMI builds. This makes it immediately available on instances which are running without internet access (or which can't rely

svn commit: r357749 - head/release/tools

2020-02-10 Thread Colin Percival
Author: cperciva Date: Tue Feb 11 04:03:22 2020 New Revision: 357749 URL: https://svnweb.freebsd.org/changeset/base/357749 Log: Remove /qemu from EC2 ARM AMIs I forgot to do this as part of r345858 -- I added it to the vm_extra_pre_umount in vmimage.subr but forgot that function was ove

svn commit: r357750 - head/release/tools

2020-02-10 Thread Colin Percival
Author: cperciva Date: Tue Feb 11 04:05:45 2020 New Revision: 357750 URL: https://svnweb.freebsd.org/changeset/base/357750 Log: Mount /dev while deinstalling pkg inside EC2 AMIs. This gets rid of (harmless) warnings: "pkg: Cannot open /dev/null:No such file or directory". MFC after:

svn commit: r358478 - head/usr.sbin/powerd

2020-02-29 Thread Colin Percival
Author: cperciva Date: Sat Feb 29 22:31:23 2020 New Revision: 358478 URL: https://svnweb.freebsd.org/changeset/base/358478 Log: Add -N option to powerd(8) to ignore "nice" time. With powerd_flags="-N", this makes powerd(8) exclude "nice" time when computing the CPU utilization. This make

Re: svn commit: r355570 - head/sys/dev/sound/pci/hda

2020-03-18 Thread Colin Percival
Latitude 7390 too -- nid20 is the internal speakers while nid33 is the headphone jack. Can you make the change or walk me through what needs to be done? (I'm not sure how the _SUBVENDOR bit works.) -- Colin Percival Security Officer Emeritus, FreeBSD | Th

svn commit: r221049 - head/sbin/newfs

2011-04-25 Thread Colin Percival
Author: cperciva Date: Tue Apr 26 02:06:31 2011 New Revision: 221049 URL: http://svn.freebsd.org/changeset/base/221049 Log: Stop trying to zero UFS1 superblocks if we fall off the end of the disk. This avoids a potentially many-hours-long loop of failed writes if newfs finds a partially-o

svn commit: r206396 - head

2010-04-08 Thread Colin Percival
Author: cperciva Date: Thu Apr 8 09:01:20 2010 New Revision: 206396 URL: http://svn.freebsd.org/changeset/base/206396 Log: People working on sysinstall are encouraged to contact randi to coordinate major changes. Modified: head/MAINTAINERS Modified: head/MAINTAINERS ==

Re: svn commit: r206687 - head/usr.bin/indent

2010-04-16 Thread Colin Percival
was guaranteed to work on any conforming POSIX system, one would naturally wish to avoid symbols which might legitimately be defined in headers; but as long as we're concerned with one specific system which happens to not define the symbol "_t" in any header, this is a non-issue. -- Coli

svn commit: r208586 - head/contrib/opie/libopie head/lib/libc/sys head/sys/nfsclient head/usr.sbin/jail releng/6.4 releng/6.4/contrib/opie/libopie releng/6.4/sys/conf releng/7.1 releng/7.1/contrib/...

2010-05-26 Thread Colin Percival
Author: cperciva Date: Thu May 27 03:15:04 2010 New Revision: 208586 URL: http://svn.freebsd.org/changeset/base/208586 Log: Change the current working directory to be inside the jail created by the jail(8) command. [10:04] Fix a one-NUL-byte buffer overflow in libopie. [10:05] Correc

svn commit: r208606 - head/crypto/openssh

2010-05-27 Thread Colin Percival
Author: cperciva Date: Fri May 28 01:06:40 2010 New Revision: 208606 URL: http://svn.freebsd.org/changeset/base/208606 Log: Fix .Dd line: FreeBSD's mdoc code doesn't understand OpenBSD's $Mdocdate$. MFC after:3 days Modified: head/crypto/openssh/ssh-pkcs11-helper.8 Modified: head/cr

svn commit: r208803 - head/sys/kern

2010-06-04 Thread Colin Percival
Author: cperciva Date: Fri Jun 4 14:38:24 2010 New Revision: 208803 URL: http://svn.freebsd.org/changeset/base/208803 Log: Declare ip6 as (struct in6_addr *) instead of (struct in_addr *). This is a harmless bug since we never actually use ip6 as anything other than an opaque pointer.

svn commit: r209072 - head/usr.sbin/sysinstall

2010-06-11 Thread Colin Percival
Author: cperciva Date: Fri Jun 11 21:46:45 2010 New Revision: 209072 URL: http://svn.freebsd.org/changeset/base/209072 Log: Clean up code by removing pre-C99 struct hack preprocessor magic. Approved by: randi (maintainer) Modified: head/usr.sbin/sysinstall/sysinstall.h Modified: head/u

svn commit: r209117 - head/lib/libc/stdlib

2010-06-12 Thread Colin Percival
Author: cperciva Date: Sun Jun 13 01:13:36 2010 New Revision: 209117 URL: http://svn.freebsd.org/changeset/base/209117 Log: In threaded processes, destroy the mutex atexit_mutex when we've finished using it. This allows the mutex's allocated memory to be freed. This is one sense a rath

Re: svn commit: r209221 - head/bin/sh

2010-06-15 Thread Colin Percival
mpletion and insert a tab character instead. For what it's worth, I find that having tab completion disabled is very useful when I paste pieces of shell script into consoles. If other people also do this, it might be an argument in favour of providing a more user-friendly way to disable tab completion

svn commit: r209546 - head/share/man/man9

2010-06-26 Thread Colin Percival
Author: cperciva Date: Sun Jun 27 02:30:19 2010 New Revision: 209546 URL: http://svn.freebsd.org/changeset/base/209546 Log: Note that internal_underscores should be used in identifier names rather than camelCase or TitleCase. According to grep and my checked-out source tree, we're current

svn commit: r228843 - head/contrib/telnet/libtelnet head/crypto/heimdal/appl/telnet/libtelnet head/include head/lib/libc/gen head/lib/libc/iconv head/lib/libc/include head/lib/libc/net head/libexec...

2011-12-23 Thread Colin Percival
Author: cperciva Date: Fri Dec 23 15:00:37 2011 New Revision: 228843 URL: http://svn.freebsd.org/changeset/base/228843 Log: Fix a problem whereby a corrupt DNS record can cause named to crash. [11:06] Add an API for alerting internal libc routines to the presence of "unsafe" paths post-ch

Re: svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnm

2011-12-30 Thread Colin Percival
de that gives us up to 2048 chunks. >> >> Should be "11 bits", no? > > I'm not a native speaker, but I think "11 bit wide" is correct here. I am a native speaker, and it's "11 bits wide". English is an odd language: An "11 bit wide

Re: svn commit: r230125 - head/sys/kern

2012-01-15 Thread Colin Percival
ge from "(null)" to "(unknown)" is useful, since when I see "(null)" printed my immediate thought is "looks like there's a bug I need to track down here". -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap

svn commit: r230183 - head/sys/dev/xen/xenpci

2012-01-15 Thread Colin Percival
Author: cperciva Date: Mon Jan 16 02:38:45 2012 New Revision: 230183 URL: http://svn.freebsd.org/changeset/base/230183 Log: Make XENHVM work on i386. The __ffs() function counts bits starting from zero, unlike ffs(3), which starts counting from 1. Modified: head/sys/dev/xen/xenpci/evtchn.c

svn commit: r230184 - head/sys/i386/conf

2012-01-15 Thread Colin Percival
Author: cperciva Date: Mon Jan 16 02:42:16 2012 New Revision: 230184 URL: http://svn.freebsd.org/changeset/base/230184 Log: Copy XENHVM config file from amd64, now that i386+XENHVM works. Added: - copied unchanged from r230183, head/sys/amd64/conf/XENHVM Directory Properties: head/sys/i3

svn commit: r230185 - head/sys/i386/conf

2012-01-15 Thread Colin Percival
Author: cperciva Date: Mon Jan 16 02:42:41 2012 New Revision: 230185 URL: http://svn.freebsd.org/changeset/base/230185 Log: s/amd64/i386/ in comment. Modified: head/sys/i386/conf/XENHVM Modified: head/sys/i386/conf/XENHVM ==

svn commit: r221780 - head/usr.sbin/freebsd-update

2011-05-11 Thread Colin Percival
Author: cperciva Date: Wed May 11 15:23:27 2011 New Revision: 221780 URL: http://svn.freebsd.org/changeset/base/221780 Log: Make freebsd-update(8) smarter in how it handles $FreeBSD$ tags in configuration files. If the current file differs from the canonical version from the old release

svn commit: r221900 - head

2011-05-14 Thread Colin Percival
Author: cperciva Date: Sat May 14 17:44:12 2011 New Revision: 221900 URL: http://svn.freebsd.org/changeset/base/221900 Log: Encourage Ben Laurie to finish getting his commit bit by appointing him as the OpenSSL maintainer. With hat: security-officer Reviewed by: simon (former maint

svn commit: r223582 - head/lib/libmd

2011-06-26 Thread Colin Percival
is non-null it must point to at .Xr sha 3 .Sh HISTORY These functions appeared in -.Fx 4.0 . +.Fx 6.0 . .Sh AUTHORS The core hash routines were implemented by Colin Percival based on the published Modified: head/lib/libmd/sha512.3

svn commit: r223797 - head/sys/netinet

2011-07-05 Thread Colin Percival
Author: cperciva Date: Tue Jul 5 18:43:54 2011 New Revision: 223797 URL: http://svn.freebsd.org/changeset/base/223797 Log: Don't allow lro->len to exceed 65535, as this will result in overflow when len is inserted back into the synthetic IP packet and cause a multiple of 2^16 bytes of TCP "

svn commit: r223799 - head/sys/netinet

2011-07-05 Thread Colin Percival
Author: cperciva Date: Tue Jul 5 18:49:55 2011 New Revision: 223799 URL: http://svn.freebsd.org/changeset/base/223799 Log: Remove #ifdef notyet code dating back to 4.3BSD Net/2 (and possibly earlier). I think the benefit of making the code cleaner and easier to understand outweighs the h

Re: svn commit: r209787 - head/usr.sbin/sysinstall

2010-07-08 Thread Colin Percival
to a release it doesn't support (freebsd-update only does RELEASEs, BETAs, and RCs). But a more *sensual* message is probably not necessary. :-) -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tar

svn commit: r209964 - head/sys/kern releng/7.1 releng/7.1/sys/conf releng/7.1/sys/kern releng/7.3 releng/7.3/sys/conf releng/7.3/sys/kern releng/8.0 releng/8.0/sys/conf releng/8.0/sys/kern releng/8...

2010-07-12 Thread Colin Percival
Author: cperciva Date: Tue Jul 13 02:45:17 2010 New Revision: 209964 URL: http://svn.freebsd.org/changeset/base/209964 Log: Correctly copy the M_RDONLY flag when duplicating a reference to an mbuf external buffer. Approved by: so (cperciva) Approved by: re (kensmith) Security: F

Re: svn commit: r210225 - in head/sys: kern sys

2010-07-18 Thread Colin Percival
and the old and new cr_ruidinfo proc If you don't want to have "/*-" for these, please change them instead to "/**", since that is an alternative "box comment" marker. -- Colin Percival Security Officer, FreeBSD | freebsd.org |

Re: svn commit: r211084 - head/bin/sh

2010-08-08 Thread Colin Percival
NOPQRSTUCVWXYZ", "ISUPPER"); > + add("abcdefghijklmnopqrstuvwxyz", "ISLOWER"); > + add("ABCDEFGHIJKLMNOPQRSTUVWXYZ", "ISUPPER"); Ok, I have to wonder: Why was there ever the extra 'C' between 'U' and 'V'? It see

svn commit: r212431 - head/usr.sbin/freebsd-update

2010-09-10 Thread Colin Percival
Author: cperciva Date: Fri Sep 10 19:20:52 2010 New Revision: 212431 URL: http://svn.freebsd.org/changeset/base/212431 Log: Remind the user that he needs to run 'freebsd-update install' to install new bits after downloading them using 'freebsd-update upgrade'. Submitted by: bapt MFC aft

svn commit: r212432 - head/usr.sbin/freebsd-update

2010-09-10 Thread Colin Percival
Author: cperciva Date: Fri Sep 10 19:23:59 2010 New Revision: 212432 URL: http://svn.freebsd.org/changeset/base/212432 Log: Add warning about freebsd-update upgrade needing lots of disk space. Submitted by: jpaetzel MFC after:1 month Modified: head/usr.sbin/freebsd-update/freebsd-u

svn commit: r212434 - head/usr.sbin/freebsd-update

2010-09-10 Thread Colin Percival
Author: cperciva Date: Fri Sep 10 20:20:28 2010 New Revision: 212434 URL: http://svn.freebsd.org/changeset/base/212434 Log: "freebsd-update fetch -r NEWRELEASE" is meaningless and probably a typo for "freebsd-update upgrade -r NEWRELEASE". Error out and suggest what the user probably meant.

svn commit: r212901 - head/contrib/bzip2 releng/6.4 releng/6.4/contrib/bzip2 releng/6.4/sys/conf releng/7.1 releng/7.1/contrib/bzip2 releng/7.1/sys/conf releng/7.3 releng/7.3/contrib/bzip2 releng/7...

2010-09-20 Thread Colin Percival
Author: cperciva Date: Mon Sep 20 14:58:08 2010 New Revision: 212901 URL: http://svn.freebsd.org/changeset/base/212901 Log: Fix an integer overflow in RLE length parsing when decompressing corrupt bzip2 data. Approved by: so (cperciva) Security: FreeBSD-SA-10:08.bzip2 Modified:

svn commit: r213287 - head/games/fortune/datfiles

2010-09-29 Thread Colin Percival
Author: cperciva Date: Wed Sep 29 23:47:06 2010 New Revision: 213287 URL: http://svn.freebsd.org/changeset/base/213287 Log: Add advice to new fathers from Thomas Ptacek. Suggested by: wilko Approved by: Thomas Ptacek Security: New parents often feel very insecure. Modified: head

svn commit: r215105 - head/contrib/binutils/bfd

2010-11-10 Thread Colin Percival
Author: cperciva Date: Thu Nov 11 00:29:19 2010 New Revision: 215105 URL: http://svn.freebsd.org/changeset/base/215105 Log: Zero the buffer containing the .gnu_debuglink section before writing into it. Prior to this commit the .gnu_debuglink section can have up to 3 bytes of uninitialized g

svn commit: r215470 - head/sys/i386/xen

2010-11-18 Thread Colin Percival
Author: cperciva Date: Thu Nov 18 21:02:40 2010 New Revision: 215470 URL: http://svn.freebsd.org/changeset/base/215470 Log: Don't KASSERT in pmap_release that xpmap_ptom(VM_PAGE_TO_PHYS(m)) == (pmap->pm_pdpt[i] & PG_FRAME) for i = NPGPTD, since pmap->pm_pdpt[i] is only initialized for 0

svn commit: r215472 - head/sys/i386/xen

2010-11-18 Thread Colin Percival
Author: cperciva Date: Thu Nov 18 21:29:43 2010 New Revision: 215472 URL: http://svn.freebsd.org/changeset/base/215472 Log: Make pmap_release match pmap_pinit by invoking pmap_qremove(pmap->pm_pdpt) to match pmap_pinit's pmap_qenter(pmap->pm_pdpt) call in the case of PAE. Modified: head/sys

svn commit: r215525 - head/sys/i386/xen

2010-11-19 Thread Colin Percival
Author: cperciva Date: Fri Nov 19 15:12:19 2010 New Revision: 215525 URL: http://svn.freebsd.org/changeset/base/215525 Log: Make pmap_release consistent with pmap_pinit with respect to unpinning pages. The pinning of NPGPTD pages is #if 0ed out in pmap_pinit (I'm not quite sure why...) and

svn commit: r215587 - in head/sys/i386: include xen

2010-11-20 Thread Colin Percival
Author: cperciva Date: Sat Nov 20 20:04:29 2010 New Revision: 215587 URL: http://svn.freebsd.org/changeset/base/215587 Log: Add VTOM(va) macro as xpmap_ptom(VTOP(va)) to convert to machine addresses. Clean up the code by converting xpmap_ptom(VTOP(...)) to VTOM(...) and converting xpmap_p

svn commit: r215593 - head/sys/i386/xen

2010-11-20 Thread Colin Percival
Author: cperciva Date: Sat Nov 20 21:36:12 2010 New Revision: 215593 URL: http://svn.freebsd.org/changeset/base/215593 Log: Unifdef XEN. This file is only compiled with the XEN kernel option set, and the !XEN bits get in the way of understanding the code. Modified: head/sys/i386/xen/pmap.c

svn commit: r215663 - head/sys/i386/xen

2010-11-22 Thread Colin Percival
Author: cperciva Date: Mon Nov 22 09:04:29 2010 New Revision: 215663 URL: http://svn.freebsd.org/changeset/base/215663 Log: In xen_get_timecount, return the full ns-precision time rather than rounding to 1/HZ precision. I have no idea why the rounding was introduced in the first place, bu

svn commit: r215665 - head/sys/kern

2010-11-22 Thread Colin Percival
Author: cperciva Date: Mon Nov 22 09:13:25 2010 New Revision: 215665 URL: http://svn.freebsd.org/changeset/base/215665 Log: In tc_windup, handle the case where the previous call to tc_windup was more than 1s earlier. Prior to this commit, the computation of th_scale * delta (which produces

svn commit: r215732 - head/sys/kern

2010-11-22 Thread Colin Percival
Author: cperciva Date: Tue Nov 23 04:50:01 2010 New Revision: 215732 URL: http://svn.freebsd.org/changeset/base/215732 Log: Add parentheses for clarity. The parentheses around the two terms of the && are unnecessary but I'm leaving them in for the sake of avoiding confusion (I confuse easil

  1   2   3   4   >