Re: svn commit: r336002 - in head: usr.bin/netstat usr.sbin/tcpdrop

2018-07-05 Thread Bruce Evans
On Fri, 6 Jul 2018, Bruce Evans wrote: On Thu, 5 Jul 2018, Brooks Davis wrote: Log: Work around lame warnings in ancient gcc on 32-bit platforms. Fixes r335979. These are correct warnings. Why not fix the bug instead of rorking around it? Modified: head/usr.bin/netstat/inet.c

Re: svn commit: r336025 - in head/sys: amd64/include i386/include

2018-07-06 Thread Bruce Evans
On Fri, 6 Jul 2018, John Baldwin wrote: On 7/6/18 8:52 AM, Rodney W. Grimes wrote: ... Trivial to fix this with +#if defined(SMP) || !defined(_KERNEL) || defined(KLD_MODULE) || !defined(KLD_UP_MODULES) This is not worth it. Note that we already use LOCK always in userland which is probably

svn commit: r336362 - in head/lib/msun: ld128 ld80 src

2018-07-17 Thread Bruce Evans
Author: bde Date: Tue Jul 17 07:42:14 2018 New Revision: 336362 URL: https://svnweb.freebsd.org/changeset/base/336362 Log: Add a macro nan_mix() and use it to get NaN results that are (bitwise) independent of the precision in most cases. This is mainly to simplify checking for errors. r176

svn commit: r336400 - head/lib/msun/src

2018-07-17 Thread Bruce Evans
Author: bde Date: Tue Jul 17 10:44:16 2018 New Revision: 336400 URL: https://svnweb.freebsd.org/changeset/base/336400 Log: Fix scaling bugs which gave innaccuracies and spurious underflows in csqrt() and csqrtl(). When one component is huge and the other is tiny, scaling down the tiny c

svn commit: r336412 - head/lib/msun/src

2018-07-17 Thread Bruce Evans
Author: bde Date: Tue Jul 17 12:01:59 2018 New Revision: 336412 URL: https://svnweb.freebsd.org/changeset/base/336412 Log: Minor cleanups to csqrt*(), mostly in comments. Remove the STDC CX_LIMITED_RANGE pragma and its verbose comment. We still don't have any C99 compilers (that support

svn commit: r336484 - head/lib/msun/src

2018-07-19 Thread Bruce Evans
Author: bde Date: Thu Jul 19 14:24:48 2018 New Revision: 336484 URL: https://svnweb.freebsd.org/changeset/base/336484 Log: Oops, r336412 undid the fix of the overflow threshold in r323003. Restore the previous overflow threshold and adjust comments. Modified: head/lib/msun/src/s_csqrtl.c

svn commit: r336488 - head/lib/msun/src

2018-07-19 Thread Bruce Evans
Author: bde Date: Thu Jul 19 15:04:10 2018 New Revision: 336488 URL: https://svnweb.freebsd.org/changeset/base/336488 Log: Fix spurious and extra underflows and resulting inaccuracies for some cases with 1 huge component and 1 tiny (but nowhere near denormal) component. Rescale earlier so th

Re: svn commit: r336517 - head/sys/powerpc/include

2018-07-19 Thread Bruce Evans
On Thu, 19 Jul 2018, Justin Hibbits wrote: Log: Revert r336509. Fails buildworld. I had naively assumed that building kernel would be sufficient to test that the header is sane. However, it turns out this now needs -fms-extensions to build. Rather than sprinkling -fms-extensions all over

svn commit: r336545 - in head/lib/msun: ld128 ld80 src

2018-07-20 Thread Bruce Evans
Author: bde Date: Fri Jul 20 12:42:24 2018 New Revision: 336545 URL: https://svnweb.freebsd.org/changeset/base/336545 Log: Centralize the complications for special efficient rounding to integers. This was open-coded in range reduction for trig and exp functions. Now there are 3 static in

svn commit: r336663 - head/lib/msun/src

2018-07-24 Thread Bruce Evans
Author: bde Date: Tue Jul 24 10:10:16 2018 New Revision: 336663 URL: https://svnweb.freebsd.org/changeset/base/336663 Log: Fix the conversion to use nan_mix() in r336362. fmod*(x, y), remainder*(x, y) and remquo*(x, y, quo) were broken for y = 0 by changing multiplication by y to addition o

svn commit: r336665 - head/lib/msun/src

2018-07-24 Thread Bruce Evans
Author: bde Date: Tue Jul 24 11:50:05 2018 New Revision: 336665 URL: https://svnweb.freebsd.org/changeset/base/336665 Log: In C remquol() and thus also in C remainderl(), don't clobber the sign bit of NaNs before possible returning a NaN. The remquo*() and remainder*() functions should no

Re: svn commit: r337334 - head/lib/libc/sys

2018-08-05 Thread Bruce Evans
On Sat, 4 Aug 2018, Conrad Meyer wrote: Log: settimeofday(2): Remove stale note about timezone Contrary to the removed comment, the kernel does appear to use the timezone argument of settimeofday. The comment dates to the BSD4.4 import; I assume it is just stale. The kernel not only appe

Re: svn commit: r337334 - head/lib/libc/sys

2018-08-05 Thread Bruce Evans
On Sun, 5 Aug 2018, Ian Lepore wrote: On Sat, 2018-08-04 at 16:39 -0600, Warner Losh wrote: [Context lost to corruption of spaces} Specifically, for compatibility, we store minutes west of UTC on settimeofday and we retrieve it for settimeofday. Otherwise it's 100% unused by anything else at

Re: svn commit: r337334 - head/lib/libc/sys

2018-08-05 Thread Bruce Evans
On Mon, 6 Aug 2018, Bruce Evans wrote: ... I forgot about FAT times, and only remembered that utc_offset() was used for RTC drivers. I thought that utc_offset() is 0 unless something sets the timezone to nonzero or the RTC is on local time (wall_cmos_clock case). However, since the kernel

Re: svn commit: r337518 - in head/sys: kern sys

2018-08-09 Thread Bruce Evans
On Thu, 9 Aug 2018, Kyle Evans wrote: Log: kern: Add a BOOT_TAG marker at the beginning of boot dmesg From the "newly licensed to drive" PR department, add a BOOT_TAG marker (by default, --<>--, to the beginning of each boot's dmesg. This makes it easier to do textproc magic to locate the s

Re: svn commit: r337426 - head/sbin/ifconfig

2018-08-09 Thread Bruce Evans
On Tue, 7 Aug 2018, Mark Johnston wrote: Log: ifconfig: Fix use of _Noreturn. The _Noreturn is a function-specifier (like inline) which must preceed the declarator. Submitted by: Sebastian Huber MFC after: 1 week _Noreturn is even more broken than I knew. It should never be used.

Re: svn commit: r337518 - in head/sys: kern sys

2018-08-09 Thread Bruce Evans
On Thu, 9 Aug 2018, Kyle Evans wrote: On Thu, Aug 9, 2018 at 6:22 PM, Bruce Evans wrote: ... The only obvious bug in (a later version of) the output is a missing newline for the tag. My dmesg output on amd64: X ---<>--<>---Test of early printf to msgbuf X GDB: debug port

Re: svn commit: r337518 - in head/sys: kern sys

2018-08-09 Thread Bruce Evans
On Fri, 10 Aug 2018, Bruce Evans wrote: On Thu, 9 Aug 2018, Kyle Evans wrote: ... When you say you call msgbufinit() earlier-- before the static environment is even setup, or at least after that? The above is with a simplified version that first calls msgbufinit() after the static env is set

Re: svn commit: r345138 - head/share/man/man9

2019-03-15 Thread Bruce Evans
On Fri, 15 Mar 2019, Poul-Henning Kamp wrote: In message <201903150152.x2f1q34w027...@gndrsh.dnsmgr.net>, "Rodney W. Grimes" writes: The first versions of CTM used diff -e and ed(1) to transmit changes, and that choked up on binary files. We didn't have patch in the tree back then.

Re: svn commit: r345359 - in head/sys/cddl/dev/dtrace: amd64 i386

2019-03-21 Thread Bruce Evans
On Wed, 20 Mar 2019, Mark Johnston wrote: On Wed, Mar 20, 2019 at 08:20:18PM -0700, Rodney W. Grimes wrote: Author: markj Date: Thu Mar 21 02:52:22 2019 New Revision: 345359 URL: https://svnweb.freebsd.org/changeset/base/345359 Log: Don't attempt to measure TSC skew when running as a VM gues

Re: svn commit: r345359 - in head/sys/cddl/dev/dtrace: amd64 i386

2019-03-21 Thread Bruce Evans
On Thu, 21 Mar 2019, Bruce Evans wrote: On Wed, 20 Mar 2019, Mark Johnston wrote: On Wed, Mar 20, 2019 at 08:20:18PM -0700, Rodney W. Grimes wrote: Author: markj Date: Thu Mar 21 02:52:22 2019 New Revision: 345359 URL: https://svnweb.freebsd.org/changeset/base/345359 Log: Don't attem

Re: svn commit: r345380 - head/lib/libc/gen

2019-03-21 Thread Bruce Evans
On Thu, 21 Mar 2019, Conrad Meyer wrote: Log: arc4random: Adjust example code to use uniform() API This changes the example from correct to broken. I see 4 bugs: 1. The log message says that the example uses uniform(), but it actually uses arc4random_uniform(). PR:236678

Re: svn commit: r345380 - head/lib/libc/gen

2019-03-22 Thread Bruce Evans
On Fri, 22 Mar 2019, Bruce Evans wrote: On Thu, 21 Mar 2019, Conrad Meyer wrote: Log: arc4random: Adjust example code to use uniform() API This changes the example from correct to broken. I see 4 bugs: I see many more (old but related) bugs. 1. The log message says that the example

Re: svn commit: r345359 - in head/sys/cddl/dev/dtrace: amd64 i386

2019-03-22 Thread Bruce Evans
On Thu, 21 Mar 2019, Mark Johnston wrote: On Thu, Mar 21, 2019 at 10:44:49PM +1100, Bruce Evans wrote: On Wed, 20 Mar 2019, Mark Johnston wrote: On Wed, Mar 20, 2019 at 08:20:18PM -0700, Rodney W. Grimes wrote: Author: markj Date: Thu Mar 21 02:52:22 2019 New Revision: 345359 URL: https

Re: svn commit: r345359 - in head/sys/cddl/dev/dtrace: amd64 i386

2019-03-23 Thread Bruce Evans
On Sat, 23 Mar 2019, Bruce Evans wrote: I now have an almost perfect skew measuring program. It has a variance of about 2 cycles. Output on i4790k (only for CPU 0 vs CPU [1-7], since nothing different happens for the general CPU i vs CPU j comparison): XX(min/avg/max/sd) XX

svn commit: r345474 - head/lib/libvgl

2019-03-24 Thread Bruce Evans
Author: bde Date: Sun Mar 24 16:47:43 2019 New Revision: 345474 URL: https://svnweb.freebsd.org/changeset/base/345474 Log: Fix libvgl to not always fail to initialize due to its invalid mmap() args (neither MAP_PRIVATE nor MAP_SHARED). It was broken in r271635 and/or r271724 by stricter che

svn commit: r345481 - head/lib/libvgl

2019-03-24 Thread Bruce Evans
Author: bde Date: Sun Mar 24 19:27:03 2019 New Revision: 345481 URL: https://svnweb.freebsd.org/changeset/base/345481 Log: Fix reading of pixels in (4 and 8-plane) planar modes. There seems to be no alternative to reading each plane independently using 3 slow i/o's per plane (this deliver

svn commit: r345483 - head/lib/libvgl

2019-03-24 Thread Bruce Evans
Author: bde Date: Sun Mar 24 19:41:45 2019 New Revision: 345483 URL: https://svnweb.freebsd.org/changeset/base/345483 Log: Add support for arbitrary font widths. Only multiples of 8 were supported. Since the font format is undocumented, it is unclear how non-multiples of 8 should be padd

svn commit: r345478 - head/lib/libvgl

2019-03-24 Thread Bruce Evans
Author: bde Date: Sun Mar 24 18:57:03 2019 New Revision: 345478 URL: https://svnweb.freebsd.org/changeset/base/345478 Log: Fix buffer overruns in modes with color depth more than 8. Support for 16-bit and 32-bit Truecolor modes was supposed to be complete in r70991 of main.c and in nearby

svn commit: r345484 - head/lib/libvgl

2019-03-24 Thread Bruce Evans
Author: bde Date: Sun Mar 24 20:36:35 2019 New Revision: 345484 URL: https://svnweb.freebsd.org/changeset/base/345484 Log: Fix the type of the color args for VGLMouseFreeze(), VGLBitmapPutChar(), VGLBitmapString() and VGLSetBorder() so as to not truncate to 8 bits. Complete the correspond

svn commit: r345486 - head/lib/libvgl

2019-03-24 Thread Bruce Evans
Author: bde Date: Sun Mar 24 20:43:21 2019 New Revision: 345486 URL: https://svnweb.freebsd.org/changeset/base/345486 Log: Oops, my previous commit to libvgl was missing the change of VGLSetBorder() to match the change in its declaration. Change the declaration back to "byte color" since se

svn commit: r345496 - head/lib/libvgl

2019-03-25 Thread Bruce Evans
Author: bde Date: Mon Mar 25 11:48:40 2019 New Revision: 345496 URL: https://svnweb.freebsd.org/changeset/base/345496 Log: Fix another type of buffer overrun for segmented modes. The buffer index was not taken modulo the window size in VGLClear(). Segmented modes also need a kernel fix t

svn commit: r345568 - head/lib/libvgl

2019-03-27 Thread Bruce Evans
Author: bde Date: Wed Mar 27 08:02:55 2019 New Revision: 345568 URL: https://svnweb.freebsd.org/changeset/base/345568 Log: Fix copying of bitmaps in depths > 8. This fix is complete, except different depths for the source and target are not supported. The bits for higher numbered planes (m

svn commit: r345585 - head/lib/libvgl

2019-03-27 Thread Bruce Evans
Author: bde Date: Wed Mar 27 18:03:34 2019 New Revision: 345585 URL: https://svnweb.freebsd.org/changeset/base/345585 Log: Fix accessing pixels under the mouse cursor: Reading of single pixels didn't look under the cursor. Copying of 1x1 bitmaps didn't look under the cursor for either

svn commit: r345637 - head/lib/libvgl

2019-03-28 Thread Bruce Evans
Author: bde Date: Thu Mar 28 09:51:37 2019 New Revision: 345637 URL: https://svnweb.freebsd.org/changeset/base/345637 Log: Oops, r345496 got the pointer args backwards for bcopy() in VGLClear for segmented modes. Also fix some style bugs in the 2 changed lines. libvgl uses a very non-KNF

svn commit: r345639 - head/lib/libvgl

2019-03-28 Thread Bruce Evans
Author: bde Date: Thu Mar 28 12:28:29 2019 New Revision: 345639 URL: https://svnweb.freebsd.org/changeset/base/345639 Log: Fix VGLGetXY(), VGLSetXY() and VGLClear() for MEMBUFs in depths > 8. This depends on PixelBytes being properly initialized, which it is for all bitmaps constructed by

svn commit: r345643 - head/lib/libvgl

2019-03-28 Thread Bruce Evans
Author: bde Date: Thu Mar 28 14:21:22 2019 New Revision: 345643 URL: https://svnweb.freebsd.org/changeset/base/345643 Log: Fix VGLLine() in depths > 8. It started truncating its color arg to 8 bits using plot() in r229415. The version in r229415 is also more than 3 times slower in segment

Re: svn commit: r345680 - head/sys/conf

2019-03-28 Thread Bruce Evans
On Thu, 28 Mar 2019, Ravi Pokala wrote: -Original Message- From: on behalf of Kyle Evans Date: 2019-03-28, Thursday at 21:00 To: , , Subject: svn commit: r345680 - head/sys/conf Author: kevans Date: Fri Mar 29 04:00:46 2019 New Revision: 345680 URL: https://svnweb.freebsd.org/chan

Re: svn commit: r345680 - head/sys/conf

2019-03-29 Thread Bruce Evans
On Fri, 29 Mar 2019, Alexey Dokuchaev wrote: On Fri, Mar 29, 2019 at 05:40:05PM +1100, Bruce Evans wrote: ... -optionsBOOT_TAG=\"---<>---\" +optionsBOOT_TAG=\"\" Useful variations are not always easy to invent. I usually just add 1 for numeric value

svn commit: r345695 - head/lib/libvgl

2019-03-29 Thread Bruce Evans
Author: bde Date: Fri Mar 29 15:20:48 2019 New Revision: 345695 URL: https://svnweb.freebsd.org/changeset/base/345695 Log: Fix races in mouse signal handling almost properly using the INTOFF/INTON method as in /bin/sh. We still do technically undefined things in the signal handler, but it

svn commit: r345696 - head/lib/libvgl

2019-03-29 Thread Bruce Evans
Author: bde Date: Fri Mar 29 15:57:08 2019 New Revision: 345696 URL: https://svnweb.freebsd.org/changeset/base/345696 Log: Fix endless loops for handling SIGBUS and SIGSEGV. r80270 has the usual wrong fix for unsafe signal handling -- just set a flag and return to let an event loop check

svn commit: r345698 - head/lib/libvgl

2019-03-29 Thread Bruce Evans
Author: bde Date: Fri Mar 29 16:30:19 2019 New Revision: 345698 URL: https://svnweb.freebsd.org/changeset/base/345698 Log: Fix restoring to graphics modes in VGLEnd(). Correct restoring was only attempted for mode 258 (800x600x4 P). (This was the only useful graphics mode supported in th

Re: svn commit: r345696 - head/lib/libvgl

2019-03-29 Thread Bruce Evans
On Fri, 29 Mar 2019, Konstantin Belousov wrote: On Fri, Mar 29, 2019 at 03:57:09PM +, Bruce Evans wrote: Author: bde Date: Fri Mar 29 15:57:08 2019 New Revision: 345696 URL: https://svnweb.freebsd.org/changeset/base/345696 Log: Fix endless loops for handling SIGBUS and SIGSEGV

Re: svn commit: r345696 - head/lib/libvgl

2019-03-31 Thread Bruce Evans
On Sat, 30 Mar 2019, Konstantin Belousov wrote: On Sat, Mar 30, 2019 at 03:24:40PM +1100, Bruce Evans wrote: On Fri, 29 Mar 2019, Konstantin Belousov wrote: On Fri, Mar 29, 2019 at 03:57:09PM +, Bruce Evans wrote: Author: bde Date: Fri Mar 29 15:57:08 2019 New Revision: 345696 URL

Re: svn commit: r345696 - head/lib/libvgl

2019-03-31 Thread Bruce Evans
On Sun, 31 Mar 2019, Konstantin Belousov wrote: On Sun, Mar 31, 2019 at 10:27:54PM +1100, Bruce Evans wrote: On Sat, 30 Mar 2019, Konstantin Belousov wrote: On Sat, Mar 30, 2019 at 03:24:40PM +1100, Bruce Evans wrote: On Fri, 29 Mar 2019, Konstantin Belousov wrote: On Fri, Mar 29, 2019 at

Re: svn commit: r345696 - head/lib/libvgl

2019-04-01 Thread Bruce Evans
On Sun, 31 Mar 2019, Konstantin Belousov wrote: On Mon, Apr 01, 2019 at 12:04:45AM +1100, Bruce Evans wrote: Serial consoles are not always available. Better debuggers switch the screen mode as necessary. I recently noticed another mode switching problem. On i386, cycling through about 50

Re: svn commit: r345807 - head/usr.bin/top

2019-04-03 Thread Bruce Evans
On Tue, 2 Apr 2019, Dimitry Andric wrote: Author: dim Date: Tue Apr 2 18:01:54 2019 New Revision: 345807 URL: https://svnweb.freebsd.org/changeset/base/345807 Log: Fix regression in top(1) after r344381, causing informational messages to no longer be displayed. This was because the reimplem

Re: svn commit: r345853 - head/usr.bin/rctl

2019-04-04 Thread Bruce Evans
On Wed, 3 Apr 2019, Enji Cooper wrote: On Apr 3, 2019, at 1:37 PM, Mateusz Guzik wrote: Author: mjg Date: Wed Apr 3 20:37:14 2019 New Revision: 345853 URL: https://svnweb.freebsd.org/changeset/base/345853 Log: rctl: fix sysctl kern.racct.enable use after r341182 The value was changed from

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Bruce Evans
On Fri, 5 Apr 2019, Ed Maste wrote: On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: +static const u_char dot_name[] = { + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; +static const u_char dotdot_name[] = { + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; + Does it make s

svn commit: r346024 - head/usr.sbin/vidcontrol

2019-04-07 Thread Bruce Evans
Author: bde Date: Mon Apr 8 04:07:37 2019 New Revision: 346024 URL: https://svnweb.freebsd.org/changeset/base/346024 Log: Fix restoring the geometry when recovering from an error. Just restore the previous geometry, and don't do extra work to calculate the default geometry so as to reset t

svn commit: r346025 - head/lib/libvgl

2019-04-07 Thread Bruce Evans
Author: bde Date: Mon Apr 8 04:54:15 2019 New Revision: 346025 URL: https://svnweb.freebsd.org/changeset/base/346025 Log: Fix copying of MEMBUFs to MEMBUFs. This case was implemented by using the same code as the VIDBUF8 case, so it only worked for depths <= 8. The 2 directions for copying

Re: svn commit: r346176 - head/sys/sys

2019-04-12 Thread Bruce Evans
On Sat, 13 Apr 2019, Warner Losh wrote: Fix sbttons for values > 2s Add test against negative times. Add code to cope with larger values properly. Discussed with: bde@ (quite some time ago, for an earlier version) I am unhappy with previous attempted fixes in this area, and still have la

Re: svn commit: r346176 - head/sys/sys

2019-04-13 Thread Bruce Evans
On Sat, 13 Apr 2019, Bruce Evans wrote: On Sat, 13 Apr 2019, Warner Losh wrote: Fix sbttons for values > 2s Add test against negative times. Add code to cope with larger values properly. Discussed with: bde@ (quite some time ago, for an earlier version) I am unhappy with previ

svn commit: r346215 - head/lib/libvgl

2019-04-14 Thread Bruce Evans
Author: bde Date: Sun Apr 14 13:37:50 2019 New Revision: 346215 URL: https://svnweb.freebsd.org/changeset/base/346215 Log: For writing and reading single pixels, avoid some pessimizations for depths > 8. Add some smaller optimizations for these depths. Use a more generic method for all dep

svn commit: r346276 - head/lib/libvgl

2019-04-16 Thread Bruce Evans
Author: bde Date: Tue Apr 16 14:28:33 2019 New Revision: 346276 URL: https://svnweb.freebsd.org/changeset/base/346276 Log: Fix a variable name in r346215. Clearing of the right of the screen was broken, except it worked accidentally in most cases where the virtual screen is larger than the

svn commit: r346278 - head/lib/libvgl

2019-04-16 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:31:23 2019 New Revision: 346278 URL: https://svnweb.freebsd.org/changeset/base/346278 Log: Quick fix for slow clearing and context switches of large frame buffers with old kernels, by breaking the support for large frame buffers in the same way as for current

svn commit: r346279 - head/lib/libvgl

2019-04-16 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:41:45 2019 New Revision: 346279 URL: https://svnweb.freebsd.org/changeset/base/346279 Log: Oops, r346278 committed a test version with the change annulled. Modified: head/lib/libvgl/main.c Modified: head/lib/libvgl/main.c ==

svn commit: r346280 - head/lib/libvgl

2019-04-16 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:52:04 2019 New Revision: 346280 URL: https://svnweb.freebsd.org/changeset/base/346280 Log: Sigh, r346279 was also a test version with the reduced size doubled (so it was actually double the full size in current kernels where the reduction is null, so overran t

svn commit: r346416 - head/lib/libvgl

2019-04-19 Thread Bruce Evans
Author: bde Date: Fri Apr 19 20:29:49 2019 New Revision: 346416 URL: https://svnweb.freebsd.org/changeset/base/346416 Log: Fix copying of overlapping bitmaps. The cases of copying within the screen bitmap and within a single MEMBUF were broken when first source line is before the first dest

svn commit: r346454 - head/lib/libvgl

2019-04-20 Thread Bruce Evans
Author: bde Date: Sat Apr 20 20:29:03 2019 New Revision: 346454 URL: https://svnweb.freebsd.org/changeset/base/346454 Log: Make libvgl mostly work without superuser privilege in direct modes by not doing any unnecessary PIO instructions or refusing to start when the i/o privilege needed for

svn commit: r346486 - head/lib/libvgl

2019-04-21 Thread Bruce Evans
Author: bde Date: Sun Apr 21 10:33:09 2019 New Revision: 346486 URL: https://svnweb.freebsd.org/changeset/base/346486 Log: Fix missing restoring of the mouse cursor position, the border color and the blank state after a screen switch. Modified: head/lib/libvgl/main.c head/lib/libvgl/mouse

svn commit: r346488 - head/lib/libvgl

2019-04-21 Thread Bruce Evans
Author: bde Date: Sun Apr 21 16:17:35 2019 New Revision: 346488 URL: https://svnweb.freebsd.org/changeset/base/346488 Log: Use a shadow buffer and never read from the frame buffer. Remove large slow code for reading from the frame buffer. Reading from the frame buffer is usually much slo

Re: svn commit: r346554 - head/sys/netinet

2019-04-22 Thread Bruce Evans
On Mon, 22 Apr 2019, Bjoern A. Zeeb wrote: On 22 Apr 2019, at 14:20, Bjoern A. Zeeb wrote: Log: Remove some excessive brackets. No functional change. But it includes a stye bug; sorry; I had re-indented the lines to validate the change. Ill remedy this with the follow-up commit which w

svn commit: r346580 - head/lib/libvgl

2019-04-22 Thread Bruce Evans
Author: bde Date: Mon Apr 22 19:31:16 2019 New Revision: 346580 URL: https://svnweb.freebsd.org/changeset/base/346580 Log: Fix mouse cursor coloring in depths > 8 (previously, a hack that only worked right for white interiors and black borders was used). Advertise this by changing the defau

svn commit: r346631 - head/lib/libvgl

2019-04-24 Thread Bruce Evans
Author: bde Date: Wed Apr 24 13:15:56 2019 New Revision: 346631 URL: https://svnweb.freebsd.org/changeset/base/346631 Log: Fix some races and screeen clearing in VGLEnd(). The mouse signal SIGUSR2 was not turned off for normal termination and in some other cases. Thus mouse signals arriv

svn commit: r346639 - head/lib/libvgl

2019-04-24 Thread Bruce Evans
Author: bde Date: Wed Apr 24 15:35:29 2019 New Revision: 346639 URL: https://svnweb.freebsd.org/changeset/base/346639 Log: Refactor mouse freezing and fix some minor bugs. VGLMouseFreeze() now only defers mouse signals and leaves it to higher levels to hide and unhide the mouse cursor if

svn commit: r346641 - head/lib/libvgl

2019-04-24 Thread Bruce Evans
Author: bde Date: Wed Apr 24 16:03:35 2019 New Revision: 346641 URL: https://svnweb.freebsd.org/changeset/base/346641 Log: Avoid hiding and unhiding the mouse cursor when copying bitmaps to the screen. Instead, copy a merged bitmap 1 line at a time. This fixes flashing of the cursor and

svn commit: r346678 - head/lib/libvgl

2019-04-25 Thread Bruce Evans
Author: bde Date: Thu Apr 25 15:48:23 2019 New Revision: 346678 URL: https://svnweb.freebsd.org/changeset/base/346678 Log: Restore doing nothing for calls to VGLEnd() after the first. I broke this in r346631. VGLEnd() clears some state variables as it restores state, but not all of them, so

Re: svn commit: r346593 - head/sys/sys

2019-04-26 Thread Bruce Evans
On Fri, 26 Apr 2019, Mark Johnston wrote: On Fri, Apr 26, 2019 at 10:38:36AM +0300, Konstantin Belousov wrote: On Fri, Apr 26, 2019 at 02:04:56AM -0400, Mark Johnston wrote: On Thu, Apr 25, 2019 at 11:22:22AM +0300, Konstantin Belousov wrote: On Thu, Apr 25, 2019 at 07:38:21AM +0200, Wojciech

svn commit: r346743 - head/lib/libvgl

2019-04-26 Thread Bruce Evans
Author: bde Date: Fri Apr 26 13:04:10 2019 New Revision: 346743 URL: https://svnweb.freebsd.org/changeset/base/346743 Log: Fix an off-by-1 error for copying overlapping bitmaps in r346416. For nonzero height, the first line in the original order was not copied, and for zero height, garbage

svn commit: r346744 - head/lib/libvgl

2019-04-26 Thread Bruce Evans
Author: bde Date: Fri Apr 26 13:22:54 2019 New Revision: 346744 URL: https://svnweb.freebsd.org/changeset/base/346744 Log: Restore the line width in VGLEnd(). The line width may be changed by VGLSetVScreenSize(), but is not restored by mode switches to at least standard text mode, so must b

svn commit: r346745 - head/lib/libvgl

2019-04-26 Thread Bruce Evans
Author: bde Date: Fri Apr 26 13:49:06 2019 New Revision: 346745 URL: https://svnweb.freebsd.org/changeset/base/346745 Log: Fix the only known remaining (libvgl) bug for 24-bit modes, and enable support for 24-bit modes. The non-segmented case has worked for a long time, but the segmented

svn commit: r346747 - head/lib/libvgl

2019-04-26 Thread Bruce Evans
Author: bde Date: Fri Apr 26 14:44:20 2019 New Revision: 346747 URL: https://svnweb.freebsd.org/changeset/base/346747 Log: Remove save/restore of the crtc and gdc registers when showing and hiding the mouse cursor. The showing and hiding is often done asynchronously in a not very safe signa

svn commit: r346752 - head/lib/libvgl

2019-04-26 Thread Bruce Evans
Author: bde Date: Fri Apr 26 16:14:23 2019 New Revision: 346752 URL: https://svnweb.freebsd.org/changeset/base/346752 Log: In VGLClear(), check for the overlap of the mouse cursor in the whole display, not just in the unpanned top left corner. This currently makes no difference since the ke

svn commit: r346754 - head/lib/libvgl

2019-04-26 Thread Bruce Evans
Author: bde Date: Fri Apr 26 16:38:23 2019 New Revision: 346754 URL: https://svnweb.freebsd.org/changeset/base/346754 Log: Merge __VGLGetXY() back into VGLGetXY(). They were split to simplify the organization of fixes for the mouse cursor, but after optimizations VGLGetXY() automatically av

svn commit: r346761 - head/lib/libvgl

2019-04-26 Thread Bruce Evans
Author: bde Date: Fri Apr 26 18:28:54 2019 New Revision: 346761 URL: https://svnweb.freebsd.org/changeset/base/346761 Log: Use __VGLBitmapCopy() directly to show the mouse cursor. The mouse cursor must be merged with the shadow buffer on the way to the screen, and __VGLBitmapCopy() now has

svn commit: r346889 - head/lib/libvgl

2019-04-29 Thread Bruce Evans
Author: bde Date: Mon Apr 29 14:13:53 2019 New Revision: 346889 URL: https://svnweb.freebsd.org/changeset/base/346889 Log: Refactor and simplify hiding the mouse cursor and fix bugs caused by complications in the previous methods. r346761 broke showing the mouse cursor after changing its

svn commit: r346890 - head/lib/libvgl

2019-04-29 Thread Bruce Evans
Author: bde Date: Mon Apr 29 15:58:05 2019 New Revision: 346890 URL: https://svnweb.freebsd.org/changeset/base/346890 Log: Oops, r346889 broke showing of the mouse cursor after clearing, by forgetting to tell the bitmap-copying clearing method to preserve the cursor. Modified: head/lib/li

svn commit: r346895 - head/lib/libvgl

2019-04-29 Thread Bruce Evans
Author: bde Date: Mon Apr 29 16:26:29 2019 New Revision: 346895 URL: https://svnweb.freebsd.org/changeset/base/346895 Log: Support all reasonable cursor sizes. Reduce the size of the standard cursor from 16x16 (with 6 columns unused) to 10x16 and rename it to the "small" cursor. Add a "lar

svn commit: r347054 - head/lib/libvgl

2019-05-03 Thread Bruce Evans
Author: bde Date: Fri May 3 13:06:46 2019 New Revision: 347054 URL: https://svnweb.freebsd.org/changeset/base/347054 Log: Fix copying planar bitmaps when the horizontal start and end are both not multiples of 8. Then the misaligned pixels at the end were not copied. Clean up variable mi

Re: svn commit: r347063 - head/sys/kern

2019-05-07 Thread Bruce Evans
On Mon, 6 May 2019, John Baldwin wrote: On 5/6/19 11:45 AM, Mark Johnston wrote: On Mon, May 06, 2019 at 11:07:18AM -0700, John Baldwin wrote: On 5/3/19 2:26 PM, Mark Johnston wrote: Author: markj Date: Fri May 3 21:26:44 2019 New Revision: 347063 URL: https://svnweb.freebsd.org/changeset/ba

Re: svn commit: r347063 - head/sys/kern

2019-05-07 Thread Bruce Evans
On Tue, 7 May 2019, John Baldwin wrote: On 5/7/19 8:45 AM, Bruce Evans wrote: On Mon, 6 May 2019, John Baldwin wrote: On 5/6/19 11:45 AM, Mark Johnston wrote: On Mon, May 06, 2019 at 11:07:18AM -0700, John Baldwin wrote: On 5/3/19 2:26 PM, Mark Johnston wrote: Author: markj Date: Fri May

Re: svn commit: r347484 - head/sys/kern

2019-05-11 Thread Bruce Evans
On Sat, 11 May 2019, Doug Moore wrote: Log: When bitpos can't be implemented with an inline ffs* instruction, change the binary search so that it does not depend on a single bit only being set in the bitmask. Use bitpos more generally, and avoid some clearing of bits to accommodate its curre

Re: svn commit: r347484 - head/sys/kern

2019-05-12 Thread Bruce Evans
On Sat, 11 May 2019, Doug Moore wrote: On 5/11/19 5:52 AM, Bruce Evans wrote: On Sat, 11 May 2019, Doug Moore wrote: +#ifdef HAVE_INLINE_FFS +?? case sizeof(int): +?? return (ffs(mask) - 1); +#endif This is unreachable, since sizeof(int) is 4 on all supported arches, and

Re: svn commit: r347953 - head/cddl/contrib/opensolaris/cmd/zfs

2019-05-18 Thread Bruce Evans
On Sat, 18 May 2019, Toomas Soome wrote: On 18 May 2019, at 15:37, Alexey Dokuchaev wrote: On Sat, May 18, 2019 at 12:27:22PM +, Allan Jude wrote: New Revision: 347953 URL: https://svnweb.freebsd.org/changeset/base/347953 Log: MFV/ZoL: `zfs userspace` ignored all unresolved UIDs after t

Re: svn commit: r347984 - in head/sys: amd64/vmm/io arm/allwinner arm/allwinner/a10 arm/allwinner/clkng arm/arm arm/broadcom/bcm2835 arm/freescale/imx arm/mv arm/mv/armada arm/nvidia arm/nvidia/tegra1

2019-05-20 Thread Bruce Evans
On Mon, 20 May 2019, Conrad Meyer wrote: Log: Extract eventfilter declarations to sys/_eventfilter.h sys/_eventhandler.h has 2 identical 72-line copies of the correct version. The second copy of the reinclusion guard works as a guard against the doubling too. This allows replacing "sys/ev

Re: svn commit: r315277 - in head/sys: dev/cxgb/ulp/iw_cxgb netinet

2017-03-14 Thread Bruce Evans
On Tue, 14 Mar 2017, Eric van Gyzen wrote: Log: KTR: log IPv4 addresses in hex rather than dotted-quad When I made the changes in r313821, I fell victim to one of the classic blunders, the most famous of which is: never get involved in a land war in Asia. But only slightly less well known

Re: svn commit: r315365 - head/lib/libkvm

2017-03-15 Thread Bruce Evans
On Thu, 16 Mar 2017, Ngie Cooper wrote: Log: Tweak r315363 slightly I noticed after commit that kvm_dpcpu_setcpu was defined in the manpage. Thus, the correct macro for the function reference is .Fn, not .Xr. Is .Xr ever correct for a function? I think it names man pages, not functions, a

Re: svn commit: r314646 - head/sys/dev/syscons

2017-03-15 Thread Bruce Evans
On Tue, 14 Mar 2017, Ravi Pokala wrote: This breaks all sparc64 kernconfs. (And no, this is *not* fixed by r314997.) --- syscons.o --- cc1: warnings being treated as errors /usr/home/rpokala/freebsd/clean/base/head/sys/dev/syscons/syscons.c:261: warning: 'ec_scroffset' defined but not

svn commit: r315390 - head/sys/dev/syscons

2017-03-16 Thread Bruce Evans
Author: bde Date: Thu Mar 16 07:40:33 2017 New Revision: 315390 URL: https://svnweb.freebsd.org/changeset/base/315390 Log: The previous fix didn't ifdef out enough for sparc64 to actually work. Fix this by using more dynamic initialization with simpler ifdefs for the machine dependencies.

svn commit: r315418 - in head/sys/teken: . libteken

2017-03-16 Thread Bruce Evans
Author: bde Date: Thu Mar 16 16:40:54 2017 New Revision: 315418 URL: https://svnweb.freebsd.org/changeset/base/315418 Log: Add teken_256to16() to convert xterm-256 256-color codes to xterm 16-color codes. This will be used to fix bright colors. Improve teken_256to8(). Use a lookup table

Re: svn commit: r315418 - in head/sys/teken: . libteken

2017-03-16 Thread Bruce Evans
On Thu, 16 Mar 2017, Bruce Evans wrote: Log: Add teken_256to16() to convert xterm-256 256-color codes to xterm 16-color codes. This will be used to fix bright colors. Improve teken_256to8(). Use a lookup table instead of calculations. The ... A shell script for printing some text

Re: svn commit: r315418 - in head/sys/teken: . libteken

2017-03-16 Thread Bruce Evans
On Thu, 16 Mar 2017, Oliver Pinter wrote: On 3/16/17, Bruce Evans wrote: On Thu, 16 Mar 2017, Bruce Evans wrote: Log: Add teken_256to16() to convert xterm-256 256-color codes to xterm 16-color codes. This will be used to fix bright colors. Improve teken_256to8(). Use a lookup table

svn commit: r315454 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include

2017-03-17 Thread Bruce Evans
Author: bde Date: Fri Mar 17 13:49:05 2017 New Revision: 315454 URL: https://svnweb.freebsd.org/changeset/base/315454 Log: Don't access the reserved registers %dr4 and %dr5 on i386. On the original i386, %dr[4-5] were unimplemented but not very clearly reserved, so debuggers read them to

svn commit: r315477 - head/sys/ddb

2017-03-18 Thread Bruce Evans
Author: bde Date: Sat Mar 18 07:01:18 2017 New Revision: 315477 URL: https://svnweb.freebsd.org/changeset/base/315477 Log: Fix right shifts on arches with db_expr_t larger than u_int (LP64 arches in practice). db_expr_t is a signed type, but right shifts are fudged to evaluate them in a

svn commit: r315480 - in head/sys: dev/syscons dev/vt kern teken

2017-03-18 Thread Bruce Evans
Author: bde Date: Sat Mar 18 11:13:54 2017 New Revision: 315480 URL: https://svnweb.freebsd.org/changeset/base/315480 Log: Fix bright colors for syscons, and make them work for the first time for vt. Restore syscons' rendering of background (bg) brightness as foreground (fg) blinking and vi

Re: svn commit: r315522 - in head: contrib/binutils/ld/emulparams sys/conf

2017-03-18 Thread Bruce Evans
On Sun, 19 Mar 2017, Ed Maste wrote: Log: use INT3 instead of NOP for x86 binary padding We should never end up executing the inter-function padding, so we are better off faulting than silently carrying on to whatever function happens to be next. Note that LLD will soon do this by default

Re: svn commit: r315498 - head/sys/compat/linux

2017-03-18 Thread Bruce Evans
On Sat, 18 Mar 2017, Dmitry Chagin wrote: Log: Check for negative nanoseconds. Linux do that in timespec_valid(). This uses the unsigned hack to further obfuscate the code. No check is necessary on any supported arch, since there are no representability problems and FreeBSD checks for inval

Re: svn commit: r315694 - head/lib/libc/sys

2017-03-21 Thread Bruce Evans
On Wed, 22 Mar 2017, Eric van Gyzen wrote: Log: clock_gettime.2: add some clock IDs Add the CLOCK_PROCESS_CPUTIME_ID and CLOCK_THREAD_CPUTIME_ID clock_id values to the clock_gettime(2) man page. Reformat the excessively long paragraph (sentence!) into a tag list. Some old bugs are now cl

Re: svn commit: r315850 - head/sys/boot/forth

2017-03-23 Thread Bruce Evans
On Thu, 23 Mar 2017, [UTF-8] Dag-Erling Sm??rgrav wrote: Log: The original author abused Nd (one-line description, used by makewhatis) for its side effect of producing an en-dash. This broke whatis with newer versions of mdocml. Use \(en instead. Nd (or is it mumble-dash?) is broken for a

<    2   3   4   5   6   7   8   9   10   11   >