Re: svn commit: r327495 - head/usr.sbin/rpcbind

2018-02-03 Thread Bruce Evans
On Tue, 2 Jan 2018, Conrad Meyer wrote: Log: rpcbind: Fix race in signal termination I have yet to see any application that was correctly converted from using unsafe signal handlers to safe signal handlers that just set a flag. That is without even noticing this race problem before. If a

Re: svn commit: r327495 - head/usr.sbin/rpcbind

2018-02-04 Thread Bruce Evans
On Sat, 3 Feb 2018, Conrad Meyer wrote: On Sat, Feb 3, 2018 at 6:46 AM, Bruce Evans wrote: On Tue, 2 Jan 2018, Conrad Meyer wrote: ... Today I learned from the POSIX list that the pselect() function is designed to avoid this bug. It takes a signal mask arg (like msleep() in the kernel). I

Re: svn commit: r327495 - head/usr.sbin/rpcbind

2018-02-04 Thread Bruce Evans
On Sun, 4 Feb 2018, Konstantin Belousov wrote: On Sun, Feb 04, 2018 at 04:15:16PM +1100, Bruce Evans wrote: sig_atomic_t is no better than plain int. This behaviour now makes complete sense. It is just like the undefined behaviour with the ctype functions, except since we own terminate_wfd

Re: svn commit: r329127 - head/sys/sys

2018-02-11 Thread Bruce Evans
On Sun, 11 Feb 2018, Warner Losh wrote: Log: Consistent macro indentation is the hobgoblin of small minds Line up the macro definitions and names here like the machine/stdarg.h files that this replaced. This is easier to read and also makes it easier to match up with other includes. Also tw

Re: svn commit: r329126 - head/etc/devd

2018-02-11 Thread Bruce Evans
On Sun, 11 Feb 2018, Warner Losh wrote: On Feb 11, 2018 7:05 PM, "Conrad Meyer" wrote: On Sun, Feb 11, 2018 at 3:46 PM, Rodney W. Grimes wrote: Moving this to /usr creates a cyclic issue in that you then need /usr to be mounted before devd can start and devd's /etc/rc.d file says: # PROVIDE:

Re: svn commit: r329237 - head/sys/libkern

2018-02-13 Thread Bruce Evans
On Tue, 13 Feb 2018, Ian Lepore wrote: On Tue, 2018-02-13 at 14:43 -0500, Ed Maste wrote: On 13 February 2018 at 14:23, Ian Lepore wrote: On Tue, 2018-02-13 at 19:17 +, Ed Maste wrote: Author: emaste Date: Tue Feb 13 19:17:48 2018 New Revision: 329237 URL: https://svnweb.freebsd.org/ch

Re: svn commit: r329296 - head/sbin/devd

2018-02-15 Thread Bruce Evans
On Wed, 14 Feb 2018, Warner Losh wrote: On Wed, Feb 14, 2018 at 8:51 PM, Eitan Adler wrote: On 14 February 2018 at 19:48, Warner Losh wrote: On Wed, Feb 14, 2018 at 8:39 PM, Warner Losh wrote: On Feb 14, 2018 8:23 PM, "Eitan Adler" wrote: Log: devd: don't pass &fds in useless paramet

Re: svn commit: r329340 - head/sys/amd64/include

2018-02-15 Thread Bruce Evans
On Thu, 15 Feb 2018, Jung-uk Kim wrote: Log: Change size of padding to reflect reality. No functional change. Discussed with:kib Modified: head/sys/amd64/include/pcpu.h Modified: head/sys/amd64/include/pcpu.h

Re: svn commit: r329269 - head/stand/i386/boot2

2018-02-16 Thread Bruce Evans
On Wed, 14 Feb 2018, Benno Rice wrote: Log: Reformat to come significantly closer to style(9). This gives unreadable diffs. It does more than reformatting. Bugs have been reported. They must be in the non-reformatting changes. Modified: head/stand/i386/boot2/boot2.c =

Re: svn commit: r329737 - head/stand/i386/boot2

2018-02-22 Thread Bruce Evans
On Wed, 21 Feb 2018, Benno Rice wrote: On Feb 21, 2018, at 10:46 AM, Colin Percival wrote: On 02/21/18 10:10, Benno Rice wrote: Curiously, changing whitespace seems to cause the md5 of the .o files to differ these days hence the following testing strategy: Tested by: objdump -d | md5

Re: svn commit: r329859 - in head: contrib/compiler-rt/lib/builtins include stand sys/arm/include sys/arm64/include sys/mips/include sys/powerpc/include sys/riscv/include sys/sparc64/include sys/sys s

2018-02-22 Thread Bruce Evans
On Fri, 23 Feb 2018, Warner Losh wrote: Log: Do not include float interfaces when using libsa. We don't support float in the boot loaders, so don't include interfaces for float or double in systems headers. In addition, take the unusual step of spiking double and float to prevent any more

Re: svn commit: r329859 - in head: contrib/compiler-rt/lib/builtins include stand sys/arm/include sys/arm64/include sys/mips/include sys/powerpc/include sys/riscv/include sys/sparc64/include sys/sys s

2018-02-23 Thread Bruce Evans
On Fri, 23 Feb 2018, Bruce Evans wrote: On Fri, 23 Feb 2018, Warner Losh wrote: Log: Do not include float interfaces when using libsa. We don't support float in the boot loaders, so don't include interfaces for float or double in systems headers. In addition, take the unusu

Re: svn commit: r329859 - in head: contrib/compiler-rt/lib/builtins include stand sys/arm/include sys/arm64/include sys/mips/include sys/powerpc/include sys/riscv/include sys/sparc64/include sys/sys s

2018-02-23 Thread Bruce Evans
On Fri, 23 Feb 2018, Warner Losh wrote: On Thu, Feb 22, 2018 at 11:12 PM, Bruce Evans wrote: On Fri, 23 Feb 2018, Warner Losh wrote: * ... Modified: head/sys/arm/include/_types.h == --- head/sys/arm/include

Re: svn commit: r330285 - head/sys/sys

2018-03-02 Thread Bruce Evans
On Fri, 2 Mar 2018, Konstantin Belousov wrote: On Fri, Mar 02, 2018 at 12:43:34PM -0500, Pedro Giffuni wrote: ... I think use of _Nonnull attributes in the threading functions may also be a waste (I introduced them mostly to be compatible with Android). FWIW, Dragonfly sprinkled some restrict t

Re: svn commit: r330294 - head/sys/kern

2018-03-02 Thread Bruce Evans
On Fri, 2 Mar 2018, Mateusz Guzik wrote: Log: sx: fix adaptive spinning broken in r327397 The condition was flipped. In particular heavy multithreaded kernel builds on zfs started suffering due to nested sx locks. For instance make -s -j 128 buildkernel: before: 3326.67s user 1269.62s

Re: svn commit: r330285 - head/sys/sys

2018-03-03 Thread Bruce Evans
On Sat, 3 Mar 2018, Konstantin Belousov wrote: On Sat, Mar 03, 2018 at 01:47:41PM +1100, Bruce Evans wrote: On Fri, 2 Mar 2018, Konstantin Belousov wrote: On Fri, Mar 02, 2018 at 12:43:34PM -0500, Pedro Giffuni wrote: ... I think use of _Nonnull attributes in the threading functions may

Re: svn commit: r330352 - in head/sys/compat/linuxkpi/common: include/linux src

2018-03-03 Thread Bruce Evans
On Sat, 3 Mar 2018, Ian Lepore wrote: On Sat, 2018-03-03 at 22:49 +0200, Konstantin Belousov wrote: ,,, BTW mstosbt() and other functions have weird bracing in the formula. I think that the formula as calculated by the C operator precedence is fine, i.e. multiplication is done before right shif

Re: svn commit: r330436 - head/bin/chflags

2018-03-04 Thread Bruce Evans
On Sun, 4 Mar 2018, Ian Lepore wrote: On Mon, 2018-03-05 at 01:56 +, Bryan Drewery wrote: Log: \xa0 chflags: Add -x option to not traverse mount points. Yay! \xa0One day later than I needed it, but still, yay! I recently noticed that find(1) needs an option to not look at mount points

Re: svn commit: r330602 - head/sys/compat/cloudabi

2018-03-07 Thread Bruce Evans
On Wed, 7 Mar 2018, Benjamin Kaduk wrote: On Wed, Mar 7, 2018 at 9:44 AM, Ed Maste wrote: On 7 March 2018 at 09:47, Eitan Adler wrote: ... Log: sys/cloudabi: Avoid relying on GNU specific extensions An empty initializer list is not technically valid C grammar. MFC After:1 week

Re: svn commit: r330436 - head/bin/chflags

2018-03-07 Thread Bruce Evans
On Mon, 5 Mar 2018, Bruce Evans wrote: On Sun, 4 Mar 2018, Ian Lepore wrote: On Mon, 2018-03-05 at 01:56 +, Bryan Drewery wrote: Log: \xa0 chflags: Add -x option to not traverse mount points. Yay! \xa0One day later than I needed it, but still, yay! I recently noticed that find(1

Re: svn commit: r315480 - in head/sys: dev/syscons dev/vt kern teken

2018-03-08 Thread Bruce Evans
On Wed, 7 Mar 2018, Eitan Adler wrote: On 18 March 2017 at 04:13, Bruce Evans wrote: Author: bde Date: Sat Mar 18 11:13:54 2017 New Revision: 315480 URL: https://svnweb.freebsd.org/changeset/base/315480 Log: Fix bright colors for syscons, and make them work for the first time for vt

Re: svn commit: r330663 - head/sys/kern

2018-03-08 Thread Bruce Evans
On Thu, 8 Mar 2018, Mark Johnston wrote: Log: Return E2BIG if we run out of space writing a compressed kernel dump. E2BIG a very wrong errno. It means "Argment list too long". It is broken as designed, with "too" encrypted as "2" and no indication of what is too big. EFBIG is not so wrong.

Re: svn commit: r330663 - head/sys/kern

2018-03-09 Thread Bruce Evans
On Thu, 8 Mar 2018, Conrad Meyer wrote: On Thu, Mar 8, 2018 at 8:42 PM, Bruce Evans wrote: On Thu, 8 Mar 2018, Mark Johnston wrote: ... +++ head/sys/kern/kern_shutdown.c Thu Mar 8 17:04:36 2018 (r330663) @@ -1115,6 +1115,12 @@ dump_check_bounds(struct dumperinfo *di, off_t offset

Re: svn commit: r330338 - head/sys/amd64/amd64

2018-03-09 Thread Bruce Evans
On Fri, 9 Mar 2018, John Baldwin wrote: On Saturday, March 03, 2018 03:10:37 PM Andriy Gapon wrote: Author: avg Date: Sat Mar 3 15:10:37 2018 New Revision: 330338 URL: https://svnweb.freebsd.org/changeset/base/330338 Log: db_nextframe/amd64: catch up with r328083 to recognize fast_syscall_c

Re: svn commit: r330338 - head/sys/amd64/amd64

2018-03-09 Thread Bruce Evans
On Sat, 10 Mar 2018, Bruce Evans wrote: On Fri, 9 Mar 2018, John Baldwin wrote: I think you actually just want to replace Xfast_syscall with fast_syscall_common. Neither Xfast_syscall nor Xfast_syscall_pti call any functions before jumping to the common label, so when unwinding from a

Re: svn commit: r330338 - head/sys/amd64/amd64

2018-03-09 Thread Bruce Evans
On Fri, 9 Mar 2018, John Baldwin wrote: On Saturday, March 10, 2018 07:41:30 AM Bruce Evans wrote: On Fri, 9 Mar 2018, John Baldwin wrote: On Saturday, March 03, 2018 03:10:37 PM Andriy Gapon wrote: Author: avg Date: Sat Mar 3 15:10:37 2018 New Revision: 330338 URL: https

Re: svn commit: r330712 - head/bin/ps

2018-03-09 Thread Bruce Evans
On Sat, 10 Mar 2018, Mike Karels wrote: ... Log: Change ps(1) output width to unlimited if not interactive ... Modified: head/bin/ps/ps.1 == --- head/bin/ps/ps.1Fri Mar 9 23:37:19 2018(r330711) +++ head/

Re: svn commit: r330722 - head/sys/conf

2018-03-09 Thread Bruce Evans
On Sat, 10 Mar 2018, Bryan Drewery wrote: Log: Reduce overhead for simple 'make -V' lookups by avoiding 'find sys/'. Setting -DNO_SKIP_MPATH can be used for debugging. Reported by: bde Thanks. Bruce ___ svn-src-head@freebsd.org mailing list h

Re: svn commit: r330745 - head/sys/kern

2018-03-11 Thread Bruce Evans
On Sat, 10 Mar 2018, Ian Lepore wrote: Author: ian ... Log: Make root mount timeout logic work for filesystems other than ufs. ... These changes are based on the patch attached to the PR, but it's rewritten enough that all mistakes belong to me. PR:208882 X-MFC after: suffici

Re: svn commit: r330780 - in head/sys: amd64/include isa x86/isa

2018-03-12 Thread Bruce Evans
On Mon, 12 Mar 2018, Konstantin Belousov wrote: On Mon, Mar 12, 2018 at 09:34:51AM -0600, Ian Lepore wrote: On Sun, 2018-03-11 at 23:25 +0200, Konstantin Belousov wrote: On Sun, Mar 11, 2018 at 02:20:39PM -0600, Ian Lepore wrote: On Sun, 2018-03-11 at 21:58 +0200, Konstantin Belousov wrote:

Re: svn commit: r331063 - head/sys/arm/arm

2018-03-16 Thread Bruce Evans
On Fri, 16 Mar 2018, Ian Lepore wrote: Log: Add the header file needed for the recently-added call to pagedaemon_wakeup(). Modified: head/sys/arm/arm/pmap-v4.c Modified: head/sys/arm/arm/pmap-v4.c == --- head/sys/arm

Re: svn commit: r331083 - in head: lib/libufs sbin/dump sbin/fsck_ffs sbin/fsdb sbin/newfs sbin/quotacheck sbin/restore sbin/tunefs stand/libsa sys/fs/ext2fs sys/fs/nandfs sys/ufs/ffs sys/ufs/ufs usr.

2018-03-17 Thread Bruce Evans
On Sat, 17 Mar 2018, Ed Maste wrote: Log: Prefix UFS symbols with UFS_ to reduce namespace pollution Followup to r313780. Also prefix ext2's and nandfs's versions with EXT2_ and NANDFS_. S_IFMT is already MI. So this churnge is mostly wrong unless file systems do the identity translation

Re: svn commit: r331226 - in head/sys: amd64/linux amd64/linux32 i386/linux

2018-03-20 Thread Bruce Evans
On Mon, 19 Mar 2018, Ed Maste wrote: Log: Rename linuxulator functions with linux_ prefix It's preferable to have a consistent prefix. This also reduces differences between the three linux*_sysvec.c files. It is preferable to have a well-chosen (short...) prefix. The linux emulator mostl

Re: svn commit: r331226 - in head/sys: amd64/linux amd64/linux32 i386/linux

2018-03-20 Thread Bruce Evans
On Tue, 20 Mar 2018, Ed Maste wrote: On 20 March 2018 at 04:19, Bruce Evans wrote: It is preferable to have a well-chosen (short...) prefix. The linux emulator mostly uses l_ for internal names. That is a bit too short for external names. l_ is too short. The only reasonable alternative

Re: svn commit: r331269 - head/share/man/man9

2018-03-20 Thread Bruce Evans
On Tue, 20 Mar 2018, Warner Losh wrote: Log: Remove reference to lint. We no longer support it, so exceptions for it are no longer relevant. ... Modified: head/share/man/man9/style.9 == --- head/share/man/man9/style.9

svn commit: r304758 - head/sys/dev/syscons

2016-08-24 Thread Bruce Evans
Author: bde Date: Wed Aug 24 17:26:11 2016 New Revision: 304758 URL: https://svnweb.freebsd.org/changeset/base/304758 Log: Reorganise a little to prepare for locking fixes: - in sccnopen(), open the keyboard before the screen. The keyboard currently requires Giant (although it must be spi

svn commit: r304773 - head/sys/dev/syscons

2016-08-24 Thread Bruce Evans
Author: bde Date: Wed Aug 24 18:59:24 2016 New Revision: 304773 URL: https://svnweb.freebsd.org/changeset/base/304773 Log: Flesh out the state and flags args to sccnopen(). Set state flags to indicate (potentially partial) success of the open. Use these to decide what to close in sccnclose

svn commit: r304800 - head/sys/dev/syscons

2016-08-25 Thread Bruce Evans
Author: bde Date: Thu Aug 25 12:04:57 2016 New Revision: 304800 URL: https://svnweb.freebsd.org/changeset/base/304800 Log: Fix logic errors in bounds checks in previous commit. The 2-entry stack was overrun for grab levels larger than 2. Reported by: pluknet Modified: head/sys/dev/sy

svn commit: r304804 - in head/sys: dev/syscons kern

2016-08-25 Thread Bruce Evans
Author: bde Date: Thu Aug 25 13:46:52 2016 New Revision: 304804 URL: https://svnweb.freebsd.org/changeset/base/304804 Log: Less-quick fix for locking fixes in r172250. r172250 added a second syscons spinlock for the output routine alone. It is better to extend the coverage of the first sys

svn commit: r304895 - head/usr.bin/netstat

2016-08-27 Thread Bruce Evans
Author: bde Date: Sat Aug 27 11:06:06 2016 New Revision: 304895 URL: https://svnweb.freebsd.org/changeset/base/304895 Log: Fix build without INET6 and with gcc. A function definition was ifdefed for INET6, but its protototype was not, and gcc detects the error. Modified: head/usr.bin/netst

Re: svn commit: r304928 - in head/lib/libc: amd64/sys i386/sys sys

2016-08-27 Thread Bruce Evans
On Sun, 28 Aug 2016, Andrey Chernov wrote: On 28.08.2016 4:52, Konstantin Belousov wrote: POSIX: "For each thread of a process, the value of errno shall not be affected by function calls or assignments to errno by other threads." And ? What should the citation add new to the substance of the

svn commit: r304957 - head/sys/i386/i386

2016-08-28 Thread Bruce Evans
Author: bde Date: Sun Aug 28 14:03:25 2016 New Revision: 304957 URL: https://svnweb.freebsd.org/changeset/base/304957 Log: Fix vm86 initialization, part 1 of 2 and a half. vm86 uses the tss, but r273995 moved tss initialization to after where it may be first used, just because tss_esp0 no

svn commit: r304958 - head/sys/i386/i386

2016-08-28 Thread Bruce Evans
Author: bde Date: Sun Aug 28 15:23:44 2016 New Revision: 304958 URL: https://svnweb.freebsd.org/changeset/base/304958 Log: Fix vm86 initialization, part 1 of 2 and a half. Early use of vm86 depends on the PIC being reset to mask interrupts, but r286667 moved PIC initialization to after wh

Re: svn commit: r304895 - head/usr.bin/netstat

2016-08-28 Thread Bruce Evans
On Sun, 28 Aug 2016, hiren panchasara wrote: On 08/27/16 at 11:06P, Bruce Evans wrote: Log: Fix build without INET6 and with gcc. A function definition was ifdefed for INET6, but its protototype was not, and gcc detects the error. Modified: head/usr.bin/netstat/route.c Thanks for

svn commit: r304962 - head/sys/ddb

2016-08-28 Thread Bruce Evans
Author: bde Date: Sun Aug 28 19:33:09 2016 New Revision: 304962 URL: https://svnweb.freebsd.org/changeset/base/304962 Log: Expand error messages: print symbol names, parentheses and shift tokens, and negative shift counts. Fix error messages: print "Division" instead of "Divide"; print

svn commit: r304986 - head/sys/amd64/amd64

2016-08-28 Thread Bruce Evans
Author: bde Date: Mon Aug 29 06:07:43 2016 New Revision: 304986 URL: https://svnweb.freebsd.org/changeset/base/304986 Log: Restore the nontemporal pagezero() under the name sse2_pagezero() (the same name as for i386). It is not reconnected yet. Which method is better is too machine-depen

svn commit: r305004 - in head/sys: amd64/amd64 amd64/include i386/i386

2016-08-29 Thread Bruce Evans
Author: bde Date: Mon Aug 29 13:07:21 2016 New Revision: 305004 URL: https://svnweb.freebsd.org/changeset/base/305004 Log: On amd64, declare sse2_pagezero() and start using it again, but only for zeroing pages in idle where nontemporal writes are clearly best. This is almost a no-op since ze

svn commit: r305005 - in head/sys: amd64/amd64 i386/i386

2016-08-29 Thread Bruce Evans
Author: bde Date: Mon Aug 29 14:38:31 2016 New Revision: 305005 URL: https://svnweb.freebsd.org/changeset/base/305005 Log: Shorten banal comments about zeroing and copying pages. Don't give implementation details that last echoed the code 15-20 years ago. But add a detail about pagezero() o

Re: svn commit: r305004 - in head/sys: amd64/amd64 amd64/include i386/i386

2016-08-29 Thread Bruce Evans
On Mon, 29 Aug 2016, Slawa Olhovchenkov wrote: On Mon, Aug 29, 2016 at 01:07:21PM +, Bruce Evans wrote: ... Log: On amd64, declare sse2_pagezero() and start using it again, but only for zeroing pages in idle where nontemporal writes are clearly best. This is almost a no-op since

svn commit: r305010 - head/sys/dev/syscons

2016-08-29 Thread Bruce Evans
Author: bde Date: Mon Aug 29 18:41:06 2016 New Revision: 305010 URL: https://svnweb.freebsd.org/changeset/base/305010 Log: Add screen locking calls to sc cn grab and ungrab. The locking functions just use the same mutex locking as sc cn putc so they have the same defects. The locking c

Re: svn commit: r304895 - head/usr.bin/netstat

2016-08-30 Thread Bruce Evans
On Mon, 29 Aug 2016, hiren panchasara wrote: On 08/29/16 at 05:14P, Bruce Evans wrote: On Sun, 28 Aug 2016, hiren panchasara wrote: On 08/27/16 at 11:06P, Bruce Evans wrote: Log: Fix build without INET6 and with gcc. A function definition was ifdefed for INET6, but its protototype was

svn commit: r305059 - head/sys/dev/syscons

2016-08-30 Thread Bruce Evans
Author: bde Date: Tue Aug 30 10:57:19 2016 New Revision: 305059 URL: https://svnweb.freebsd.org/changeset/base/305059 Log: Start adding locking to sc_cngetc(). Restore an splx() lost in r228644. We aren't nearly ready to remove spl's. They give hints about missing locking. This lost on

svn commit: r305060 - head/sys/dev/kbdmux

2016-08-30 Thread Bruce Evans
Author: bde Date: Tue Aug 30 12:36:14 2016 New Revision: 305060 URL: https://svnweb.freebsd.org/changeset/base/305060 Log: Fix keyboard polling "on/off" to support recursion. vt depends on this, and sc will soon depend on it again. The on/off request is passed without modification to low

Re: svn commit: r305091 - head/sys/sys

2016-08-30 Thread Bruce Evans
On Wed, 31 Aug 2016, Mateusz Guzik wrote: On Tue, Aug 30, 2016 at 03:35:39PM -0700, Conrad Meyer wrote: On Tue, Aug 30, 2016 at 2:48 PM, Mateusz Guzik wrote: Author: mjg Date: Tue Aug 30 21:48:10 2016 New Revision: 305091 URL: https://svnweb.freebsd.org/changeset/base/305091 Log: fd: simpl

svn commit: r305121 - head/sys/dev/syscons

2016-08-31 Thread Bruce Evans
Author: bde Date: Wed Aug 31 11:10:39 2016 New Revision: 305121 URL: https://svnweb.freebsd.org/changeset/base/305121 Log: Add some locking to sc_cngetc(). Keyboard input needs Giant locking, and that is not possible to do correctly here. Use mtx_trylock() and proceed unlocked as before

Re: svn commit: r305129 - head/sys/vm

2016-08-31 Thread Bruce Evans
On Wed, 31 Aug 2016, Konstantin Belousov wrote: Log: Make swapoff reliable. The swap_pager_swapoff() function uses trylock for the object lock before pagein, which means that either i/o to md(4) over swap, or intensive page faults over swap pager objects might prevent swapoff() from making

svn commit: r305231 - head/sys/dev/syscons

2016-09-01 Thread Bruce Evans
Author: bde Date: Thu Sep 1 19:18:26 2016 New Revision: 305231 URL: https://svnweb.freebsd.org/changeset/base/305231 Log: The log message for the previous commit didn't mention the most the important detail that sc_cngetc() now opens and closes the keyboard on every call again. This was mo

Re: svn commit: r305362 - in head: share/man/man9 sys/amd64/amd64 sys/arm/arm sys/arm64/arm64 sys/conf sys/i386/i386 sys/i386/include sys/mips/mips sys/powerpc/aim sys/powerpc/booke sys/powerpc/powerp

2016-09-03 Thread Bruce Evans
On Sat, 3 Sep 2016, Mark Johnston wrote: Log: Remove support for idle page zeroing. Idle page zeroing has been disabled by default on all architectures since r170816 and has some bugs that make it seemingly unusable. Specifically, the idle-priority pagezero thread exacerbates contention for

svn commit: r305380 - head/lib/msun/src

2016-09-04 Thread Bruce Evans
Author: bde Date: Sun Sep 4 12:01:32 2016 New Revision: 305380 URL: https://svnweb.freebsd.org/changeset/base/305380 Log: Fix missing fmodl() on arches with 53-bit long doubles. PR: 199422, 211965 MFC after:1 week Modified: head/lib/msun/src/e_fmod.c Modified: head/lib/

svn commit: r305382 - in head/lib/msun: amd64 i387

2016-09-04 Thread Bruce Evans
Author: bde Date: Sun Sep 4 12:22:14 2016 New Revision: 305382 URL: https://svnweb.freebsd.org/changeset/base/305382 Log: Add asm versions of fmod(), fmodf() and fmodl() on amd64. Add asm versions of fmodf() amd fmodl() on i387. fmod is similar to remainder, and the C versions are 3 to

svn commit: r305384 - head/lib/msun/i387

2016-09-04 Thread Bruce Evans
Author: bde Date: Sun Sep 4 14:12:19 2016 New Revision: 305384 URL: https://svnweb.freebsd.org/changeset/base/305384 Log: Disconnect the "optimized" asm variants of cos(), sin() and tan() from the build on i386. Leave them in the source tree for regression tests. The asm functions were

svn commit: r305385 - head/lib/msun/i387

2016-09-04 Thread Bruce Evans
Author: bde Date: Sun Sep 4 15:08:14 2016 New Revision: 305385 URL: https://svnweb.freebsd.org/changeset/base/305385 Log: Oops, the previous i386 version of e_fmodf.S and e_fmodl.S was actually the amd64 version. Modified: head/lib/msun/i387/e_fmodf.S head/lib/msun/i387/e_fmodl.S Modifi

Re: svn commit: r305382 - in head/lib/msun: amd64 i387

2016-09-04 Thread Bruce Evans
On Sun, 4 Sep 2016, Konstantin Belousov wrote: On Sun, Sep 04, 2016 at 12:22:14PM +, Bruce Evans wrote: ... Log: Add asm versions of fmod(), fmodf() and fmodl() on amd64. Add asm versions of fmodf() amd fmodl() on i387. ... It seems that wrong version of i387/f_fmodf.S, it is

svn commit: r305612 - head/sys/i386/i386

2016-09-08 Thread Bruce Evans
Author: bde Date: Thu Sep 8 14:43:39 2016 New Revision: 305612 URL: https://svnweb.freebsd.org/changeset/base/305612 Log: Fix single-stepping of instructions emulated by vm86. In vm86.c, fix 2 (rarely used) cases where the return code lost the single-step indicator. While here, fix 2 mi

svn commit: r305622 - in head/sys/ufs: ffs ufs

2016-09-08 Thread Bruce Evans
Author: bde Date: Thu Sep 8 17:40:40 2016 New Revision: 305622 URL: https://svnweb.freebsd.org/changeset/base/305622 Log: Sprinkle DOINGASYNC() checks so as to do delayed writes for async mounts in almost all cases instead of in most cases. Don't override DOINGASYNC() by any condition exce

Re: svn commit: r305636 - head/sys/ddb

2016-09-08 Thread Bruce Evans
On Fri, 9 Sep 2016, Justin Hibbits wrote: Log: Correct the type of db_cmd_loop_done. On big endian hardware that uses 1 byte bool a type mismatch of bool vs int will cause the least signifcant byte of db_cmd_loop_done to be set, but the MSB to be read, and read as 0. This causes ddb to s

svn commit: r305661 - head/share/man/man4

2016-09-09 Thread Bruce Evans
Author: bde Date: Fri Sep 9 13:23:07 2016 New Revision: 305661 URL: https://svnweb.freebsd.org/changeset/base/305661 Log: Give the full syntax of the 'count' arg for all commmands that support it. This arg is most interesting for the 'break' command where it never worked, and for the step

svn commit: r305663 - head/sys/ddb

2016-09-09 Thread Bruce Evans
Author: bde Date: Fri Sep 9 14:09:50 2016 New Revision: 305663 URL: https://svnweb.freebsd.org/changeset/base/305663 Log: Fix stopping when the specified breakpoint count is reached. The countdown was done correctly, but the action when the count was not reduced to 0 was to fall through to

svn commit: r305665 - head/sys/ddb

2016-09-09 Thread Bruce Evans
Author: bde Date: Fri Sep 9 15:53:42 2016 New Revision: 305665 URL: https://svnweb.freebsd.org/changeset/base/305665 Log: Pass the trap type and code down from db_trap() to db_stop_at_pc() so that the latter can easily determine what the trap type actually is after callers are fixed to enco

svn commit: r305807 - in head/sys: amd64/amd64 i386/i386 x86/include

2016-09-14 Thread Bruce Evans
Author: bde Date: Wed Sep 14 12:57:40 2016 New Revision: 305807 URL: https://svnweb.freebsd.org/changeset/base/305807 Log: Use the MI macro TRAPF_USERMODE() instead of open-coded checks for SEL_UPL and sometimes PSL_VM. This is just a style change on amd64, but on i386 it fixes 1 unimportan

Re: svn commit: r305807 - in head/sys: amd64/amd64 i386/i386 x86/include

2016-09-14 Thread Bruce Evans
On Wed, 14 Sep 2016, Bruce Evans wrote: ... Log: ... Fix logic errors in treating vm86 bioscall mode as kernel mode. The main place checked all the necessary flags, but put the necessary parentheses for the PSL_VM and PCB_VM86CALL checks in the wrong place. The broken case is only

Re: svn commit: r305811 - head/sys/amd64/amd64

2016-09-14 Thread Bruce Evans
On Wed, 14 Sep 2016, Bjoern A. Zeeb wrote: Log: Try to fix LINT builds after r305807. Seems to be a simple s&r error I missed while reading through the 1st time as well. Thanks. The fix looks right. Modified: head/sys/amd64/amd64/trap.c Modified: head/sys/amd64/amd64/trap.c ===

Re: svn commit: r305807 - in head/sys: amd64/amd64 i386/i386 x86/include

2016-09-14 Thread Bruce Evans
On Wed, 14 Sep 2016, Bjoern A. Zeeb wrote: On 14 Sep 2016, at 12:57, Bruce Evans wrote: Author: bde Date: Wed Sep 14 12:57:40 2016 New Revision: 305807 URL: https://svnweb.freebsd.org/changeset/base/305807 Log: Modified: head/sys/amd64/amd64/trap.c breaks all amd64 LINT* kernels

Re: svn commit: r305814 - head/sys/boot/common

2016-09-14 Thread Bruce Evans
On Wed, 14 Sep 2016, Emmanuel Vadot wrote: Log: ufsread: Do not cast struct direct from void * This cause alignment problem on ARM (and possibly other archs), instead copy it. MFC after: 1 week Modified: head/sys/boot/common/ufsread.c Modified: head/sys/boot/common/ufsread.c

Re: svn commit: r305814 - head/sys/boot/common

2016-09-14 Thread Bruce Evans
On Wed, 14 Sep 2016, Emmanuel Vadot wrote: Bruce Evans wrote: On Wed, 14 Sep 2016, Emmanuel Vadot wrote: Log: ufsread: Do not cast struct direct from void * This cause alignment problem on ARM (and possibly other archs), instead copy it. ... This looks like a good pessimization for

Re: svn commit: r305821 - head/usr.bin/login

2016-09-14 Thread Bruce Evans
On Thu, 15 Sep 2016, Ed Maste wrote: Log: login: clean up errx strings errx() prefixes the error string with argv[0] so including "login: " in the string is redundant. Also remove a superfluous newline. The strings still have plenty of dirt: Modified: head/usr.bin/login/login_audit.c ===

svn commit: r305840 - in head/sys: amd64/amd64 amd64/include ddb i386/i386 i386/include

2016-09-15 Thread Bruce Evans
Author: bde Date: Thu Sep 15 17:24:23 2016 New Revision: 305840 URL: https://svnweb.freebsd.org/changeset/base/305840 Log: Abort single stepping in ddb if the trap is not for single-stepping. This is not very easy to do, since ddb didn't know when traps are for single-stepping. It more or l

svn commit: r305849 - head/sys/amd64/include

2016-09-15 Thread Bruce Evans
Author: bde Date: Thu Sep 15 18:30:53 2016 New Revision: 305849 URL: https://svnweb.freebsd.org/changeset/base/305849 Log: Decode some REX prefixes in inst_call(). This makes the 'next' and 'until' commands work in more cases. Modified: head/sys/amd64/include/db_machdep.h Modified: head/s

svn commit: r305862 - in head/sys: amd64/amd64 i386/i386

2016-09-15 Thread Bruce Evans
Author: bde Date: Fri Sep 16 04:58:37 2016 New Revision: 305862 URL: https://svnweb.freebsd.org/changeset/base/305862 Log: (1) Ifdef the new dr6 variable for KDB. While here, avoid using the old variable 'code' and remove it in trap(). ('code' was meant for holding things like %dr6, bu

svn commit: r305864 - head/sys/ddb

2016-09-15 Thread Bruce Evans
Author: bde Date: Fri Sep 16 06:31:10 2016 New Revision: 305864 URL: https://svnweb.freebsd.org/changeset/base/305864 Log: Statically initialize the run mode to the one that will become current on first entry. This fixes a spurious "Stepping aborted" message when the first entry is for a br

svn commit: r305865 - in head/sys: amd64/amd64 x86/include

2016-09-16 Thread Bruce Evans
Author: bde Date: Fri Sep 16 07:09:35 2016 New Revision: 305865 URL: https://svnweb.freebsd.org/changeset/base/305865 Log: Fix decoding of tf_rsp on amd64, and move TF_HAS_STACKREGS() to the i386-only section, and fix a comment about the amd64 kernel trapframe not having stackregs. tf_r

svn commit: r305897 - head/sys/ddb

2016-09-17 Thread Bruce Evans
Author: bde Date: Sat Sep 17 11:43:51 2016 New Revision: 305897 URL: https://svnweb.freebsd.org/changeset/base/305897 Log: Silently ignore unexpected single-step traps (except for turning off single-stepping). Only do this on arches (only x86 so far) which classify single-step traps unambig

svn commit: r305899 - in head/sys/i386: i386 include

2016-09-17 Thread Bruce Evans
Author: bde Date: Sat Sep 17 14:00:52 2016 New Revision: 305899 URL: https://svnweb.freebsd.org/changeset/base/305899 Log: Remove all kernel uses of pcb_psl, but keep in in the struct to preserve the ABI and API for applications. It was removed in the port to amd64, but was remained as garb

Re: svn commit: r305899 - in head/sys/i386: i386 include

2016-09-17 Thread Bruce Evans
On Sat, 17 Sep 2016, Bruce Evans wrote: Author: bde Date: Sat Sep 17 14:00:52 2016 New Revision: 305899 URL: https://svnweb.freebsd.org/changeset/base/305899 Log: Remove all kernel uses of pcb_psl, but keep in in the struct to preserve the ABI and API for applications. It was removed in the

Re: svn commit: r305998 - in head/usr.bin: cmp indent tr

2016-09-19 Thread Bruce Evans
On Mon, 19 Sep 2016, John Baldwin wrote: On Monday, September 19, 2016 01:45:01 PM Ngie Cooper wrote: On Sep 19, 2016, at 1:43 PM, Conrad E. Meyer wrote: Log: Move sys/capsicum.h includes after types.h or param.h This is not actually documented or even implied in style(9). Make the chang

Re: svn commit: r306012 - head/etc/autofs

2016-09-19 Thread Bruce Evans
On Tue, 20 Sep 2016, Edward Tomasz Napierala wrote: Log: Fix -media to not mount ufs with "async"; it doesn't make sense when there is softupdates. It does make sense when there isn't soft updates. With soft updates, it is silently ignored. However, I don't like changing the default. asyn

Re: svn commit: r306012 - head/etc/autofs

2016-09-20 Thread Bruce Evans
On Tue, 20 Sep 2016, Edward Tomasz Napierala wrote: On 0920T1653, Bruce Evans wrote: On Tue, 20 Sep 2016, Edward Tomasz Napierala wrote: Log: Fix -media to not mount ufs with "async"; it doesn't make sense when there is softupdates. It does make sense when there isn't

svn commit: r306310 - in head/sys: amd64/amd64 i386/i386

2016-09-25 Thread Bruce Evans
Author: bde Date: Sun Sep 25 14:56:24 2016 New Revision: 306310 URL: https://svnweb.freebsd.org/changeset/base/306310 Log: Fix vm86 initialization, part 3 of 2 and a half. (Actually, just fix early printfs and debugging of vm86 initialization and some other early initialization in some case

svn commit: r306311 - in head: share/man/man4 sys/ddb sys/i386/i386 sys/i386/include

2016-09-25 Thread Bruce Evans
Author: bde Date: Sun Sep 25 16:30:29 2016 New Revision: 306311 URL: https://svnweb.freebsd.org/changeset/base/306311 Log: Determine the operand/address size of %cs in a new function db_segsize(). Use db_segsize() to set the default operand/address size for disassembling. Allow overrid

svn commit: r306319 - head/sys/i386/i386

2016-09-25 Thread Bruce Evans
Author: bde Date: Sun Sep 25 18:39:24 2016 New Revision: 306319 URL: https://svnweb.freebsd.org/changeset/base/306319 Log: Minor fixes for 160-bit disassembly: (1) Print the default segment %ss before adresses relative to %bp. This is too cluttered for me, but so is printing some othe

Re: svn commit: r306319 - head/sys/i386/i386

2016-09-25 Thread Bruce Evans
On Sun, 25 Sep 2016, Colin Percival wrote: On 09/25/16 11:39, Bruce Evans wrote: Author: bde Date: Sun Sep 25 18:39:24 2016 New Revision: 306319 URL: https://svnweb.freebsd.org/changeset/base/306319 Log: Minor fixes for 160-bit disassembly: I thought the x86 architecture was limited to

Re: svn commit: r306337 - head/sys/kern

2016-09-26 Thread Bruce Evans
On Mon, 26 Sep 2016, Hiren Panchasara wrote: Author: hiren Date: Mon Sep 26 10:13:58 2016 New Revision: 306337 URL: https://svnweb.freebsd.org/changeset/base/306337 Log: In sendit(), if mp->msg_control is present, then in sockargs() we are allocating mbuf to store mp->msg_control. Later in k

Re: svn commit: r306337 - head/sys/kern

2016-09-26 Thread Bruce Evans
On Mon, 26 Sep 2016, Bruce Evans wrote: On Mon, 26 Sep 2016, Hiren Panchasara wrote: Author: hiren Date: Mon Sep 26 10:13:58 2016 New Revision: 306337 URL: https://svnweb.freebsd.org/changeset/base/306337 Log: In sendit(), if mp->msg_control is present, then in sockargs() we are allocat

Re: svn commit: r306538 - head/lib/libstand

2016-09-30 Thread Bruce Evans
On Fri, 30 Sep 2016, Toomas Soome wrote: Author: tsoome Date: Fri Sep 30 23:19:08 2016 New Revision: 306538 URL: https://svnweb.freebsd.org/changeset/base/306538 Log: cstyle fix of cd9660_open in libstand rS306534 did create bad cstyle by my mistake, correcting it. Modified: head/lib/libsta

Re: svn commit: r306346 - head/sys/kern

2016-10-04 Thread Bruce Evans
On Tue, 4 Oct 2016, Gleb Smirnoff wrote: On Mon, Sep 26, 2016 at 03:30:30PM +, Eric van Gyzen wrote: E> ... E> Modified: head/sys/kern/kern_mutex.c E> == E> --- head/sys/kern/kern_mutex.cMon Sep 26 15:03:31 2016

Re: svn commit: r306346 - head/sys/kern

2016-10-05 Thread Bruce Evans
On Wed, 5 Oct 2016, Slawa Olhovchenkov wrote: On Wed, Oct 05, 2016 at 11:19:10AM +1100, Bruce Evans wrote: On Tue, 4 Oct 2016, Gleb Smirnoff wrote: On Mon, Sep 26, 2016 at 03:30:30PM +, Eric van Gyzen wrote: E> ... E> Modified: head/sys/kern/kern_mut

Re: svn commit: r306902 - in head/sys/arm: allwinner amlogic/aml8726 at91 broadcom/bcm2835 freescale/imx lpc mv rockchip ti ti/am335x ti/omap4 ti/twl xscale/i8134x xscale/ixp425

2016-10-09 Thread Bruce Evans
On Sun, 9 Oct 2016, Michal Meloun wrote: Log: ARM: Remove unused includes. MFC after: 1 week ... Modified: head/sys/arm/allwinner/a10_gpio.c == --- head/sys/arm/allwinner/a10_gpio.c Sun Oct 9 10:24:10 2016

Re: svn commit: r307148 - in head/lib/libc: gen stdlib

2016-10-12 Thread Bruce Evans
On Wed, 12 Oct 2016, Ed Maste wrote: Log: Add comment on use of abort() in libc Suggested by: jonathan (in review D8133) It is almost easier to fix the bugs than add the comment. Modified: head/lib/libc/gen/arc4random.c

Re: svn commit: r307231 - head/lib/libgcc_s

2016-10-13 Thread Bruce Evans
On Thu, 13 Oct 2016, Ed Maste wrote: Log: libgcc_s: add libm dependencies from div{d,s,x}c3 compiler-rt's complex division support routines contain calls to compiler builtins such as `__builtin_scalbnl`. Unfortunately Clang turns these back into a call to `scalbnl`. gcc-4.2 has the same

Re: svn commit: r307231 - head/lib/libgcc_s

2016-10-13 Thread Bruce Evans
On Fri, 14 Oct 2016, Ed Maste wrote: Hi Bruce, thank you for the detailed response. On 14 October 2016 at 01:53, Bruce Evans wrote: compiler-rt's complex division support routines contain calls to compiler builtins such as `__builtin_scalbnl`. Unfortunately Clang turns these back i

<    4   5   6   7   8   9   10   11   12   13   >