Re: svn commit: r223138 - head/sys/ufs/ffs

2011-06-16 Thread Bruce Evans
On Thu, 16 Jun 2011, Stefan Farfeleder wrote: Log: Fixing compilation bustage by introducing another forward declaration. Modified: head/sys/ufs/ffs/ffs_extern.h Modified: head/sys/ufs/ffs/ffs_extern.h == --- head/

Re: svn commit: r223139 - head/lib/libstand

2011-06-16 Thread Bruce Evans
On Thu, 16 Jun 2011, Garrett Cooper wrote: On Thu, Jun 16, 2011 at 12:19 AM, Garrett Cooper wrote: On Thu, Jun 16, 2011 at 12:14 AM, Tai-hwa Liang wrote: Author: avatar Date: Thu Jun 16 07:14:55 2011 New Revision: 223139 URL: http://svn.freebsd.org/changeset/base/223139 Log: ?Unbreaking bui

Re: svn commit: r223139 - head/lib/libstand

2011-06-16 Thread Bruce Evans
On Thu, 16 Jun 2011, Tai-hwa Liang wrote: On Thu, 16 Jun 2011, Bruce Evans wrote: On Thu, 16 Jun 2011, Garrett Cooper wrote: And you need to add #include to stand.h in order to get uintmax_t. Here's a proper patch for amd64.. This would add namespace pollution. stand.h doesn&

Re: svn commit: r223138 - head/sys/ufs/ffs

2011-06-16 Thread Bruce Evans
On Thu, 16 Jun 2011, Tai-hwa Liang wrote: On Thu, 16 Jun 2011, Bruce Evans wrote: It might be a style bug (like typedefing a struct) to use enums for anything. They are impossible to declare opaquely. Does that mean we have to #include in userland makefs/ffs/ffs_bswap.c? It means

Re: svn commit: r223211 - head/sys/x86/x86

2011-06-18 Thread Bruce Evans
On Fri, 17 Jun 2011, Jung-uk Kim wrote: Log: Teach the compiler how to shift TSC value efficiently. As noted in r220631, some times compiler inserts redundant instructions to preserve unused upper 32 bits even when it is casted to a 32-bit value. Unfortunately, it seems the problem becomes

Re: svn commit: r222866 - head/sys/x86/x86

2011-06-18 Thread Bruce Evans
Long ago, On Wed, 8 Jun 2011, Jung-uk Kim wrote: On Wednesday 08 June 2011 04:55 pm, Bruce Evans wrote: On Wed, 8 Jun 2011, Jung-uk Kim wrote: Log: Introduce low-resolution TSC timecounter "TSC-low". It replaces the normal TSC timecounter if TSC frequency is higher than ~4.29 MHz

Re: svn commit: r222884 - head/sys/x86/x86

2011-06-18 Thread Bruce Evans
On Wed, 8 Jun 2011, Jung-uk Kim wrote: Log: Tidy up r222866. - Re-add accidentally removed atomic op. for sysctl(9) handler. - Remove a period(`.') at the end of a debugging message. - Consistently spell "low" for "TSC-low" timecounter throughout. Pointed out by:bde Thanks. Bru

Re: svn commit: r223262 - in head: cddl/contrib/opensolaris/lib/libdtrace/common contrib/binutils/bfd contrib/binutils/gas contrib/binutils/gas/config contrib/binutils/ld contrib/binutils/opcodes cont

2011-06-18 Thread Bruce Evans
On Sat, 18 Jun 2011, Ben Laurie wrote: Author: benl Date: Sat Jun 18 13:56:33 2011 New Revision: 223262 URL: http://svn.freebsd.org/changeset/base/223262 Log: Fix clang warnings. Approved by: philip (mentor) Most of these seem to be bugs in clang, so source code can only be broken by avo

Re: svn commit: r223262 - in head: cddl/contrib/opensolaris/lib/libdtrace/common contrib/binutils/bfd contrib/binutils/gas contrib/binutils/gas/config contrib/binutils/ld contrib/binutils/opcodes cont

2011-06-19 Thread Bruce Evans
On Sun, 19 Jun 2011, TAKAHASHI Yoshihiro wrote: In article <201106181356.p5iduxhw044...@svn.freebsd.org> Ben Laurie writes: Log: Fix clang warnings. Modified: head/sys/sys/diskpc98.h == --- head/sys/sys/diskpc98.h

Re: svn commit: r223262 - in head: cddl/contrib/opensolaris/lib/libdtrace/common contrib/binutils/bfd contrib/binutils/gas contrib/binutils/gas/config contrib/binutils/ld contrib/binutils/opcodes cont

2011-06-19 Thread Bruce Evans
On Sun, 19 Jun 2011, Ben Laurie wrote: On 18/06/2011 18:45, Kostik Belousov wrote: Modified: head/sys/sys/param.h == --- head/sys/sys/param.hSat Jun 18 13:54:36 2011(r223261) +++ head/sys/sys/param.h

Re: svn commit: r222866 - head/sys/x86/x86

2011-06-20 Thread Bruce Evans
On Mon, 20 Jun 2011, Peter Jeremy wrote: On 2011-Jun-18 22:05:06 +1000, Bruce Evans wrote: My clock measurement program (mostly an old program by Wollman) shows the following histogram of times for a non-invariant TSC timecounter on a 2GHz UP system: % min 273, max 265102, mean 273.998217

Re: svn commit: r223307 - head/sys/vm

2011-06-21 Thread Bruce Evans
On Tue, 21 Jun 2011, Bjoern A. Zeeb wrote: On Jun 19, 2011, at 7:13 PM, Alan Cox wrote: Hi Alan, Author: alc Date: Sun Jun 19 19:13:24 2011 New Revision: 223307 URL: http://svn.freebsd.org/changeset/base/223307 Log: Precisely document the synchronization rules for the page's dirty field. (

Re: svn commit: r223380 - head/sys/dev/xl

2011-06-21 Thread Bruce Evans
On Tue, 21 Jun 2011, Ben Kaduk wrote: On Tue, Jun 21, 2011 at 4:51 PM, Warner Losh wrote: Author: imp Date: Tue Jun 21 20:51:09 2011 New Revision: 223380 URL: http://svn.freebsd.org/changeset/base/223380 --- head/sys/dev/xl/if_xl.c ? ? Tue Jun 21 20:50:55 2011 ? ? ? ?(r223379) +++ head/sys/de

Re: svn commit: r223307 - head/sys/vm

2011-06-21 Thread Bruce Evans
On Tue, 21 Jun 2011, Attilio Rao wrote: 2011/6/21 Bruce Evans : vm_page.o: In function `vm_page_clear_dirty': /sys/vm/vm_page.c:(.text+0x18d0): undefined reference to `atomic_clear_8' /sys/vm/vm_page.c:(.text+0x18d0): relocation truncated to fit: R_MIPS_26 against `atomic_clear_8&

Re: svn commit: r223307 - head/sys/vm

2011-06-22 Thread Bruce Evans
On Wed, 22 Jun 2011, John Baldwin wrote: On Tuesday, June 21, 2011 4:58:10 pm Bruce Evans wrote: On Tue, 21 Jun 2011, Bjoern A. Zeeb wrote: ... vm_page.o: In function `vm_page_clear_dirty': /sys/vm/vm_page.c:(.text+0x18d0): undefined reference to `atomic_clear_8' /sys/vm/vm_pag

Re: svn commit: r223307 - head/sys/vm

2011-06-22 Thread Bruce Evans
On Wed, 22 Jun 2011, Warner Losh wrote: On Jun 22, 2011, at 3:26 AM, Attilio Rao wrote: 2011/6/22 Warner Losh : On Jun 21, 2011, at 5:27 PM, Alan Cox wrote: On 06/21/2011 16:09, Attilio Rao wrote: 2011/6/21 Bruce Evans: On Tue, 21 Jun 2011, Bjoern A. Zeeb wrote: On Jun 19, 2011, at 7:13

Re: svn commit: r223429 - head/sbin/growfs

2011-06-22 Thread Bruce Evans
On Wed, 22 Jun 2011, Edward Tomasz Napierala wrote: Log: Cosmetic fixes; mostly s/file system/filesystem/g and removing weird indent from messages. The first part seems backwards. It undoes the 2002 change that does s/filesystem/file system/g, except the 2002 change was not restricted to gr

Re: svn commit: r223493 - in head/usr.bin: ktrace ncplogin systat tftp vmstat

2011-06-24 Thread Bruce Evans
On Fri, 24 Jun 2011, Alexander Best wrote: On Fri Jun 24 11, Roman Divacky wrote: On Fri, Jun 24, 2011 at 07:18:44AM +, Kevin Lo wrote: Author: kevlo Date: Fri Jun 24 07:18:44 2011 New Revision: 223493 URL: http://svn.freebsd.org/changeset/base/223493 Log: Remove duplicated header files

Re: svn commit: r223877 - in head: include/rpc lib/libc/xdr

2011-07-09 Thread Bruce Evans
On Sat, 9 Jul 2011, Kevin Lo wrote: Log: - Add xdr_sizeof(3) to libc - Document xdr_sizeof(3); from NetBSD Discussed with:kib Any reason to further break the style of every changed line of the header? Modified: head/include/rpc/xdr.h ==

Re: svn commit: r223900 - in head/sys: geom ufs/ffs

2011-07-09 Thread Bruce Evans
On Sun, 10 Jul 2011, Kirk McKusick wrote: Log: Allow disk partitions associated with UFS read-only mounted filesystems to be opened for writing. This functionality used to be special-cased for just the root filesystem, but with this change is now available for all UFS filesystems. This chang

Re: svn commit: r223877 - in head: include/rpc lib/libc/xdr

2011-07-10 Thread Bruce Evans
On Sun, 10 Jul 2011, Kevin Lo wrote: On Sun, 2011-07-10 at 03:45 +1000, Bruce Evans wrote: On Sat, 9 Jul 2011, Kevin Lo wrote: Log: - Add xdr_sizeof(3) to libc - Document xdr_sizeof(3); from NetBSD Discussed with:kib Any reason to further break the style of every changed line

Re: svn commit: r223904 - head/lib/libstand

2011-07-10 Thread Bruce Evans
On Sun, 10 Jul 2011, Kevin Lo wrote: Log: style(9) cleanup Modified: head/lib/libstand/zalloc_defs.h Modified: head/lib/libstand/zalloc_defs.h == --- head/lib/libstand/zalloc_defs.h Sun Jul 10 06:57:00 2011

Re: svn commit: r223906 - head/include/rpc

2011-07-10 Thread Bruce Evans
On Sun, 10 Jul 2011, Kevin Lo wrote: Log: Revert the previous change and add xdr_sizeof Requested by: bde Modified: head/include/rpc/xdr.h Thanks. Bruce ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-sr

Re: svn commit: r223930 - head/sys/geom

2011-07-12 Thread Bruce Evans
On Mon, 11 Jul 2011, Andrey V. Elsukov wrote: Log: Remove include of sys/sbuf.h from geom/geom.h. sbuf support is not always required for geom/geom.h users, and no need to depend from it. PR:kern/158398 Thanks. It's not easy to recover from pollution. Modified: head/sys/geo

Re: svn commit: r224150 - head/sbin/fdisk

2011-07-17 Thread Bruce Evans
On Sun, 17 Jul 2011, Ryan Stone wrote: Log: The MBR uses a 32-bit unsigned integer to store the size of a slice, but fdisk(1) internally uses a signed int. Should a user attempt to specify a slice containing more than 2^31 - 1 sectors, an error will be reported on systems with sizeof(long)

Re: svn commit: r224150 - head/sbin/fdisk

2011-07-18 Thread Bruce Evans
On Sun, 17 Jul 2011, Ryan Stone wrote: On Sun, Jul 17, 2011 at 7:09 PM, Bruce Evans wrote: There was no need to further break the style. Ack. Should have caught that. Will fix. Thanks. @@ -990,7 +990,7 @@ parse_config_line(char *line, CMD *comma ? ? ? ? ? ?if (isalpha(*cp

Re: svn commit: r223989 - head/sys/dev/usb/input

2011-07-20 Thread Bruce Evans
On Wed, 20 Jul 2011, Hans Petter Selasky wrote: On Wednesday 20 July 2011 12:37:44 Andriy Gapon wrote: This special code is a workaround. The problem is that when not polling the key presses will be fed into syscons I think, and not returned via the polling function. That's why there is a time

Re: svn commit: r209763 - head/sys/amd64/include

2010-07-08 Thread Bruce Evans
On Wed, 7 Jul 2010, Rui Paulo wrote: Log: Fix style issues with the previous commit, namely use-tab-instead-of-space and don't use underscores in macro variables. Pointed out by:bde Thanks. Bruce ___ svn-src-head@freebsd.org mailing list

Re: svn commit: r209842 - head/lib/libstand

2010-07-10 Thread Bruce Evans
On Fri, 9 Jul 2010, Jung-uk Kim wrote: Log: Fix build by defining MAX() macro here. Modified: head/lib/libstand/printf.c Arrgh. The unsafe macros MAX() and MIN() were deprecated in the kernel, but this has been broken (in 2001 for NetBSD and 2003 for FreeBSD). Use of MAX() in kern/subr_prf

Re: svn commit: r209928 - head/sys/mips/include

2010-07-12 Thread Bruce Evans
On Mon, 12 Jul 2010, Jayachandran C. wrote: Log: Move KSEG address definitions from cpu.h to cpuregs.h with the other definitions, add some XKPHYS related definitions for n64. This is a good start to cleaning up mips cpu.h. but far from complete. cpu.h is for MD implementations of a few (ab

Re: svn commit: r209949 - in head: lib/libstand sys/kern

2010-07-12 Thread Bruce Evans
On Mon, 12 Jul 2010, Jung-uk Kim wrote: Log: Use type-specific inline function imax() instead of deprecated macro MAX(). Prodded by:bde Thanks. Bruce ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-

Re: svn commit: r209900 - head/sys/kern

2010-07-13 Thread Bruce Evans
On Mon, 12 Jul 2010, Alexander Motin wrote: John Baldwin wrote: On Sunday, July 11, 2010 12:47:46 pm Alexander Motin wrote: ... Log: Remove interval validation from cpu_tick_calibrate(). As I found, check was needed at preliminary version of the patch, where number of CPU ticks was divid

Re: svn commit: r209900 - head/sys/kern

2010-07-13 Thread Bruce Evans
On Tue, 13 Jul 2010, Alexander Motin wrote: Bruce Evans wrote: Fix for cputick calibration: ... Variable frequencies have the interesting capability of varying in both positive and negative directions. This fixes the case of negative-going changes. ... I have no hardware to check, but I

Re: svn commit: r210005 - head/sys/modules/acpi/acpi

2010-07-15 Thread Bruce Evans
On Tue, 13 Jul 2010, Jung-uk Kim wrote: Log: Define SMP unconditionally for amd64 and remove opt_global.h from SRCS. Note it is done just for correctness sake because we do not build, ship, or support acpi.ko on amd64. Prodded by:bde Thanks. It was much more interesting than I notice

Re: svn commit: r210225 - in head/sys: kern sys

2010-07-18 Thread Bruce Evans
On Sun, 18 Jul 2010, Colin Percival wrote: On 07/18/10 13:23, Edward Tomasz Napierala wrote: Log: The "/*-" comment marker is supposed to denote copyrights. Remove non-copyright occurences from sys/sys/ and sys/kern/. The "/*-" comment marker indicates to utilities that comments should

Re: svn commit: r210217 - head/sys/kern

2010-07-20 Thread Bruce Evans
On Mon, 19 Jul 2010, John Baldwin wrote: Log: In keeping with the Age-of-the-fruitbat theme, scale up hirunningspace on machines which can clearly afford the memory. This is a somewhat conservative version of the patch - more fine tuning may be necessary. Idea from: Thread on hackers

Re: svn commit: r210217 - head/sys/kern

2010-07-21 Thread Bruce Evans
On Wed, 21 Jul 2010, Ivan Voras wrote: On 21 July 2010 06:18, Bruce Evans wrote: On Mon, 19 Jul 2010, John Baldwin wrote: Log: ??In keeping with the Age-of-the-fruitbat theme, scale up hirunningspace on ??machines which can clearly afford the memory. ??This is a somewhat conservative

Re: svn commit: r210321 - head/lib/libelf

2010-07-21 Thread Bruce Evans
On Wed, 21 Jul 2010, Alexey Dokuchaev wrote: On Wed, Jul 21, 2010 at 08:43:48AM +, Kai Wang wrote: Log: Remove a superfluous comment. Obtained from: elftoolchain MFC after: 1 month (Just picking random of the similar commits): guys, please, try to uniformly alig

Re: svn commit: r210451 - head/sys/sys

2010-07-25 Thread Bruce Evans
On Sat, 24 Jul 2010, Stefan Farfeleder wrote: declaring enums like this is not standard C code (seems to be a GCC extension). I don't think we should use this feature in our headers. This is unfortunate. This is because the size of an enum variable depends on its complete declaration. This i

Re: svn commit: r210451 - head/sys/sys

2010-07-26 Thread Bruce Evans
On Sun, 25 Jul 2010, Kostik Belousov wrote: On Sun, Jul 25, 2010 at 09:55:10PM +0200, Nathan Whitehorn wrote: On 07/25/10 20:12, Kostik Belousov wrote: On Mon, Jul 26, 2010 at 01:36:07AM +1000, Bruce Evans wrote: On Sat, 24 Jul 2010, Stefan Farfeleder wrote: declaring enums like this is

Re: svn commit: r211023 - head/usr.sbin/syslogd

2010-08-09 Thread Bruce Evans
On Mon, 9 Aug 2010, Jilles Tjoelker wrote: On Sun, Aug 08, 2010 at 03:36:08PM -0600, M. Warner Losh wrote: The casting that syslogd does with struct sockaddrFOO is what triggers it. I'm not sure how to fix it, so there's about 6 or 8 programs in the tree that have WARNS lowered to 3 because

Re: svn commit: r208165 - in head/sys: kern mips/conf mips/include mips/mips mips/rmi mips/rmi/dev/xlr

2010-08-10 Thread Bruce Evans
On Mon, 9 Aug 2010, M. Warner Losh wrote: In message: "Jayachandran C." writes: : > Actually the 32 bits limit is well aware and acknowledged in cpumask_t. : > While it is true that it should be an 'opaque' type, in reality it is : > not. The maximum limit of 32 CPUs is a reality du

Re: svn commit: r211023 - head/usr.sbin/syslogd

2010-08-10 Thread Bruce Evans
On Mon, 9 Aug 2010, M. Warner Losh wrote: In message: <86tyn4tbuc@ds4.des.no> Dag-Erling Sm?rgrav writes: : Jilles Tjoelker writes: : > In other cases, I propose adding a cast to void * in between, like : > (struct sockaddr_in *)(void *)ai->ai_addr : : Better to cast through u

Re: svn commit: r211130 - head/libexec/rtld-elf/mips

2010-08-10 Thread Bruce Evans
On Tue, 10 Aug 2010, Stefan Farfeleder wrote: On Tue, Aug 10, 2010 at 12:55:38PM +0530, Jayachandran C. wrote: I think there is a problem in sys/mips/include/_endian.h -- #define __bswap16(x)(__uint16_t)(__is_constant(x) ? \ __bswap16_const((__uint16_t)x) : __bswap16_var(

Re: svn commit: r211023 - head/usr.sbin/syslogd

2010-08-10 Thread Bruce Evans
On Tue, 10 Aug 2010, M. Warner Losh wrote: In message: <86sk2m1hsj@ds4.des.no> Dag-Erling Sm?rgrav writes: : "M. Warner Losh" writes: : > /* : > * Macros to cast a struct sockaddr, or parts thereof. : > * On architectures with strict alignment requirements, the compiler : > *

Re: svn commit: r211252 - head/usr.sbin/acpi/acpidump

2010-08-13 Thread Bruce Evans
On Fri, 13 Aug 2010, Takanori Watanabe wrote: Log: Fix build on amd64 and ia64. Why not fix it on all arches? Modified: head/usr.sbin/acpi/acpidump/acpi.c == --- head/usr.sbin/acpi/acpidump/acpi.c Fri Aug 13 00:21:

Re: svn commit: r211221 - head/usr.sbin/acpi/acpidump

2010-08-13 Thread Bruce Evans
On Thu, 12 Aug 2010, John Baldwin wrote: Dag-Erling Sm??rgrav wrote: John Baldwin writes: Dag-Erling Sm??rgrav writes: Oops, I replied to the commit mail for the round after this before noticing this thread. Slightly better: printf("\tClass %u Base Address 0x%jx Length %ju\n\n",

Re: svn commit: r211228 - head/sys/kern

2010-08-13 Thread Bruce Evans
On Thu, 12 Aug 2010, Jung-uk Kim wrote: On Thursday 12 August 2010 12:37 pm, m...@freebsd.org wrote: On Thu, Aug 12, 2010 at 9:13 AM, Jung-uk Kim wrote: Log: ?Provide description for 'machdep.disable_rtc_set' sysctl. ?Clean up style(9) ?nits. ?Remove a redundant return statement and an unnec

Re: svn commit: r211221 - head/usr.sbin/acpi/acpidump

2010-08-13 Thread Bruce Evans
On Fri, 13 Aug 2010, [utf-8] Dag-Erling Sm??rgrav wrote: Bruce Evans writes: - `platform_class' has type uint16_t. u_int is larger than that on all supported machines, and also on unsupported ones with 16-31 bit u_ints. Thus the cast has almost no effect, and has no effect on the r

Re: svn commit: r211338 - head/lib/libutil

2010-08-15 Thread Bruce Evans
On Sun, 15 Aug 2010, Dag-Erling Smorgrav wrote: Log: no-op commit to note that the example given in the previous commit is a very bad one, since the shift does not actually overflow. Indeed. You barely escaped more mail about it :-). This is a better example (assuming uint64_t = unsigned

Re: svn commit: r211397 - in head: lib/libbluetooth lib/libc/gen lib/libc/net lib/libc/stdlib lib/libc/sys lib/libedit lib/libelf lib/libgeom lib/libgpib lib/libgssapi lib/libpmc lib/libradius lib/lib

2010-08-17 Thread Bruce Evans
Hi Joel, On Mon, 16 Aug 2010, Joel Dahl wrote: Log: Fix typos, spelling, formatting and mdoc mistakes found by Nobuyuki while translating these manual pages. Minor corrections by me. I noticed a few fixes missed nearby while checking the change in msun. Modified: head/lib/libbluetooth/bl

Re: svn commit: r211505 - head/contrib/gcc

2010-08-19 Thread Bruce Evans
On Thu, 19 Aug 2010, Rui Paulo wrote: Log: Remove unneeded casts in inline assembly in contrib/gcc/longlong.h, These seem to be needed, and some of them valid. Any lvalue arg that can be put in a register can be cast to USItype (unsigned int) on i386. The args are macro args, so they may hav

Re: svn commit: r211505 - head/contrib/gcc

2010-08-20 Thread Bruce Evans
On Fri, 20 Aug 2010, Dimitry Andric wrote: On 2010-08-20 00:20, Bruce Evans wrote: These seem to be needed, and some of them valid. Any lvalue arg that can be put in a register can be cast to USItype (unsigned int) on i386. The args are macro args, so they may have any integer type no larger

Re: svn commit: r211505 - head/contrib/gcc

2010-08-22 Thread Bruce Evans
On Sat, 21 Aug 2010, Dimitry Andric wrote: On 2010-08-20 22:36, Bruce Evans wrote: On Fri, 20 Aug 2010, Dimitry Andric wrote: [...] But will the casts not potentially hide problems, if you pass the wrong types to those macros? Maybe it is better if the compiler complains that some argument

Re: svn commit: r211304 - head/lib/libutil

2010-08-23 Thread Bruce Evans
On Mon, 23 Aug 2010, [utf-8] Dag-Erling Sm??rgrav wrote: Dimitry Andric writes: Dag-Erling Sm??rgrav writes: Bruce Cran writes: Somewhat related, there are overflow bugs in humanize_number - for example df(1) fails to display space from a 100PB filesystem correctly. Patch? :) Attached.

Re: svn commit: r211936 - in head: bin/test lib/libc/net lib/libc/stdio lib/libc/stdlib lib/libc/sys lib/libipx libexec/ypxfr sbin/ipfw secure/lib/libcrypto/man share/man/man4 share/man/man9 usr.sbin/

2010-08-28 Thread Bruce Evans
On Sat, 28 Aug 2010, Bruce Cran wrote: Log: Fix incorrect usage of 'assure' and 'insure'. I think some of the `assure's are more correct than their replacement of `ensure'. The difference is subtle -- my small 1960's English dictionary starts by saying that both mean "make safe"; it gives th

Re: svn commit: r211936 - in head: bin/test lib/libc/net lib/libc/stdio lib/libc/stdlib lib/libc/sys lib/libipx libexec/ypxfr sbin/ipfw secure/lib/libcrypto/man share/man/man4 share/man/man9 usr.sbin/

2010-08-29 Thread Bruce Evans
On Sun, 29 Aug 2010, Bruce Cran wrote: On Sun, 29 Aug 2010 12:12:46 +1000 (EST) Bruce Evans wrote: On Sat, 28 Aug 2010, Bruce Cran wrote: Log: Fix incorrect usage of 'assure' and 'insure'. I think some of the `assure's are more correct than their replacement of

Re: svn commit: r212182 - head/sys/kern

2010-09-06 Thread Bruce Evans
On Fri, 3 Sep 2010, pluknet wrote: On 3 September 2010 21:23, Matthew D Fleming wrote: Log: ?Fix user-space libsbuf build. ?Why isn't CTASSERT available to ?user-space? Well, user headers shouldn't be enlisted to check for kernel bugs that can be checked well enough in the kernel. Modified

Re: svn commit: r212177 - in head/sys: amd64/include i386/include

2010-09-07 Thread Bruce Evans
On Fri, 3 Sep 2010, Roman Divacky wrote: Log: Change the parameter passed to the inline assembly to u_short as we are dealing with 16bit segment registers. Change mov to movw. u_ints were used intentionally to avoid operand size prefixes here and extra code for promotions in callers. Segme

Re: svn commit: r212453 - in head/sys: conf powerpc/aim powerpc/booke powerpc/include powerpc/powerpc

2010-09-11 Thread Bruce Evans
On Sat, 11 Sep 2010, Alexander Motin wrote: Log: Update PowerPC event timer code to use new event timers infrastructure. What are the advantages of using the new event timers infrastructure? Here it seems to only take longer and cost more (200 more lines of code). Bruce _

Re: svn commit: r212607 - head/sbin/geom/core

2010-09-14 Thread Bruce Evans
On Tue, 14 Sep 2010, Pawel Jakub Dawidek wrote: Log: Remove dot which shouldn't be here, as err(3) will attach error message at the end of the string. In KNF, error messages are neither capitalized or terminated by a dot, partly because of this. Modified: head/sbin/geom/core/geom.c ===

Re: svn commit: r212374 - head/usr.bin/printf

2010-09-16 Thread Bruce Evans
On Thu, 16 Sep 2010, David O'Brien wrote: On Thu, Sep 09, 2010 at 12:51:11PM -0700, Juli Mallett wrote: On Thu, Sep 9, 2010 at 12:27, David E. O'Brien wrote: Author: obrien Date: Thu Sep ?9 19:27:40 2010 New Revision: 212374 URL: http://svn.freebsd.org/changeset/base/212374 Log: ?Note bug in

Re: svn commit: r212661 - head/sys/dev/aac

2010-09-16 Thread Bruce Evans
On Wed, 15 Sep 2010, Kostik Belousov wrote: On Wed, Sep 15, 2010 at 04:57:15PM +0200, Attilio Rao wrote: 2010/9/15 Kostik Belousov : On Wed, Sep 15, 2010 at 02:24:21PM +, Attilio Rao wrote: ... Log: ? Fix bogus busying mechanism from cdevsw callbacks: ? - D_TRACKCLOSE may be used there as

Re: svn commit: r212374 - head/usr.bin/printf

2010-09-17 Thread Bruce Evans
On Thu, 16 Sep 2010, David O'Brien wrote: ... Interestingly, we may not be compliant with susv3 if I am reading this correctly: The printf utility is required to notify the user when conversion errors are detected while producing numeric output; thus, the following results would be exp

Re: svn commit: r212860 - head/sys/kern

2010-09-19 Thread Bruce Evans
On Sun, 19 Sep 2010, Ed Schouten wrote: * Kostik Belousov wrote: Shouldn't you always report CLOCAL for console then ? Hmmm... That would be a lot more elegant, also for callout devices. The change I just committed, doesn't take a loss of SER_DCD into account after opening the device. This

Re: svn commit: r212886 - head/sbin/growfs

2010-09-19 Thread Bruce Evans
On Mon, 20 Sep 2010, Marcel Moolenaar wrote: Log: Unbreak the build on strong-aligned architectures (arm, ia64). Casting from (char *) to (struct ufs1_dinode *) changes the alignment requirement of the pointer and GCC does not know that the pointer is adequately aligned (due to malloc(3)), a

Re: svn commit: r212867 - head/sys/kern

2010-09-20 Thread Bruce Evans
On Sun, 19 Sep 2010, Ed Schouten wrote: Log: Just make callout devices and /dev/console force CLOCAL on open(). Instead of adding custom checks to wait for DCD on open(), just modify the termios structure to set CLOCAL. This means SIGHUP is no longer generated when losing DCD as well. Rev

Re: svn commit: r212867 - head/sys/kern

2010-09-20 Thread Bruce Evans
On Mon, 20 Sep 2010, Ed Schouten wrote: * Bruce Evans wrote: Er, my review explained how wrong this is. Please back it out. So basically you want to have it in its current form, with the only difference that CLOCAL is not enforced for callout devices, but still want callout devices to skip

Re: svn commit: r212886 - head/sbin/growfs

2010-09-21 Thread Bruce Evans
On Tue, 21 Sep 2010, Brian Somers wrote: On Mon, 20 Sep 2010 16:55:57 +1000 (EST) Bruce Evans wrote: On Mon, 20 Sep 2010, Marcel Moolenaar wrote: Log: Unbreak the build on strong-aligned architectures (arm, ia64). Casting from (char *) to (struct ufs1_dinode *) changes the alignment

Re: svn commit: r212886 - head/sbin/growfs

2010-09-23 Thread Bruce Evans
On Mon, 20 Sep 2010, Marcel Moolenaar wrote: On Sep 19, 2010, at 11:55 PM, Bruce Evans wrote: On Mon, 20 Sep 2010, Marcel Moolenaar wrote: Log: Unbreak the build on strong-aligned architectures (arm, ia64). Casting from (char *) to (struct ufs1_dinode *) changes the alignment requirement of

Re: svn commit: r213281 - head/lib/libc/amd64/gen

2010-09-29 Thread Bruce Evans
On Wed, 29 Sep 2010, Jung-uk Kim wrote: On Wednesday 29 September 2010 05:20 pm, Dimitry Andric wrote: Log: Apply the same workaround for clang to amd64's version of ldexp.c (as in r212976): order the incoming arguments to fscale as st(0), st(1), and mark temp2 volatile (only in case of compi

Re: svn commit: r213281 - head/lib/libc/amd64/gen

2010-09-30 Thread Bruce Evans
On Thu, 30 Sep 2010, Dimitry Andric wrote: On 2010-09-30 05:46, Bruce Evans wrote: ... This file probably shouldn't exist, especially on amd64. There are 4 or 5 versions of ldexp(), and this file implements what seems to be the worst one, even without the bug. ... The version in lib

Re: svn commit: r213308 - in head/lib/libc: amd64/gen i386/gen

2010-09-30 Thread Bruce Evans
On Thu, 30 Sep 2010, Dimitry Andric wrote: Log: Retire the amd64 and i386 specific inline assembly versions of ldexp.c, as they are slower than the generic version in C, at least on modern hardware. This leaves us with just five implementations. Suggested by: bde Approved by: rpaulo (m

Re: svn commit: r213326 - head/lib/libc/i386/string

2010-10-01 Thread Bruce Evans
On Fri, 1 Oct 2010, Dimitry Andric wrote: On 2010-10-01 15:22, Roman Divacky wrote: there's "rep cmps" in bcmp.S and memcmp.S in both amd64/i386 they both have C counterparts, no idea how fast those are (they are going char by char). does this wisdom apply to those too? Well, these versions

Re: svn commit: r213337 - in head/lib/msun: amd64 i387

2010-10-01 Thread Bruce Evans
On Fri, 1 Oct 2010, Dimitry Andric wrote: Log: Use __FBSDID() instead of RCSID() in most .S files under lib/msun/i386, and one under lib/msun/amd64. This avoids adding the identifiers to the .text section, and moves them to the .comment section instead. Suggested by: bde Approved by: r

Re: svn commit: r213337 - in head/lib/msun: amd64 i387

2010-10-01 Thread Bruce Evans
On Sat, 2 Oct 2010, Bruce Evans wrote: ... Also, all except 11 files in msun/i387 and 1 file in msun/amd64 are missing a commented-out RCSID("$NetBSD...$") to indicated where they came from. I think most of the NetBSD ids were corrupted in the initial import when the id string was s

Re: svn commit: r213401 - head/sys/sys

2010-10-04 Thread Bruce Evans
On Mon, 4 Oct 2010, Poul-Henning Kamp wrote: Log: Certain static code analysis tools (FlexeLint being one) are very suspicious about 'l' and '1' being confused in numeric constants. The fear being that some old fart programmer might still think that he is using a Remmington Noiseless as inpu

Re: svn commit: r213568 - head/sys/boot/i386/gptboot

2010-10-08 Thread Bruce Evans
On Fri, 8 Oct 2010, Peter Holm wrote: Log: Ensure that a make from sys/boot does not pick up include files from /usr/include. Discussed with: kib Modified: head/sys/boot/i386/gptboot/Makefile Modified: head/sys/boot/i386/gptboot/Makefile ===

Re: svn commit: r213648 - head/sys/kern

2010-10-09 Thread Bruce Evans
On Sat, 9 Oct 2010, Andriy Gapon wrote: Log: panic_cpu variable should be volatile This is to prevent caching of its value in a register when it is checked and modified by multiple CPUs in parallel. Also, move the variable into the scope of the only function that uses it. Reviewed by:

Re: svn commit: r213643 - head/usr.bin/ar

2010-10-09 Thread Bruce Evans
On Sat, 9 Oct 2010, Erik Cederstrand wrote: Den 09/10/2010 kl. 07.43 skrev Ben Kaduk: On Sat, Oct 9, 2010 at 1:31 AM, Tim Kientzle wrote: Log: Add -D (deterministic) option to ar. When set, it forces all timestamps and owners to zero and modes to 0644. Useful for producing libraries that

Re: svn commit: r213664 - in head/sys: fs/cd9660 fs/hpfs fs/msdosfs fs/ntfs gnu/fs/reiserfs kern sys ufs/ffs ufs/ufs

2010-10-12 Thread Bruce Evans
On Sun, 10 Oct 2010, Konstantin Belousov wrote: Log: The r184588 changed the layout of struct export_args, causing an ABI breakage for old mount(2) syscall, since most struct _args embed export_args. The mount(2) is supposed to provide ABI compatibility for pre-nmount mount(8) binaries, so r

Re: svn commit: r213648 - head/sys/kern

2010-10-12 Thread Bruce Evans
On Wed, 13 Oct 2010, Gennady Proskurin wrote: On Sat, Oct 09, 2010 at 12:48:50PM +0300, Andriy Gapon wrote: on 09/10/2010 12:33 Bruce Evans said the following: On Sat, 9 Oct 2010, Andriy Gapon wrote: [>]*... Now, why don't the partial memory barriers prevent caching the variable?

Re: svn commit: r213725 - head/sys/fs/devfs

2010-10-12 Thread Bruce Evans
On Tue, 12 Oct 2010, Jaakko Heinonen wrote: Log: Format prototypes to follow style(9) more closely. Discussed with:kib, phk Thanks, but style(9) says "The kernel has a name associated with parameter types [sic]", and the old prototypes mostly used named parameters. [The reason for

Re: svn commit: r213744 - head/bin/sh

2010-10-12 Thread Bruce Evans
On Tue, 12 Oct 2010, David E. O'Brien wrote: Log: If DEBUG is 3 or greater, disable STATICization of functions. Also correct the documented location of the trace file. Private functions should always be static, which no `#define STATIC static' hack to control this, but there are compiler bug

Re: svn commit: r213643 - head/usr.bin/ar

2010-10-12 Thread Bruce Evans
On Sun, 10 Oct 2010, Erik Cederstrand wrote: Den 10/10/2010 kl. 00.11 skrev Bruce Evans: On Sat, 9 Oct 2010, Erik Cederstrand wrote: Thanks! Has anyone looked at the feasibility of setting AR?=ar -D in sys.mk? I will probably try this when I get my scratch box up again. I hope not. The

Re: svn commit: r213744 - head/bin/sh

2010-10-12 Thread Bruce Evans
On Tue, 12 Oct 2010, David O'Brien wrote: On Wed, Oct 13, 2010 at 02:18:33PM +1100, Bruce Evans wrote: On Tue, 12 Oct 2010, David E. O'Brien wrote: Log: If DEBUG is 3 or greater, disable STATICization of functions. Also correct the documented location of the trace file. Private

Re: svn commit: r213793 - in head/sys/dev: ce cp

2010-10-13 Thread Bruce Evans
On Wed, 13 Oct 2010, Jung-uk Kim wrote: On Wednesday 13 October 2010 01:27 pm, Roman Divacky wrote: Modified: head/sys/dev/ce/if_ce.c = = --- head/sys/dev/ce/if_ce.c Wed Oct 13 17:16:08 2010(r213792) +++ head

Re: svn commit: r213744 - head/bin/sh

2010-10-13 Thread Bruce Evans
On Wed, 13 Oct 2010, John Baldwin wrote: On Wednesday, October 13, 2010 12:29:27 am Bruce Evans wrote: On Tue, 12 Oct 2010, David O'Brien wrote: On Wed, Oct 13, 2010 at 02:18:33PM +1100, Bruce Evans wrote: ... Of course, debugging and profiling are magic, but I don't want to hav

Re: svn commit: r213793 - in head/sys/dev: ce cp

2010-10-14 Thread Bruce Evans
On Thu, 14 Oct 2010, Jung-uk Kim wrote: On Wednesday 13 October 2010 09:16 pm, Bruce Evans wrote: On Wed, 13 Oct 2010, Jung-uk Kim wrote: ... I think the attached patch should do. % Index: sys/dev/ce/if_ce.c % === % --- sys/dev

Re: svn commit: r213643 - head/usr.bin/ar

2010-10-14 Thread Bruce Evans
On Thu, 14 Oct 2010, Erik Cederstrand wrote: Den 13/10/2010 kl. 05.55 skrev Bruce Evans: I also don't like distributions that stamp every file with their release build time (or maybe a little later, with a single release time). How would do you prevent clobbering metadata outside of arc

Re: svn commit: r213985 - head/sys/sparc64/sparc64

2010-10-18 Thread Bruce Evans
On Tue, 19 Oct 2010, Alexander Motin wrote: Marius Strobl wrote: On Mon, Oct 18, 2010 at 05:05:24PM -0400, John Baldwin wrote: On Monday, October 18, 2010 4:52:24 pm Marius Strobl wrote: AFAICT this is not true; intr_event_handle() in sys/kern/kern_intr.c is what enters a critical section and

Re: svn commit: r214137 - head/usr.bin/unzip

2010-10-21 Thread Bruce Evans
On Thu, 21 Oct 2010, Gleb Smirnoff wrote: Log: Make it possible to read input from stdin. Without this change I don't see a way to unpack a multivolume archive without wasting disk space for a temporary file. What's wrong with the canonical "cat foo*.zip | unzip /dev/stdin"? This is bett

Re: svn commit: r214431 - head/bin/rm

2010-10-27 Thread Bruce Evans
On Wed, 27 Oct 2010, Xin LI wrote: I think what really defeats -P is the fact that the file system or underlying data storage would not overwrite data on a file at sync(). COW is of course one of the case, journaling MAY defeat -P but is not guaranteed. FS with variable block size - I believe t

Re: svn commit: r214457 - in head/sys: amd64/amd64 conf i386/i386 x86/x86

2010-10-28 Thread Bruce Evans
On Thu, 28 Oct 2010, John Baldwin wrote: On Thursday, October 28, 2010 12:31:39 pm Attilio Rao wrote: Log: Merge nexus.c from amd64 and i386 to x86 subtree. ... == --- head/sys/i386/i386/nexus.c Thu Oct 28 07:5

Re: svn commit: r214510 - in head: include lib/libc/gen sys/kern

2010-10-30 Thread Bruce Evans
On Sat, 30 Oct 2010, Pawel Jakub Dawidek wrote: On Fri, Oct 29, 2010 at 01:31:10PM +, David Xu wrote: Log: Add sysctl kern.sched.cpusetsize to export the size of kernel cpuset, also add sysconf() key _SC_CPUSET_SIZE to get sysctl value. Submitted by: gcooper [...] +#ifdef _SC_CPUSE

Re: svn commit: r214817 - head/sys/teken

2010-11-05 Thread Bruce Evans
On Fri, 5 Nov 2010, Ed Schouten wrote: Log: Partially implement the mysterious cons25 \e[x escape sequence. CSI x is not mysterious. It is from pccons in 386BSD (probably from Net/2, since pccons is also in 4.4BSD). I think it came from pc3 originally. It is still in pccons in NetBSD, at l

Re: svn commit: r215237 - head/lib/msun/src

2010-11-14 Thread Bruce Evans
On Mon, 15 Nov 2010, Alexander Best wrote: also it seems one of the regression tests in tools/regression/lib/msun fails (assert tripped): test-lrint. I get this on amd64, and lots more failures starting with csqrt() on i386. Here is the output of make >foo 2>&1, after adding "set +e; " to the

Re: svn commit: r215304 - head/sys/kern

2010-11-14 Thread Bruce Evans
On Sun, 14 Nov 2010, Bruce Cran wrote: Log: Fix some more style(9) issues. Better, but still has style bug(s) on almost every changed line... Modified: head/sys/kern/kern_proc.c == --- head/sys/kern/kern_proc.c Su

Re: svn commit: r215281 - head/sys/kern

2010-11-14 Thread Bruce Evans
On Sun, 14 Nov 2010, Bruce Cran wrote: Log: Add some descriptions to sys/kern sysctls. Modified: head/sys/kern/kern_tc.c == --- head/sys/kern/kern_tc.c Sun Nov 14 05:05:41 2010(r215280) +++ head/sys/kern/

Re: svn commit: r215237 - head/lib/msun/src

2010-11-15 Thread Bruce Evans
On Sat, 13 Nov 2010, Alexander Best wrote: thank you very much for fixing this long outstanding issue. you might want to have a look at [1], where two more issues have been reported. [1] http://mailman.oakapple.net/pipermail/numeric-interest/2010-September/thread.html These are either featur

<    1   2   3   4   5   6   7   8   9   10   >