Re: svn commit: r331605 - head/sys/vm

2018-03-27 Thread Bruce Evans
On Tue, 27 Mar 2018, Jeff Roberson wrote: Log: Move vm_ndomains to vm.h where it can be used with a single header include rather than requiring a half-dozen. Many non-vm files may want to know the number of valid domains. Shouldn't it go in vm_extern.h? What is the point of having vm_exte

Re: svn commit: r327056 - in head/sys: kern sys x86/acpica x86/x86

2018-04-02 Thread Bruce Evans
On Mon, 2 Apr 2018, Andriy Gapon wrote: On 21/12/2017 11:17, Bruce Evans wrote: Author: bde Date: Thu Dec 21 09:17:48 2017 New Revision: 327056 URL: https://svnweb.freebsd.org/changeset/base/327056 Log: Use resume_cpus() instead of restart_cpus() to resume from ACPI suspension. Bruce, do

Re: svn commit: r332073 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include x86/include x86/x86

2018-04-05 Thread Bruce Evans
On Thu, 5 Apr 2018, [UTF-8] Roger Pau Monn?? wrote: Log: x86: improve reservation of AP trampoline memory This has lots of style bugs. Mainly changing the KNF spelling of 'unsigned' as u_int to the verbose 'unsigned int' in code that used to be careful to use the KNF spelling. Bruce

Re: svn commit: r332072 - head/sys/sys

2018-04-05 Thread Bruce Evans
On Thu, 5 Apr 2018, [UTF-8] Roger Pau Monn?? wrote: Log: introduce GiB and MiB macros This macros convert from GiB or MiB into bytes. This is undocumented namspace pollution with bad names and worse types. The better names GB and MB would be more likely to conflicted with code not written

Re: svn commit: r332072 - head/sys/sys

2018-04-05 Thread Bruce Evans
On Thu, 5 Apr 2018, Warner Losh wrote: On Thu, Apr 5, 2018 at 9:46 AM, Roger Pau Monn?? wrote: On Thu, Apr 05, 2018 at 09:32:57AM -0600, Ian Lepore wrote: On Thu, 2018-04-05 at 14:31 +, Roger Pau Monn?? wrote: Log: introduce GiB and MiB macros ... +/* Unit conversion macros. */ +#defi

Re: svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86

2018-04-06 Thread Bruce Evans
On Fri, 6 Apr 2018, [UTF-8] Roger Pau Monn?? wrote: Log: remove GiB/MiB macros from param.h And instead define them in the files where they are used. Requested by: bde Thanks, but these files have a negative need for the macros. Modified: head/sys/amd64/amd64/mp_machdep.c ==

Re: svn commit: r331369 - head/sys/vm

2018-04-07 Thread Bruce Evans
On Sat, 7 Apr 2018, Cy Schubert wrote: In message <201803230615.w2n6ftmj040...@slippy.cwsent.com>, Cy Schubert writes: In message <20180323150709.h...@besplex.bde.org>, Bruce Evans writes: On Thu, 22 Mar 2018, Jeff Roberson wrote: On Thu, 22 Mar 2018, Cy Schubert wrote: It br

Re: svn commit: r332395 - head/sys/kern

2018-04-11 Thread Bruce Evans
On Tue, 10 Apr 2018, Ian Lepore wrote: URL: https://svnweb.freebsd.org/changeset/base/332395 Log: Use explicit_bzero() when cleaning values out of the kernel environment. Sometimes the values contain geli passphrases being communicated from loader(8) to the kernel, and some day the compiler

Re: svn commit: r332860 - head/sys/kern

2018-04-21 Thread Bruce Evans
On Sat, 21 Apr 2018, Jonathan T. Looney wrote: Log: When running with INVARIANTS, the kernel contains extra checks. However, these assumptions may not hold true once we've panic'd. Therefore, the checks hold less value after a panic. Additionally, if one of the checks fails while we are al

Re: svn commit: r333010 - head/sys/mips/mips

2018-04-27 Thread Bruce Evans
On Fri, 27 Apr 2018, John Baldwin wrote: On Thursday, April 26, 2018 09:29:30 AM Ian Lepore wrote: On Thu, 2018-04-26 at 19:01 +0800, Li-Wen Hsu wrote: On Thu, Apr 26, 2018 at 7:59 AM, Ian Lepore wrote: On Wed, 2018-04-25 at 19:46 +, Li-Wen Hsu wrote: Author: lwhsu (ports committer) D

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

2018-05-04 Thread Bruce Evans
On Fri, 4 May 2018, Conrad Meyer wrote: On Fri, May 4, 2018 at 8:53 AM, Brooks Davis wrote: On Fri, May 04, 2018 at 04:00:48AM +, Mateusz Guzik wrote: Author: mjg Date: Fri May 4 04:00:48 2018 New Revision: 333240 URL: https://svnweb.freebsd.org/changeset/base/333240 Log: Allow __buil

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

2018-05-04 Thread Bruce Evans
On Sat, 5 May 2018, Mateusz Guzik wrote: On Fri, May 4, 2018 at 5:53 PM, Brooks Davis wrote: On Fri, May 04, 2018 at 04:00:48AM +, Mateusz Guzik wrote: Author: mjg Date: Fri May 4 04:00:48 2018 New Revision: 333240 URL: https://svnweb.freebsd.org/changeset/base/333240 Log: Allow __bu

Re: svn commit: r333242 - head/sys/kern

2018-05-04 Thread Bruce Evans
On Fri, 4 May 2018, John Baldwin wrote: On Friday, May 04, 2018 06:51:02 AM Matt Macy wrote: Author: mmacy Date: Fri May 4 06:51:01 2018 New Revision: 333242 URL: https://svnweb.freebsd.org/changeset/base/333242 Log: `dup1_processes -t 96 -s 5` on a dual 8160 x dup_before + dup_after

Re: svn commit: r333266 - head/sys/amd64/amd64

2018-05-04 Thread Bruce Evans
On Fri, 4 May 2018, Warner Losh wrote: While i wholeheartedly agree, an earlier commit explained why in this case. It allows the compiler to inline for small copies. [This should have been killfiled due to top-posting.] No, it has nothing to do with that. The compiler can inline either bcopy

Re: svn commit: r333266 - head/sys/amd64/amd64

2018-05-04 Thread Bruce Evans
On Fri, 4 May 2018, Warner Losh wrote: On Fri, May 4, 2018 at 5:12 PM, Mateusz Guzik wrote: On Sat, May 5, 2018 at 12:58 AM, Steven Hartland < steven.hartl...@multiplay.co.uk> wrote: Can we get the why in commit messages please? This sort of message doesnt provide anything more that can be

Re: svn commit: r333265 - head/sys/sys

2018-05-04 Thread Bruce Evans
On Fri, 4 May 2018, Mateusz Guzik wrote: Log: Allow the compiler to use __builtin_memcpy In particular this allows the compiler to avoid heavy-handed machinery if the to be copied buffer is small. Reviewed by: jhb Bugs in this: Modified: head/sys/sys/systm.h =

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

2018-05-05 Thread Bruce Evans
On Sat, 5 May 2018, Mateusz Guzik wrote: On Sat, May 5, 2018 at 2:38 AM, Bruce Evans wrote: I don't believe the claimed speeding of using the optimized bcopy() in cpu_fetch_sycall_args() on amd64 (r333241). This changes the copy size from a variable to 6*8 bytes. It is claimed to spe

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

2018-05-06 Thread Bruce Evans
On Sat, 5 May 2018, Mateusz Guzik wrote: On Sat, May 5, 2018 at 2:00 PM, Alexey Dokuchaev wrote: On Sat, May 05, 2018 at 10:38:29AM +1000, Bruce Evans wrote: ... Summary: this change wouldn't have passed my review. I have used similar changes for 15-20 years but never made them produ

Re: svn commit: r333324 - in head/sys: amd64/amd64 conf

2018-05-07 Thread Bruce Evans
On Mon, 7 May 2018, Mateusz Guzik wrote: Log: amd64: replace libkern's memset and memmove with assembly variants memmove is repurposed bcopy (arguments swapped, return value added) The libkern variant is a wrapper around bcopy, so this is a big improvement. This is a tiny improvement, per

Re: svn commit: r333324 - in head/sys: amd64/amd64 conf

2018-05-07 Thread Bruce Evans
On Tue, 8 May 2018, Bruce Evans wrote: On Mon, 7 May 2018, Mateusz Guzik wrote: Log: amd64: replace libkern's memset and memmove with assembly variants ... memset is repurposed memcpy. The librkern variant is doing fishy stuff, including branching on 0 and calling bzero. You mean th

Re: svn commit: r333344 - in head/sys: kern sys

2018-05-07 Thread Bruce Evans
On Mon, 7 May 2018, Mateusz Guzik wrote: Log: Inlined sched_userret. The tested condition is rarely true and it induces a function call on each return to userspace. Bumps getuid rate by about 1% on Broadwell. ... Modified: head/sys/kern/sched_4bsd.c

Re: svn commit: r333461 - head/sys/amd64/amd64

2018-05-10 Thread Bruce Evans
On Thu, 10 May 2018, Konstantin Belousov wrote: Log: Make fpusave() and fpurestore() on amd64 ifuncs. From now on, linking amd64 kernel requires either lld or newer ld.bfd. This breaks building with gcc: XX cc1: warnings being treated as errors XX ../../../amd64/amd64/fpu.c:195: warning: '

Re: svn commit: r333461 - head/sys/amd64/amd64

2018-05-10 Thread Bruce Evans
On Thu, 10 May 2018, Konstantin Belousov wrote: On Fri, May 11, 2018 at 03:31:46AM +1000, Bruce Evans wrote: On Thu, 10 May 2018, Konstantin Belousov wrote: Log: Make fpusave() and fpurestore() on amd64 ifuncs. From now on, linking amd64 kernel requires either lld or newer ld.bfd. This

Re: svn commit: r333482 - head/usr.bin/expand

2018-05-11 Thread Bruce Evans
On Fri, 11 May 2018, Eitan Adler wrote: Log: [expand] add __dead2 annotation to usage Declaring static functions as __dead2 has no good effect, but reduces portability and is a style bug. Compilers have always been able to see inside static functions and determine if they return. Primitive

Re: svn commit: r318262 - head/usr.sbin/mountd

2017-05-13 Thread Bruce Evans
On Sun, 14 May 2017, Rick Macklem wrote: Log: Change the default uid/gid values for nobody/nogroup to 65534/65533. The default values found in /etc/passwd and /etc/group are 65534, 65533. In mountd.c, the defaults were -2, which was 65534 back when uid_t was 16bits. Without this patch, a fi

Re: svn commit: r319052 - in head/sys/modules: linux linux64

2017-05-28 Thread Bruce Evans
On Sun, 28 May 2017, Dmitry Chagin wrote: Log: Strip _binary_linux_locore_o_size from ${VDSO}.so as it is a low absolute symbol, and this breaks symbol lookup in ddb. Requested by: bde@ Thanks. This works because the symbol is auto-generated by the linker from the name of a file and not

Re: svn commit: r319507 - head/sys/fs/msdosfs

2017-06-03 Thread Bruce Evans
On Fri, 2 Jun 2017, Ed Maste wrote: Log: msdosfs: use mem{cpy,move,set} instead of bcopy,bzero This somewhat simplifies use of msdosfs code in userland (for makefs), reduces diffs with NetBSD and is standard C as of C89. This is a style bug in the kernel. The kernel should use the standar

Re: svn commit: r319507 - head/sys/fs/msdosfs

2017-06-05 Thread Bruce Evans
On Sun, 4 Jun 2017, Bryan Drewery wrote: On 6/4/17 4:27 PM, Ed Maste wrote: On 4 June 2017 at 14:06, Bryan Drewery wrote: In r189170. It seems to me we should change systm.h back to a macro #define memmove(dst, src, len) bcopy((src), (dst), (len)) Note that they're not quite equivalent: me

Re: svn commit: r319720 - head/sys/dev/vt

2017-06-11 Thread Bruce Evans
On Sat, 10 Jun 2017, Konstantin Belousov wrote: On Sat, Jun 10, 2017 at 09:33:48AM -0700, Jonathan Looney wrote: Hi Konstantin, On Sat, Jun 10, 2017 at 2:12 AM, Konstantin Belousov wrote: No, acquire is only specified for loads, and release for stores. In other words, on some hypothetical l

Re: svn commit: r319720 - head/sys/dev/vt

2017-06-11 Thread Bruce Evans
On Sun, 11 Jun 2017, Konstantin Belousov wrote: On Sun, Jun 11, 2017 at 07:53:47PM +1000, Bruce Evans wrote: On Sat, 10 Jun 2017, Konstantin Belousov wrote: On Sat, Jun 10, 2017 at 09:33:48AM -0700, Jonathan Looney wrote: Hi Konstantin, On Sat, Jun 10, 2017 at 2:12 AM, Konstantin Belousov

svn commit: r320805 - head/sys/dev/syscons/fonts

2017-07-08 Thread Bruce Evans
Author: bde Date: Sat Jul 8 15:01:55 2017 New Revision: 320805 URL: https://svnweb.freebsd.org/changeset/base/320805 Log: Add files to help manage the (vga) syscons mouse cursor. To mostly fix distortion of mouse cursors by non-square pixels, I needed 8 variants of the same cursor shape

svn commit: r320808 - head/sys/dev/syscons

2017-07-08 Thread Bruce Evans
Author: bde Date: Sat Jul 8 17:30:33 2017 New Revision: 320808 URL: https://svnweb.freebsd.org/changeset/base/320808 Log: Add many bitmaps (now there are 13) for mouse cursors and logic to try to choose the best one. The old 9x13 cursor was was sort of correct for CGA 640x200 text mode,

svn commit: r320829 - head/sys/dev/syscons

2017-07-09 Thread Bruce Evans
Author: bde Date: Sun Jul 9 12:13:37 2017 New Revision: 320829 URL: https://svnweb.freebsd.org/changeset/base/320829 Log: Move open coding of construction of attributes for cut regions and text cursors to functions so that it is easier to fix and improve. This commit doesn't fix anything ex

svn commit: r320869 - head/sys/dev/syscons

2017-07-10 Thread Bruce Evans
Author: bde Date: Mon Jul 10 09:00:35 2017 New Revision: 320869 URL: https://svnweb.freebsd.org/changeset/base/320869 Log: Fix attribute flipping for cut marking in pixel mode. The text-mode code was used, so the lightness bit was not flipped, so the flipping was unnecessarily null in some

Re: svn commit: r320900 - in head/sys: fs/cd9660 fs/ext2fs fs/fifofs fs/msdosfs fs/nandfs fs/nfsclient fs/smbfs fs/tmpfs ufs/ufs

2017-07-12 Thread Bruce Evans
On Tue, 11 Jul 2017, John Baldwin wrote: Log: Consistently use vop_stdpathconf() for default pathconf values. Update filesystems not currently using vop_stdpathconf() in pathconf VOPs to use vop_stdpathconf() for any configuration variables that do not have filesystem-specific values. vop_

Re: svn commit: r320803 - head/sbin/mount

2017-07-12 Thread Bruce Evans
On Tue, 11 Jul 2017, John Baldwin wrote: On Tuesday, July 11, 2017 02:35:15 PM Ian Lepore wrote: I think the docs on this are pretty clear... under -u it says: The set of options is determined by applying the options specified in the argument to -o and finally applying the -r or -w opt

Re: svn commit: r320901 - in head/sys: amd64/amd64 isa x86/isa

2017-07-12 Thread Bruce Evans
On Wed, 12 Jul 2017, Ian Lepore wrote: Log: Protect access to the AT realtime clock with its own mutex. The mutex protecting access to the registered realtime clock should not be overloaded to protect access to the atrtc hardware, which might not even be the registered rtc. More importantly

Re: svn commit: r320900 - in head/sys: fs/cd9660 fs/ext2fs fs/fifofs fs/msdosfs fs/nandfs fs/nfsclient fs/smbfs fs/tmpfs ufs/ufs

2017-07-13 Thread Bruce Evans
On Wed, 12 Jul 2017, John Baldwin wrote: On Wednesday, July 12, 2017 08:08:42 PM Bruce Evans wrote: On Tue, 11 Jul 2017, John Baldwin wrote: Log: Consistently use vop_stdpathconf() for default pathconf values. ... This is sort of backwards. Not many settings are the same for most file

Re: svn commit: r320803 - head/sbin/mount

2017-07-14 Thread Bruce Evans
On Thu, 13 Jul 2017, Rodney W. Grimes wrote: On Tuesday, July 11, 2017 02:35:15 PM Ian Lepore wrote: I think the docs on this are pretty clear... under -u it says: The set of options is determined by applying the options specified in the argument to -o and finally applying the -r or -w

Re: svn commit: r308443 - head/bin/hostname

2016-11-08 Thread Bruce Evans
On Tue, 8 Nov 2016, Renato Botelho wrote: On 8 Nov 2016, at 09:36, Marcelo Araujo wrote: Log: Add -d flag that prints domain only. PR:212875 Submitted by: Ben RUBSON Reviewed by: pi This has many style bugs. Modified: head/bin/hostname/hostname.1 head/bin/hostname/ho

Re: svn commit: r308614 - head/sys/conf

2016-11-13 Thread Bruce Evans
On Sun, 13 Nov 2016, Michal Meloun wrote: Log: Allow embeding DRM2 code into kernel. Thanks. It's usefull for development (for netboot) and it also helps to boot FreeBSD on some embeded platforms (where we must boot kernel directly, without standard boot loader). It is required for LIN

Re: svn commit: r309331 - head/usr.bin/locale

2016-11-30 Thread Bruce Evans
On Wed, 30 Nov 2016, Eric van Gyzen wrote: Log: Include limits.h for CHAR_MAX This was needed on stable/10. Apparently, sys/param.h supplies CHAR_MAX on head. Include limits.h anyway, for consistency, and because C says so. sys/param.actually supplies CHAR_MAX (undocumented namespace pol

Re: svn commit: r309364 - head/usr.bin/locale

2016-12-01 Thread Bruce Evans
On Thu, 1 Dec 2016, Eric van Gyzen wrote: Log: locale: fix buffer management Also, handle signed and unsigned chars, and more gracefully handle invalid input. Submitted by: bde in response to r309331 MFC after: 1 week Sponsored by: Dell EMC Thanks. Modified: head/usr.bin/locale

Re: svn commit: r309658 - head/sys/vm

2016-12-06 Thread Bruce Evans
On Tue, 6 Dec 2016, Mark Johnston wrote: Log: Provide dummy sysctls for v_cache_count and v_tcached. Some utilities (notably top(1)) exit if any of their input sysctls don't exist, and the removal of the above-mentioned PG_CACHE-related sysctls makes it difficult to run such utilities on di

Re: svn commit: r309658 - head/sys/vm

2016-12-07 Thread Bruce Evans
On Wed, 7 Dec 2016, Warner Losh wrote: On Wed, Dec 7, 2016 at 2:26 PM, Gleb Smirnoff wrote: On Tue, Dec 06, 2016 at 10:52:45PM +, Mark Johnston wrote: M> Author: markj M> Date: Tue Dec 6 22:52:45 2016 M> New Revision: 309658 M> URL: https://svnweb.freebsd.org/changeset/base/309658 M> M> L

Re: svn commit: r309676 - in head: bin/ps lib/libkvm sys/compat/freebsd32 sys/kern sys/sys usr.bin/procstat usr.bin/top

2016-12-07 Thread Bruce Evans
On Wed, 7 Dec 2016, Eric van Gyzen wrote: Log: Export the whole thread name in kinfo_proc kinfo_proc::ki_tdname is three characters shorter than thread::td_name. Add a ki_moretdname field for these three extra characters. Add the new field to kinfo_proc32, as well. Update all in-tree con

Re: svn commit: r309891 - head/sys/kern

2016-12-12 Thread Bruce Evans
On Mon, 12 Dec 2016, Edward Tomasz Napierala wrote: On 1212T1833, Konstantin Belousov wrote: On Mon, Dec 12, 2016 at 03:22:22PM +, Edward Tomasz Napierala wrote: Author: trasz Date: Mon Dec 12 15:22:21 2016 New Revision: 309891 URL: https://svnweb.freebsd.org/changeset/base/309891 Log:

Re: svn commit: r310045 - head/sys/ddb

2016-12-14 Thread Bruce Evans
On Tue, 13 Dec 2016, John Baldwin wrote: On Wednesday, December 14, 2016 12:18:12 AM John Baldwin wrote: Log: Use casts to force an unsigned comparison in db_search_symbol(). On all of our platforms, db_expr_t is a signed integer while db_addr_t is an unsigned integer value. db_search_

Re: svn commit: r310045 - head/sys/ddb

2016-12-14 Thread Bruce Evans
On Wed, 14 Dec 2016, Bruce Evans wrote: I fixed printing of negative offsets from the frame pointer on i386, but this is currently broken on i386 and never worked on other arches. DB_LARGE_VALUE_MIN has the old i386 value on all arches, but this is now wrong for i386 and never worked on other

Re: svn commit: r353103 - head/sys/net

2019-10-04 Thread Bruce Evans
On Fri, 4 Oct 2019, John Baldwin wrote: On 10/4/19 6:43 AM, Kyle Evans wrote: Author: kevans Date: Fri Oct 4 13:43:07 2019 New Revision: 353103 URL: https://svnweb.freebsd.org/changeset/base/353103 Log: tuntap(4): loosen up tunclose restrictions Realistically, this cannot work. We don't

Re: svn commit: r353640 - head/sys/kern

2019-10-23 Thread Bruce Evans
On Tue, 22 Oct 2019, Alan Somers wrote: On Wed, Oct 16, 2019 at 7:21 AM Andrew Turner wrote: Author: andrew Date: Wed Oct 16 13:21:01 2019 New Revision: 353640 URL: https://svnweb.freebsd.org/changeset/base/353640 Log: Stop leaking information from the kernel through timespec The timesp

Re: svn commit: r354076 - head/sys/dev/ow

2019-10-26 Thread Bruce Evans
On Fri, 25 Oct 2019, Andriy Gapon wrote: On 25/10/2019 18:46, Ian Lepore wrote: On Fri, 2019-10-25 at 15:38 +, Andriy Gapon wrote: Author: avg Date: Fri Oct 25 15:38:09 2019 New Revision: 354076 URL: https://svnweb.freebsd.org/changeset/base/354076 Log: owc_gpiobus_read_data: compare ti

Re: svn commit: r351319 - in head/usr.sbin/makefs: ffs msdos

2019-08-29 Thread Bruce Evans
On Wed, 21 Aug 2019, Ed Maste wrote: Author: emaste Date: Wed Aug 21 01:45:29 2019 New Revision: 351319 URL: https://svnweb.freebsd.org/changeset/base/351319 Log: makefs: use `char *` not `void *` for buf b_data, drop casts in msdos (The kernel uses caddr_t.) This is much better than churn

svn commit: r345585 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Wed Mar 27 18:03:34 2019 New Revision: 345585 URL: https://svnweb.freebsd.org/changeset/base/345585 Log: Fix accessing pixels under the mouse cursor: Reading of single pixels didn't look under the cursor. Copying of 1x1 bitmaps didn't look under the cursor for either

svn commit: r345637 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Thu Mar 28 09:51:37 2019 New Revision: 345637 URL: https://svnweb.freebsd.org/changeset/base/345637 Log: Oops, r345496 got the pointer args backwards for bcopy() in VGLClear for segmented modes. Also fix some style bugs in the 2 changed lines. libvgl uses a very non-KNF

svn commit: r345643 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Thu Mar 28 14:21:22 2019 New Revision: 345643 URL: https://svnweb.freebsd.org/changeset/base/345643 Log: Fix VGLLine() in depths > 8. It started truncating its color arg to 8 bits using plot() in r229415. The version in r229415 is also more than 3 times slower in segment

svn commit: r345639 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Thu Mar 28 12:28:29 2019 New Revision: 345639 URL: https://svnweb.freebsd.org/changeset/base/345639 Log: Fix VGLGetXY(), VGLSetXY() and VGLClear() for MEMBUFs in depths > 8. This depends on PixelBytes being properly initialized, which it is for all bitmaps constructed by

Re: svn commit: r345680 - head/sys/conf

2019-09-03 Thread Bruce Evans
On Thu, 28 Mar 2019, Ravi Pokala wrote: -Original Message- From: on behalf of Kyle Evans Date: 2019-03-28, Thursday at 21:00 To: , , Subject: svn commit: r345680 - head/sys/conf Author: kevans Date: Fri Mar 29 04:00:46 2019 New Revision: 345680 URL: https://svnweb.freebsd.org/chan

Re: svn commit: r345680 - head/sys/conf

2019-09-03 Thread Bruce Evans
On Fri, 29 Mar 2019, Alexey Dokuchaev wrote: On Fri, Mar 29, 2019 at 05:40:05PM +1100, Bruce Evans wrote: ... -optionsBOOT_TAG=\"---<>---\" +optionsBOOT_TAG=\"\" Useful variations are not always easy to invent. I usually just add 1 for numeric value

svn commit: r345695 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Fri Mar 29 15:20:48 2019 New Revision: 345695 URL: https://svnweb.freebsd.org/changeset/base/345695 Log: Fix races in mouse signal handling almost properly using the INTOFF/INTON method as in /bin/sh. We still do technically undefined things in the signal handler, but it

Re: svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
On Fri, 29 Mar 2019, Konstantin Belousov wrote: On Fri, Mar 29, 2019 at 03:57:09PM +, Bruce Evans wrote: Author: bde Date: Fri Mar 29 15:57:08 2019 New Revision: 345696 URL: https://svnweb.freebsd.org/changeset/base/345696 Log: Fix endless loops for handling SIGBUS and SIGSEGV

svn commit: r345698 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Fri Mar 29 16:30:19 2019 New Revision: 345698 URL: https://svnweb.freebsd.org/changeset/base/345698 Log: Fix restoring to graphics modes in VGLEnd(). Correct restoring was only attempted for mode 258 (800x600x4 P). (This was the only useful graphics mode supported in th

svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Fri Mar 29 15:57:08 2019 New Revision: 345696 URL: https://svnweb.freebsd.org/changeset/base/345696 Log: Fix endless loops for handling SIGBUS and SIGSEGV. r80270 has the usual wrong fix for unsafe signal handling -- just set a flag and return to let an event loop check

Re: svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
On Sat, 30 Mar 2019, Konstantin Belousov wrote: On Sat, Mar 30, 2019 at 03:24:40PM +1100, Bruce Evans wrote: On Fri, 29 Mar 2019, Konstantin Belousov wrote: On Fri, Mar 29, 2019 at 03:57:09PM +, Bruce Evans wrote: Author: bde Date: Fri Mar 29 15:57:08 2019 New Revision: 345696 URL

Re: svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
On Sun, 31 Mar 2019, Konstantin Belousov wrote: On Mon, Apr 01, 2019 at 12:04:45AM +1100, Bruce Evans wrote: Serial consoles are not always available. Better debuggers switch the screen mode as necessary. I recently noticed another mode switching problem. On i386, cycling through about 50

Re: svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
On Sun, 31 Mar 2019, Konstantin Belousov wrote: On Sun, Mar 31, 2019 at 10:27:54PM +1100, Bruce Evans wrote: On Sat, 30 Mar 2019, Konstantin Belousov wrote: On Sat, Mar 30, 2019 at 03:24:40PM +1100, Bruce Evans wrote: On Fri, 29 Mar 2019, Konstantin Belousov wrote: On Fri, Mar 29, 2019 at

Re: svn commit: r345807 - head/usr.bin/top

2019-09-03 Thread Bruce Evans
On Tue, 2 Apr 2019, Dimitry Andric wrote: Author: dim Date: Tue Apr 2 18:01:54 2019 New Revision: 345807 URL: https://svnweb.freebsd.org/changeset/base/345807 Log: Fix regression in top(1) after r344381, causing informational messages to no longer be displayed. This was because the reimplem

Re: svn commit: r345853 - head/usr.bin/rctl

2019-09-03 Thread Bruce Evans
On Wed, 3 Apr 2019, Enji Cooper wrote: On Apr 3, 2019, at 1:37 PM, Mateusz Guzik wrote: Author: mjg Date: Wed Apr 3 20:37:14 2019 New Revision: 345853 URL: https://svnweb.freebsd.org/changeset/base/345853 Log: rctl: fix sysctl kern.racct.enable use after r341182 The value was changed from

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Bruce Evans
On Fri, 5 Apr 2019, Ed Maste wrote: On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: +static const u_char dot_name[] = { + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; +static const u_char dotdot_name[] = { + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; + Does it make s

svn commit: r346024 - head/usr.sbin/vidcontrol

2019-09-03 Thread Bruce Evans
Author: bde Date: Mon Apr 8 04:07:37 2019 New Revision: 346024 URL: https://svnweb.freebsd.org/changeset/base/346024 Log: Fix restoring the geometry when recovering from an error. Just restore the previous geometry, and don't do extra work to calculate the default geometry so as to reset t

svn commit: r346025 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Mon Apr 8 04:54:15 2019 New Revision: 346025 URL: https://svnweb.freebsd.org/changeset/base/346025 Log: Fix copying of MEMBUFs to MEMBUFs. This case was implemented by using the same code as the VIDBUF8 case, so it only worked for depths <= 8. The 2 directions for copying

Re: svn commit: r346176 - head/sys/sys

2019-09-03 Thread Bruce Evans
On Sat, 13 Apr 2019, Warner Losh wrote: Fix sbttons for values > 2s Add test against negative times. Add code to cope with larger values properly. Discussed with: bde@ (quite some time ago, for an earlier version) I am unhappy with previous attempted fixes in this area, and still have la

Re: svn commit: r346176 - head/sys/sys

2019-09-03 Thread Bruce Evans
On Sat, 13 Apr 2019, Bruce Evans wrote: On Sat, 13 Apr 2019, Warner Losh wrote: Fix sbttons for values > 2s Add test against negative times. Add code to cope with larger values properly. Discussed with: bde@ (quite some time ago, for an earlier version) I am unhappy with previ

svn commit: r346215 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Sun Apr 14 13:37:50 2019 New Revision: 346215 URL: https://svnweb.freebsd.org/changeset/base/346215 Log: For writing and reading single pixels, avoid some pessimizations for depths > 8. Add some smaller optimizations for these depths. Use a more generic method for all dep

svn commit: r346276 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Tue Apr 16 14:28:33 2019 New Revision: 346276 URL: https://svnweb.freebsd.org/changeset/base/346276 Log: Fix a variable name in r346215. Clearing of the right of the screen was broken, except it worked accidentally in most cases where the virtual screen is larger than the

svn commit: r346278 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:31:23 2019 New Revision: 346278 URL: https://svnweb.freebsd.org/changeset/base/346278 Log: Quick fix for slow clearing and context switches of large frame buffers with old kernels, by breaking the support for large frame buffers in the same way as for current

svn commit: r346280 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:52:04 2019 New Revision: 346280 URL: https://svnweb.freebsd.org/changeset/base/346280 Log: Sigh, r346279 was also a test version with the reduced size doubled (so it was actually double the full size in current kernels where the reduction is null, so overran t

svn commit: r346279 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:41:45 2019 New Revision: 346279 URL: https://svnweb.freebsd.org/changeset/base/346279 Log: Oops, r346278 committed a test version with the change annulled. Modified: head/lib/libvgl/main.c Modified: head/lib/libvgl/main.c ==

svn commit: r346416 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Fri Apr 19 20:29:49 2019 New Revision: 346416 URL: https://svnweb.freebsd.org/changeset/base/346416 Log: Fix copying of overlapping bitmaps. The cases of copying within the screen bitmap and within a single MEMBUF were broken when first source line is before the first dest

svn commit: r346488 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Sun Apr 21 16:17:35 2019 New Revision: 346488 URL: https://svnweb.freebsd.org/changeset/base/346488 Log: Use a shadow buffer and never read from the frame buffer. Remove large slow code for reading from the frame buffer. Reading from the frame buffer is usually much slo

svn commit: r346454 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Sat Apr 20 20:29:03 2019 New Revision: 346454 URL: https://svnweb.freebsd.org/changeset/base/346454 Log: Make libvgl mostly work without superuser privilege in direct modes by not doing any unnecessary PIO instructions or refusing to start when the i/o privilege needed for

svn commit: r346486 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Sun Apr 21 10:33:09 2019 New Revision: 346486 URL: https://svnweb.freebsd.org/changeset/base/346486 Log: Fix missing restoring of the mouse cursor position, the border color and the blank state after a screen switch. Modified: head/lib/libvgl/main.c head/lib/libvgl/mouse

Re: svn commit: r346554 - head/sys/netinet

2019-09-03 Thread Bruce Evans
On Mon, 22 Apr 2019, Bjoern A. Zeeb wrote: On 22 Apr 2019, at 14:20, Bjoern A. Zeeb wrote: Log: Remove some excessive brackets. No functional change. But it includes a stye bug; sorry; I had re-indented the lines to validate the change. Ill remedy this with the follow-up commit which w

svn commit: r346641 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Wed Apr 24 16:03:35 2019 New Revision: 346641 URL: https://svnweb.freebsd.org/changeset/base/346641 Log: Avoid hiding and unhiding the mouse cursor when copying bitmaps to the screen. Instead, copy a merged bitmap 1 line at a time. This fixes flashing of the cursor and

svn commit: r346580 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Mon Apr 22 19:31:16 2019 New Revision: 346580 URL: https://svnweb.freebsd.org/changeset/base/346580 Log: Fix mouse cursor coloring in depths > 8 (previously, a hack that only worked right for white interiors and black borders was used). Advertise this by changing the defau

svn commit: r346639 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Wed Apr 24 15:35:29 2019 New Revision: 346639 URL: https://svnweb.freebsd.org/changeset/base/346639 Log: Refactor mouse freezing and fix some minor bugs. VGLMouseFreeze() now only defers mouse signals and leaves it to higher levels to hide and unhide the mouse cursor if

svn commit: r346631 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Wed Apr 24 13:15:56 2019 New Revision: 346631 URL: https://svnweb.freebsd.org/changeset/base/346631 Log: Fix some races and screeen clearing in VGLEnd(). The mouse signal SIGUSR2 was not turned off for normal termination and in some other cases. Thus mouse signals arriv

Re: svn commit: r351659 - in head: contrib/libc++/include contrib/netbsd-tests/lib/libc/ssp gnu/lib/libssp include lib/libc/stdio

2019-09-13 Thread Bruce Evans
On Sun, 1 Sep 2019, Cy Schubert wrote: I'm replying to this reply since I lost the original mail. In message <201909011612.x81gc5dw097...@repo.freebsd.org>, Ed Maste writes: Author: emaste Date: Sun Sep 1 16:12:05 2019 New Revision: 351659 URL: https://svnweb.freebsd.org/changeset/base/351659

Re: svn commit: r351700 - head/lib/libc/string

2019-09-20 Thread Bruce Evans
On Mon, 2 Sep 2019, Ed Maste wrote: Author: emaste Date: Mon Sep 2 13:56:44 2019 New Revision: 351700 URL: https://svnweb.freebsd.org/changeset/base/351700 Log: libc: Use musl's optimized memchr Parentheses added to HASZERO macro to avoid a GCC warning. Reviewed by: kib, mjg Obtained f

Re: svn commit: r352661 - head/sys/netinet/tcp_stacks

2019-09-24 Thread Bruce Evans
On Tue, 24 Sep 2019, Randall Stewart wrote: Log: lets put (void) in a couple of functions to keep older platforms that are stuck with gcc happy (ppc). The changes are needed in both bbr and rack. You mean "Don't use K&R declarations. clang is too broken to warn about K&R declarations even

Re: svn commit: r351700 - head/lib/libc/string

2019-09-25 Thread Bruce Evans
On Wed, 25 Sep 2019, Ed Maste wrote: On Fri, 20 Sep 2019 at 08:14, Bruce Evans wrote: Optimizing this function [memchr] is especially unimportant, Why? Because it is almost never used, and most of its uses are unimportant. It is used a whole 26 times in all of /usr/src/*bin: - sh/exec.c

Re: svn commit: r352795 - head/lib/libc/sys

2019-09-27 Thread Bruce Evans
On Fri, 27 Sep 2019, Konstantin Belousov wrote: On Fri, Sep 27, 2019 at 08:32:20PM +0200, Mateusz Guzik wrote: On 9/27/19, Warner Losh wrote: Author: imp Date: Fri Sep 27 16:11:47 2019 New Revision: 352795 URL: https://svnweb.freebsd.org/changeset/base/352795 Log: Document varadic args as

Re: svn commit: r352846 - head/lib/libc/sys

2019-09-29 Thread Bruce Evans
On Sun, 29 Sep 2019, Konstantin Belousov wrote: On Sat, Sep 28, 2019 at 05:15:48PM +, Warner Losh wrote: Author: imp Date: Sat Sep 28 17:15:48 2019 New Revision: 352846 URL: https://svnweb.freebsd.org/changeset/base/352846 Log: Revert the mode_t -> int changes and add a warning in the BU

Re: svn commit: r352795 - head/lib/libc/sys

2019-10-02 Thread Bruce Evans
On Tue, 1 Oct 2019, Ed Maste wrote: On Tue, 1 Oct 2019 at 12:23, Brooks Davis wrote: This isn't true with CHERI and as a result I've moved the variadic argument handling (except for syscall() and __syscall()) into libc. My grep found: open, openat, fcntl, semsys, msgsys, shmsys Is that the

Re: svn commit: r348419 - in head: crypto/heimdal/lib/ipc share/man/man4 sys/compat/linux sys/kern sys/sys usr.sbin/mountd

2019-06-04 Thread Bruce Evans
On Tue, 4 Jun 2019, Gleb Smirnoff wrote: On Thu, May 30, 2019 at 02:24:27PM +, Dmitry Chagin wrote: D> Author: dchagin D> ... D> Log: D> Complete LOCAL_PEERCRED support. Cache pid of the remote process in the D> struct xucred. Do not bump XUCRED_VERSION as struct layout is not changed. D

Re: svn commit: r348843 - head/sys/vm

2019-06-09 Thread Bruce Evans
On Mon, 10 Jun 2019, Doug Moore wrote: Log: There are times when a len==0 parameter to mmap is okay. But on a 32-bit machine, a len parameter just a few bytes short of 4G, rounded up to a page boundary and hitting zero then, is not okay. Return failure in that case. Some overflows still oc

Re: svn commit: r348843 - head/sys/vm

2019-06-10 Thread Bruce Evans
On Mon, 10 Jun 2019, Shawn Webb wrote: On Mon, Jun 10, 2019 at 03:07:11AM +, Doug Moore wrote: ... Log: There are times when a len==0 parameter to mmap is okay. But on a 32-bit machine, a len parameter just a few bytes short of 4G, rounded up to a page boundary and hitting zero then,

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Bruce Evans
On Mon, 10 Jun 2019, Ian Lepore wrote: On Mon, 2019-06-10 at 07:49 -0600, Warner Losh wrote: On Mon, Jun 10, 2019, 7:44 AM Conrad Meyer wrote: On Mon, Jun 10, 2019 at 2:10 AM T??l Coosemans wrote: On Mon, 10 Jun 2019 05:28:04 + (UTC) Dmitry Chagin wrote: ... URL: https://svnweb.freeb

Re: svn commit: r349029 - head/sys/kern

2019-06-14 Thread Bruce Evans
On Fri, 14 Jun 2019, Alexander Motin wrote: Log: Update td_runtime of running thread on each statclock(). Normally td_runtime is updated on context switch, but there are some kernel threads that due to high absolute priority may run for many seconds without context switches (yes, that is ba

Re: svn commit: r349029 - head/sys/kern

2019-06-14 Thread Bruce Evans
On Fri, 14 Jun 2019, Alexander Motin wrote: On 14.06.2019 08:58, Bruce Evans wrote: On Fri, 14 Jun 2019, Alexander Motin wrote: Log: ??Update td_runtime of running thread on each statclock(). ??Normally td_runtime is updated on context switch, but there are some kernel ??threads that due to

<    1   2   3   4   5   6   7   8   9   10   >