Re: svn commit: r364946 - head/sys/kern

2020-08-29 Thread Mateusz Guzik
This crashes on boot for me: atal trap 12: page fault while in kernel mode cpuid = 0; apic id = 00 fault virtual address = 0x0 fault code = supervisor read data, page not present instruction pointer = 0x20:0x805b0a7f stack pointer = 0x28:0xfe002366a7f0 fram

Re: svn commit: r364944 - head/sys/kern

2020-08-29 Thread Hans Petter Selasky
On 2020-08-29 06:29, Warner Losh wrote: +#define DEVCTL_BUFFER (1024 - sizeof(void *)) struct dev_event_info { - char *dei_data; STAILQ_ENTRY(dev_event_info) dei_link; + char dei_data[DEVCTL_BUFFER]; }; Maybe add: CTASSERT(sizeof(struct dev_event_info) == 1024); Not su

Re: svn commit: r364941 - in head/sys: net net/route netinet netinet6

2020-08-29 Thread Hartmann, O.
On Fri, 28 Aug 2020 22:50:21 + (UTC) "Alexander V. Chernikov" wrote: > Author: melifaro > Date: Fri Aug 28 22:50:20 2020 > New Revision: 364941 > URL: https://svnweb.freebsd.org/changeset/base/364941 > > Log: > Move net/route/shared.h definitions to net/route/route_var.h. > > No funct

svn commit: r364949 - head/sys/kern

2020-08-29 Thread Warner Losh
Author: imp Date: Sat Aug 29 09:59:52 2020 New Revision: 364949 URL: https://svnweb.freebsd.org/changeset/base/364949 Log: Avoid NULL pointer dereferences Add back NULL pointer checks accidentally dropped in r364946. We need to append a NUL character when that happens. Modified: head/s

Re: svn commit: r364946 - head/sys/kern

2020-08-29 Thread Warner Losh
On Sat, Aug 29, 2020 at 1:09 AM Mateusz Guzik wrote: > This crashes on boot for me: > I wasn't able to get it to crash on boot for me, but I was able to recreate it. Fixed in r364949. I think it didn't crash on boot for me because kldxref failed due to the segment thing so devmatch didn't run wh

Re: svn commit: r364946 - head/sys/kern

2020-08-29 Thread Michal Meloun
On 29.08.2020 12:04, Warner Losh wrote: > On Sat, Aug 29, 2020 at 1:09 AM Mateusz Guzik wrote: > >> This crashes on boot for me: >> > > I wasn't able to get it to crash on boot for me, but I was able to recreate > it. It crashed on ofw based systems where some enumerated devices have not a su

Re: svn commit: r364946 - head/sys/kern

2020-08-29 Thread Warner Losh
On Sat, Aug 29, 2020 at 4:38 AM Michal Meloun wrote: > > > On 29.08.2020 12:04, Warner Losh wrote: > > On Sat, Aug 29, 2020 at 1:09 AM Mateusz Guzik wrote: > > > >> This crashes on boot for me: > >> > > > > I wasn't able to get it to crash on boot for me, but I was able to > recreate > > it. > I

svn commit: r364950 - head/sys/net/route

2020-08-29 Thread Alexander V. Chernikov
Author: melifaro Date: Sat Aug 29 11:04:24 2020 New Revision: 364950 URL: https://svnweb.freebsd.org/changeset/base/364950 Log: Fix build with RADIX_MPATH. Reported by: Hartmann, O Modified: head/sys/net/route/route_ctl.c Modified: head/sys/net/route/route_ctl.c ==

svn commit: r364951 - head/sys/kern

2020-08-29 Thread Warner Losh
Author: imp Date: Sat Aug 29 11:18:10 2020 New Revision: 364951 URL: https://svnweb.freebsd.org/changeset/base/364951 Log: Use sbuf_cat instead of sbuf_cpy sbuf_cpy doesn't work with sysctl sbufs because of the drain function. Modified: head/sys/kern/subr_bus.c Modified: head/sys/kern/s

Re: svn commit: r364946 - head/sys/kern

2020-08-29 Thread Michal Meloun
On 29.08.2020 13:02, Warner Losh wrote: > On Sat, Aug 29, 2020 at 4:38 AM Michal Meloun > wrote: > >> >> >> On 29.08.2020 12:04, Warner Losh wrote: >>> On Sat, Aug 29, 2020 at 1:09 AM Mateusz Guzik wrote: >>> This crashes on boot for me: >>> >>> I wasn't able to get it to crash on b

Re: svn commit: r364946 - head/sys/kern

2020-08-29 Thread Warner Losh
On Sat, Aug 29, 2020 at 5:25 AM Michal Meloun wrote: > > > On 29.08.2020 13:02, Warner Losh wrote: > > On Sat, Aug 29, 2020 at 4:38 AM Michal Meloun > > wrote: > > > >> > >> > >> On 29.08.2020 12:04, Warner Losh wrote: > >>> On Sat, Aug 29, 2020 at 1:09 AM Mateusz Guzik > wrote: > >>> > Th

svn commit: r364952 - head/sys/arm/allwinner/clkng

2020-08-29 Thread Emmanuel Vadot
Author: manu Date: Sat Aug 29 11:39:53 2020 New Revision: 364952 URL: https://svnweb.freebsd.org/changeset/base/364952 Log: Fix arm64 build after r364927 Reported by: jenkins, dch Pointy hat to:manu Modified: head/sys/arm/allwinner/clkng/aw_clk_nm.c Modified: head/sys/arm/all

svn commit: r364953 - head/sys/kern

2020-08-29 Thread Warner Losh
Author: imp Date: Sat Aug 29 11:46:50 2020 New Revision: 364953 URL: https://svnweb.freebsd.org/changeset/base/364953 Log: We don't need to INCLUDENUL, so turn it off to avoid assertion... sbuf_new_for_sysctl turns on INCLUDENUL, but we don't need it. And we assert for it in the new bus_

svn commit: r364954 - head/sys/net/route

2020-08-29 Thread Alexander V. Chernikov
Author: melifaro Date: Sat Aug 29 12:04:13 2020 New Revision: 364954 URL: https://svnweb.freebsd.org/changeset/base/364954 Log: Revert uma zone alignemnt cache unadvertenly committed in r364950. Modified: head/sys/net/route/route_ctl.c Modified: head/sys/net/route/route_ctl.c ===

Re: svn commit: r364946 - head/sys/kern

2020-08-29 Thread Brandon Bergren
On Sat, Aug 29, 2020, at 6:34 AM, Warner Losh wrote: > > > On Sat, Aug 29, 2020 at 5:25 AM Michal Meloun wrote: > > Yeah, sorry. Local symbols are not available for netbooted kernel :(. > > And i csan confirm that problem is cause by using sbuf_cpy() on sbuf > > allocated by sbuf_new_for_sysctl(

svn commit: r364956 - head/release

2020-08-29 Thread Glen Barber
Author: gjb Date: Sat Aug 29 15:13:07 2020 New Revision: 364956 URL: https://svnweb.freebsd.org/changeset/base/364956 Log: Install devel/git from packages if NOPORTS is set in the release.sh configuration file. Reported by: Michael Butler Sponsored by: Rubicon Communications, LLC (netg

svn commit: r364957 - head/release

2020-08-29 Thread Glen Barber
Author: gjb Date: Sat Aug 29 15:30:21 2020 New Revision: 364957 URL: https://svnweb.freebsd.org/changeset/base/364957 Log: Avoid the build from falling over if devel/git is not installed on the system. Set a null branch/hash in this case, to avoid undefined GITREV/GITBRANCH variables from f

svn commit: r364958 - head/release

2020-08-29 Thread Glen Barber
Author: gjb Date: Sat Aug 29 15:31:23 2020 New Revision: 364958 URL: https://svnweb.freebsd.org/changeset/base/364958 Log: Indentation fixes. No functional changes. Sponsored by: Rubicon Communications, LLC (netgate.com) Modified: head/release/Makefile.inc1 Modified: head/release/Makef

svn commit: r364959 - head/release

2020-08-29 Thread Glen Barber
Author: gjb Date: Sat Aug 29 15:50:27 2020 New Revision: 364959 URL: https://svnweb.freebsd.org/changeset/base/364959 Log: Add a VCSUPDATE command to run 'git pull' instead of 'git clone' if the tree already exists. Reported by: Michael Butler Sponsored by: Rubicon Communications, LLC

svn commit: r364960 - head/release

2020-08-29 Thread Glen Barber
Author: gjb Date: Sat Aug 29 16:04:02 2020 New Revision: 364960 URL: https://svnweb.freebsd.org/changeset/base/364960 Log: Refine the VCSUPDATE logic further: - Look for the .git directory instead of top-level directory. - Use 'git -C' instead of cd(1). Sponsored by: Rubicon Communicati

Re: svn commit: r364946 - head/sys/kern

2020-08-29 Thread Ian Lepore
On Sat, 2020-08-29 at 05:02 -0600, Warner Losh wrote: > > > > sbuf_cpy() at _gone_in_dev+0x560 > > pc = 0x003c1ff0 lr = 0x003a9078 > > sp = 0x6f21a510 fp = 0x6f21a570 > > > > _gone_in_dev() at sbuf_new_for_sysctl+0x170 > > pc = 0x

svn commit: r364964 - in head: share/man/man9 sys/compat/linuxkpi/common/include/linux sys/kern sys/sys sys/vm

2020-08-29 Thread Vladimir Kondratyev
Author: wulf Date: Sat Aug 29 19:26:31 2020 New Revision: 364964 URL: https://svnweb.freebsd.org/changeset/base/364964 Log: LinuxKPI: Implement ksize() function. In Linux, ksize() gets the actual amount of memory allocated for a given object. This commit adds malloc_usable_size() to FreeB

svn commit: r364965 - in head/stand: common libsa

2020-08-29 Thread Simon J. Gerraty
Author: sjg Date: Sat Aug 29 21:05:43 2020 New Revision: 364965 URL: https://svnweb.freebsd.org/changeset/base/364965 Log: zalloc_malloc:Free hexdump preceeding buffer when we detect overflow Move hexdump from stand/common/misc.c to stand/libsa/hexdump.c (svn cp) Disable use of pager -

svn commit: r364966 - head/release

2020-08-29 Thread Glen Barber
Author: gjb Date: Sat Aug 29 21:42:59 2020 New Revision: 364966 URL: https://svnweb.freebsd.org/changeset/base/364966 Log: Remove the VCSUPDATE command, because git is too stupid to have the '-C ' after the subcommand. Meanwhile, hard-code 'git -C <...> pull' for now. Reported by: M

svn commit: r364967 - head/release

2020-08-29 Thread Glen Barber
Author: gjb Date: Sat Aug 29 21:46:34 2020 New Revision: 364967 URL: https://svnweb.freebsd.org/changeset/base/364967 Log: Restore the '-q' flag to the 'git pull' command. Sponsored by: Rubicon Communications, LLC (netgate.com) Modified: head/release/release.sh Modified: head/release/re

svn commit: r364968 - head/release

2020-08-29 Thread Glen Barber
Author: gjb Date: Sat Aug 29 21:47:49 2020 New Revision: 364968 URL: https://svnweb.freebsd.org/changeset/base/364968 Log: Fix ordering of the 'pull' subcommand and the '-q' flag. Pointyhat to: gjb (myself) Sponsored by: Rubicon Communications, LLC (netgate.com) Modified: head/release/

svn commit: r364970 - head/sys/sys

2020-08-29 Thread Jamie Gritton
Author: jamie Date: Sat Aug 29 22:24:41 2020 New Revision: 364970 URL: https://svnweb.freebsd.org/changeset/base/364970 Log: Add __BEGIN_DECLS to jail.h to keep C++ happy. PR: 238928 Reported by: yuri@ Modified: head/sys/sys/jail.h Modified: head/sys/sys/jail.h