svn commit: r341814 - head/sys/arm64/acpica

2018-12-11 Thread Andrew Turner
Author: andrew Date: Tue Dec 11 11:13:11 2018 New Revision: 341814 URL: https://svnweb.freebsd.org/changeset/base/341814 Log: Only read the ACPI proximity tabled on arm64 when we are booting from ACPI. Sponsored by: DARPA, AFRL Modified: head/sys/arm64/acpica/acpi_machdep.c Modified:

Re: svn commit: r341682 - head/sys/sys

2018-12-11 Thread Warner Losh
On Mon, Dec 10, 2018 at 9:57 PM Scott Long wrote: > > > > On Dec 10, 2018, at 4:47 PM, Konstantin Belousov > wrote: > > > > On Mon, Dec 10, 2018 at 02:15:20PM -0800, John Baldwin wrote: > >> On 12/8/18 7:43 PM, Warner Losh wrote: > >>> > >>> > >>> On Sat, Dec 8, 2018, 8:36 PM Kevin Bowling

Re: svn commit: r341682 - head/sys/sys

2018-12-11 Thread Poul-Henning Kamp
In message , Warner Losh writes: >We haven't ever supported SMP on i486, to my knowledge. There were never any usable i486 SMP hardware. The i486 CPU was not designed to do SMP so getting two CPUs to talk together (IPIs and all that) required a lot of glue-logic, which never got chip-i

svn commit: r341816 - head/sys/kern

2018-12-11 Thread Mateusz Guzik
Author: mjg Date: Tue Dec 11 11:57:12 2018 New Revision: 341816 URL: https://svnweb.freebsd.org/changeset/base/341816 Log: fd: stop looking for exact freefile after allocation If a lower fd is closed later, the lookup goes to waste. Allocation always performs the lookup anyway. Spons

svn commit: r341817 - head/sys/kern

2018-12-11 Thread Mateusz Guzik
Author: mjg Date: Tue Dec 11 11:58:44 2018 New Revision: 341817 URL: https://svnweb.freebsd.org/changeset/base/341817 Log: fd: tidy up closing a fd - avoid a call to knote_close in the common case - annotate mqueue as unlikely Sponsored by: The FreeBSD Foundation Modified: head/sy

svn commit: r341818 - in head/sys: kern sys

2018-12-11 Thread Mateusz Guzik
Author: mjg Date: Tue Dec 11 12:01:46 2018 New Revision: 341818 URL: https://svnweb.freebsd.org/changeset/base/341818 Log: Make lim_cur inline if possible. It is a function call only to accomodate *some* ABIs which install a hook. They only care for 3 types of limits: DATA, STACK, VMEM

svn commit: r341819 - head/sys/kern

2018-12-11 Thread Mateusz Guzik
Author: mjg Date: Tue Dec 11 12:08:18 2018 New Revision: 341819 URL: https://svnweb.freebsd.org/changeset/base/341819 Log: fd: dedup code in sys_getdtablesize Sponsored by: The FreeBSD Foundation Modified: head/sys/kern/kern_descrip.c Modified: head/sys/kern/kern_descrip.c =

svn commit: r341820 - head/sys/dev/asmc

2018-12-11 Thread David Bright
Author: dab Date: Tue Dec 11 16:35:59 2018 New Revision: 341820 URL: https://svnweb.freebsd.org/changeset/base/341820 Log: asmc: Add Support for MacBookAir 7,1 and 7,2 PR: 226172 Submitted by: James Wright Reported by: James Wright MFC after:1 week Differential Revi

svn commit: r341821 - head/sys/x86/x86

2018-12-11 Thread Mark Johnston
Author: markj Date: Tue Dec 11 16:49:01 2018 New Revision: 341821 URL: https://svnweb.freebsd.org/changeset/base/341821 Log: Fix the PAE kernel gcc build. The error was caused by map_ucode() casting a vm_paddr_t to a void *. Use a uintptr_t instead to match the caller. Fix some style bug

svn commit: r341822 - head/sys/security/audit

2018-12-11 Thread Mateusz Guzik
Author: mjg Date: Tue Dec 11 17:14:12 2018 New Revision: 341822 URL: https://svnweb.freebsd.org/changeset/base/341822 Log: audi: replace open-coded TDP_AUDITREC checks with the macro Sponsored by: The FreeBSD Foundation Modified: head/sys/security/audit/audit.h Modified: head/sys/securi

Re: svn commit: r341803 - head/libexec/rc

2018-12-11 Thread John Baldwin
On 12/10/18 5:38 PM, Conrad Meyer wrote: > Author: cem > Date: Tue Dec 11 01:38:50 2018 > New Revision: 341803 > URL: https://svnweb.freebsd.org/changeset/base/341803 > > Log: > rc.subr: Implement list_vars without using 'read' > > 'read' pessimistically read(2)s one byte at a time, which c

Re: svn commit: r341803 - head/libexec/rc

2018-12-11 Thread Devin Teske
> On Dec 11, 2018, at 9:23 AM, John Baldwin wrote: > > On 12/10/18 5:38 PM, Conrad Meyer wrote: >> Author: cem >> Date: Tue Dec 11 01:38:50 2018 >> New Revision: 341803 >> URL: https://svnweb.freebsd.org/changeset/base/341803 >> >> Log: >> rc.subr: Implement list_vars without using 'read' >>

svn commit: r341824 - head/sys/net

2018-12-11 Thread Stephen Hurd
Author: shurd Date: Tue Dec 11 17:46:01 2018 New Revision: 341824 URL: https://svnweb.freebsd.org/changeset/base/341824 Log: Fix !tx_abdicate error from r336560 r336560 was supposed to restore pre-r323954 behaviour when tx_abdicate is not set (the default case). However, it appears that r

Re: svn commit: r341803 - head/libexec/rc

2018-12-11 Thread John Baldwin
On 12/11/18 9:40 AM, Devin Teske wrote: > > >> On Dec 11, 2018, at 9:23 AM, John Baldwin > > wrote: >> >> On 12/10/18 5:38 PM, Conrad Meyer wrote: >>> Author: cem >>> Date: Tue Dec 11 01:38:50 2018 >>> New Revision: 341803 >>> URL: https://svnweb.freebsd.org/changeset/bas

Re: svn commit: r341803 - head/libexec/rc

2018-12-11 Thread Warner Losh
On Tue, Dec 11, 2018, 9:55 AM John Baldwin The 'read' builtin in sh can't use buffering, so it is always going to be > slow > It can't use it because of pipes. The example from the parts of this that was on IRC was basically: foo | (read bar; baz) Which reads one line into the bar variable and

svn commit: r341827 - in head/sys: cddl/compat/opensolaris/kern cddl/contrib/opensolaris/uts/common/fs/zfs compat/linux dev/filemon fs/ext2fs fs/fuse fs/msdosfs fs/nandfs fs/nfs fs/nfsserver fs/tmp...

2018-12-11 Thread Mateusz Guzik
Author: mjg Date: Tue Dec 11 19:32:16 2018 New Revision: 341827 URL: https://svnweb.freebsd.org/changeset/base/341827 Log: Remove unused argument to priv_check_cred. Patch mostly generated with cocinnelle: @@ expression E1,E2; @@ - priv_check_cred(E1,E2,0) + priv_check_cred(

Re: svn commit: r341803 - head/libexec/rc

2018-12-11 Thread Conrad Meyer
On Tue, Dec 11, 2018 at 9:24 AM John Baldwin wrote: > list_vars is rarely used outside of > 'netif', so it probably doesn't make a measurable difference on bare metal. To clarify: It likely doesn't make a measurable difference *to boot times* on bare metal, but even on amd64 bare metal the time o

Re: svn commit: r341803 - head/libexec/rc

2018-12-11 Thread Conrad Meyer
On Tue, Dec 11, 2018 at 10:04 AM Warner Losh wrote: > On Tue, Dec 11, 2018, 9:55 AM John Baldwin > >> The 'read' builtin in sh can't use buffering, so it is always going to be >> slow > > It can't use it because of pipes. The example from the parts of this that was > on IRC was basically: > > fo

Re: svn commit: r341803 - head/libexec/rc

2018-12-11 Thread Devin Teske
> On Dec 11, 2018, at 11:57 AM, Conrad Meyer wrote: > > On Tue, Dec 11, 2018 at 10:04 AM Warner Losh wrote: >> On Tue, Dec 11, 2018, 9:55 AM John Baldwin >> >>> The 'read' builtin in sh can't use buffering, so it is always going to be >>> slow >> >> It can't use it because of pipes. The exa

svn commit: r341829 - head/usr.sbin/bhyve

2018-12-11 Thread Alexander Motin
Author: mav Date: Tue Dec 11 20:47:00 2018 New Revision: 341829 URL: https://svnweb.freebsd.org/changeset/base/341829 Log: Allow CTL device specification in bhyve virtio-scsi. There was a large refactoring done in CTL to allow multiple ioctl frontend ports (and respective devices) to be c

Re: svn commit: r341803 - head/libexec/rc

2018-12-11 Thread Bruce Evans
On Tue, 11 Dec 2018, John Baldwin wrote: On 12/11/18 9:40 AM, Devin Teske wrote: ... Thank you for the background which was lost by the time I got to the phab. I can't help but ask though,... If it was noticed that read(2) processes the stream one byte at a time, why not just optimize read(2)

svn commit: r341832 - head/tools/build/options

2018-12-11 Thread Bjoern A. Zeeb
Author: bz Date: Tue Dec 11 21:16:09 2018 New Revision: 341832 URL: https://svnweb.freebsd.org/changeset/base/341832 Log: Remove a dead file. CVS was removed in r251794. Deleted: head/tools/build/options/WITHOUT_CVS ___ svn-src-head@freebsd.org mai

Re: svn commit: r341803 - head/libexec/rc

2018-12-11 Thread Poul-Henning Kamp
In message <20181212071210.l...@besplex.bde.org>, Bruce Evans writes: >But software bloat is now outrunning CPU speed increases. Some bandwidths >for reading 1 byte at a time run today on the same 2GHz CPU i386 UP hardware > >linux-2.1.128 kernel built in 1998: 2500k/sec >linux-2.4.0t8 k

svn commit: r341833 - head/sys/netpfil/pf

2018-12-11 Thread Kristof Provost
Author: kp Date: Tue Dec 11 21:44:39 2018 New Revision: 341833 URL: https://svnweb.freebsd.org/changeset/base/341833 Log: pf: Prevent integer overflow in PF when calculating the adaptive timeout. Mainly states of established TCP connections would be affected resulting in immediate state r

svn commit: r341834 - head/tests/sys/netpfil/pf/ioctl

2018-12-11 Thread Kristof Provost
Author: kp Date: Tue Dec 11 21:45:56 2018 New Revision: 341834 URL: https://svnweb.freebsd.org/changeset/base/341834 Log: pf tests: ioctl tests require root rights Explicitly mark these tests as requiring root rights. We need to be able to open /dev/pf. Reported by: Marie Helene Kve

svn commit: r341835 - head/tests/sys/netpfil/pf/ioctl

2018-12-11 Thread Kristof Provost
Author: kp Date: Tue Dec 11 21:49:13 2018 New Revision: 341835 URL: https://svnweb.freebsd.org/changeset/base/341835 Log: pf tests: Use the ATF cleanup infrastructure in the ioctl tests Use ATF_TC_CLEANUP(), because that means the cleanup code will get called even if a test fails. Before

Re: svn commit: r341803 - head/libexec/rc

2018-12-11 Thread Conrad Meyer
On Tue, Dec 11, 2018 at 12:35 PM Devin Teske wrote: > > On Dec 11, 2018, at 11:57 AM, Conrad Meyer wrote: > > Is there any interest in a tee(2)-like syscall? > > > > Linux has vmsplice(2). I know jmg@ also expressed interest in having a > vmsplice in FreeBSD. Sure; they're related. See also spl

svn commit: r341836 - in head: lib/libufs sbin/fsck_ffs sbin/fsirand sbin/newfs sys/sys sys/ufs/ffs sys/ufs/ufs

2018-12-11 Thread Kirk McKusick
Author: mckusick Date: Tue Dec 11 22:14:37 2018 New Revision: 341836 URL: https://svnweb.freebsd.org/changeset/base/341836 Log: Continuing efforts to provide hardening of FFS. This change adds a check hash to the filesystem inodes. Access attempts to files associated with an inode with an in

Re: svn commit: r341803 - head/libexec/rc

2018-12-11 Thread Devin Teske
> On Dec 11, 2018, at 1:54 PM, Conrad Meyer wrote: > > On Tue, Dec 11, 2018 at 12:35 PM Devin Teske wrote: >>> On Dec 11, 2018, at 11:57 AM, Conrad Meyer wrote: >>> Is there any interest in a tee(2)-like syscall? >>> >> >> Linux has vmsplice(2). I know jmg@ also expressed interest in havin

Re: svn commit: r341803 - head/libexec/rc

2018-12-11 Thread Conrad Meyer
On Tue, Dec 11, 2018 at 2:42 PM Devin Teske wrote: > In that case, would it be appropriate to say that: > > blah | while read x; do ...; done > > Is always more efficiently written as: > > IFS=$'\n' > for x in $( blah ); do ...; done I don't know. The suggestion came from

Re: svn commit: r341682 - head/sys/sys

2018-12-11 Thread Konstantin Belousov
On Mon, Dec 10, 2018 at 09:57:08PM -0700, Scott Long wrote: > > > > On Dec 10, 2018, at 4:47 PM, Konstantin Belousov > > wrote: > > > > On Mon, Dec 10, 2018 at 02:15:20PM -0800, John Baldwin wrote: > >> On 12/8/18 7:43 PM, Warner Losh wrote: > >>> > >>> > >>> On Sat, Dec 8, 2018, 8:36 PM Kev

Re: svn commit: r341803 - head/libexec/rc

2018-12-11 Thread Simon J. Gerraty
Just caught the tail of this thread so sorry for chiming in from the peanut gallery... blah | while read x; do ...; done behaves very differently to the for loop variant in that the body of the loop runs in a sub-shell and thus cannot affect the outer scope. In many cases that's exactly w

svn commit: r341837 - head/sbin/ping

2018-12-11 Thread Mark Johnston
Author: markj Date: Wed Dec 12 02:33:01 2018 New Revision: 341837 URL: https://svnweb.freebsd.org/changeset/base/341837 Log: Use Capsicum helpers in ping(8). Also use caph_cache_catpages() to ensure that strerror() works when run with kern.trap_enotcap=1. Reviewed by: oshogbo MFC

svn commit: r341838 - in head/lib/libc: regex tests/regex

2018-12-11 Thread Yuri Pankov
Author: yuripv Date: Wed Dec 12 04:23:00 2018 New Revision: 341838 URL: https://svnweb.freebsd.org/changeset/base/341838 Log: regcomp: reduce size of bitmap for multibyte locales This fixes the obscure endless loop seen with case-insensitive patterns containing characters in 128-255 range

Re: svn commit: r341759 - in head: contrib/wpa contrib/wpa/hostapd contrib/wpa/hs20/client contrib/wpa/src/ap contrib/wpa/src/common contrib/wpa/src/crypto contrib/wpa/src/drivers contrib/wpa/src/eap_

2018-12-11 Thread Jung-uk Kim
On 18. 12. 9., Cy Schubert wrote: > Author: cy > Date: Sun Dec 9 06:45:49 2018 > New Revision: 341759 > URL: https://svnweb.freebsd.org/changeset/base/341759 > > Log: > MFV r341618: > > Update wpa 2.6 --> 2.7. ... This broke my network configuration and I found the following messages fro

Re: svn commit: r341759 - in head: contrib/wpa contrib/wpa/hostapd contrib/wpa/hs20/client contrib/wpa/src/ap contrib/wpa/src/common contrib/wpa/src/crypto contrib/wpa/src/drivers contrib/wpa/src/eap_

2018-12-11 Thread Jung-uk Kim
On 18. 12. 12., Jung-uk Kim wrote: > On 18. 12. 9., Cy Schubert wrote: >> Author: cy >> Date: Sun Dec 9 06:45:49 2018 >> New Revision: 341759 >> URL: https://svnweb.freebsd.org/changeset/base/341759 >> >> Log: >> MFV r341618: >> >> Update wpa 2.6 --> 2.7. > > ... > > This broke my network

svn commit: r341839 - head/usr.sbin/wpa

2018-12-11 Thread Cy Schubert
Author: cy Date: Wed Dec 12 05:18:53 2018 New Revision: 341839 URL: https://svnweb.freebsd.org/changeset/base/341839 Log: Set default ciphers. Submitted by: jkim@ Modified: head/usr.sbin/wpa/Makefile.inc Modified: head/usr.sbin/wpa/Makefile.inc ==

Re: svn commit: r341759 - in head: contrib/wpa contrib/wpa/hostapd contrib/wpa/hs20/client contrib/wpa/src/ap contrib/wpa/src/common contrib/wpa/src/crypto contrib/wpa/src/drivers contrib/wpa/src/e

2018-12-11 Thread Cy Schubert
In message , Jung-uk Kim writ es: > This is an OpenPGP/MIME signed message (RFC 4880 and 3156) > --1WzVlQChcwPiBmKooCiYuMNrbS28KVujs > Content-Type: multipart/mixed; boundary="mK5ijTqRdq36SSbJEKLOKtLDhMyjY2IRB"; > protected-headers="v1" > From: Jung-uk Kim > To: Cy Schubert , src-committ...@free

Re: svn commit: r341759 - in head: contrib/wpa contrib/wpa/hostapd contrib/wpa/hs20/client contrib/wpa/src/ap contrib/wpa/src/common contrib/wpa/src/crypto contrib/wpa/src/drivers contrib/wpa/src/eap_

2018-12-11 Thread Jung-uk Kim
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 18. 12. 12., Jung-uk Kim wrote: > On 18. 12. 12., Jung-uk Kim wrote: >> On 18. 12. 9., Cy Schubert wrote: >>> Author: cy Date: Sun Dec 9 06:45:49 2018 New Revision: 341759 >>> URL: https://svnweb.freebsd.org/changeset/base/341759 >>> >>> Log: M

svn commit: r341840 - head/sys/geom/mirror

2018-12-11 Thread Conrad Meyer
Author: cem Date: Wed Dec 12 05:48:27 2018 New Revision: 341840 URL: https://svnweb.freebsd.org/changeset/base/341840 Log: gmirror: Fix a bug introduced in r341674 r341674 inadvertently introduced a bug where newer mirror components being tasted would clear the high sc_flags that are not