svn commit: r328111 - head/sys/powerpc/powerpc

2018-01-18 Thread Wojciech Macek
Author: wma Date: Thu Jan 18 07:41:04 2018 New Revision: 328111 URL: https://svnweb.freebsd.org/changeset/base/328111 Log: PPC: machdep, zero BSS always but BookE Zero BSS always. The only case when this operation is ommitted is when booting on BookE. Created by:Wojciech

svn commit: r328113 - head/sys/powerpc/powerpc

2018-01-18 Thread Wojciech Macek
Author: wma Date: Thu Jan 18 08:34:20 2018 New Revision: 328113 URL: https://svnweb.freebsd.org/changeset/base/328113 Log: Call platform_smp_ap_init before decr_ap_init In platform_smp_ap_init we are doing some crucial code (eg. set LPCR register) which have influence over furthe

Re: svn commit: r327890 - head/usr.sbin/bsdinstall/partedit

2018-01-18 Thread Gary Jennejohn
On Thu, 18 Jan 2018 07:26:11 + Alexey Dokuchaev wrote: > On Sat, Jan 13, 2018 at 06:53:47AM +, Alexey Dokuchaev wrote: > > On Fri, Jan 12, 2018 at 08:25:57PM +, Ed Maste wrote: > > > New Revision: 327890 > > > URL: https://svnweb.freebsd.org/changeset/base/327890 > > > > > > Log: >

Re: svn commit: r327890 - head/usr.sbin/bsdinstall/partedit

2018-01-18 Thread Alexey Dokuchaev
On Thu, Jan 18, 2018 at 10:46:20AM +0100, Gary Jennejohn wrote: > On Thu, 18 Jan 2018 07:26:11 + > Alexey Dokuchaev wrote: > > > ... > > > Thanks; I keep seeing it quite often. > > > Is it safe to disable SUJ on already populated filesystem? > > > Can (should) it better be done on live, mounte

Re: svn commit: r319971 - in head: contrib/jemalloc contrib/jemalloc/doc contrib/jemalloc/include/jemalloc contrib/jemalloc/include/jemalloc/internal contrib/jemalloc/src include lib/libc/stdlib/jemal

2018-01-18 Thread Alexey Dokuchaev
On Sat, Jan 13, 2018 at 05:04:30PM +, Alexey Dokuchaev wrote: > On Thu, Jun 15, 2017 at 07:15:06AM +, Jason Evans wrote: > > New Revision: 319971 > > URL: https://svnweb.freebsd.org/changeset/base/319971 > > > > Log: > > Update jemalloc to 5.0.0. > > I've finally bisected the problem of

svn commit: r328115 - head/sys/arm64/arm64

2018-01-18 Thread Andrew Turner
Author: andrew Date: Thu Jan 18 10:52:31 2018 New Revision: 328115 URL: https://svnweb.freebsd.org/changeset/base/328115 Log: Add a pmap invalidate that doesn't call sched_pin. When demoting DMAP pages curthread may be pointing to data within the page we are demoting. Create a new invalid

svn commit: r328120 - in head/sys/amd64: amd64 include

2018-01-18 Thread Konstantin Belousov
Author: kib Date: Thu Jan 18 11:21:03 2018 New Revision: 328120 URL: https://svnweb.freebsd.org/changeset/base/328120 Log: Fix compilation with gcc. etext is already declared in machine/cpu.h, move kernphys declaration there too. Based on the patch by:bde MFC after:13 d

svn commit: r328116 - head/sys/amd64/amd64

2018-01-18 Thread Konstantin Belousov
Author: kib Date: Thu Jan 18 11:01:41 2018 New Revision: 328116 URL: https://svnweb.freebsd.org/changeset/base/328116 Log: Remove the 'last' argument from the pmap_pti_free_page(). It is in fact unused. Noted and reviewed by:markj Sponsored by: The FreeBSD Foundation MFC af

svn commit: r328119 - head/sys/amd64/include

2018-01-18 Thread Konstantin Belousov
Author: kib Date: Thu Jan 18 11:19:58 2018 New Revision: 328119 URL: https://svnweb.freebsd.org/changeset/base/328119 Log: Fix compilation with gas. Submitted by: bde MFC after:13 days Modified: head/sys/amd64/include/asmacros.h Modified: head/sys/amd64/include/asmacros.h

Re: svn commit: r328083 - in head/sys: amd64/amd64 amd64/ia32 amd64/include amd64/vmm amd64/vmm/intel dev/hyperv/vmbus dev/hyperv/vmbus/amd64 dev/hyperv/vmbus/i386 i386/i386 x86/include x86/isa x86/x8

2018-01-18 Thread Konstantin Belousov
On Wed, Jan 17, 2018 at 07:38:03PM -0800, Conrad Meyer wrote: > On Wed, Jan 17, 2018 at 3:44 AM, Konstantin Belousov wrote: > > Author: kib > > Date: Wed Jan 17 11:44:21 2018 > > New Revision: 328083 > > URL: https://svnweb.freebsd.org/changeset/base/328083 > > > > Log: > > PTI for amd64. > > T

Re: svn commit: r328110 - head/sys/kern

2018-01-18 Thread Andriy Gapon
On 18/01/2018 09:38, Wojciech Macek wrote: > Author: wma > Date: Thu Jan 18 07:38:54 2018 > New Revision: 328110 > URL: https://svnweb.freebsd.org/changeset/base/328110 > > Log: > KDB: restart only CPUs stopped by KDB > > There is a case when not all CPUs went online. In that situation, >

Re: svn commit: r327890 - head/usr.sbin/bsdinstall/partedit

2018-01-18 Thread Eugene Grosbein
On 18.01.2018 16:49, Alexey Dokuchaev wrote: > OK, that answers the second question (silly one). What about the > first one: Is it safe to disable SUJ on already populated filesystem? Yes. However, this must be done before mounting. ___ svn-src-head@

svn commit: r328126 - head/sys/kern

2018-01-18 Thread Andriy Gapon
Author: avg Date: Thu Jan 18 12:59:04 2018 New Revision: 328126 URL: https://svnweb.freebsd.org/changeset/base/328126 Log: correct read-ahead calculations in vfs_bio_getpages Previously the calculations were done as if the requested region ended at the start of the last requested page, no

Re: svn commit: r328110 - head/sys/kern

2018-01-18 Thread Wojciech Macek
Adding author wma 2018-01-18 11:43 GMT+01:00 Andriy Gapon : > On 18/01/2018 09:38, Wojciech Macek wrote: > > Author: wma > > Date: Thu Jan 18 07:38:54 2018 > > New Revision: 328110 > > URL: https://svnweb.freebsd.org/changeset/base/328110 > > > > Log: > > KDB: restart only CPUs stopped by KDB

Re: svn commit: r328110 - head/sys/kern

2018-01-18 Thread Bruce Evans
On Thu, 18 Jan 2018, Andriy Gapon wrote: On 18/01/2018 09:38, Wojciech Macek wrote: ... Log: KDB: restart only CPUs stopped by KDB There is a case when not all CPUs went online. In that situation, restart only APs which were operational before entering KDB. What is the context here? I

Re: svn commit: r327890 - head/usr.sbin/bsdinstall/partedit

2018-01-18 Thread Warner Losh
On Thu, Jan 18, 2018 at 5:27 AM, Eugene Grosbein wrote: > On 18.01.2018 16:49, Alexey Dokuchaev wrote: > > > OK, that answers the second question (silly one). What about the > > first one: Is it safe to disable SUJ on already populated filesystem? > > Yes. However, this must be done before mount

svn commit: r328128 - in head/sys/amd64: amd64 include

2018-01-18 Thread Konstantin Belousov
Author: kib Date: Thu Jan 18 15:15:35 2018 New Revision: 328128 URL: https://svnweb.freebsd.org/changeset/base/328128 Log: Move the kernphys declaration to machine/md_var.h. Apparently machinde/cpu.h is supposed to contain MD implementations of MI interfaces. Also, remove kernphys declar

Re: svn commit: r327950 - in head/sys/powerpc: aim include powerpc ps3

2018-01-18 Thread Nathan Whitehorn
On 01/17/18 01:44, Konstantin Belousov wrote: On Tue, Jan 16, 2018 at 09:30:29PM -0800, Nathan Whitehorn wrote: On 01/16/18 11:32, Marius Strobl wrote: On Mon, Jan 15, 2018 at 03:20:49PM -0800, Nathan Whitehorn wrote: On 01/15/18 09:53, Konstantin Belousov wrote: On Mon, Jan 15, 2018 at 09

svn commit: r328129 - head/sys/fs/nfsserver

2018-01-18 Thread Emmanuel Vadot
Author: manu Date: Thu Jan 18 15:28:49 2018 New Revision: 328129 URL: https://svnweb.freebsd.org/changeset/base/328129 Log: nfs: Do not printf each time a lock structure is freed during module unload There can be a lot of those structures and printing a line each time we free one on modul

Re: svn commit: r327950 - in head/sys/powerpc: aim include powerpc ps3

2018-01-18 Thread Konstantin Belousov
On Thu, Jan 18, 2018 at 07:24:11AM -0800, Nathan Whitehorn wrote: > > > On 01/17/18 01:44, Konstantin Belousov wrote: > > On Tue, Jan 16, 2018 at 09:30:29PM -0800, Nathan Whitehorn wrote: > >> > >> On 01/16/18 11:32, Marius Strobl wrote: > >>> On Mon, Jan 15, 2018 at 03:20:49PM -0800, Nathan Whit

Re: svn commit: r328129 - head/sys/fs/nfsserver

2018-01-18 Thread Emmanuel Vadot
On Thu, 18 Jan 2018 15:28:49 + (UTC) Emmanuel Vadot wrote: > Author: manu > Date: Thu Jan 18 15:28:49 2018 > New Revision: 328129 > URL: https://svnweb.freebsd.org/changeset/base/328129 > > Log: > nfs: Do not printf each time a lock structure is freed during module unload > > There ca

Re: svn commit: r327950 - in head/sys/powerpc: aim include powerpc ps3

2018-01-18 Thread Nathan Whitehorn
On 01/18/18 07:35, Konstantin Belousov wrote: On Thu, Jan 18, 2018 at 07:24:11AM -0800, Nathan Whitehorn wrote: On 01/17/18 01:44, Konstantin Belousov wrote: On Tue, Jan 16, 2018 at 09:30:29PM -0800, Nathan Whitehorn wrote: On 01/16/18 11:32, Marius Strobl wrote: On Mon, Jan 15, 2018 at 03

Re: svn commit: r327950 - in head/sys/powerpc: aim include powerpc ps3

2018-01-18 Thread Alan Cox
On 01/18/2018 09:35, Konstantin Belousov wrote: > On Thu, Jan 18, 2018 at 07:24:11AM -0800, Nathan Whitehorn wrote: >> >> On 01/17/18 01:44, Konstantin Belousov wrote: >>> On Tue, Jan 16, 2018 at 09:30:29PM -0800, Nathan Whitehorn wrote: On 01/16/18 11:32, Marius Strobl wrote: > On Mon, Ja

svn commit: r328130 - head/sys/arm64/arm64

2018-01-18 Thread Ruslan Bukin
Author: br Date: Thu Jan 18 16:20:09 2018 New Revision: 328130 URL: https://svnweb.freebsd.org/changeset/base/328130 Log: Set the base address of translation table 0. This fixes operation on Qualcomm Snapdragon and some other platforms. During boot time on subsystems initialization we

svn commit: r328132 - head/sys/dev/uart

2018-01-18 Thread Ruslan Bukin
Author: br Date: Thu Jan 18 17:43:32 2018 New Revision: 328132 URL: https://svnweb.freebsd.org/changeset/base/328132 Log: Support for UART device found in Qualcomm Snapdragon 410E SoC. Tested on DragonBoard 410c. Reviewed by: andrew Sponsored by: DARPA, AFRL Differential Revision:

svn commit: r328133 - head/sys/dev/uart

2018-01-18 Thread Ruslan Bukin
Author: br Date: Thu Jan 18 18:19:31 2018 New Revision: 328133 URL: https://svnweb.freebsd.org/changeset/base/328133 Log: UART Clock Selection Register holds a divider value for a supplied clock, not a final baud rate. The value for this register has to be calculated. Sponsored by: DARPA,

svn commit: r328134 - in head: sys/sys usr.bin/vmstat

2018-01-18 Thread John Baldwin
Author: jhb Date: Thu Jan 18 19:43:02 2018 New Revision: 328134 URL: https://svnweb.freebsd.org/changeset/base/328134 Log: Update various statements in vmstat(8) to match reality. - The process stats are actually thread counts rather than process counts. - Simplify various description

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Eric van Gyzen
On 01/17/2018 16:40, Gleb Smirnoff wrote: > On Fri, Dec 29, 2017 at 07:05:07PM +, Konstantin Belousov wrote: > K> Author: kib > K> Date: Fri Dec 29 19:05:07 2017 > K> New Revision: 327354 > K> URL: https://svnweb.freebsd.org/changeset/base/327354 > K> > K> Log: > K> Style. > K> > K> Rev

svn commit: r328135 - head/sys/amd64/amd64

2018-01-18 Thread John Baldwin
Author: jhb Date: Thu Jan 18 20:12:12 2018 New Revision: 328135 URL: https://svnweb.freebsd.org/changeset/base/328135 Log: Adjust branch target in NMI handler for the !PTI case. In the !PTI case the NMI handler jumped past the instructions that set %rdi to point to the current PCB, but th

Re: svn commit: r328083 - in head/sys: amd64/amd64 amd64/ia32 amd64/include amd64/vmm amd64/vmm/intel dev/hyperv/vmbus dev/hyperv/vmbus/amd64 dev/hyperv/vmbus/i386 i386/i386 x86/include x86/isa x86/x8

2018-01-18 Thread Conrad Meyer
On Thu, Jan 18, 2018 at 3:23 AM, Konstantin Belousov wrote: > On Wed, Jan 17, 2018 at 07:38:03PM -0800, Conrad Meyer wrote: >> On Wed, Jan 17, 2018 at 3:44 AM, Konstantin Belousov >> wrote: >> > Author: kib >> > Date: Wed Jan 17 11:44:21 2018 >> > New Revision: 328083 >> > URL: https://svnweb.fr

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Conrad Meyer
On Thu, Jan 18, 2018 at 12:01 PM, Eric van Gyzen wrote: > On 01/17/2018 16:40, Gleb Smirnoff wrote: >> Yeah, style is sacred, but is there a single person on Earth who would >> not agree that moving variables from smaller blocks to function block >> reduces readability of the code? > > I agree tha

svn commit: r328136 - in head/etc: defaults rc.d

2018-01-18 Thread Brad Davis
Author: brd (doc,ports committer) Date: Thu Jan 18 20:45:41 2018 New Revision: 328136 URL: https://svnweb.freebsd.org/changeset/base/328136 Log: Teach the resolv startup script to respect its enable flag. Reviewed by: will, imp Approved by: imp Modified: head/etc/defaults/rc.conf h

Re: svn commit: r328136 - in head/etc: defaults rc.d

2018-01-18 Thread Steven Hartland
Did you intend to add the growfs option at the same time as it wasn’t mentioned in the commit msg On Thu, 18 Jan 2018 at 20:46, Brad Davis wrote: > Author: brd (doc,ports committer) > Date: Thu Jan 18 20:45:41 2018 > New Revision: 328136 > URL: https://svnweb.freebsd.org/changeset/base/328136 >

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Warner Losh
On Thu, Jan 18, 2018 at 1:32 PM, Conrad Meyer wrote: > On Thu, Jan 18, 2018 at 12:01 PM, Eric van Gyzen > wrote: > > On 01/17/2018 16:40, Gleb Smirnoff wrote: > >> Yeah, style is sacred, but is there a single person on Earth who would > >> not agree that moving variables from smaller blocks to f

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Matt Joras
On Thu, Jan 18, 2018 at 1:04 PM, Warner Losh wrote: > >> 1. Allowing local / block scoped variables >> 2. Allowing C99 for loop initial declarations >> >> But I could see the argument that (2) is just a boring subset of (1). > > > Tell me again where #1/#2 are disallowed? I can't seem to find that

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Warner Losh
On Thu, Jan 18, 2018 at 2:10 PM, Matt Joras wrote: > On Thu, Jan 18, 2018 at 1:04 PM, Warner Losh wrote: > > > >> 1. Allowing local / block scoped variables > >> 2. Allowing C99 for loop initial declarations > >> > >> But I could see the argument that (2) is just a boring subset of (1). > > > >

svn commit: r328137 - head/sys/sys

2018-01-18 Thread Conrad Meyer
Author: cem Date: Thu Jan 18 21:19:57 2018 New Revision: 328137 URL: https://svnweb.freebsd.org/changeset/base/328137 Log: Add Elf_Nhdr definition to match NetBSD, OpenBSD, Linux The mesa port started to use this type and fails to build without it. NetBSD: http://cvsweb.netbsd.org/bsd

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Conrad Meyer
On Thu, Jan 18, 2018 at 1:04 PM, Warner Losh wrote: > On Thu, Jan 18, 2018 at 1:32 PM, Conrad Meyer wrote: >> 1. Allowing local / block scoped variables >> 2. Allowing C99 for loop initial declarations > > Tell me again where #1/#2 are disallowed? I can't seem to find that in > style(9), except b

svn commit: r328141 - head/contrib/llvm/tools/lld/ELF

2018-01-18 Thread Ed Maste
Author: emaste Date: Thu Jan 18 21:38:21 2018 New Revision: 328141 URL: https://svnweb.freebsd.org/changeset/base/328141 Log: lld: Fix for ld.lld does not accept "AT" syntax for declaring LMA region AT> lma_region expression allows to specify the memory region for section load address.

svn commit: r328143 - head/contrib/llvm/tools/lld/ELF

2018-01-18 Thread Ed Maste
Author: emaste Date: Thu Jan 18 21:39:19 2018 New Revision: 328143 URL: https://svnweb.freebsd.org/changeset/base/328143 Log: lld: Handle parsing AT(ADDR(.foo-bar)). The problem we had with it is that anything inside an AT is an expression, so we failed to parse the section name because o

svn commit: r328144 - head/contrib/llvm/tools/lld/ELF

2018-01-18 Thread Ed Maste
Author: emaste Date: Thu Jan 18 21:39:59 2018 New Revision: 328144 URL: https://svnweb.freebsd.org/changeset/base/328144 Log: lld: Fix incorrect physical address on self-referencing AT command. When a section placement (AT) command references the section itself, the physical address of th

svn commit: r328145 - head/contrib/llvm/lib/Analysis

2018-01-18 Thread Dimitry Andric
Author: dim Date: Thu Jan 18 21:44:07 2018 New Revision: 328145 URL: https://svnweb.freebsd.org/changeset/base/328145 Log: Pull in r322016 from upstream llvm trunk (by Sanjay Patel): [ValueTracking] remove overzealous assert The test is derived from a failing fuzz test: https:/

svn commit: r328146 - head/contrib/llvm/lib/Target/X86

2018-01-18 Thread Dimitry Andric
Author: dim Date: Thu Jan 18 21:46:09 2018 New Revision: 328146 URL: https://svnweb.freebsd.org/changeset/base/328146 Log: Pull in r322106 from upstream llvm trunk (by Alexey Bataev): [COST]Fix PR35865: Fix cost model evaluation for shuffle on X86. Summary: If the vector type i

svn commit: r328150 - in head: sys/crypto/ccp sys/modules sys/modules/ccp tests/sys/opencrypto

2018-01-18 Thread Conrad Meyer
Author: cem Date: Thu Jan 18 22:01:30 2018 New Revision: 328150 URL: https://svnweb.freebsd.org/changeset/base/328150 Log: Add ccp(4): experimental driver for AMD Crypto Co-Processor * Registers TRNG source for random(4) * Finds available queues, LSBs; allocates static objects * Allocat

svn commit: r328153 - head/sys/amd64/amd64

2018-01-18 Thread John Baldwin
Author: jhb Date: Thu Jan 18 22:13:53 2018 New Revision: 328153 URL: https://svnweb.freebsd.org/changeset/base/328153 Log: Remove two no-longer-used labels from the NMI interrupt handler. Reviewed by: kib Modified: head/sys/amd64/amd64/exception.S Modified: head/sys/amd64/amd64/excepti

Re: svn commit: r328129 - head/sys/fs/nfsserver

2018-01-18 Thread Rick Macklem
Emmanuel Vadot wrote: >> Author: manu >> Date: Thu Jan 18 15:28:49 2018 >> New Revision: 328129 >> URL: https://svnweb.freebsd.org/changeset/base/328129 >> >> Log: >> nfs: Do not printf each time a lock structure is freed during module unload >> >> There can be a lot of those structures and pri

svn commit: r328154 - head/share/man/man9

2018-01-18 Thread Warner Losh
Author: imp Date: Thu Jan 18 22:20:30 2018 New Revision: 328154 URL: https://svnweb.freebsd.org/changeset/base/328154 Log: Make igor happier with this file: o Don't use contractions. o Add common after e.g. where needed Modified: head/share/man/man9/style.9 Modified: head/share/man/man9/

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Andriy Gapon
On 18/01/2018 23:10, Matt Joras wrote: > "/* Insert an empty line if the function has no local variables. */" And if there is a single silly rule in style(9) then it is this. Waste a line for no possible benefit at all. -- Andriy Gapon ___ svn-src-head

svn commit: r328155 - head/share/man/man9

2018-01-18 Thread Warner Losh
Author: imp Date: Thu Jan 18 22:23:16 2018 New Revision: 328155 URL: https://svnweb.freebsd.org/changeset/base/328155 Log: No need for the zero width space now that I put the comma in. Modified: head/share/man/man9/style.9 Modified: head/share/man/man9/style.9 ===

Re: svn commit: r328136 - in head/etc: defaults rc.d

2018-01-18 Thread Brad Davis
On Thu, Jan 18, 2018, at 1:54 PM, Steven Hartland wrote: > Did you intend to add the growfs option at the same time as it wasn’t > mentioned in the commit msg  Opps, no, I forgot about that. I had made it years ago, but never got around to submitting it. Unless anyone has any objections I will

svn commit: r328156 - in head/stand: arm/uboot efi/loader/arch/arm

2018-01-18 Thread Kyle Evans
Author: kevans Date: Thu Jan 18 22:46:47 2018 New Revision: 328156 URL: https://svnweb.freebsd.org/changeset/base/328156 Log: stand: Move sections around to fix stand/ build with ld.lld on armv7 When building loader bits, lld fails with the following error: "ld: error: section: .dynamic i

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Ian Lepore
On Fri, 2018-01-19 at 00:21 +0200, Andriy Gapon wrote: > On 18/01/2018 23:10, Matt Joras wrote: > > > > "/* Insert an empty line if the function has no local variables. > > */" > And if there is a single silly rule in style(9) then it is this. > Waste a line for no possible benefit at all. > Esp

svn commit: r328157 - in head/sys/amd64: amd64 include

2018-01-18 Thread John Baldwin
Author: jhb Date: Thu Jan 18 23:50:21 2018 New Revision: 328157 URL: https://svnweb.freebsd.org/changeset/base/328157 Log: Use a dedicated per-CPU stack for machine check exceptions. Similar to NMIs, machine check exceptions can fire at any time and are not masked by IF. This means that

svn commit: r328158 - head/gnu/usr.bin/gdb/kgdb

2018-01-18 Thread John Baldwin
Author: jhb Date: Fri Jan 19 01:36:25 2018 New Revision: 328158 URL: https://svnweb.freebsd.org/changeset/base/328158 Log: Recognize mchk_calltrap as a trapframe generator. Should have been included in r328157. Modified: head/gnu/usr.bin/gdb/kgdb/trgt_amd64.c Modified: head/gnu/usr.bin/

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Bruce Evans
On Thu, 18 Jan 2018, Eric van Gyzen wrote: On 01/17/2018 16:40, Gleb Smirnoff wrote: On Fri, Dec 29, 2017 at 07:05:07PM +, Konstantin Belousov wrote: K> Author: kib K> Date: Fri Dec 29 19:05:07 2017 K> New Revision: 327354 K> URL: https://svnweb.freebsd.org/changeset/base/327354 K> K> Log:

svn commit: r328159 - head/sys/modules

2018-01-18 Thread Conrad Meyer
Author: cem Date: Fri Jan 19 04:34:06 2018 New Revision: 328159 URL: https://svnweb.freebsd.org/changeset/base/328159 Log: Unbreak i386 build The logical result of a right shift >= the width of a type is zero, but our compiler decides this is a warning (and thus, error). Just remove ccp(

Re: svn commit: r328159 - head/sys/modules

2018-01-18 Thread Benjamin Kaduk
On Thu, Jan 18, 2018 at 10:34 PM, Conrad Meyer wrote: > Author: cem > Date: Fri Jan 19 04:34:06 2018 > New Revision: 328159 > URL: https://svnweb.freebsd.org/changeset/base/328159 > > Log: > Unbreak i386 build > > The logical result of a right shift >= the width of a type is zero, but > our >

Re: svn commit: r328159 - head/sys/modules

2018-01-18 Thread Benjamin Kaduk
On Thu, Jan 18, 2018 at 10:49 PM, Conrad Meyer wrote: > No. It is the only logical result of a logical right shift larger > than the left operand. The C standard may claim that is undefined, > but that does not change the only logical result (zero). > > My point is that the compiler does not ar

Re: svn commit: r328159 - head/sys/modules

2018-01-18 Thread Conrad Meyer
No. It is the only logical result of a logical right shift larger than the left operand. The C standard may claim that is undefined, but that does not change the only logical result (zero). On Thu, Jan 18, 2018 at 8:38 PM, Benjamin Kaduk wrote: > On Thu, Jan 18, 2018 at 10:34 PM, Conrad Meyer

Re: svn commit: r328159 - head/sys/modules

2018-01-18 Thread Conrad Meyer
The spec says the behavior is undefined; not that the compiler has to produce a warning or error message. The compiler *does* get to arbitrarily decide what it wants to do when it encounters UB. It is wholly free to implement this particular UB with the logical result and no warning/error. On Th