svn commit: r325433 - head/sys/kern

2017-11-05 Thread Mateusz Guzik
Author: mjg Date: Sun Nov 5 08:31:25 2017 New Revision: 325433 URL: https://svnweb.freebsd.org/changeset/base/325433 Log: namecache: skip locking in cache_purge_negative if there are no entries Modified: head/sys/kern/vfs_cache.c Modified: head/sys/kern/vfs_cache.c =

Re: svn commit: r325404 - head/share/mk

2017-11-05 Thread O. Hartmann
Am Sat, 4 Nov 2017 22:31:33 +0100 "O. Hartmann" schrieb: > Am Sat, 4 Nov 2017 21:02:27 + (UTC) > "Simon J. Gerraty" schrieb: > > > Author: sjg > > Date: Sat Nov 4 21:02:26 2017 > > New Revision: 325404 > > URL: https://svnweb.freebsd.org/changeset/base/325404 > > > > Log: > > Ensure .OB

svn commit: r325434 - head/sys/netinet

2017-11-05 Thread Michael Tuexen
Author: tuexen Date: Sun Nov 5 11:59:33 2017 New Revision: 325434 URL: https://svnweb.freebsd.org/changeset/base/325434 Log: Fix an accounting bug where data was counted twice if on the read queue and on the ordered or unordered queue. While there, improve the checking in INVARIANTs when co

Re: svn commit: r324853 - in head/sys: kern sys

2017-11-05 Thread Konstantin Belousov
On Sun, Nov 05, 2017 at 03:06:22AM +1100, Bruce Evans wrote: > On Sun, 22 Oct 2017, Konstantin Belousov wrote: > > > Author: kib > > Date: Sun Oct 22 08:11:45 2017 > > New Revision: 324853 > > URL: https://svnweb.freebsd.org/changeset/base/324853 > > > > Log: > > Remove the support for mknod(S_IF

Re: svn commit: r325386 - head/sys/kern

2017-11-05 Thread Konstantin Belousov
On Sat, Nov 04, 2017 at 12:04:56PM -0700, Conrad Meyer wrote: > This is a functional change, because MPASS (via KASSERT) is only > enabled on DEBUG kernels. Ideally we would have a kind of ASSERT that > worked on NODEBUG kernels. Why would we need such thing ? Our conventions are clear: consisten

svn commit: r325435 - head/sys/ufs/ffs

2017-11-05 Thread Konstantin Belousov
Author: kib Date: Sun Nov 5 13:28:48 2017 New Revision: 325435 URL: https://svnweb.freebsd.org/changeset/base/325435 Log: Improve the message printed when the cylinder group checksum is wrong. Mention the device path and mount point path, handle snapshots. Tested by:imp Sponsore

Re: svn commit: r324857 - in head: lib/libc/gen sys/vm

2017-11-05 Thread Bruce Evans
On Sun, 22 Oct 2017, Edward Tomasz Napierala wrote: Log: Add OID for the vm.overcommit sysctl. This makes it possible to remove one call to sysctl(2) from jemalloc startup code. (That also requires changes to jemalloc, but I plan to push those to upstream first.) This change has many style

svn commit: r325436 - head/sys/net

2017-11-05 Thread Eugene Grosbein
Author: eugen (ports committer) Date: Sun Nov 5 14:41:48 2017 New Revision: 325436 URL: https://svnweb.freebsd.org/changeset/base/325436 Log: Allow a process to assign an IP address to local ppp interface even if kernel routing table already has a route to the address in question installed

Re: svn commit: r324853 - in head/sys: kern sys

2017-11-05 Thread Bruce Evans
On Sun, 5 Nov 2017, Konstantin Belousov wrote: On Sun, Nov 05, 2017 at 03:06:22AM +1100, Bruce Evans wrote: On Sun, 22 Oct 2017, Konstantin Belousov wrote: Author: kib Date: Sun Oct 22 08:11:45 2017 New Revision: 324853 URL: https://svnweb.freebsd.org/changeset/base/324853 Log: Remove the s

Re: svn commit: r324853 - in head/sys: kern sys

2017-11-05 Thread Konstantin Belousov
On Mon, Nov 06, 2017 at 01:46:49AM +1100, Bruce Evans wrote: > On Sun, 5 Nov 2017, Konstantin Belousov wrote: > > > On Sun, Nov 05, 2017 at 03:06:22AM +1100, Bruce Evans wrote: > >> On Sun, 22 Oct 2017, Konstantin Belousov wrote: > >> > >>> Author: kib > >>> Date: Sun Oct 22 08:11:45 2017 > >>> Ne

Re: svn commit: r325404 - head/share/mk

2017-11-05 Thread Bryan Drewery
On 11/5/2017 2:16 AM, O. Hartmann wrote: > Am Sat, 4 Nov 2017 22:31:33 +0100 > "O. Hartmann" schrieb: > >> Am Sat, 4 Nov 2017 21:02:27 + (UTC) >> "Simon J. Gerraty" schrieb: >> >>> Author: sjg >>> Date: Sat Nov 4 21:02:26 2017 >>> New Revision: 325404 >>> URL: https://svnweb.freebsd.org/cha

Re: svn commit: r325404 - head/share/mk

2017-11-05 Thread Simon J. Gerraty
Bryan Drewery wrote: > > ${.OBJDIR} == /${RELDIR})) make[6]: Fatal errors encountered -- cannot > > continue make[6]: > > stopped > > in > > /usr/obj/usr/src/amd64.amd64/sys/THOR/usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-5.2.0/out/freebsd.amd64/release/bin/src/vboxdrv > > *** Error

svn commit: r325437 - head/share/mk

2017-11-05 Thread Bryan Drewery
Author: bdrewery Date: Sun Nov 5 16:28:05 2017 New Revision: 325437 URL: https://svnweb.freebsd.org/changeset/base/325437 Log: Follow-up r325405: Fix assertion still for kernel module builds. Apparently they have SRCTOP set, but won't have RELDIR set since they are not in-tree. Poin

Re: svn commit: r325404 - head/share/mk

2017-11-05 Thread Bryan Drewery
On 11/5/2017 8:00 AM, Bryan Drewery wrote: > On 11/5/2017 2:16 AM, O. Hartmann wrote: >> Am Sat, 4 Nov 2017 22:31:33 +0100 >> "O. Hartmann" schrieb: >> >>> Am Sat, 4 Nov 2017 21:02:27 + (UTC) >>> "Simon J. Gerraty" schrieb: >>> Author: sjg Date: Sat Nov 4 21:02:26 2017 New Rev

Re: svn commit: r325404 - head/share/mk

2017-11-05 Thread Bryan Drewery
On 11/5/2017 8:26 AM, Simon J. Gerraty wrote: > Bryan Drewery wrote: >>> ${.OBJDIR} == /${RELDIR})) make[6]: Fatal errors encountered -- cannot >>> continue make[6]: >>> stopped >>> in >>> /usr/obj/usr/src/amd64.amd64/sys/THOR/usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-5.2.0/out/fre

svn commit: r325438 - head/sys/arm/include

2017-11-05 Thread Michal Meloun
Author: mmel Date: Sun Nov 5 16:52:54 2017 New Revision: 325438 URL: https://svnweb.freebsd.org/changeset/base/325438 Log: All CP15 registers are bit fields or counters, don't use signed type when accessing them. MFC after:3 weeks Modified: head/sys/arm/include/cpu-v4.h head/sys

Re: svn commit: r325404 - head/share/mk

2017-11-05 Thread Simon J. Gerraty
Bryan Drewery wrote: > I only find RELDIR useful in the non-kernel builds, so I don't really > care to extend it here. Yes I said as much in the other thread. ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-h

svn commit: r325439 - head/sys/arm/arm

2017-11-05 Thread Michal Meloun
Author: mmel Date: Sun Nov 5 17:14:44 2017 New Revision: 325439 URL: https://svnweb.freebsd.org/changeset/base/325439 Log: Remove support for ARMv6/v7 platform from elf_trampoline. The elf_trampoline.c is not connected to build for ARMv6/v7 for long time and it uses outdated low level cp

Re: svn commit: r325386 - head/sys/kern

2017-11-05 Thread Conrad Meyer
On Sun, Nov 5, 2017 at 5:06 AM, Konstantin Belousov wrote: > On Sat, Nov 04, 2017 at 12:04:56PM -0700, Conrad Meyer wrote: >> This is a functional change, because MPASS (via KASSERT) is only >> enabled on DEBUG kernels. Ideally we would have a kind of ASSERT that >> worked on NODEBUG kernels. > W

Re: svn commit: r325386 - head/sys/kern

2017-11-05 Thread Konstantin Belousov
On Sun, Nov 05, 2017 at 09:16:28AM -0800, Conrad Meyer wrote: > On Sun, Nov 5, 2017 at 5:06 AM, Konstantin Belousov > wrote: > > On Sat, Nov 04, 2017 at 12:04:56PM -0700, Conrad Meyer wrote: > >> This is a functional change, because MPASS (via KASSERT) is only > >> enabled on DEBUG kernels. Idea

svn commit: r325440 - head/lib/libc/gen

2017-11-05 Thread Benedict Reuschling
Author: bcr (doc committer) Date: Sun Nov 5 18:24:31 2017 New Revision: 325440 URL: https://svnweb.freebsd.org/changeset/base/325440 Log: The last example used LOG_INFO, but the message itself said error. Change to LOG_ERR to be less confusing. PR: 216756 Submitted by

Re: svn commit: r324853 - in head/sys: kern sys

2017-11-05 Thread Bruce Evans
On Sun, 5 Nov 2017, Konstantin Belousov wrote: On Mon, Nov 06, 2017 at 01:46:49AM +1100, Bruce Evans wrote: On Sun, 5 Nov 2017, Konstantin Belousov wrote: On Sun, Nov 05, 2017 at 03:06:22AM +1100, Bruce Evans wrote: On Sun, 22 Oct 2017, Konstantin Belousov wrote: Author: kib Date: Sun Oct

Re: svn commit: r325386 - head/sys/kern

2017-11-05 Thread Conrad Meyer
E.g., --- a/sys/ufs/ffs/ffs_alloc.c +++ b/sys/ufs/ffs/ffs_alloc.c @@ -304,8 +304,7 @@ retry: } if (bp->b_blkno == bp->b_lblkno) { - if (lbprev >= UFS_NDADDR) - panic("ffs_realloccg: lbprev out of range"); + ASSERT(lbprev < UFS_NDAD

Re: svn commit: r325386 - head/sys/kern

2017-11-05 Thread Warner Losh
On Sun, Nov 5, 2017 at 11:32 AM, Conrad Meyer wrote: > E.g., > > --- a/sys/ufs/ffs/ffs_alloc.c > +++ b/sys/ufs/ffs/ffs_alloc.c > @@ -304,8 +304,7 @@ retry: > } > > if (bp->b_blkno == bp->b_lblkno) { > - if (lbprev >= UFS_NDADDR) > - panic("ffs_r

svn commit: r325441 - head/share/man/man4

2017-11-05 Thread Benedict Reuschling
Author: bcr (doc committer) Date: Sun Nov 5 18:45:43 2017 New Revision: 325441 URL: https://svnweb.freebsd.org/changeset/base/325441 Log: Extend the synopsis section of md(4) to look more like other manpages of this kind. Describe how to compile the driver into the kernel and how to load i

Re: svn commit: r325386 - head/sys/kern

2017-11-05 Thread Oliver Pinter
On 11/5/17, Warner Losh wrote: > On Sun, Nov 5, 2017 at 11:32 AM, Conrad Meyer wrote: > >> E.g., >> >> --- a/sys/ufs/ffs/ffs_alloc.c >> +++ b/sys/ufs/ffs/ffs_alloc.c >> @@ -304,8 +304,7 @@ retry: >> } >> >> if (bp->b_blkno == bp->b_lblkno) { >> - if (lbprev >= UFS_ND

Re: svn commit: r325368 - head/sys/kern

2017-11-05 Thread Ian Lepore
On Fri, 2017-11-03 at 17:22 -0400, Ed Maste wrote: > "On 3 November 2017 at 16:42, Bryan Drewery > wrote: > > > > > > > > > >   Differential Revision:  D12929 > > Apparently this format closes the review now? I thought we needed a > > full > > URL? > Interesting, Phabricator reports "We fou

Re: svn commit: r325386 - head/sys/kern

2017-11-05 Thread Konstantin Belousov
On Sun, Nov 05, 2017 at 11:42:51AM -0700, Warner Losh wrote: > On Sun, Nov 5, 2017 at 11:32 AM, Conrad Meyer wrote: > > > E.g., > > > > --- a/sys/ufs/ffs/ffs_alloc.c > > +++ b/sys/ufs/ffs/ffs_alloc.c > > @@ -304,8 +304,7 @@ retry: > > } > > > > if (bp->b_blkno == bp->b_lblkno) { >

Re: svn commit: r325386 - head/sys/kern

2017-11-05 Thread Andriy Gapon
On 05/11/2017 21:02, Konstantin Belousov wrote: > On Sun, Nov 05, 2017 at 11:42:51AM -0700, Warner Losh wrote: >> On Sun, Nov 5, 2017 at 11:32 AM, Conrad Meyer wrote: >> >>> E.g., >>> >>> --- a/sys/ufs/ffs/ffs_alloc.c >>> +++ b/sys/ufs/ffs/ffs_alloc.c >>> @@ -304,8 +304,7 @@ retry: >>> } >

Re: svn commit: r325386 - head/sys/kern

2017-11-05 Thread Conrad Meyer
On Sun, Nov 5, 2017 at 11:13 AM, Andriy Gapon wrote: > I guess (only guess) that Conrad is saying that it would be useful to have a > macro like KASSERT but which would be always active regardless of INVARIANTS. > E.g. in illumos they have ASSERT and VERIFY. Yes, exactly. There are numerous plac

svn commit: r325442 - in head/lib/libclang_rt: . profile

2017-11-05 Thread Ngie Cooper
Author: ngie Date: Sun Nov 5 19:25:06 2017 New Revision: 325442 URL: https://svnweb.freebsd.org/changeset/base/325442 Log: Support compiling lib/libclang_rt/profile a bit more with recent versions of gcc Several of the flags were being treated as CFLAGS, when they were actually technica

Re: svn commit: r325386 - head/sys/kern

2017-11-05 Thread Ian Lepore
On Sun, 2017-11-05 at 11:24 -0800, Conrad Meyer wrote: > On Sun, Nov 5, 2017 at 11:13 AM, Andriy Gapon wrote: > > > > I guess (only guess) that Conrad is saying that it would be useful to have a > > macro like KASSERT but which would be always active regardless of > > INVARIANTS. > > E.g. in ill

svn commit: r325443 - in head: . lib/libclang_rt share/mk

2017-11-05 Thread Ngie Cooper
eFiles.inc == --- head/ObsoleteFiles.inc Sun Nov 5 19:25:06 2017(r325442) +++ head/ObsoleteFiles.inc Sun Nov 5 19:38:51 2017(r325443) @@ -38,6 +38,21 @@ # xargs -n1 | sort | uniq -d; # done +# 20171105: fixing lib/libclang_rt CRTARCH for arm:armv[67]. +.if ${MACHIN

Re: svn commit: r325442 - in head/lib/libclang_rt: . profile

2017-11-05 Thread Ngie Cooper (yaneurabeya)
> On Nov 5, 2017, at 11:25, Ngie Cooper wrote: > > Author: ngie > Date: Sun Nov 5 19:25:06 2017 > New Revision: 325442 > URL: https://svnweb.freebsd.org/changeset/base/325442 > > Log: > Support compiling lib/libclang_rt/profile a bit more with recent versions of > gcc > > Several of the fl

Re: svn commit: r325443 - in head: . lib/libclang_rt share/mk

2017-11-05 Thread Ngie Cooper (yaneurabeya)
> On Nov 5, 2017, at 11:38, Ngie Cooper wrote: > > Author: ngie > Date: Sun Nov 5 19:38:51 2017 > New Revision: 325443 > URL: https://svnweb.freebsd.org/changeset/base/325443 > > Log: > Fix paths for cross-built versions of lib/libclang_rt and hardfloat arm > variants > > - Define TARGET_C

svn commit: r325444 - head/sys/kern

2017-11-05 Thread Ed Maste
Author: emaste Date: Sun Nov 5 19:49:44 2017 New Revision: 325444 URL: https://svnweb.freebsd.org/changeset/base/325444 Log: ANSIfy sys/kern/md4c.c PR: 223453 Submitted by: o...@j.email.ne.jp MFC After:2 weeks Modified: head/sys/kern/md4c.c Modified: head/sys/kern/md4

Re: svn commit: r325443 - in head: . lib/libclang_rt share/mk

2017-11-05 Thread Warner Losh
les.inc Sun Nov 5 19:25:06 2017(r325442) > +++ head/ObsoleteFiles.inc Sun Nov 5 19:38:51 2017(r325443) > @@ -38,6 +38,21 @@ > # xargs -n1 | sort | uniq -d; > # done > > +# 20171105: fixing lib/libclang_rt CRTARCH for arm:armv[67]. > +.if ${MACHINE} == &qu

Re: svn commit: r325443 - in head: . lib/libclang_rt share/mk

2017-11-05 Thread Warner Losh
t;> Modified: head/ObsoleteFiles.inc >> ==== >> == >> --- head/ObsoleteFiles.inc Sun Nov 5 19:25:06 2017(r325442) >> +++ head/ObsoleteFiles.inc Sun Nov 5 19:38:51 2017(r325443) >>

svn commit: r325446 - in head: . lib/libclang_rt share/mk

2017-11-05 Thread Ngie Cooper
eFiles.inc == --- head/ObsoleteFiles.inc Sun Nov 5 19:52:11 2017(r325445) +++ head/ObsoleteFiles.inc Sun Nov 5 20:01:00 2017(r325446) @@ -38,21 +38,6 @@ # xargs -n1 | sort | uniq -d; # done -# 20171105: fixing lib/libclang_rt CRTARCH for arm:armv

svn commit: r325447 - head/sys/amd64/amd64

2017-11-05 Thread Konstantin Belousov
Author: kib Date: Sun Nov 5 20:03:57 2017 New Revision: 325447 URL: https://svnweb.freebsd.org/changeset/base/325447 Log: Zero the structure instead of the pointer to it. Reported by: Don Morris MFC after:4 days Modified: head/sys/amd64/amd64/pmap.c Modified: head/sys/amd64/amd

Re: svn commit: r325446 - in head: . lib/libclang_rt share/mk

2017-11-05 Thread Warner Losh
9:52:11 2017(r325445) > +++ head/ObsoleteFiles.inc Sun Nov 5 20:01:00 2017(r325446) > @@ -38,21 +38,6 @@ > # xargs -n1 | sort | uniq -d; > # done > > -# 20171105: fixing lib/libclang_rt CRTARCH for arm:armv[67]. > -.if ${MACHINE} == "arm" &g

Re: svn commit: r325386 - head/sys/kern

2017-11-05 Thread Konstantin Belousov
On Sun, Nov 05, 2017 at 12:37:50PM -0700, Ian Lepore wrote: > IMO, the only reason ASSERT-style macros exist is to hide the > conditional-on-build-type part of the operation.  That is, to avoid > having #ifdef INVARIANTS scattered everywhere. bde' point is that KASSERT() is badly designed, and I ag

Re: svn commit: r325386 - head/sys/kern

2017-11-05 Thread Mateusz Guzik
On Sun, Nov 5, 2017 at 9:15 PM, Konstantin Belousov wrote: > On Sun, Nov 05, 2017 at 12:37:50PM -0700, Ian Lepore wrote: > > IMO, the only reason ASSERT-style macros exist is to hide the > > conditional-on-build-type part of the operation. That is, to avoid > > having #ifdef INVARIANTS scattered

svn commit: r325449 - in head: . lib/libclang_rt

2017-11-05 Thread Ngie Cooper
) +++ head/ObsoleteFiles.inc Sun Nov 5 20:38:40 2017(r325449) @@ -38,6 +38,21 @@ # xargs -n1 | sort | uniq -d; # done +# 20171105: fixing lib/libclang_rt CRTARCH for arm:armv[67]. +.if ${MACHINE} == "arm" +.if ${MACHINE_ARCH:Marmv[67]*} != ""

svn commit: r325450 - head/bin/rm

2017-11-05 Thread Ngie Cooper
Author: ngie Date: Sun Nov 5 21:43:26 2017 New Revision: 325450 URL: https://svnweb.freebsd.org/changeset/base/325450 Log: Fix cosmetic nit when printing out "override $mode" and "$owner/$group ..." The wrong index was being checked for == ' ' in the resulting stringified mode from strmo

svn commit: r325451 - head/sys/kern

2017-11-05 Thread Mateusz Guzik
Author: mjg Date: Sun Nov 5 21:59:39 2017 New Revision: 325451 URL: https://svnweb.freebsd.org/changeset/base/325451 Log: namecache: skip locking in cache_lookup_nomakeentry if there is no entry Modified: head/sys/kern/vfs_cache.c Modified: head/sys/kern/vfs_cache.c

svn commit: r325452 - in head: . rescue/rescue sbin sbin/badsect sys/mips/rmi usr.sbin/crunch/examples

2017-11-05 Thread Konstantin Belousov
# 20171105: fixing lib/libclang_rt CRTARCH for arm:armv[67]. .if ${MACHINE} == "arm" .if ${MACHINE_ARCH:Marmv[67]*} != "" && ${CPUTYPE:M*soft*} == "" Modified: head/rescue/rescue/Makefile

svn commit: r325453 - head/sys/powerpc/mpc85xx

2017-11-05 Thread Justin Hibbits
Author: jhibbits Date: Sun Nov 5 22:09:59 2017 New Revision: 325453 URL: https://svnweb.freebsd.org/changeset/base/325453 Log: Fix an off-by-one error missed in the initial commit of this driver When the segment count is > 16 it spills into an 'indirect descriptor list', which immediatel

svn commit: r325456 - head/sys/kern

2017-11-05 Thread Mateusz Guzik
Author: mjg Date: Sun Nov 5 22:28:39 2017 New Revision: 325456 URL: https://svnweb.freebsd.org/changeset/base/325456 Log: namecache: wlock buckets in cache_lookup_nomakeentry Since the case of an empty chain was already covered, it si very likely that the existing entry is matching. Skip

svn commit: r325458 - head/sys/kern

2017-11-05 Thread Mateusz Guzik
Author: mjg Date: Sun Nov 5 22:29:45 2017 New Revision: 325458 URL: https://svnweb.freebsd.org/changeset/base/325458 Log: namecache: bump numcache after dropping all locks This makes no difference correctness-wise, but shortens total hold time. Modified: head/sys/kern/vfs_cache.c Modif

svn commit: r325457 - head/release/scripts

2017-11-05 Thread Bryan Drewery
Author: bdrewery Date: Sun Nov 5 22:29:34 2017 New Revision: 325457 URL: https://svnweb.freebsd.org/changeset/base/325457 Log: Rework r325076: Just use the pre-existing OBJDIR. Like was done in usr.sbin/mergemaster in r249906, we can just use the already-built OBJDIR for install(1).

Re: svn commit: r325368 - head/sys/kern

2017-11-05 Thread Bryan Drewery
On 11/5/2017 10:56 AM, Ian Lepore wrote: > On Fri, 2017-11-03 at 17:22 -0400, Ed Maste wrote: >> "On 3 November 2017 at 16:42, Bryan Drewery >> wrote: >>> >>>   Differential Revision:  D12929 >>> Apparently this format closes the review now? I thought we needed a >>> full >>> URL? >>

svn commit: r325468 - head/sys/powerpc/mpc85xx

2017-11-05 Thread Justin Hibbits
Author: jhibbits Date: Mon Nov 6 05:09:18 2017 New Revision: 325468 URL: https://svnweb.freebsd.org/changeset/base/325468 Log: Set the PRD extension list base address in little endian All data accesses with the SATA controller are little endian. This was missed when writing the extensio

svn commit: r325469 - head/sys/kern

2017-11-05 Thread Mateusz Guzik
Author: mjg Date: Mon Nov 6 05:14:05 2017 New Revision: 325469 URL: https://svnweb.freebsd.org/changeset/base/325469 Log: rwlock: fix up compilation without KDTRACE_HOOKS after r324787 Modified: head/sys/kern/kern_rwlock.c Modified: head/sys/kern/kern_rwlock.c ==

Re: svn commit: r325444 - head/sys/kern

2017-11-05 Thread Bruce Evans
On Sun, 5 Nov 2017, Ed Maste wrote: Log: ANSIfy sys/kern/md4c.c PR:223453 Submitted by: o...@j.email.ne.jp MFC After: 2 weeks This doesn't ANSIfy md4c.c, but churns its style away from both the vendor version and the copy in libmd. The style is very non-KNF, but is prese

Re: svn commit: r325386 - head/sys/kern

2017-11-05 Thread Bruce Evans
On Sun, 5 Nov 2017, Mateusz Guzik wrote: On Sun, Nov 5, 2017 at 9:15 PM, Konstantin Belousov wrote: On Sun, Nov 05, 2017 at 12:37:50PM -0700, Ian Lepore wrote: IMO, the only reason ASSERT-style macros exist is to hide the conditional-on-build-type part of the operation. That is, to avoid ha

Re: svn commit: r325386 - head/sys/kern

2017-11-05 Thread Bruce Evans
On Sun, 5 Nov 2017, Konstantin Belousov wrote: On Sun, Nov 05, 2017 at 11:42:51AM -0700, Warner Losh wrote: On Sun, Nov 5, 2017 at 11:32 AM, Conrad Meyer wrote: E.g., --- a/sys/ufs/ffs/ffs_alloc.c +++ b/sys/ufs/ffs/ffs_alloc.c @@ -304,8 +304,7 @@ retry: } if (bp->b_blkno ==