Re: svn commit: r314945 - head/sys/boot/i386/libi386

2017-03-09 Thread Bruce Evans
On Thu, 9 Mar 2017, Mariusz Zaborski wrote: Log: Some style(9) fixes. No functional changes. Submitted by: kczekirda Sponsored by: Oktawave MFC after: 3 weeks Differential Revision: https://reviews.freebsd.org/D9395 About half of this is backwards, or just moves the style bugs. M

svn commit: r314953 - head/sys/compat/linuxkpi/common/src

2017-03-09 Thread Hans Petter Selasky
Author: hselasky Date: Thu Mar 9 09:17:43 2017 New Revision: 314953 URL: https://svnweb.freebsd.org/changeset/base/314953 Log: Don't create any threads before SI_SUB_INIT_IF in the LinuxKPI. Else kthread_add() will assert it is called too soon. This fixes a startup issue when COMPAT_LINUXKP

svn commit: r314954 - head/lib/libc/tests/sys

2017-03-09 Thread Ngie Cooper
Author: ngie Date: Thu Mar 9 09:25:11 2017 New Revision: 314954 URL: https://svnweb.freebsd.org/changeset/base/314954 Log: style(9): sort the #includes MFC after:1 week Sponsored by: Dell EMC Isilon Modified: head/lib/libc/tests/sys/mlock_helper.c Modified: head/lib/libc/tests/sy

svn commit: r314955 - head/sys/netpfil/ipfw

2017-03-09 Thread Maxim Konovalov
Author: maxim Date: Thu Mar 9 09:54:23 2017 New Revision: 314955 URL: https://svnweb.freebsd.org/changeset/base/314955 Log: o Typo in the comment fixed. PR: 217617 Submitted by: lutz Modified: head/sys/netpfil/ipfw/ip_fw_table.c Modified: head/sys/netpfil/ipfw/ip_fw_table.c

Re: svn commit: r314862 - head/sys/modules/qlxgbe

2017-03-09 Thread Bruce Evans
On Wed, 8 Mar 2017, Gleb Smirnoff wrote: On Wed, Mar 08, 2017 at 07:47:13PM +1100, Bruce Evans wrote: B> > On 08/03/2017 00:17, Gleb Smirnoff wrote: B> >> On Tue, Mar 07, 2017 at 03:43:49PM +, Andriy Gapon wrote: B> >> A> Author: avg B> >> A> Date: Tue Mar 7 15:43:49 2017 B> >> A> New Revis

svn commit: r314956 - head/sys/boot/efi/loader

2017-03-09 Thread Dexuan Cui
Author: dexuan Date: Thu Mar 9 12:09:07 2017 New Revision: 314956 URL: https://svnweb.freebsd.org/changeset/base/314956 Log: loader.efi: only reduce the size of the staging area on Hyper-V Doing this on physical hosts turns out to be problematic, e.g. see comment 24 and 28 in https://bug

svn commit: r314960 - head/sys/sys

2017-03-09 Thread Konstantin Belousov
Author: kib Date: Thu Mar 9 13:41:57 2017 New Revision: 314960 URL: https://svnweb.freebsd.org/changeset/base/314960 Log: Fix typo in comment. Sponsored by: The FreeBSD Foundation MFC after:3 days Modified: head/sys/sys/signalvar.h Modified: head/sys/sys/signalvar.h =

svn commit: r314961 - head/usr.bin/localedef

2017-03-09 Thread Pedro F. Giffuni
Author: pfg Date: Thu Mar 9 15:21:03 2017 New Revision: 314961 URL: https://svnweb.freebsd.org/changeset/base/314961 Log: localedef(1): Fix for memory leaks reported by coverity. Also some small cleanups to match better current illumos. CID: 1338540, 1338541, 1338557, 1338566 Obt

Re: svn commit: r314961 - head/usr.bin/localedef

2017-03-09 Thread Rodney W. Grimes
> Author: pfg > Date: Thu Mar 9 15:21:03 2017 > New Revision: 314961 > URL: https://svnweb.freebsd.org/changeset/base/314961 > > Log: > localedef(1): Fix for memory leaks reported by coverity. > > Also some small cleanups to match better current illumos. > > CID: 1338540, 1338541, 133

Re: svn commit: r314961 - head/usr.bin/localedef

2017-03-09 Thread Warner Losh
On Thu, Mar 9, 2017 at 8:26 AM, Rodney W. Grimes wrote: >> Author: pfg >> Date: Thu Mar 9 15:21:03 2017 >> New Revision: 314961 >> URL: https://svnweb.freebsd.org/changeset/base/314961 >> >> Log: >> localedef(1): Fix for memory leaks reported by coverity. >> >> Also some small cleanups to mat

Re: svn commit: r314961 - head/usr.bin/localedef

2017-03-09 Thread Warner Losh
On Thu, Mar 9, 2017 at 8:29 AM, Warner Losh wrote: > On Thu, Mar 9, 2017 at 8:26 AM, Rodney W. Grimes > wrote: >>> Author: pfg >>> Date: Thu Mar 9 15:21:03 2017 >>> New Revision: 314961 >>> URL: https://svnweb.freebsd.org/changeset/base/314961 >>> >>> Log: >>> localedef(1): Fix for memory leak

Re: svn commit: r314961 - head/usr.bin/localedef

2017-03-09 Thread Pedro Giffuni
On 3/9/2017 10:26 AM, Rodney W. Grimes wrote: Author: pfg Date: Thu Mar 9 15:21:03 2017 New Revision: 314961 URL: https://svnweb.freebsd.org/changeset/base/314961 Log: localedef(1): Fix for memory leaks reported by coverity. Also some small cleanups to match better current illumos.

svn commit: r314962 - head/sys/boot/efi/loader

2017-03-09 Thread Dexuan Cui
Author: dexuan Date: Thu Mar 9 15:44:25 2017 New Revision: 314962 URL: https://svnweb.freebsd.org/changeset/base/314962 Log: loader.efi: only include the machine/ header files on x86 The 2 files may not exist on other archs like aarch64 and hence we can have a build failure there. R

Re: svn commit: r314961 - head/usr.bin/localedef

2017-03-09 Thread Warner Losh
On Thu, Mar 9, 2017 at 8:37 AM, Pedro Giffuni wrote: > > On 3/9/2017 10:26 AM, Rodney W. Grimes wrote: >>> >>> Author: pfg >>> Date: Thu Mar 9 15:21:03 2017 >>> New Revision: 314961 >>> URL: https://svnweb.freebsd.org/changeset/base/314961 >>> >>> Log: >>>localedef(1): Fix for memory leaks re

svn commit: r314963 - head/usr.sbin/fstyp

2017-03-09 Thread Alan Somers
Author: asomers Date: Thu Mar 9 16:22:21 2017 New Revision: 314963 URL: https://svnweb.freebsd.org/changeset/base/314963 Log: Fix harmless mismerge from r286964 MFC after:3 days Sponsored by: Spectra Logic Corp Modified: head/usr.sbin/fstyp/Makefile Modified: head/usr.sbin/fstyp/

svn commit: r314964 - head/sbin/camcontrol

2017-03-09 Thread Alexander Motin
Author: mav Date: Thu Mar 9 16:34:55 2017 New Revision: 314964 URL: https://svnweb.freebsd.org/changeset/base/314964 Log: Decode modern PIM flags. MFC after:2 weeks Modified: head/sbin/camcontrol/camcontrol.c Modified: head/sbin/camcontrol/camcontrol.c =

svn commit: r314965 - head/sys/compat/linuxkpi/common/include/linux

2017-03-09 Thread Hans Petter Selasky
Author: hselasky Date: Thu Mar 9 17:01:00 2017 New Revision: 314965 URL: https://svnweb.freebsd.org/changeset/base/314965 Log: Cleanup the LinuxKPI mutex wrappers. Add support for using mutexes during KDB and shutdown. This is also required for doing mode-switching during panic for drm-n

svn commit: r314966 - head/sys/dev/mpt

2017-03-09 Thread Alexander Motin
Author: mav Date: Thu Mar 9 17:06:34 2017 New Revision: 314966 URL: https://svnweb.freebsd.org/changeset/base/314966 Log: Report FC link speed. MFC after:2 weeks Modified: head/sys/dev/mpt/mpt_cam.c Modified: head/sys/dev/mpt/mpt_cam.c ==

svn commit: r314967 - head/sys/dev/mpt

2017-03-09 Thread Alexander Motin
Author: mav Date: Thu Mar 9 17:35:35 2017 New Revision: 314967 URL: https://svnweb.freebsd.org/changeset/base/314967 Log: Add support for XPT_GET_SIM_KNOB in FC mode. MFC after:2 weeks Modified: head/sys/dev/mpt/mpt.h head/sys/dev/mpt/mpt_cam.c Modified: head/sys/dev/mpt/mpt.h ==

Re: svn commit: r314961 - head/usr.bin/localedef

2017-03-09 Thread O. Hartmann
Am Thu, 9 Mar 2017 15:21:03 + (UTC) "Pedro F. Giffuni" schrieb: > Author: pfg > Date: Thu Mar 9 15:21:03 2017 > New Revision: 314961 > URL: https://svnweb.freebsd.org/changeset/base/314961 > > Log: > localedef(1): Fix for memory leaks reported by coverity. > > Also some small cleanup

Re: svn commit: r314961 - head/usr.bin/localedef

2017-03-09 Thread Pedro Giffuni
On 3/9/2017 12:50 PM, O. Hartmann wrote: Am Thu, 9 Mar 2017 15:21:03 + (UTC) "Pedro F. Giffuni" schrieb: ... Something broke buildworld, I presume: /usr/src/share/colldef/af_ZA.UTF-8.src: 2421: error: Bad file descriptor *** [af_ZA.ISO8859-1.LC_COLLATE] Error code 4 make[4]: stopped i

svn commit: r314968 - head/sys/dev/mpt

2017-03-09 Thread Alexander Motin
Author: mav Date: Thu Mar 9 17:53:37 2017 New Revision: 314968 URL: https://svnweb.freebsd.org/changeset/base/314968 Log: Report some more data in XPT_PATH_INQ. I am not sure they are used anywhere, but why not. MFC after:2 weeks Modified: head/sys/dev/mpt/mpt.h head/sys/dev/

Re: svn commit: r314961 - head/usr.bin/localedef

2017-03-09 Thread Konstantin Belousov
On Thu, Mar 09, 2017 at 03:21:03PM +, Pedro F. Giffuni wrote: > void > +delete_category(FILE *f) > +{ > + (void) fclose(f); > + (void) unlink(category_file()); > +} > + > +void > close_category(FILE *f) > { > - if (fchmod(fileno(f), 0644) < 0) { > + if (fchmod(fileno(f), 0644

svn commit: r314969 - head/usr.bin/localedef

2017-03-09 Thread Pedro F. Giffuni
Author: pfg Date: Thu Mar 9 18:06:48 2017 New Revision: 314969 URL: https://svnweb.freebsd.org/changeset/base/314969 Log: localedef(1): Fix mismatch in previous commit. delete_category is meant to replace fclose() and unlink(). This broke world. Found by: kib Pointedhat: pfg

Re: svn commit: r314969 - head/usr.bin/localedef

2017-03-09 Thread Konstantin Belousov
On Thu, Mar 09, 2017 at 06:06:48PM +, Pedro F. Giffuni wrote: > Author: pfg > Date: Thu Mar 9 18:06:48 2017 > New Revision: 314969 > URL: https://svnweb.freebsd.org/changeset/base/314969 > > Log: > localedef(1): Fix mismatch in previous commit. > > delete_category is meant to replace f

Re: svn commit: r314969 - head/usr.bin/localedef

2017-03-09 Thread Pedro Giffuni
Hello; On 3/9/2017 1:11 PM, Konstantin Belousov wrote: On Thu, Mar 09, 2017 at 06:06:48PM +, Pedro F. Giffuni wrote: Author: pfg Date: Thu Mar 9 18:06:48 2017 New Revision: 314969 URL: https://svnweb.freebsd.org/changeset/base/314969 Log: localedef(1): Fix mismatch in previous commit.

svn commit: r314970 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf modules/linuxkpi

2017-03-09 Thread Hans Petter Selasky
Author: hselasky Date: Thu Mar 9 18:33:40 2017 New Revision: 314970 URL: https://svnweb.freebsd.org/changeset/base/314970 Log: Implement support for mutexes with deadlock avoidance in the LinuxKPI. When locking a mutex and deadlock is detected the first mutex lock call that sees the dead

svn commit: r314971 - head/sys/compat/linuxkpi/common/include/linux

2017-03-09 Thread Hans Petter Selasky
Author: hselasky Date: Thu Mar 9 18:37:17 2017 New Revision: 314971 URL: https://svnweb.freebsd.org/changeset/base/314971 Log: Fix implementation of the DECLARE_WORK() macro in the LinuxKPI to fully initialize the declared work structure and not only the function callback pointer. MFC

svn commit: r314972 - head/usr.bin/localedef

2017-03-09 Thread Pedro F. Giffuni
Author: pfg Date: Thu Mar 9 19:02:36 2017 New Revision: 314972 URL: https://svnweb.freebsd.org/changeset/base/314972 Log: Revert r314969, r314961: The localdef(1) changes are breaking world: 00:18:40.750 /usr/src/share/colldef/af_ZA.UTF-8.src: 2421: error: Bad file descriptor I

Re: svn commit: r314969 - head/usr.bin/localedef

2017-03-09 Thread Bryan Drewery
On 3/9/2017 10:06 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Thu Mar 9 18:06:48 2017 > New Revision: 314969 > URL: https://svnweb.freebsd.org/changeset/base/314969 > > Log: > localedef(1): Fix mismatch in previous commit. > > delete_category is meant to replace fclose() and unlink()

Re: svn commit: r314972 - head/usr.bin/localedef

2017-03-09 Thread Bryan Drewery
On 3/9/2017 11:02 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Thu Mar 9 19:02:36 2017 > New Revision: 314972 > URL: https://svnweb.freebsd.org/changeset/base/314972 > > Log: > Revert r314969, r314961: > > The localdef(1) changes are breaking world: > > 00:18:40.750 /usr/src/shar

svn commit: r314973 - head/libexec/rtld-elf

2017-03-09 Thread Konstantin Belousov
Author: kib Date: Thu Mar 9 21:05:47 2017 New Revision: 314973 URL: https://svnweb.freebsd.org/changeset/base/314973 Log: Avoid bind lock recursion. When dlclose(3) unloads an object with filtees, it recursively calls dlclose(3) on each filtee in free_needed_filtees(). Introduce dlclo

Re: svn commit: r314862 - head/sys/modules/qlxgbe

2017-03-09 Thread Gleb Smirnoff
Bruce, On Thu, Mar 09, 2017 at 10:51:17PM +1100, Bruce Evans wrote: B> > Bruce, I am sorry, I can't resist from asking that in a straight unpolite way: B> > B> > Unportable to what? Back to XX century? B> B> Unportable to all versions of standard C up to and including at least B> C11. Unporta

svn commit: r314974 - head/usr.bin/localedef

2017-03-09 Thread Pedro F. Giffuni
Author: pfg Date: Thu Mar 9 21:49:11 2017 New Revision: 314974 URL: https://svnweb.freebsd.org/changeset/base/314974 Log: localedef(1): Fix small coverity issues. - Operands don't affect result (CONSTANT_EXPRESSION_RESULT) - Buffer not null terminated (BUFFER_SIZE_WARNING) CID: 133

svn commit: r314987 - head/usr.sbin/camdd

2017-03-09 Thread Marcelo Araujo
Author: araujo Date: Fri Mar 10 04:24:21 2017 New Revision: 314987 URL: https://svnweb.freebsd.org/changeset/base/314987 Log: Use nitems() from sys/param.h. Reviewed by: asomers MFC after:3 weeks. Differential Revision:https://reviews.freebsd.org/D9944 Modified: head/usr

svn commit: r314988 - head/usr.bin/w

2017-03-09 Thread Marcelo Araujo
Author: araujo Date: Fri Mar 10 04:30:31 2017 New Revision: 314988 URL: https://svnweb.freebsd.org/changeset/base/314988 Log: Use nitems() from sys/param.h. Reviewed by: ume MFC after:3 weeks. Differential Revision:https://reviews.freebsd.org/D9938 Modified: head/usr.bin

svn commit: r314989 - head/usr.bin/vmstat

2017-03-09 Thread Marcelo Araujo
Author: araujo Date: Fri Mar 10 04:49:40 2017 New Revision: 314989 URL: https://svnweb.freebsd.org/changeset/base/314989 Log: Use nitems() from sys/param.h and also remove the cast. Reviewed by: markj MFC after:3 weeks. Differential Revision:https://reviews.freebsd.org/D993

svn commit: r314993 - head/usr.bin/uuencode

2017-03-09 Thread Marcelo Araujo
Author: araujo Date: Fri Mar 10 06:23:15 2017 New Revision: 314993 URL: https://svnweb.freebsd.org/changeset/base/314993 Log: Use nitems() from sys/param.h. Reviewed by: ngie MFC after:3 weeks. Differential Revision:https://reviews.freebsd.org/D9936 Modified: head/usr.bi

svn commit: r314994 - head/usr.sbin/acpi/acpidump

2017-03-09 Thread Marcelo Araujo
Author: araujo Date: Fri Mar 10 06:25:54 2017 New Revision: 314994 URL: https://svnweb.freebsd.org/changeset/base/314994 Log: Use nitems() from sys/param.h. Reviewed by: ngie MFC after:3 weeks. Differential Revision:https://reviews.freebsd.org/D9940 Modified: head/usr.sb

Re: svn commit: r314862 - head/sys/modules/qlxgbe

2017-03-09 Thread Bruce Evans
On Thu, 9 Mar 2017, Gleb Smirnoff wrote: On Thu, Mar 09, 2017 at 10:51:17PM +1100, Bruce Evans wrote: B> > Bruce, I am sorry, I can't resist from asking that in a straight unpolite way: B> > B> > Unportable to what? Back to XX century? B> B> Unportable to all versions of standard C up to and in

Re: svn commit: r314989 - head/usr.bin/vmstat

2017-03-09 Thread Bruce Evans
On Fri, 10 Mar 2017, Marcelo Araujo wrote: ... Log: Use nitems() from sys/param.h and also remove the cast. Reviewed by: markj MFC after: 3 weeks. Differential Revision: https://reviews.freebsd.org/D9937 ... Modified: head/usr.bin/vmstat/vmstat.c ==