Re: svn commit: r287236 - head/bin/df

2015-08-28 Thread O'Connor, Daniel
> On 28 Aug 2015, at 15:34, Alexey Dokuchaev wrote: > On Thu, Aug 27, 2015 at 10:25:28PM -0700, NGie Cooper wrote: >> On Thu, Aug 27, 2015 at 9:43 PM, Alexey Dokuchaev wrote: >>> On Fri, Aug 28, 2015 at 12:44:59AM +, Xin LI wrote: New Revision: 287236 URL: https://svnweb.freebsd.or

Re: svn commit: r287236 - head/bin/df

2015-08-28 Thread Garrett Cooper
> On Aug 28, 2015, at 00:24, O'Connor, Daniel wrote: > >> On 28 Aug 2015, at 15:34, Alexey Dokuchaev wrote: >>> On Thu, Aug 27, 2015 at 10:25:28PM -0700, NGie Cooper wrote: On Thu, Aug 27, 2015 at 9:43 PM, Alexey Dokuchaev wrote: > On Fri, Aug 28, 2015 at 12:44:59AM +, Xin L

Re: svn commit: r287236 - head/bin/df

2015-08-28 Thread Xin Li
On 8/27/15 21:43, Alexey Dokuchaev wrote: > On Fri, Aug 28, 2015 at 12:44:59AM +, Xin LI wrote: >> New Revision: 287236 >> URL: https://svnweb.freebsd.org/changeset/base/287236 >> >> Log: >> Use exit() instead of return in main(). > > Because?.. Because the explicit exit() have a subtle d

Re: svn commit: r286880 - head/sys/kern

2015-08-28 Thread Julien Charbon
Hi Konstantin, On 27/08/15 19:19, Konstantin Belousov wrote: > On Thu, Aug 27, 2015 at 06:28:03PM +0200, Julien Charbon wrote: >> On 27/08/15 12:49, Konstantin Belousov wrote: >>> On Wed, Aug 26, 2015 at 08:14:15PM +0200, Julien Charbon wrote: As I said, I am not opposed to back out this c

svn commit: r287249 - head/sys/netinet6

2015-08-28 Thread Bjoern A. Zeeb
Author: bz Date: Fri Aug 28 09:38:18 2015 New Revision: 287249 URL: https://svnweb.freebsd.org/changeset/base/287249 Log: remove a left-over after r220463 empty #ifdef INET check. MFC after:1 week Modified: head/sys/netinet6/udp6_usrreq.c Modified: head/sys/netinet6/udp6_usrreq.c ==

svn commit: r287250 - head/sys/dev/mmc/host

2015-08-28 Thread Andrew Turner
Author: andrew Date: Fri Aug 28 10:34:37 2015 New Revision: 287250 URL: https://svnweb.freebsd.org/changeset/base/287250 Log: Only check for the bus frequency if it has not already been set, for example through a driver running as a subclass of this. Sponsored by: ABT Systems Ltd Modifie

Re: svn commit: r287217 - head/usr.sbin/syslogd

2015-08-28 Thread Bruce Evans
On Thu, 27 Aug 2015, Xin LI wrote: Log: die() would never return, mark it as so. Why? (Except to add a style bug.) Modified: head/usr.sbin/syslogd/syslogd.c == --- head/usr.sbin/syslogd/syslogd.c Thu Aug 27 17:

Re: svn commit: r287236 - head/bin/df

2015-08-28 Thread Warner Losh
On Fri, Aug 28, 2015 at 1:48 AM, Garrett Cooper wrote: > > Libxo (iirc) doesn't install atexit handlers, which means that you need to > use exit (or a reason facsimile) in order for it to flush its file streams. > > This is unintuitive though. I wish it did the right thing as part of > initializi

Re: svn commit: r287227 - in head: lib/libstand share/mk sys/boot/efi sys/boot/ficl sys/boot/i386 sys/boot/libstand32 sys/boot/pc98 sys/boot/userboot/ficl sys/boot/userboot/libstand sys/boot/zfs

2015-08-28 Thread Nikolai Lifanov
On 08/27/15 19:46, Warner Losh wrote: > Author: imp > Date: Thu Aug 27 23:46:42 2015 > New Revision: 287227 > URL: https://svnweb.freebsd.org/changeset/base/287227 > > Log: > Use CFLAGS_NO_SIMD in preference to varying lists of -mno- flags. > Go ahead and defined -D_STANDALONE for all targ

svn commit: r287253 - head/sys/conf

2015-08-28 Thread Warner Losh
Author: imp Date: Fri Aug 28 13:57:30 2015 New Revision: 287253 URL: https://svnweb.freebsd.org/changeset/base/287253 Log: Fix cleaning of files generated from .m sources. Modified: head/sys/conf/kmod.mk Modified: head/sys/conf/kmod.mk

Re: svn commit: r287227 - in head: lib/libstand share/mk sys/boot/efi sys/boot/ficl sys/boot/i386 sys/boot/libstand32 sys/boot/pc98 sys/boot/userboot/ficl sys/boot/userboot/libstand sys/boot/zfs

2015-08-28 Thread Warner Losh
I'm testing a fix now. Not sure why I didn't see it until now. Warner On Fri, Aug 28, 2015 at 7:45 AM, Nikolai Lifanov wrote: > On 08/27/15 19:46, Warner Losh wrote: > > Author: imp > > Date: Thu Aug 27 23:46:42 2015 > > New Revision: 287227 > > URL: https://svnweb.freebsd.org/changeset/base/2

Re: svn commit: r287236 - head/bin/df

2015-08-28 Thread Conrad Meyer
On Fri, Aug 28, 2015 at 1:36 AM, Xin Li wrote: > > > On 8/27/15 21:43, Alexey Dokuchaev wrote: >> On Fri, Aug 28, 2015 at 12:44:59AM +, Xin LI wrote: >>> New Revision: 287236 >>> URL: https://svnweb.freebsd.org/changeset/base/287236 >>> >>> Log: >>> Use exit() instead of return in main(). >>

svn commit: r287254 - head/sys/sys

2015-08-28 Thread Pedro F. Giffuni
Author: pfg Date: Fri Aug 28 14:06:28 2015 New Revision: 287254 URL: https://svnweb.freebsd.org/changeset/base/287254 Log: Be more GCC-friendly with attributes Being clang the default compiler, we were always giving precedence to the __has_attribute check. Unfortunately clang generally do

svn commit: r287255 - head/sys/sys

2015-08-28 Thread Pedro F. Giffuni
Author: pfg Date: Fri Aug 28 14:13:01 2015 New Revision: 287255 URL: https://svnweb.freebsd.org/changeset/base/287255 Log: trailing space Modified: head/sys/sys/cdefs.h Modified: head/sys/sys/cdefs.h == --- head/sys/

svn commit: r287256 - head/sys/fs/nfs

2015-08-28 Thread Edward Tomasz Napierala
Author: trasz Date: Fri Aug 28 14:26:11 2015 New Revision: 287256 URL: https://svnweb.freebsd.org/changeset/base/287256 Log: Fix an NFS server bug that manifested in "ls -al" displaying a plus sign on every directory exported via NFSv4 with NFSv4 ACLs enabled. Reviewed by: rmacklem@ MF

Re: svn commit: r287217 - head/usr.sbin/syslogd

2015-08-28 Thread Joerg Sonnenberger
On Fri, Aug 28, 2015 at 10:17:56PM +1000, Bruce Evans wrote: > >-static void die(int); > >+static void die(int) __dead2; > > Since the function is static, it is very easy for the compiler to see > that it doesn't return. But the compiler can't tell if it is the *intention* that the function never

svn commit: r287257 - head/sys/boot/libstand32

2015-08-28 Thread Warner Losh
Author: imp Date: Fri Aug 28 14:50:36 2015 New Revision: 287257 URL: https://svnweb.freebsd.org/changeset/base/287257 Log: Add back missing -m32 for amd64 and powerpc64 that was lost in the move to bsd.stand.mk. Modified: head/sys/boot/libstand32/Makefile Modified: head/sys/boot/libstand32

Re: svn commit: r287254 - head/sys/sys

2015-08-28 Thread Tijl Coosemans
On Fri, 28 Aug 2015 14:06:29 + (UTC) "Pedro F. Giffuni" wrote: > Author: pfg > Date: Fri Aug 28 14:06:28 2015 > New Revision: 287254 > URL: https://svnweb.freebsd.org/changeset/base/287254 > > Log: > Be more GCC-friendly with attributes > > Being clang the default compiler, we were al

svn commit: r287258 - head/sys/dev/mmc/host

2015-08-28 Thread Andrew Turner
Author: andrew Date: Fri Aug 28 15:27:55 2015 New Revision: 287258 URL: https://svnweb.freebsd.org/changeset/base/287258 Log: Move dwmmc.h to dwmmc_reg.h. This is in preperation for adding support to subclass the dwmmc driver to allow SoC specific attachments. Sponsored by: ABT Systems Lt

Re: svn commit: r287254 - head/sys/sys

2015-08-28 Thread Pedro Giffuni
On 08/28/15 10:22, Tijl Coosemans wrote: On Fri, 28 Aug 2015 14:06:29 + (UTC) "Pedro F. Giffuni" wrote: Author: pfg Date: Fri Aug 28 14:06:28 2015 New Revision: 287254 URL: https://svnweb.freebsd.org/changeset/base/287254 Log: Be more GCC-friendly with attributes Being clang the

svn commit: r287259 - head/sys/sys

2015-08-28 Thread Pedro F. Giffuni
Author: pfg Date: Fri Aug 28 15:36:05 2015 New Revision: 287259 URL: https://svnweb.freebsd.org/changeset/base/287259 Log: Add underscores to attributes when checking for __has_attribute. This is a good practice to avoid confusion with allowed macros. Suggested by: jilles Modified:

Re: svn commit: r287259 - head/sys/sys

2015-08-28 Thread Pedro Giffuni
On 08/28/15 10:36, Pedro F. Giffuni wrote: Author: pfg Date: Fri Aug 28 15:36:05 2015 New Revision: 287259 URL: https://svnweb.freebsd.org/changeset/base/287259 Log: Add underscores to attributes when checking for __has_attribute. This is a good practice to avoid confusion with allowed

svn commit: r287260 - in head/sys: pc98/include x86/include

2015-08-28 Thread Warner Losh
Author: imp Date: Fri Aug 28 15:41:09 2015 New Revision: 287260 URL: https://svnweb.freebsd.org/changeset/base/287260 Log: Add missing ofw_machdep.h. Make x86 ofw_machdep.h work pc98 too. This allows the owc module to compile on pc98 and seems preferable to adding another special case in the

Re: svn commit: r287236 - head/bin/df

2015-08-28 Thread Allan Jude
On 2015-08-28 03:48, Garrett Cooper wrote: > >> On Aug 28, 2015, at 00:24, O'Connor, Daniel wrote: >> >>> On 28 Aug 2015, at 15:34, Alexey Dokuchaev wrote: On Thu, Aug 27, 2015 at 10:25:28PM -0700, NGie Cooper wrote: > On Thu, Aug 27, 2015 at 9:43 PM, Alexey Dokuchaev > wrote: >>>

svn commit: r287262 - head/gnu/usr.bin/binutils

2015-08-28 Thread Warner Losh
Author: imp Date: Fri Aug 28 16:23:03 2015 New Revision: 287262 URL: https://svnweb.freebsd.org/changeset/base/287262 Log: Remove .WAIT hacks and put in specific dependencies. Modified: head/gnu/usr.bin/binutils/Makefile Modified: head/gnu/usr.bin/binutils/Makefile ==

Re: svn commit: r287196 - head/sys/kern

2015-08-28 Thread Hans Petter Selasky
On 08/27/15 10:15, Julien Charbon wrote: Author: jch Date: Thu Aug 27 08:15:32 2015 New Revision: 287196 URL: https://svnweb.freebsd.org/changeset/base/287196 Log: In callout_stop(), if a callout is both pending and currently being serviced return 0 (fail) but it is applicable only mpsa

svn commit: r287263 - head/sys/conf

2015-08-28 Thread Warner Losh
Author: imp Date: Fri Aug 28 16:29:38 2015 New Revision: 287263 URL: https://svnweb.freebsd.org/changeset/base/287263 Log: Comment out cleaning files, since it cleans too much. Modified: head/sys/conf/kmod.mk Modified: head/sys/conf/kmod.mk ===

Re: svn commit: r287236 - head/bin/df

2015-08-28 Thread Alexey Dokuchaev
On Fri, Aug 28, 2015 at 12:00:26PM -0400, Allan Jude wrote: > On 2015-08-28 03:48, Garrett Cooper wrote: > >> On Aug 28, 2015, at 00:24, O'Connor, Daniel wrote: > >>> On 28 Aug 2015, at 15:34, Alexey Dokuchaev wrote: > On Thu, Aug 27, 2015 at 10:25:28PM -0700, NGie Cooper wrote: > > >>>

svn commit: r287264 - head/sys/kern

2015-08-28 Thread Warner Losh
Author: imp Date: Fri Aug 28 19:53:19 2015 New Revision: 287264 URL: https://svnweb.freebsd.org/changeset/base/287264 Log: Per overwhelming sentiment in the code review, use FEATURE instead. Differential Revision: https://reviews.freebsd.org/D3488 MFC After: 2 days Modified: head/sys/k

svn commit: r287265 - head/sys/kern

2015-08-28 Thread Warner Losh
Author: imp Date: Fri Aug 28 20:06:58 2015 New Revision: 287265 URL: https://svnweb.freebsd.org/changeset/base/287265 Log: Remove now obsolete comment. MFC After: 2 days Modified: head/sys/kern/init_main.c Modified: head/sys/kern/init_main.c =

Re: svn commit: r287236 - head/bin/df

2015-08-28 Thread John Baldwin
On Friday, August 28, 2015 07:05:06 AM Conrad Meyer wrote: > On Fri, Aug 28, 2015 at 1:36 AM, Xin Li wrote: > > And then later assign a block of memory allocated from heap to it: > > > > p = malloc(size); > > > > Since p is in function scope, upon return, it's gone. If there is no > > oth

svn commit: r287268 - head/sys/dev/drm2/i915

2015-08-28 Thread Baptiste Daroussin
Author: bapt Date: Sat Aug 29 00:05:39 2015 New Revision: 287268 URL: https://svnweb.freebsd.org/changeset/base/287268 Log: Mark ValleyView/Bay Trail as not supported Modified: head/sys/dev/drm2/i915/i915_drv.c Modified: head/sys/dev/drm2/i915/i915_drv.c =

svn commit: r287270 - head/sys/net

2015-08-28 Thread Adrian Chadd
Author: adrian Date: Sat Aug 29 04:33:31 2015 New Revision: 287270 URL: https://svnweb.freebsd.org/changeset/base/287270 Log: Remove now unused (and #if 0'ed out) headers. Modified: head/sys/net/rss_config.c Modified: head/sys/net/rss_config.c

svn commit: r287276 - head/sys/powerpc/booke

2015-08-28 Thread Justin Hibbits
Author: jhibbits Date: Sat Aug 29 06:52:14 2015 New Revision: 287276 URL: https://svnweb.freebsd.org/changeset/base/287276 Log: The TLB1 TSIZE is a multiple of 4, not 2, so shift 2 bits, not 1. Modified: head/sys/powerpc/booke/pmap.c Modified: head/sys/powerpc/booke/pmap.c ==

svn commit: r287277 - head/sys/netinet

2015-08-28 Thread Adrian Chadd
Author: adrian Date: Sat Aug 29 06:58:30 2015 New Revision: 287277 URL: https://svnweb.freebsd.org/changeset/base/287277 Log: Rename rss_soft_m2cpuid() -> rss_soft_m2cpuid_v4() in preparation for an IPv6 version to show up. Submitted by: Tiwei Bie Differential Revision:https:/