Re: svn commit: r278737 - head/usr.sbin/flowctl

On Sat, 14 Feb 2015, John-Mark Gurney wrote: Bruce Evans wrote this message on Sun, Feb 15, 2015 at 17:53 +1100: On Sat, 14 Feb 2015, Pedro Giffuni wrote: On 02/14/15 13:33, Ian Lepore wrote: On Sat, 2015-02-14 at 21:15 +0300, Gleb Smirnoff wrote: On Sat, Feb 14, 2015 at 08:46:58PM +1100, B

svn commit: r278794 - head/sys/kern

Author: kib Date: Sun Feb 15 08:43:19 2015 New Revision: 278794 URL: https://svnweb.freebsd.org/changeset/base/278794 Log: Return with the process locked, caller expects p still locked after the call. Reported and tested by: bapt Sponsored by: The FreeBSD Foundation MFC after:

svn commit: r278795 - head/sys/kern

Author: kib Date: Sun Feb 15 08:44:30 2015 New Revision: 278795 URL: https://svnweb.freebsd.org/changeset/base/278795 Log: Reparenting done by debugger attach can leave reaper without direct children. Handle the situation instead asserting that it is impossible. Reported and tested by:

Re: svn commit: r278790 - head/sys/fs/ext2fs

> Il giorno 14/feb/2015, alle ore 20:12, Pedro F. Giffuni ha > scritto: > > Author: pfg > Date: Sun Feb 15 01:12:15 2015 > New Revision: 278790 > URL: https://svnweb.freebsd.org/changeset/base/278790 > > Log: > Initialize the allocation of variables related to the ext2 allocator. > > The e2

svn commit: r278797 - head/sys/arm/broadcom/bcm2835

Author: andrew Date: Sun Feb 15 11:23:27 2015 New Revision: 278797 URL: https://svnweb.freebsd.org/changeset/base/278797 Log: Add the structures needed to get/set the power state. These can be used when, for example, we boot without U-Boot and wish to enable USB, or to suspend an unneeded de

svn commit: r278798 - in head/sys: conf dev/videomode modules/videomode

Author: hselasky Date: Sun Feb 15 11:37:40 2015 New Revision: 278798 URL: https://svnweb.freebsd.org/changeset/base/278798 Log: Import videomode code from NetBSD which is needed by USB display link drivers. Added: head/sys/dev/videomode/ head/sys/dev/videomode/Makefile.ediddevs (contents,

svn commit: r278799 - in head: share/man/man4 sys/conf sys/dev/usb sys/dev/usb/video sys/modules/usb/udl

Author: hselasky Date: Sun Feb 15 12:02:17 2015 New Revision: 278799 URL: https://svnweb.freebsd.org/changeset/base/278799 Log: Import USB display link driver from OpenBSD. Support for compression has been removed and the driver has been greatly simplified and optimised for FreeBSD. The driv

svn commit: r278802 - head/sys/fs/ext2fs

Author: pfg Date: Sun Feb 15 14:25:00 2015 New Revision: 278802 URL: https://svnweb.freebsd.org/changeset/base/278802 Log: ext2fs: Plug small memory leak free() e2fs_contigdirs upon error. Undo zeroing of e2fs_gd as this was actually a false positive. X-MFC with: 278790 Modified:

svn commit: r278803 - head/lib/libc/gen

Author: pfg Date: Sun Feb 15 14:31:50 2015 New Revision: 278803 URL: https://svnweb.freebsd.org/changeset/base/278803 Log: ulimit(3): Fix broken check. The existing implementation had a broken comparison that could overflow and return confusing values. Replace this with a check that av

svn commit: r278804 - head/lib/libc/gen

Author: pfg Date: Sun Feb 15 16:50:21 2015 New Revision: 278804 URL: https://svnweb.freebsd.org/changeset/base/278804 Log: More tidy-ups on uninitialized scalar variable As a followup to r278363, there is one more case where stayopen can be accessed uninitialized, but even after swappin

svn commit: r278805 - head/lib/libc/gen

Author: pfg Date: Sun Feb 15 18:02:05 2015 New Revision: 278805 URL: https://svnweb.freebsd.org/changeset/base/278805 Log: Mismatch in r278804. Modified: head/lib/libc/gen/getgrent.c Modified: head/lib/libc/gen/getgrent.c ==

Re: svn commit: r276747 - head/sys/netpfil/pf

Craig, On Sat, Feb 14, 2015 at 07:35:53PM -0800, Craig Rodrigues wrote: C> > On Thu, Jan 22, 2015 at 10:09:41PM +0100, Nikos Vassiliadis wrote: C> > N> > Sorry guys, I backed this out due to broken kldunload of pf module, C> > which C> > N> > is critical when you are working with pf bugs. C> > N

Re: svn commit: r278737 - head/usr.sbin/flowctl

On Sun, Feb 15, 2015 at 05:53:11PM +1100, Bruce Evans wrote: B> This is not a problem B> for FreeBSD, since style(9) forbids placing declarations in inner B> blocks and no one would break that rule :-) Which is one of the worst rules from style(9), imho. -- Totus tuus, Glebius. _

svn commit: r278806 - head/bin/sh/tests/expansion

Author: jilles Date: Sun Feb 15 19:48:29 2015 New Revision: 278806 URL: https://svnweb.freebsd.org/changeset/base/278806 Log: sh: Add simple tests for globbing/splitting command substitution. Added: head/bin/sh/tests/expansion/ifs5.0 (contents, props changed) head/bin/sh/tests/expansion/p

svn commit: r278807 - head/sys/contrib/dev/ath/ath_hal/ar9300

Author: adrian Date: Sun Feb 15 19:56:31 2015 New Revision: 278807 URL: https://svnweb.freebsd.org/changeset/base/278807 Log: Add ath_hal_setbeacontimers() to the AR9300 HAL. This is a custom FreeBSD HAL method that is used by the TDMA code to program the beacon timers directly without an

svn commit: r278810 - head/usr.bin/timeout

Author: emaste Date: Sun Feb 15 20:10:53 2015 New Revision: 278810 URL: https://svnweb.freebsd.org/changeset/base/278810 Log: timeout: handle zombie grandchildren timeout previously collected only one child status with wait(2). If this was one of the grandchildren timeout would return to

svn commit: r278814 - head/lib/libc/gen

Author: pfg Date: Sun Feb 15 21:03:49 2015 New Revision: 278814 URL: https://svnweb.freebsd.org/changeset/base/278814 Log: Reverse one of the initializations from r278804. It does no harm but this is not needed after the correction in r278805 and I prefer to keep this code very similar

svn commit: r278815 - head/lib/libc/gen

Author: pfg Date: Sun Feb 15 21:11:07 2015 New Revision: 278815 URL: https://svnweb.freebsd.org/changeset/base/278815 Log: Replace strcpy() with strlcpy() The risk of an overrun here is very low but check the length, JIC. CID: 1019039 Modified: head/lib/libc/gen/fstab.c Modified

svn commit: r278816 - head/sys/contrib/dev/ath/ath_hal/ar9300

Author: adrian Date: Sun Feb 15 21:15:09 2015 New Revision: 278816 URL: https://svnweb.freebsd.org/changeset/base/278816 Log: Add initial support to the AR9300 HAL to support FreeBSD's intmit API. I don't like having it in this function; I may migrate it to ar9300_freebsd.c at some point

Re: svn commit: r276747 - head/sys/netpfil/pf

On Sun, Feb 15, 2015 at 11:01 AM, Gleb Smirnoff wrote: > Craig, > > On Sat, Feb 14, 2015 at 07:35:53PM -0800, Craig Rodrigues wrote: > C> > On Thu, Jan 22, 2015 at 10:09:41PM +0100, Nikos Vassiliadis wrote: > C> > N> > Sorry guys, I backed this out due to broken kldunload of pf > module, > C> >

svn commit: r278817 - head/usr.bin/touch

Author: jilles Date: Sun Feb 15 21:28:00 2015 New Revision: 278817 URL: https://svnweb.freebsd.org/changeset/base/278817 Log: touch: Fix some subtle bugs related to NULL times fallback: * Do not subvert vfs.timestamp_precision by reading the time and passing that to utimensat(). Instead

Re: svn commit: r276747 - head/sys/netpfil/pf

On Sun, Feb 15, 2015 at 1:26 PM, Craig Rodrigues wrote: > On Sun, Feb 15, 2015 at 11:01 AM, Gleb Smirnoff > wrote: > >> Craig, >> >> On Sat, Feb 14, 2015 at 07:35:53PM -0800, Craig Rodrigues wrote: >> C> > On Thu, Jan 22, 2015 at 10:09:41PM +0100, Nikos Vassiliadis wrote: >> C> > N> > Sorry gu

svn commit: r278818 - head/bin/sh

Author: jilles Date: Sun Feb 15 21:41:29 2015 New Revision: 278818 URL: https://svnweb.freebsd.org/changeset/base/278818 Log: sh: Add stsavestr(), like savestr() but allocates using stalloc(). Modified: head/bin/sh/cd.c head/bin/sh/expand.c head/bin/sh/memalloc.c head/bin/sh/memalloc.h

svn commit: r278819 - head/usr.sbin/pw/tests

Author: brd (doc committer) Date: Sun Feb 15 21:42:10 2015 New Revision: 278819 URL: https://svnweb.freebsd.org/changeset/base/278819 Log: Really fix the pw_usernext tests. PR: 197612 Approved by: will Modified: head/usr.sbin/pw/tests/pw_usernext.sh Modified: head/usr.sbin/

svn commit: r278820 - head/bin/sh

Author: jilles Date: Sun Feb 15 21:47:43 2015 New Revision: 278820 URL: https://svnweb.freebsd.org/changeset/base/278820 Log: sh: Prefer "" to nullstr where possible. Modified: head/bin/sh/cd.c head/bin/sh/eval.c head/bin/sh/expand.c head/bin/sh/mail.c head/bin/sh/miscbltin.c head/b

svn commit: r278824 - head/sys/dev/usb/video

Author: hselasky Date: Sun Feb 15 22:05:30 2015 New Revision: 278824 URL: https://svnweb.freebsd.org/changeset/base/278824 Log: Bugfixes. Check if a framebuffer is present before using it. Dequeue element from correct head structure. No need to multiply framebuffer offset by two. It is alrea

svn commit: r278825 - in head/sys/dev/usb: . video

Author: hselasky Date: Sun Feb 15 22:06:28 2015 New Revision: 278825 URL: https://svnweb.freebsd.org/changeset/base/278825 Log: Add new device ID. Modified: head/sys/dev/usb/usbdevs head/sys/dev/usb/video/udl.c Modified: head/sys/dev/usb/usbdevs

svn commit: r278826 - head/bin/sh

Author: jilles Date: Sun Feb 15 22:38:00 2015 New Revision: 278826 URL: https://svnweb.freebsd.org/changeset/base/278826 Log: sh: Various cleanups to expand.c: * Remove some gotos. * Remove unused parameter. * Remove duplicate code. Modified: head/bin/sh/expand.c Modified: head/bin/

svn commit: r278827 - head/usr.sbin/binmiscctl

Author: sbruno Date: Sun Feb 15 23:58:57 2015 New Revision: 278827 URL: https://svnweb.freebsd.org/changeset/base/278827 Log: If no arguments are passed to a subcommand that requires arguments, error out before we deref a null pointer in the check for max length. Thanks to otis in IRC for

svn commit: r278828 - head/sys/netinet6

Author: glebius Date: Mon Feb 16 01:12:20 2015 New Revision: 278828 URL: https://svnweb.freebsd.org/changeset/base/278828 Log: Factor out ip6_deletefraghdr() function, to be shared between IPv6 stack and pf(4). Submitted by: Kristof Provost Reviewed by: ae Differential Revision:

Re: svn commit: r276747 - head/sys/netpfil/pf

On Sun, Feb 15, 2015 at 01:26:18PM -0800, Craig Rodrigues wrote: C> What are the problems in 276746 that you were unhappy with C> besides being unable to kldunload PF? They were listed in Message-ID: <20150121214445.gl15...@freebsd.org>. Also, the fact that commit required a serie of followup com

Re: svn commit: r276747 - head/sys/netpfil/pf

On Sun, Feb 15, 2015 at 01:33:19PM -0800, Craig Rodrigues wrote: C> By the way, it would be helpful if you could provide feedback in C> Phabricator. When I created those Phabricator reviews, I added C> you as a reviewer to all of them, so you can't say that you didn't see C> the patches. C> You di

Re: svn commit: r278828 - head/sys/netinet6

> On 16 Feb 2015, at 01:12 , Gleb Smirnoff wrote: > > Author: glebius > Date: Mon Feb 16 01:12:20 2015 > New Revision: 278828 > URL: https://svnweb.freebsd.org/changeset/base/278828 > > Log: > Factor out ip6_deletefraghdr() function, to be shared between IPv6 > stack and pf(4). > > Submitte

Re: svn commit: r278828 - head/sys/netinet6

On Mon, Feb 16, 2015 at 01:25:05AM +, Bjoern A. Zeeb wrote: B> B> > On 16 Feb 2015, at 01:12 , Gleb Smirnoff wrote: B> > B> > Author: glebius B> > Date: Mon Feb 16 01:12:20 2015 B> > New Revision: 278828 B> > URL: https://svnweb.freebsd.org/changeset/base/278828 B> > B> > Log: B> > Factor

Re: svn commit: r278828 - head/sys/netinet6

> On 16 Feb 2015, at 01:30 , Gleb Smirnoff wrote: > > On Mon, Feb 16, 2015 at 01:25:05AM +, Bjoern A. Zeeb wrote: > B> > B> > On 16 Feb 2015, at 01:12 , Gleb Smirnoff wrote: > B> > > B> > Author: glebius > B> > Date: Mon Feb 16 01:12:20 2015 > B> > New Revision: 278828 > B> > URL: https:/

svn commit: r278829 - head/sys/mips/conf

Author: adrian Date: Mon Feb 16 02:05:34 2015 New Revision: 278829 URL: https://svnweb.freebsd.org/changeset/base/278829 Log: Remove this - I made it all work again a looong time ago. Modified: head/sys/mips/conf/AR71XX_BASE Modified: head/sys/mips/conf/AR71XX_BASE ==

svn commit: r278830 - head/usr.sbin/devctl

Author: jmg Date: Mon Feb 16 02:20:11 2015 New Revision: 278830 URL: https://svnweb.freebsd.org/changeset/base/278830 Log: install the man page... Sponsored by: FreeBSD Foundation Modified: head/usr.sbin/devctl/Makefile Modified: head/usr.sbin/devctl/Makefile ===

Re: svn commit: r278828 - head/sys/netinet6

On Mon, Feb 16, 2015 at 01:34:09AM +, Bjoern A. Zeeb wrote: B> B> > On 16 Feb 2015, at 01:30 , Gleb Smirnoff wrote: B> > B> > On Mon, Feb 16, 2015 at 01:25:05AM +, Bjoern A. Zeeb wrote: B> > B> B> > B> > On 16 Feb 2015, at 01:12 , Gleb Smirnoff wrote: B> > B> > B> > B> > Author: glebi

svn commit: r278831 - head/sys/netpfil/pf

Author: glebius Date: Mon Feb 16 03:38:27 2015 New Revision: 278831 URL: https://svnweb.freebsd.org/changeset/base/278831 Log: Update the pf fragment handling code to closer match recent OpenBSD. That partially fixes IPv6 fragment handling. Thanks to Kristof for working on that. Submitt

svn commit: r278832 - head/sys/netinet6

Author: glebius Date: Mon Feb 16 05:58:32 2015 New Revision: 278832 URL: https://svnweb.freebsd.org/changeset/base/278832 Log: Move ip6_deletefraghdr() to frag6.c. Suggested by: bz Modified: head/sys/netinet6/frag6.c head/sys/netinet6/ip6_output.c Modified: head/sys/netinet6/frag6.c =

svn commit: r278833 - head/sys/dev/sfxge

Author: arybchik Date: Mon Feb 16 06:00:43 2015 New Revision: 278833 URL: https://svnweb.freebsd.org/changeset/base/278833 Log: sfxge: remove unused variable Sponsored by: Solarflare Communications, Inc. Approved by:gnn (mentor), glebius Modified: head/sys/dev/sfxge/sfxge_tx.c M

svn commit: r278834 - head/sys/net

Author: glebius Date: Mon Feb 16 06:02:46 2015 New Revision: 278834 URL: https://svnweb.freebsd.org/changeset/base/278834 Log: Missed from r278831. Modified: head/sys/net/pfvar.h Modified: head/sys/net/pfvar.h == ---

svn commit: r278835 - head/sys/dev/sfxge

Author: arybchik Date: Mon Feb 16 06:04:26 2015 New Revision: 278835 URL: https://svnweb.freebsd.org/changeset/base/278835 Log: sfxge: remove full_packet_size from sfxge_tso_state It makes sfxge_tso_state smaller and even makes tso_start_new_packet() few bytes smaller. Data used to calcul

svn commit: r278836 - head/sys/dev/sfxge

Author: arybchik Date: Mon Feb 16 06:07:01 2015 New Revision: 278836 URL: https://svnweb.freebsd.org/changeset/base/278836 Log: sfxge: remove used sfxge_tso_state member dma_seg_i Sponsored by: Solarflare Communications, Inc. Approved by:gnn (mentor) Modified: head/sys/dev/sfxge/

svn commit: r278837 - head/sys/dev/sfxge

Author: arybchik Date: Mon Feb 16 06:08:13 2015 New Revision: 278837 URL: https://svnweb.freebsd.org/changeset/base/278837 Log: sfxge: remove inline specifiers Now compiler does not need any help. The patch does not change generated code. Sponsored by: Solarflare Communications, In

svn commit: r278838 - head/sys/dev/sfxge

Author: arybchik Date: Mon Feb 16 06:10:17 2015 New Revision: 278838 URL: https://svnweb.freebsd.org/changeset/base/278838 Log: sfxge: SYSCTL_IN/OUT should not be called with non-sleepable lock held The problem is found using WITNESS option enabled. Sponsored by: Solarflare Communica

svn commit: r278839 - head/sys/dev/sfxge/common

Author: arybchik Date: Mon Feb 16 06:12:04 2015 New Revision: 278839 URL: https://svnweb.freebsd.org/changeset/base/278839 Log: sfxge: style fixes Sponsored by: Solarflare Communications, Inc. Approved by:gnn (mentor) Modified: head/sys/dev/sfxge/common/efx_ev.c head/sys/dev/sf

svn commit: r278840 - head/share/man/man4

Author: kevlo Date: Mon Feb 16 06:12:55 2015 New Revision: 278840 URL: https://svnweb.freebsd.org/changeset/base/278840 Log: Xref the following in wlan(4): - rsu(4) - urtwn(4) Modified: head/share/man/man4/wlan.4 Modified: head/share/man/man4/wlan.4 ===

svn commit: r278841 - head/sys/dev/sfxge

Author: arybchik Date: Mon Feb 16 06:16:38 2015 New Revision: 278841 URL: https://svnweb.freebsd.org/changeset/base/278841 Log: sfxge: flush all Tx queues from if_qflush Sponsored by: Solarflare Communications, Inc. Approved by:gnn (mentor), glebius Modified: head/sys/dev/sfxge/s

svn commit: r278842 - head/sys/netinet6

Author: glebius Date: Mon Feb 16 06:30:27 2015 New Revision: 278842 URL: https://svnweb.freebsd.org/changeset/base/278842 Log: Factor out ip6_fragment() function, to be used in IPv6 stack and pf(4). Submitted by: Kristof Provost Differential Revision:D1766 Modified: hea

svn commit: r278843 - head/sys/netpfil/pf

Author: glebius Date: Mon Feb 16 07:01:02 2015 New Revision: 278843 URL: https://svnweb.freebsd.org/changeset/base/278843 Log: In the forwarding case refragment the reassembled packets with the same size as they arrived in. This allows the sender to determine the optimal fragment size by Pat

Re: svn commit: r276747 - head/sys/netpfil/pf

On Sun, Feb 15, 2015 at 5:25 PM, Gleb Smirnoff wrote: > On Sun, Feb 15, 2015 at 01:33:19PM -0800, Craig Rodrigues wrote: > C> By the way, it would be helpful if you could provide feedback in > C> Phabricator. When I created those Phabricator reviews, I added > C> you as a reviewer to all of them

Re: svn commit: r276747 - head/sys/netpfil/pf

On Sun, Feb 15, 2015 at 11:36:17PM -0800, Craig Rodrigues wrote: C> On Sun, Feb 15, 2015 at 5:25 PM, Gleb Smirnoff wrote: C> C> > On Sun, Feb 15, 2015 at 01:33:19PM -0800, Craig Rodrigues wrote: C> > C> By the way, it would be helpful if you could provide feedback in C> > C> Phabricator. When I