On 28.11.2012 00:59, Robert N. M. Watson wrote:
On 27 Nov 2012, at 23:29, Andre Oppermann wrote:
Andre.. this breaks incoming connections. TCP is immediately reset and never
even gets to the
listener process. You need to back out of fix this urgently please.
I just found out and fixed it.
On Wed, 28 Nov 2012, Andre Oppermann wrote:
Yes, and I didn't really expect you to answer (at least quickly) during your
FreeBSD hiatus. So it was seeking review by chance.
Alas I found and fixed the bug myself within 2.5hrs. While not optimal, a
sign of poor prior testing and too much trus
Author: ume
Date: Wed Nov 28 11:47:47 2012
New Revision: 243649
URL: http://svnweb.freebsd.org/changeset/base/243649
Log:
cyrus-sasl 2.1.26 was released. In this version, the type of callback
functions was changed from "unsigned long" to "size_t".
Reviewed by: gshapiro
MFC after:3
On Wed, Nov 28, 2012 at 02:23:59AM +, Alfred Perlstein wrote:
> Author: alfred
> Date: Wed Nov 28 02:23:59 2012
> New Revision: 243644
> URL: http://svnweb.freebsd.org/changeset/base/243644
> Log:
> Fix typo.
> Pointed out by: marck
> Modified:
> head/usr.sbin/nfsd/nfsd.c
> Modified:
On Wed, Nov 28, 2012 at 02:47:32AM +, Alfred Perlstein wrote:
> Author: alfred
> Date: Wed Nov 28 02:47:31 2012
> New Revision: 243645
> URL: http://svnweb.freebsd.org/changeset/base/243645
>
> Log:
> Don't allow minthreads > maxthreads.
>
> Suggested by: rmacklem
>
> Modified:
> hea
Author: pfg
Date: Wed Nov 28 15:48:32 2012
New Revision: 243652
URL: http://svnweb.freebsd.org/changeset/base/243652
Log:
Update some definitions or make them match NetBSD's headers.
Bring several definitions required for newer ext4 features.
Rename EXT2F_COMPAT_HTREE to EXT2F_COMPAT_D
I'm pretty sure that the "realmem" calculation is going to overflow on
i386/PAE, where the number of bytes of physical memory is greater than
the type long can represent.
On 11/27/2012 15:19, Andre Oppermann wrote:
> Author: andre
> Date: Tue Nov 27 21:19:58 2012
> New Revision: 243631
> URL: http
On 11/28/12 12:01 AM, Andre Oppermann wrote:
On 28.11.2012 00:59, Robert N. M. Watson wrote:
On 27 Nov 2012, at 23:29, Andre Oppermann wrote:
Andre.. this breaks incoming connections. TCP is immediately
reset and never even gets to the
listener process. You need to back out of fix this urge
On Wed, 28 Nov 2012, Alfred Perlstein wrote:
Yes, and I didn't really expect you to answer (at least quickly) during
your FreeBSD hiatus. So it was seeking review by chance.
Alas I found and fixed the bug myself within 2.5hrs. While not optimal, a
sign of poor prior testing and too much tru
Alfred,
On Wed, Nov 28, 2012 at 09:39:15AM -0800, Alfred Perlstein wrote:
A> Personally I don't think we need any more anchors attached to people's
A> feet when developing FreeBSD.
A>
A> Mistakes will happen, they will happen in head. Slowing down the
A> process to eliminate mistakes only wo
On 28 Nov 2012, at 17:51, Gleb Smirnoff wrote:
> On Wed, Nov 28, 2012 at 09:39:15AM -0800, Alfred Perlstein wrote:
> A> Personally I don't think we need any more anchors attached to people's
> A> feet when developing FreeBSD.
> A>
> A> Mistakes will happen, they will happen in head. Slowing do
Author: alc
Date: Wed Nov 28 18:29:34 2012
New Revision: 243659
URL: http://svnweb.freebsd.org/changeset/base/243659
Log:
Add support for the (relatively) new object type OBJT_MGTDEVICE to
vm_object_set_memattr(). Also, add a "safety belt" so that
vm_object_set_memattr() doesn't silently mo
Author: dteske
Date: Wed Nov 28 18:35:46 2012
New Revision: 243660
URL: http://svnweb.freebsd.org/changeset/base/243660
Log:
Discussed at-length on -arch.
Make the following interface changes to my beastie boot menu:
+ Move boot options to a submenu
+ Add a new "Boot Single" menu item
Author: hselasky
Date: Wed Nov 28 18:37:20 2012
New Revision: 243661
URL: http://svnweb.freebsd.org/changeset/base/243661
Log:
Regenerate usb.conf
MFC after:1 week
Modified:
head/etc/devd/usb.conf
Modified: head/etc/devd/usb.conf
=
Do you think we need another TRB?
It could be used to oust undesirable committers if needed.
Sent from my iPhone
On Nov 28, 2012, at 10:25 AM, "Robert N. M. Watson" wrote:
>
> On 28 Nov 2012, at 17:51, Gleb Smirnoff wrote:
>
>> On Wed, Nov 28, 2012 at 09:39:15AM -0800, Alfred Perlstein wrot
On 28 Nov 2012, at 19:32, Alfred Perlstein wrote:
> Do you think we need another TRB?
>
> It could be used to oust undesirable committers if needed.
Are we seriously having a discussion in which the merits of favouring
pre-commit code review for the things like TCP stack are in doubt? I'm not
On Wed, 28 Nov 2012, Alan Cox wrote:
I'm pretty sure that the "realmem" calculation is going to overflow on
i386/PAE, where the number of bytes of physical memory is greater than
the type long can represent.
It overflows on i386 even without PAE, where the number of bytes of
physical memory is
Author: pgj (ports committer)
Date: Wed Nov 28 22:04:18 2012
New Revision: 243662
URL: http://svnweb.freebsd.org/changeset/base/243662
Log:
- Update organization.dot to reflect that attilio resigned from core
Approved by: core (implicit)
Modified:
head/share/misc/organization.dot
Modif
Can you please post some example figures for machines with 16, 32, 64 and 128MB?
As Bruce has just replied, there's concern about this tuning being
very "lots of RAM" centric, which certainly isn't the case.
I'd hate to see this swing from one extreme (not enough mbufs) to the
other extreme ..
On 28.11.2012 18:37, Alan Cox wrote:
I'm pretty sure that the "realmem" calculation is going to overflow on
i386/PAE, where the number of bytes of physical memory is greater than
the type long can represent.
Right. long == int on i386/PAE, not LP64. Is uint64_t the correct type
to use to catc
On Wed, 28 Nov 2012, Andre Oppermann wrote:
On 28.11.2012 18:37, Alan Cox wrote:
I'm pretty sure that the "realmem" calculation is going to overflow on
i386/PAE, where the number of bytes of physical memory is greater than
the type long can represent.
Right. long == int on i386/PAE, not LP64
On 28.11.2012 22:45, Bruce Evans wrote:
On Wed, 28 Nov 2012, Alan Cox wrote:
I'm pretty sure that the "realmem" calculation is going to overflow on
i386/PAE, where the number of bytes of physical memory is greater than
the type long can represent.
It overflows on i386 even without PAE, where
On 29.11.2012 00:14, Bruce Evans wrote:
On Wed, 28 Nov 2012, Andre Oppermann wrote:
On 28.11.2012 18:37, Alan Cox wrote:
I'm pretty sure that the "realmem" calculation is going to overflow on
i386/PAE, where the number of bytes of physical memory is greater than
the type long can represent.
On Thu, 29 Nov 2012, Andre Oppermann wrote:
On 28.11.2012 22:45, Bruce Evans wrote:
On Wed, 28 Nov 2012, Alan Cox wrote:
I'm pretty sure that the "realmem" calculation is going to overflow on
i386/PAE, where the number of bytes of physical memory is greater than
the type long can represent.
Mateusz Guzik wrote:
> On Wed, Nov 28, 2012 at 02:47:32AM +, Alfred Perlstein wrote:
> > Author: alfred
> > Date: Wed Nov 28 02:47:31 2012
> > New Revision: 243645
> > URL: http://svnweb.freebsd.org/changeset/base/243645
> >
> > Log:
> > Don't allow minthreads > maxthreads.
> >
> > Suggeste
Author: eadler
Date: Thu Nov 29 00:32:03 2012
New Revision: 243663
URL: http://svnweb.freebsd.org/changeset/base/243663
Log:
Add support for AT&T Sierra Wireless USB 3G adapter
PR: kern/173982
Submitted by: Eric Camachat
Approved by: cperciva (implicit)
MFC after:1 wee
> a sign of poor prior testing and too much trust into the submitter of
> the patch it wasn't an earth shattering event. Doesn't distract from
Andre, I am really quite disappointed to read this from you. The patch
I sent you was fine, and has been well tested here. You modified it
and made the er
On Wed, Nov 28, 2012 at 07:14:23PM -0500, Rick Macklem wrote:
> Mateusz Guzik wrote:
> > On Wed, Nov 28, 2012 at 02:47:32AM +, Alfred Perlstein wrote:
> > > Author: alfred
> > > Date: Wed Nov 28 02:47:31 2012
> > > New Revision: 243645
> > > URL: http://svnweb.freebsd.org/changeset/base/243645
On Mon, 26 Nov 2012 05:11:07 + (UTC)
Eitan Adler mentioned:
> Author: eadler
> Date: Mon Nov 26 05:11:07 2012
> New Revision: 243554
> URL: http://svnweb.freebsd.org/changeset/base/243554
>
> Log:
> Provide an option to users to shoot themselves in the foot.
>
This should probably be a
On 28 November 2012 20:00, Stanislav Sedov wrote:
> On Mon, 26 Nov 2012 05:11:07 + (UTC)
> Eitan Adler mentioned:
>
>> Author: eadler
>> Date: Mon Nov 26 05:11:07 2012
>> New Revision: 243554
>> URL: http://svnweb.freebsd.org/changeset/base/243554
>>
>> Log:
>> Provide an option to users to
On Wed, 28 Nov 2012 21:03:58 -0500
Eitan Adler mentioned:
> On 28 November 2012 20:00, Stanislav Sedov wrote:
> > On Mon, 26 Nov 2012 05:11:07 + (UTC)
> > Eitan Adler mentioned:
> >
> >> Author: eadler
> >> Date: Mon Nov 26 05:11:07 2012
> >> New Revision: 243554
> >> URL: http://svnweb.fre
On 28 November 2012 21:34, Stanislav Sedov wrote:
> Well, it's not entirely true. I did end up with local.sqlite because I
> stepped on the landmine of portmgr-pkg becoming the default for some
> reason. So I did end up with half of my packages being in the pkgng
> sqlite database, and half in s
Author: marcel
Date: Thu Nov 29 03:48:39 2012
New Revision: 243664
URL: http://svnweb.freebsd.org/changeset/base/243664
Log:
Fix LINT build for arm: NOTES defines LDFLAGS by way of a make option
but LDFLAGS is not (yet) passed on to the linker (via SYSTEM_LD et al).
Do so now. As such, any k
On Nov 28, 2012, at 9:39 AM, Alfred Perlstein wrote:
> On 11/28/12 12:01 AM, Andre Oppermann wrote:
>> On 28.11.2012 00:59, Robert N. M. Watson wrote:
>>>
>>> On 27 Nov 2012, at 23:29, Andre Oppermann wrote:
>>>
> Andre.. this breaks incoming connections. TCP is immediately reset
On 11/28/12 7:49 PM, Garrett Cooper wrote:
On Nov 28, 2012, at 9:39 AM, Alfred Perlstein wrote:
On 11/28/12 12:01 AM, Andre Oppermann wrote:
On 28.11.2012 00:59, Robert N. M. Watson wrote:
On 27 Nov 2012, at 23:29, Andre Oppermann wrote:
Andre.. this breaks incoming connections. TCP is im
Author: eadler
Date: Thu Nov 29 05:16:50 2012
New Revision: 243665
URL: http://svnweb.freebsd.org/changeset/base/243665
Log:
Mark non-returning function as such
PR: bin/172978
Approved by: cperciva
MFC after:3 days
Modified:
head/sbin/dump/dump.h
Modified: head/sbin/d
Author: gonzo
Date: Thu Nov 29 05:46:46 2012
New Revision: 243666
URL: http://svnweb.freebsd.org/changeset/base/243666
Log:
Fix hardcoded bpp value
Modified:
head/sys/arm/broadcom/bcm2835/bcm2835_fb.c
Modified: head/sys/arm/broadcom/bcm2835/bcm2835_fb.c
==
>On 11/28/12 7:49 PM, Garrett Cooper wrote:
>> I know it's sort of done in some groups [based on commit messages], but it w
>ould be nice to have it better formalized and socialized as well. Things like
Trying to get too formalized could be counter productive.
>> An extension of this code revie
On 29.11.2012 01:35, Vijay Singh wrote:
a sign of poor prior testing and too much trust into the submitter of
the patch it wasn't an earth shattering event. Doesn't distract from
Andre, I am really quite disappointed to read this from you. The patch
I sent you was fine, and has been well teste
Author: andre
Date: Thu Nov 29 07:30:42 2012
New Revision: 243668
URL: http://svnweb.freebsd.org/changeset/base/243668
Log:
Using a long is the wrong type to represent the realmem and maxmbufmem
variable as they may overflow on i386/PAE and i386 with > 2GB RAM.
Use 64bit quad_t instead.
On Wed, Nov 28, 2012 at 06:34:22PM -0800, Stanislav Sedov wrote:
> On Wed, 28 Nov 2012 21:03:58 -0500
> Eitan Adler mentioned:
>
> > On 28 November 2012 20:00, Stanislav Sedov wrote:
> > > On Mon, 26 Nov 2012 05:11:07 + (UTC)
> > > Eitan Adler mentioned:
> > >
> > >> Author: eadler
> > >> D
On 29 Nov 2012, at 04:17, Alfred Perlstein wrote:
> I've seen what happens with large groups, it doesn't scale and basically you
> wind up with the following type of reviewers:
I think we have to assume best intent here -- the goal of code review in
complex critical components is not to elimin
On 29 Nov 2012, at 07:02, Simon J. Gerraty wrote:
> On Wed, 28 Nov 2012 20:17:33 -0800, Alfred Perlstein writes:
>> I've seen what happens with large groups, it doesn't scale and basically
>> you wind up with the following type of reviewers:
>
> The issues you cite, are the result of taking a g
43 matches
Mail list logo
