Re: svn commit: r355301 - head/usr.sbin/bhyve

2019-12-18 Thread Yamagi
Hello, the change to the defintion of 'const char *vbuf' in rfb.c is wrong. The protocol version string must be send as "RFB 003.008\n" and not as "RFB 003.008\n\r", otherwise the VNC client isn't able to complete the handshake (it doesn't recognize the protocol version). While it stays connected,

Re: svn commit: r355301 - head/usr.sbin/bhyve

2019-12-05 Thread Rodney W. Grimes
> On Thu, 2019-12-05 at 11:21 -0800, Rodney W. Grimes wrote: > > > On 12/4/19 9:35 PM, Rodney W. Grimes wrote: > > > > > I see, thanks for the pointers. > > > > > It looks like cfmakeraw() and tcsetattr() were what I was > > > > > looking for. > > > > > A bhyve-specific printf wrapper looks the rig

Re: svn commit: r355301 - head/usr.sbin/bhyve

2019-12-05 Thread Ian Lepore
On Thu, 2019-12-05 at 11:21 -0800, Rodney W. Grimes wrote: > > On 12/4/19 9:35 PM, Rodney W. Grimes wrote: > > > > I see, thanks for the pointers. > > > > It looks like cfmakeraw() and tcsetattr() were what I was > > > > looking for. > > > > A bhyve-specific printf wrapper looks the right solution

Re: svn commit: r355301 - head/usr.sbin/bhyve

2019-12-05 Thread Rodney W. Grimes
> On 12/4/19 9:35 PM, Rodney W. Grimes wrote: > >> I see, thanks for the pointers. > >> It looks like cfmakeraw() and tcsetattr() were what I was looking for. > >> A bhyve-specific printf wrapper looks the right solution to me. > >> I can try to sketch a patch for you guys to review, if that's usef

Re: svn commit: r355301 - head/usr.sbin/bhyve

2019-12-05 Thread John Baldwin
On 12/4/19 9:35 PM, Rodney W. Grimes wrote: >> I see, thanks for the pointers. >> It looks like cfmakeraw() and tcsetattr() were what I was looking for. >> A bhyve-specific printf wrapper looks the right solution to me. >> I can try to sketch a patch for you guys to review, if that's useful. >> >>

Re: svn commit: r355301 - head/usr.sbin/bhyve

2019-12-04 Thread Rodney W. Grimes
> I see, thanks for the pointers. > It looks like cfmakeraw() and tcsetattr() were what I was looking for. > A bhyve-specific printf wrapper looks the right solution to me. > I can try to sketch a patch for you guys to review, if that's useful. > > Cheers, > Vincenzo Meanwhile could you please

Re: svn commit: r355301 - head/usr.sbin/bhyve

2019-12-03 Thread Vincenzo Maffione
I see, thanks for the pointers. It looks like cfmakeraw() and tcsetattr() were what I was looking for. A bhyve-specific printf wrapper looks the right solution to me. I can try to sketch a patch for you guys to review, if that's useful. Cheers, Vincenzo Il giorno mar 3 dic 2019 alle ore 18:38

Re: svn commit: r355301 - head/usr.sbin/bhyve

2019-12-03 Thread John Baldwin
On 12/3/19 7:14 AM, Ian Lepore wrote: > On Mon, 2019-12-02 at 23:22 -0800, Rodney W. Grimes wrote: >>> On Mon, 2019-12-02 at 20:51 +, Vincenzo Maffione wrote: Author: vmaffione Date: Mon Dec 2 20:51:46 2019 New Revision: 355301 URL: https://svnweb.freebsd.org/changeset/base

Re: svn commit: r355301 - head/usr.sbin/bhyve

2019-12-03 Thread Rodney W. Grimes
> On Mon, 2019-12-02 at 23:22 -0800, Rodney W. Grimes wrote: > > > On Mon, 2019-12-02 at 20:51 +, Vincenzo Maffione wrote: > > > > Author: vmaffione > > > > Date: Mon Dec 2 20:51:46 2019 > > > > New Revision: 355301 > > > > URL: https://svnweb.freebsd.org/changeset/base/355301 > > > > > > > >

Re: svn commit: r355301 - head/usr.sbin/bhyve

2019-12-03 Thread Ian Lepore
On Mon, 2019-12-02 at 23:22 -0800, Rodney W. Grimes wrote: > > On Mon, 2019-12-02 at 20:51 +, Vincenzo Maffione wrote: > > > Author: vmaffione > > > Date: Mon Dec 2 20:51:46 2019 > > > New Revision: 355301 > > > URL: https://svnweb.freebsd.org/changeset/base/355301 > > > > > > Log: > > > bh

Re: svn commit: r355301 - head/usr.sbin/bhyve

2019-12-02 Thread Rodney W. Grimes
> On Mon, 2019-12-02 at 20:51 +, Vincenzo Maffione wrote: > > Author: vmaffione > > Date: Mon Dec 2 20:51:46 2019 > > New Revision: 355301 > > URL: https://svnweb.freebsd.org/changeset/base/355301 > > > > Log: > > bhyve: uniform printf format string newlines > > > > Some of the printf

Re: svn commit: r355301 - head/usr.sbin/bhyve

2019-12-02 Thread Ian Lepore
On Mon, 2019-12-02 at 22:35 +0100, Vincenzo Maffione wrote: > Il giorno lun 2 dic 2019 alle ore 22:14 Ian Lepore > ha > scritto: > > > On Mon, 2019-12-02 at 20:51 +, Vincenzo Maffione wrote: > > > Author: vmaffione > > > Date: Mon Dec 2 20:51:46 2019 > > > New Revision: 355301 > > > URL: htt

Re: svn commit: r355301 - head/usr.sbin/bhyve

2019-12-02 Thread Vincenzo Maffione
Il giorno lun 2 dic 2019 alle ore 22:14 Ian Lepore ha scritto: > On Mon, 2019-12-02 at 20:51 +, Vincenzo Maffione wrote: > > Author: vmaffione > > Date: Mon Dec 2 20:51:46 2019 > > New Revision: 355301 > > URL: https://svnweb.freebsd.org/changeset/base/355301 > > > > Log: > > bhyve: unifor

Re: svn commit: r355301 - head/usr.sbin/bhyve

2019-12-02 Thread Kyle Evans
On Mon, Dec 2, 2019 at 3:14 PM Ian Lepore wrote: > > On Mon, 2019-12-02 at 20:51 +, Vincenzo Maffione wrote: > > Author: vmaffione > > Date: Mon Dec 2 20:51:46 2019 > > New Revision: 355301 > > URL: https://svnweb.freebsd.org/changeset/base/355301 > > > > Log: > > bhyve: uniform printf form

Re: svn commit: r355301 - head/usr.sbin/bhyve

2019-12-02 Thread Ian Lepore
On Mon, 2019-12-02 at 20:51 +, Vincenzo Maffione wrote: > Author: vmaffione > Date: Mon Dec 2 20:51:46 2019 > New Revision: 355301 > URL: https://svnweb.freebsd.org/changeset/base/355301 > > Log: > bhyve: uniform printf format string newlines > > Some of the printf statements only use

svn commit: r355301 - head/usr.sbin/bhyve

2019-12-02 Thread Vincenzo Maffione
Author: vmaffione Date: Mon Dec 2 20:51:46 2019 New Revision: 355301 URL: https://svnweb.freebsd.org/changeset/base/355301 Log: bhyve: uniform printf format string newlines Some of the printf statements only use LF to get a newline. However, a CR character is also required for the serial