Re: svn commit: r352953 - in head/usr.bin: killall split

2019-10-03 Thread Kubilay Kocak
On 2/10/2019 9:59 pm, Kyle Evans wrote: Sorry for the crap formatting, mobile. We can perhaps also fix this class with a proper modelling file. koobs was going to send out an email about it, but I haven't seen anything. Thanks for the public reminder Kyle :] I'll flick it out soon On Wed, O

Re: svn commit: r352953 - in head/usr.bin: killall split

2019-10-02 Thread Rodney W. Grimes
> Hi Alexander, > > Coverity has millions of spurious warnings of this class and they're > basically all false positives. I think we should instead try to > figure out how to disable this class of warning on our codebase, since > it is largely incorrect. > > I would encourage reverting this chan

Re: svn commit: r352953 - in head/usr.bin: killall split

2019-10-02 Thread Kyle Evans
Sorry for the crap formatting, mobile. We can perhaps also fix this class with a proper modelling file. koobs was going to send out an email about it, but I haven't seen anything. On Wed, Oct 2, 2019, 02:03 Conrad Meyer wrote: > Hi Alexander, > > Coverity has millions of spurious warnings of th

Re: svn commit: r352953 - in head/usr.bin: killall split

2019-10-02 Thread Conrad Meyer
Hi Alexander, Coverity has millions of spurious warnings of this class and they're basically all false positives. I think we should instead try to figure out how to disable this class of warning on our codebase, since it is largely incorrect. I would encourage reverting this change, because it u

svn commit: r352953 - in head/usr.bin: killall split

2019-10-01 Thread Alexander Kabaev
Author: kan Date: Wed Oct 2 06:15:30 2019 New Revision: 352953 URL: https://svnweb.freebsd.org/changeset/base/352953 Log: Convert pnmatch to single element array in regexec calls The regexec function is declared as taking an array of regmatch_t elements, and passing in the pointer to sin