Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
It works for me too. Thank you. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. In message , Mateusz Guzik writes: > This survived light testing for me: > > https://people.freebsd.org/~mjg/unionfs-interlock.d

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Mateusz Guzik
This survived light testing for me: https://people.freebsd.org/~mjg/unionfs-interlock.diff note unionfs instantly panics with DEBUG_VFS_LOCKS regardless of any of this work. On 8/27/19, Cy Schubert wrote: > In message > om> > , Mateusz Guzik writes: >> On 8/27/19, Cy Schubert wrote: >> > Maki

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
In message , Mateusz Guzik writes: > On 8/27/19, Cy Schubert wrote: > > Making progress: > > > > Unread portion of the kernel message buffer: > > > > panic: null_unlock: LK_INTERLOCK passed > > cpuid = 2 > > time = 1566868081 > > KDB: stack backtrace: > > db_trace_self_wrapper() at db_trace_self_

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Mateusz Guzik
On 8/27/19, Cy Schubert wrote: > Making progress: > > Unread portion of the kernel message buffer: > > panic: null_unlock: LK_INTERLOCK passed > cpuid = 2 > time = 1566868081 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame > 0xfe0054a954e0 > vpanic() at vp

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
Making progress: Unread portion of the kernel message buffer: panic: null_unlock: LK_INTERLOCK passed cpuid = 2 time = 1566868081 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfe0054a954e0 vpanic() at vpanic+0x19d/frame 0xfe0054a95530 panic() at pani

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Mateusz Guzik
Sorry for the half-assed patch. I have a patch to remove the flags argument and the change above was port of it. Try this please: https://people.freebsd.org/~mjg/patches/vop_unlock-interlock2.diff On 8/27/19, Cy Schubert wrote: > It won't build. Did you intend VOP_UNLOCK(vp,LK_INTERLOCK)? > > --

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
It won't build. Did you intend VOP_UNLOCK(vp,LK_INTERLOCK)? --- vfs_subr.o --- /opt/src/svn-current/sys/kern/vfs_subr.c:1037:17: error: too few arguments to function call, expected 2, have 1 VOP_UNLOCK(vp); ~~ ^ ./vnode_if.h:873:1: note: '

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
Thanks. My lunch hour is over. I'll try this after I get home from $JOB. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. In message , Mateusz Guzik writes: > Does this do the trick for you? > > https://people

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
In message , Cy Schubert wr ites: > On August 26, 2019 8:40:50 AM PDT, Cy Schubert wr > ote: > >On August 26, 2019 7:11:22 AM PDT, Cy Schubert > > wrote: > >>In message <6c6bf3a4-dc07-4d9a-9a5f-fa075bf53...@cschubert.com>, Cy > >>Schubert wr > >>ites: > >>> On August 24, 2019 10:13:15 PM PDT, Mat

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Mateusz Guzik
Does this do the trick for you? https://people.freebsd.org/~mjg/vop_unlock-interlock.diff On 8/26/19, Cy Schubert wrote: > On August 26, 2019 8:40:50 AM PDT, Cy Schubert > wrote: >>On August 26, 2019 7:11:22 AM PDT, Cy Schubert >> wrote: >>>In message <6c6bf3a4-dc07-4d9a-9a5f-fa075bf53...@cschu

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
On August 26, 2019 8:40:50 AM PDT, Cy Schubert wrote: >On August 26, 2019 7:11:22 AM PDT, Cy Schubert > wrote: >>In message <6c6bf3a4-dc07-4d9a-9a5f-fa075bf53...@cschubert.com>, Cy >>Schubert wr >>ites: >>> On August 24, 2019 10:13:15 PM PDT, Mateusz Guzik >>wrote: >>> >Author: mjg >>> >Date: Su

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
On August 26, 2019 7:11:22 AM PDT, Cy Schubert wrote: >In message <6c6bf3a4-dc07-4d9a-9a5f-fa075bf53...@cschubert.com>, Cy >Schubert wr >ites: >> On August 24, 2019 10:13:15 PM PDT, Mateusz Guzik >wrote: >> >Author: mjg >> >Date: Sun Aug 25 05:13:15 2019 >> >New Revision: 351472 >> >URL: https:/

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
In message <6c6bf3a4-dc07-4d9a-9a5f-fa075bf53...@cschubert.com>, Cy Schubert wr ites: > On August 24, 2019 10:13:15 PM PDT, Mateusz Guzik wrote: > >Author: mjg > >Date: Sun Aug 25 05:13:15 2019 > >New Revision: 351472 > >URL: https://svnweb.freebsd.org/changeset/base/351472 > > > >Log: > > nullfs

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
On August 24, 2019 10:13:15 PM PDT, Mateusz Guzik wrote: >Author: mjg >Date: Sun Aug 25 05:13:15 2019 >New Revision: 351472 >URL: https://svnweb.freebsd.org/changeset/base/351472 > >Log: > nullfs: reduce areas protected by vnode interlock > >Some places only take the interlock to hold the vnode

svn commit: r351472 - head/sys/fs/nullfs

2019-08-24 Thread Mateusz Guzik
Author: mjg Date: Sun Aug 25 05:13:15 2019 New Revision: 351472 URL: https://svnweb.freebsd.org/changeset/base/351472 Log: nullfs: reduce areas protected by vnode interlock Some places only take the interlock to hold the vnode, which was a requiremnt before they started being manipulated