Re: svn commit: r339898 - head/lib/libc/amd64/sys

2018-11-21 Thread Ed Maste
On Tue, 20 Nov 2018 at 21:21, Shawn Webb wrote: > > Hey Kostik, > > It appears this commit broke building/linking libc with LTO. I'm > running into this assertion from clang/lld 7.0.0 (from the > projects/clang700-import feature branch): Yes, if you can reproduce with upstream clang/llvm/lld head

Re: svn commit: r339898 - head/lib/libc/amd64/sys

2018-11-20 Thread Shawn Webb
On Tue, Oct 30, 2018 at 12:11:30AM +, Konstantin Belousov wrote: > Author: kib > Date: Tue Oct 30 00:11:30 2018 > New Revision: 339898 > URL: https://svnweb.freebsd.org/changeset/base/339898 > > Log: > Convert amd64_get/set_fs/gsbase to ifunc. > > Note that this is the first use of ifun

Re: svn commit: r339898 - head/lib/libc/amd64/sys

2018-11-19 Thread Charlie Li
On 05/11/2018 21:51, Konstantin Belousov wrote: > For you, but not for me. > Turns out I omitted the fact that I have WITH_RETPOLINE enabled, which caused all this. emaste@ reported in PR 26 and committed r340650. -- Charlie Li Can't think of a witty .sigline today… (This email address is f

Re: svn commit: r339898 - head/lib/libc/amd64/sys

2018-11-05 Thread Konstantin Belousov
On Mon, Nov 05, 2018 at 09:10:13PM -0500, Charlie Li wrote: > On 03/11/2018 19:45, Konstantin Belousov wrote: > > Or rather, it is a middle of the valid instruction. > > Next frame looks like it is process_irelocs(), if trusting the line > > numbers. So most likely it is something related to calli

svn commit: r339898 - head/lib/libc/amd64/sys

2018-11-05 Thread Charlie Li
On 03/11/2018 19:45, Konstantin Belousov wrote: > Or rather, it is a middle of the valid instruction. > Next frame looks like it is process_irelocs(), if trusting the line > numbers. So most likely it is something related to calling wrong > relocator function, if anything. > > Perhaps you could t

Re: svn commit: r339898 - head/lib/libc/amd64/sys

2018-11-04 Thread Konstantin Belousov
On Sun, Nov 04, 2018 at 12:43:34AM -0700, Julian Elischer wrote: > what's an ifunc? > A special kind of relocation, controlled by the user code. ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscr

Re: svn commit: r339898 - head/lib/libc/amd64/sys

2018-11-04 Thread Dimitry Andric
On 4 Nov 2018, at 08:43, Julian Elischer wrote: > > what's an ifunc? This is a GNU extension, an "indirect function". It allows you to provide multiple different implementations of the same function, for instance optimized for specific CPU types, and choose between them at dynamic link time (e.

Re: svn commit: r339898 - head/lib/libc/amd64/sys

2018-11-04 Thread Julian Elischer
what's an ifunc? ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r339898 - head/lib/libc/amd64/sys

2018-11-03 Thread Konstantin Belousov
On Sat, Nov 03, 2018 at 06:59:02PM -0400, Charlie Li wrote: > On 03/11/2018 11:29, Konstantin Belousov wrote: > > Some minimal amount of facts instead of guesses would be much more useful. > > > Yeah, being sleep deprived and hurried (on my end) certainly doesn't help. > > What is the instruction

Re: svn commit: r339898 - head/lib/libc/amd64/sys

2018-11-03 Thread Charlie Li
On 03/11/2018 11:29, Konstantin Belousov wrote: > Some minimal amount of facts instead of guesses would be much more useful. > Yeah, being sleep deprived and hurried (on my end) certainly doesn't help. > What is the instruction which faulted ? Disassemble the text at 0x2f5664. > Regardless of wha

Re: svn commit: r339898 - head/lib/libc/amd64/sys

2018-11-03 Thread Konstantin Belousov
On Sat, Nov 03, 2018 at 08:52:16AM -0400, Charlie Li wrote: > On 01/11/2018 15:43, Charlie Li wrote: > > On 01/11/2018 12:04, Brooks Davis wrote: > >> Is this failure with devel/llvm70? It's currently missing the patch > >> required to make this work. https://reviews.freebsd.org/D17709 contains >

Re: svn commit: r339898 - head/lib/libc/amd64/sys

2018-11-03 Thread Charlie Li
On 01/11/2018 15:43, Charlie Li wrote: > On 01/11/2018 12:04, Brooks Davis wrote: >> Is this failure with devel/llvm70? It's currently missing the patch >> required to make this work. https://reviews.freebsd.org/D17709 contains >> this patch among others. I'll see about getting it applied. >> >

Re: svn commit: r339898 - head/lib/libc/amd64/sys

2018-11-01 Thread Charlie Li
On 01/11/2018 12:04, Brooks Davis wrote: > Is this failure with devel/llvm70? It's currently missing the patch > required to make this work. https://reviews.freebsd.org/D17709 contains > this patch among others. I'll see about getting it applied. > Yes, devel/llvm70. Will build with your port c

Re: svn commit: r339898 - head/lib/libc/amd64/sys

2018-11-01 Thread Brooks Davis
On Thu, Nov 01, 2018 at 08:57:24AM -0400, Charlie Li wrote: > On 29/10/2018 20:11, Konstantin Belousov wrote: > > Author: kib > > Date: Tue Oct 30 00:11:30 2018 > > New Revision: 339898 > > URL: https://svnweb.freebsd.org/changeset/base/339898 > > > > Log: > > Convert amd64_get/set_fs/gsbase to

Re: svn commit: r339898 - head/lib/libc/amd64/sys

2018-11-01 Thread Charlie Li
On 29/10/2018 20:11, Konstantin Belousov wrote: > Author: kib > Date: Tue Oct 30 00:11:30 2018 > New Revision: 339898 > URL: https://svnweb.freebsd.org/changeset/base/339898 > > Log: > Convert amd64_get/set_fs/gsbase to ifunc. > > Note that this is the first use of ifuncs in our userspace.

svn commit: r339898 - head/lib/libc/amd64/sys

2018-10-29 Thread Konstantin Belousov
Author: kib Date: Tue Oct 30 00:11:30 2018 New Revision: 339898 URL: https://svnweb.freebsd.org/changeset/base/339898 Log: Convert amd64_get/set_fs/gsbase to ifunc. Note that this is the first use of ifuncs in our userspace. Sponsored by: The FreeBSD Foundation MFC after:1 month