Re: svn commit: r337334 - head/lib/libc/sys

2018-11-13 Thread Warner Losh
On Sun, Aug 5, 2018 at 6:46 PM Bruce Evans wrote: > On Mon, 6 Aug 2018, Bruce Evans wrote: > > > ... > > I forgot about FAT times, and only remembered that utc_offset() was used > > for RTC drivers. I thought that utc_offset() is 0 unless something sets > > the timezone to nonzero or the RTC is

Re: svn commit: r337334 - head/lib/libc/sys

2018-08-05 Thread Bruce Evans
On Mon, 6 Aug 2018, Bruce Evans wrote: ... I forgot about FAT times, and only remembered that utc_offset() was used for RTC drivers. I thought that utc_offset() is 0 unless something sets the timezone to nonzero or the RTC is on local time (wall_cmos_clock case). However, since the kernel needs

Re: svn commit: r337334 - head/lib/libc/sys

2018-08-05 Thread Bruce Evans
On Sun, 5 Aug 2018, Ian Lepore wrote: On Sat, 2018-08-04 at 16:39 -0600, Warner Losh wrote: [Context lost to corruption of spaces} Specifically, for compatibility, we store minutes west of UTC on settimeofday and we retrieve it for settimeofday. Otherwise it's 100% unused by anything else at

Re: svn commit: r337334 - head/lib/libc/sys

2018-08-05 Thread Warner Losh
On Sun, Aug 5, 2018, 3:22 PM Ian Lepore wrote: > On Sat, 2018-08-04 at 16:39 -0600, Warner Losh wrote: > > On Sat, Aug 4, 2018 at 4:24 PM, Rodney W. Grimes < > > free...@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > > > > > > > > > Author: cem > > > > Date: Sat Aug 4 22:08:24 2018 > > > > New Revisio

Re: svn commit: r337334 - head/lib/libc/sys

2018-08-05 Thread Ian Lepore
On Sat, 2018-08-04 at 16:39 -0600, Warner Losh wrote: > On Sat, Aug 4, 2018 at 4:24 PM, Rodney W. Grimes < > free...@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > > > > > Author: cem > > > Date: Sat Aug  4 22:08:24 2018 > > > New Revision: 337334 > > > URL: https://svnweb.freebsd.org/changeset/base/3

Re: svn commit: r337334 - head/lib/libc/sys

2018-08-05 Thread Bruce Evans
On Sat, 4 Aug 2018, Conrad Meyer wrote: Log: settimeofday(2): Remove stale note about timezone Contrary to the removed comment, the kernel does appear to use the timezone argument of settimeofday. The comment dates to the BSD4.4 import; I assume it is just stale. The kernel not only appe

Re: svn commit: r337334 - head/lib/libc/sys

2018-08-04 Thread Warner Losh
On Sat, Aug 4, 2018 at 5:01 PM, Warner Losh wrote: > > > On Sat, Aug 4, 2018, 11:48 PM Conrad Meyer wrote: > >> If not stale, it was inaccurate as-is. It seems to be used by a bunch >> of different clock-related drivers and routines, e.g., >> >> $ rg '(tz_minuteswest|tz_dst|utc_offset)' | wc -l

Re: svn commit: r337334 - head/lib/libc/sys

2018-08-04 Thread Warner Losh
On Sat, Aug 4, 2018, 11:48 PM Conrad Meyer wrote: > If not stale, it was inaccurate as-is. It seems to be used by a bunch > of different clock-related drivers and routines, e.g., > > $ rg '(tz_minuteswest|tz_dst|utc_offset)' | wc -l > 36 > Right. Nothings sets it any more though and hasn'

Re: svn commit: r337334 - head/lib/libc/sys

2018-08-04 Thread Conrad Meyer
If not stale, it was inaccurate as-is. It seems to be used by a bunch of different clock-related drivers and routines, e.g., $ rg '(tz_minuteswest|tz_dst|utc_offset)' | wc -l 36 To me there is a disconnect between that use and "timezone is no longer used; this information is kept outside t

Re: svn commit: r337334 - head/lib/libc/sys

2018-08-04 Thread Warner Losh
On Sat, Aug 4, 2018 at 4:24 PM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > Author: cem > > Date: Sat Aug 4 22:08:24 2018 > > New Revision: 337334 > > URL: https://svnweb.freebsd.org/changeset/base/337334 > > > > Log: > > settimeofday(2): Remove stale note about timezone > > >

Re: svn commit: r337334 - head/lib/libc/sys

2018-08-04 Thread Rodney W. Grimes
> Author: cem > Date: Sat Aug 4 22:08:24 2018 > New Revision: 337334 > URL: https://svnweb.freebsd.org/changeset/base/337334 > > Log: > settimeofday(2): Remove stale note about timezone > > Contrary to the removed comment, the kernel does appear to use the timezone > argument of settimeo

Re: svn commit: r337334 - head/lib/libc/sys

2018-08-04 Thread Warner Losh
How is this stale? It said it unused, and now it doesn't say this are is completely ignored. Warner On Sat, Aug 4, 2018, 11:08 PM Conrad Meyer wrote: > Author: cem > Date: Sat Aug 4 22:08:24 2018 > New Revision: 337334 > URL: https://svnweb.freebsd.org/changeset/base/337334 > > Log: > settim

svn commit: r337334 - head/lib/libc/sys

2018-08-04 Thread Conrad Meyer
Author: cem Date: Sat Aug 4 22:08:24 2018 New Revision: 337334 URL: https://svnweb.freebsd.org/changeset/base/337334 Log: settimeofday(2): Remove stale note about timezone Contrary to the removed comment, the kernel does appear to use the timezone argument of settimeofday. The comment d