Re: svn commit: r334708 - head/sys/kern

On Fri, 17 Aug 2018 12:08:20 -0400 Mark Johnston wrote: > On Thu, Jul 19, 2018 at 12:09:21PM -0700, Bryan Drewery wrote: > > Did this issue get resolved? > > It's fixed by r337974. Thanks Mark! - Justin ___ svn-src-head@freebsd.org mailing list htt

Re: svn commit: r334708 - head/sys/kern

On Thu, Jul 19, 2018 at 12:09:21PM -0700, Bryan Drewery wrote: > Did this issue get resolved? It's fixed by r337974. > On 6/8/2018 11:37 AM, Konstantin Belousov wrote: > > On Fri, Jun 08, 2018 at 02:30:10PM -0400, Mark Johnston wrote: > >> On Fri, Jun 08, 2018 at 08:37:55PM +0300, Konstantin Belo

Re: svn commit: r334708 - head/sys/kern

To the best of my understanding, the underlying race condition within the assert has not been solved. I've worked around it for now by simply removing the assert, but that's just a workaround to keep my development going. - Justin On Thu, Jul 19, 2018 at 2:09 PM Bryan Drewery wrote: > > Did this

Re: svn commit: r334708 - head/sys/kern

Did this issue get resolved? On 6/8/2018 11:37 AM, Konstantin Belousov wrote: > On Fri, Jun 08, 2018 at 02:30:10PM -0400, Mark Johnston wrote: >> On Fri, Jun 08, 2018 at 08:37:55PM +0300, Konstantin Belousov wrote: >>> On Thu, Jun 07, 2018 at 11:02:29PM -0700, Ryan Libby wrote: On Thu, Jun 7,

Re: svn commit: r334708 - head/sys/kern

On Fri, Jun 08, 2018 at 02:30:10PM -0400, Mark Johnston wrote: > On Fri, Jun 08, 2018 at 08:37:55PM +0300, Konstantin Belousov wrote: > > On Thu, Jun 07, 2018 at 11:02:29PM -0700, Ryan Libby wrote: > > > On Thu, Jun 7, 2018 at 10:03 PM, Mateusz Guzik wrote: > > > > Checking it without any locks is

Re: svn commit: r334708 - head/sys/kern

On Fri, Jun 08, 2018 at 08:37:55PM +0300, Konstantin Belousov wrote: > On Thu, Jun 07, 2018 at 11:02:29PM -0700, Ryan Libby wrote: > > On Thu, Jun 7, 2018 at 10:03 PM, Mateusz Guzik wrote: > > > Checking it without any locks is perfectly valid in this case. It is done > > > after v_holdcnt gets bu

Re: svn commit: r334708 - head/sys/kern

On Thu, Jun 07, 2018 at 11:02:29PM -0700, Ryan Libby wrote: > On Thu, Jun 7, 2018 at 10:03 PM, Mateusz Guzik wrote: > > On Fri, Jun 8, 2018 at 6:29 AM, Ryan Libby wrote: > >> > >> On Thu, Jun 7, 2018 at 8:32 PM, Mark Johnston wrote: > >> > On Wed, Jun 06, 2018 at 05:03:11PM +0300, Konstantin Bel

Re: svn commit: r334708 - head/sys/kern

On Thu, Jun 7, 2018 at 10:03 PM, Mateusz Guzik wrote: > On Fri, Jun 8, 2018 at 6:29 AM, Ryan Libby wrote: >> >> On Thu, Jun 7, 2018 at 8:32 PM, Mark Johnston wrote: >> > On Wed, Jun 06, 2018 at 05:03:11PM +0300, Konstantin Belousov wrote: >> >> On Wed, Jun 06, 2018 at 12:57:12PM +, Justin Hi

Re: svn commit: r334708 - head/sys/kern

On Fri, Jun 08, 2018 at 07:03:04AM +0200, Mateusz Guzik wrote: > Part of the problem is lack of primitives like READ_ONCE/WRITE_ONCE as > seen in the linux kernel, someone should hack up equivalents. Only replying to this statement right now. What is the semantic of the _ONCE operations ? Isn't i

Re: svn commit: r334708 - head/sys/kern

> The main codepath which runs into this (... -> cache_lookup -> vhold) most > definitely does not need the fence for production operation. > > What is unclear without audit is whether there are vhold users which need > one. I think the patch is fine to go in if the other VI_FREE place gets a > com

Re: svn commit: r334708 - head/sys/kern

On Fri, Jun 8, 2018 at 6:29 AM, Ryan Libby wrote: > On Thu, Jun 7, 2018 at 8:32 PM, Mark Johnston wrote: > > On Wed, Jun 06, 2018 at 05:03:11PM +0300, Konstantin Belousov wrote: > >> On Wed, Jun 06, 2018 at 12:57:12PM +, Justin Hibbits wrote: > >> > Author: jhibbits > >> > Date: Wed Jun 6 1

Re: svn commit: r334708 - head/sys/kern

On Thu, Jun 7, 2018 at 8:32 PM, Mark Johnston wrote: > On Wed, Jun 06, 2018 at 05:03:11PM +0300, Konstantin Belousov wrote: >> On Wed, Jun 06, 2018 at 12:57:12PM +, Justin Hibbits wrote: >> > Author: jhibbits >> > Date: Wed Jun 6 12:57:11 2018 >> > New Revision: 334708 >> > URL: https://svnwe

Re: svn commit: r334708 - head/sys/kern

On Wed, Jun 06, 2018 at 05:03:11PM +0300, Konstantin Belousov wrote: > On Wed, Jun 06, 2018 at 12:57:12PM +, Justin Hibbits wrote: > > Author: jhibbits > > Date: Wed Jun 6 12:57:11 2018 > > New Revision: 334708 > > URL: https://svnweb.freebsd.org/changeset/base/334708 > > > > Log: > > Add a

Re: svn commit: r334708 - head/sys/kern

On Wed, Jun 06, 2018 at 12:57:12PM +, Justin Hibbits wrote: > Author: jhibbits > Date: Wed Jun 6 12:57:11 2018 > New Revision: 334708 > URL: https://svnweb.freebsd.org/changeset/base/334708 > > Log: > Add a memory barrier after taking a reference on the vnode holdcnt in _vhold > > This

Re: svn commit: r334708 - head/sys/kern

On 06/06/2018 16:02, Warner Losh wrote: > > > On Wed, Jun 6, 2018 at 8:57 AM, Justin Hibbits > wrote: > > Author: jhibbits > Date: Wed Jun  6 12:57:11 2018 > New Revision: 334708 > URL: https://svnweb.freebsd.org/changeset/base/334708 >

Re: svn commit: r334708 - head/sys/kern

On Wed, Jun 6, 2018 at 9:02 AM, Warner Losh wrote: > > > On Wed, Jun 6, 2018 at 8:57 AM, Justin Hibbits wrote: >> >> Author: jhibbits >> Date: Wed Jun 6 12:57:11 2018 >> New Revision: 334708 >> URL: https://svnweb.freebsd.org/changeset/base/334708 >> >> Log: >> Add a memory barrier after takin

Re: svn commit: r334708 - head/sys/kern

On Wed, Jun 6, 2018 at 8:57 AM, Justin Hibbits wrote: > Author: jhibbits > Date: Wed Jun 6 12:57:11 2018 > New Revision: 334708 > URL: https://svnweb.freebsd.org/changeset/base/334708 > > Log: > Add a memory barrier after taking a reference on the vnode holdcnt in > _vhold > > This is needed

svn commit: r334708 - head/sys/kern

Author: jhibbits Date: Wed Jun 6 12:57:11 2018 New Revision: 334708 URL: https://svnweb.freebsd.org/changeset/base/334708 Log: Add a memory barrier after taking a reference on the vnode holdcnt in _vhold This is needed to avoid a race between the VNASSERT() below, and another thread upda