Re: svn commit: r334595 - in head: sys/dev/hwpmc sys/kern sys/sys usr.sbin/pmcstat

2018-06-05 Thread Konstantin Belousov
On Mon, Jun 04, 2018 at 10:27:21AM -0700, Matthew Macy wrote: > On Mon, Jun 4, 2018 at 5:08 AM, Konstantin Belousov > wrote: > > On Mon, Jun 04, 2018 at 01:10:23AM +, Matt Macy wrote: > >> @@ -2214,6 +2236,11 @@ pmc_hook_handler(struct thread *td, int function, > >> void > >> > >>

Re: svn commit: r334595 - in head: sys/dev/hwpmc sys/kern sys/sys usr.sbin/pmcstat

2018-06-04 Thread Matthew Macy
On Mon, Jun 4, 2018 at 5:08 AM, Konstantin Belousov wrote: > On Mon, Jun 04, 2018 at 01:10:23AM +, Matt Macy wrote: >> @@ -2214,6 +2236,11 @@ pmc_hook_handler(struct thread *td, int function, void >> >> pmc_capture_user_callchain(PCPU_GET(cpuid), PMC_HR, >> (str

Re: svn commit: r334595 - in head: sys/dev/hwpmc sys/kern sys/sys usr.sbin/pmcstat

2018-06-04 Thread Konstantin Belousov
On Mon, Jun 04, 2018 at 03:08:15PM +0300, Konstantin Belousov wrote: > On Mon, Jun 04, 2018 at 01:10:23AM +, Matt Macy wrote: > > @@ -2214,6 +2236,11 @@ pmc_hook_handler(struct thread *td, int function, > > void > > > > pmc_capture_user_callchain(PCPU_GET(cpuid), PMC_HR, > >

Re: svn commit: r334595 - in head: sys/dev/hwpmc sys/kern sys/sys usr.sbin/pmcstat

2018-06-04 Thread Konstantin Belousov
On Mon, Jun 04, 2018 at 01:10:23AM +, Matt Macy wrote: > @@ -2214,6 +2236,11 @@ pmc_hook_handler(struct thread *td, int function, void > > pmc_capture_user_callchain(PCPU_GET(cpuid), PMC_HR, > (struct trapframe *) arg); > + > + KASSERT(td->td_pinned

svn commit: r334595 - in head: sys/dev/hwpmc sys/kern sys/sys usr.sbin/pmcstat

2018-06-03 Thread Matt Macy
Author: mmacy Date: Mon Jun 4 01:10:23 2018 New Revision: 334595 URL: https://svnweb.freebsd.org/changeset/base/334595 Log: hwpmc: support sampling both kernel and user stacks when interrupted in kernel This adds the -U options to pmcstat which will attribute in-kernel samples back to th