Re: svn commit: r334104 - in head/sys: netinet sys

2018-05-26 Thread Cy Schubert
In message <20180524044746.gx71...@freebsd.org>, Gleb Smirnoff writes: > On Thu, May 24, 2018 at 06:44:20AM +0200, Mateusz Guzik wrote: > M> I fundamentally disagree with this part. > M> > M> If a known value of a given field is needed for assertion purposes, you > M> can add (possibly conditional

Re: svn commit: r334104 - in head/sys: netinet sys

2018-05-26 Thread Matthew Macy
I've re-edited that code twice by request by others. I will amend it again at some point to reflect this viewpoint. On Sat, May 26, 2018 at 12:44 PM, Eric van Gyzen wrote: > On 05/23/2018 23:47, Gleb Smirnoff wrote: >> >> On Thu, May 24, 2018 at 06:44:20AM +0200, Mateusz Guzik wrote: >> M> I fund

Re: svn commit: r334104 - in head/sys: netinet sys

2018-05-26 Thread Eric van Gyzen
On 05/23/2018 23:47, Gleb Smirnoff wrote: On Thu, May 24, 2018 at 06:44:20AM +0200, Mateusz Guzik wrote: M> I fundamentally disagree with this part. M> M> If a known value of a given field is needed for assertion purposes, you M> can add (possibly conditional) code setting this specific value. It

Re: svn commit: r334104 - in head/sys: netinet sys

2018-05-23 Thread Gleb Smirnoff
On Thu, May 24, 2018 at 06:44:20AM +0200, Mateusz Guzik wrote: M> I fundamentally disagree with this part. M> M> If a known value of a given field is needed for assertion purposes, you M> can add (possibly conditional) code setting this specific value. It M> probably should not be zero if it can b

Re: svn commit: r334104 - in head/sys: netinet sys

2018-05-23 Thread Mateusz Guzik
On Thu, May 24, 2018 at 2:40 AM, Jonathan T. Looney wrote: > On Wed, May 23, 2018 at 7:13 PM, Matthew Macy wrote: > > > > On Wed, May 23, 2018 at 11:52 AM, John Baldwin wrote: > > > On Wednesday, May 23, 2018 05:00:05 PM Matt Macy wrote: > > >> Author: mmacy > > >> Date: Wed May 23 17:00:05 201

Re: svn commit: r334104 - in head/sys: netinet sys

2018-05-23 Thread Eitan Adler
On 23 May 2018 at 17:40, Jonathan T. Looney wrote: > On Wed, May 23, 2018 at 7:13 PM, Matthew Macy wrote: >> >> On Wed, May 23, 2018 at 11:52 AM, John Baldwin wrote: >> > On Wednesday, May 23, 2018 05:00:05 PM Matt Macy wrote: >> >> Author: mmacy >> >> Date: Wed May 23 17:00:05 2018 >> >> New Re

Re: svn commit: r334104 - in head/sys: netinet sys

2018-05-23 Thread Jonathan T. Looney
On Wed, May 23, 2018 at 7:13 PM, Matthew Macy wrote: > > On Wed, May 23, 2018 at 11:52 AM, John Baldwin wrote: > > On Wednesday, May 23, 2018 05:00:05 PM Matt Macy wrote: > >> Author: mmacy > >> Date: Wed May 23 17:00:05 2018 > >> New Revision: 334104 > >> URL: https://svnweb.freebsd.org/changese

Re: svn commit: r334104 - in head/sys: netinet sys

2018-05-23 Thread Matthew Macy
On Wed, May 23, 2018 at 11:52 AM, John Baldwin wrote: > On Wednesday, May 23, 2018 05:00:05 PM Matt Macy wrote: >> Author: mmacy >> Date: Wed May 23 17:00:05 2018 >> New Revision: 334104 >> URL: https://svnweb.freebsd.org/changeset/base/334104 >> >> Log: >> epoch: allow for conditionally asserti

Re: svn commit: r334104 - in head/sys: netinet sys

2018-05-23 Thread John Baldwin
On Wednesday, May 23, 2018 05:00:05 PM Matt Macy wrote: > Author: mmacy > Date: Wed May 23 17:00:05 2018 > New Revision: 334104 > URL: https://svnweb.freebsd.org/changeset/base/334104 > > Log: > epoch: allow for conditionally asserting that the epoch context fields > are unused by zeroing on I

svn commit: r334104 - in head/sys: netinet sys

2018-05-23 Thread Matt Macy
Author: mmacy Date: Wed May 23 17:00:05 2018 New Revision: 334104 URL: https://svnweb.freebsd.org/changeset/base/334104 Log: epoch: allow for conditionally asserting that the epoch context fields are unused by zeroing on INVARIANTS builds Modified: head/sys/netinet/ip_divert.c head/sys/ne