Re: svn commit: r333945 - head/usr.bin/top

2018-06-14 Thread Bruce Evans
On Thu, 14 Jun 2018, Eitan Adler wrote: On 10 June 2018 at 09:26, Alexey Dokuchaev wrote: On Sun, Jun 10, 2018 at 08:56:24AM -0700, Eitan Adler wrote: On 10 June 2018 at 05:28, Alexey Dokuchaev wrote: I've just tried the latest top(1). Now it's even worse: ... Also, it is COMMA now. Can w

Re: svn commit: r333945 - head/usr.bin/top

2018-06-14 Thread Alexey Dokuchaev
On Thu, Jun 14, 2018 at 05:12:09AM -0700, Eitan Adler wrote: > On 10 June 2018 at 09:26, Alexey Dokuchaev wrote: > > On Sun, Jun 10, 2018 at 08:56:24AM -0700, Eitan Adler wrote: > >> On 10 June 2018 at 05:28, Alexey Dokuchaev wrote: > >> > I've just tried the latest top(1). Now it's even worse:

Re: svn commit: r333945 - head/usr.bin/top

2018-06-14 Thread Eitan Adler
On 10 June 2018 at 09:26, Alexey Dokuchaev wrote: > On Sun, Jun 10, 2018 at 08:56:24AM -0700, Eitan Adler wrote: >> On 10 June 2018 at 05:28, Alexey Dokuchaev wrote: >> > I've just tried the latest top(1). Now it's even worse: >> > ... >> > Also, it is COMMA now. Can we please do something abou

Re: svn commit: r333945 - head/usr.bin/top

2018-06-10 Thread Alexey Dokuchaev
On Sun, Jun 10, 2018 at 08:56:24AM -0700, Eitan Adler wrote: > On 10 June 2018 at 05:28, Alexey Dokuchaev wrote: > > I've just tried the latest top(1). Now it's even worse: > > ... > > Also, it is COMMA now. Can we please do something about this? I am not > > calling for "USER PRI" as Bruce had

Re: svn commit: r333945 - head/usr.bin/top

2018-06-10 Thread Eitan Adler
On 10 June 2018 at 05:28, Alexey Dokuchaev wrote: > On Mon, May 21, 2018 at 06:39:53AM +, Alexey Dokuchaev wrote: >> I [...] have to patch top(1) locally to use namelength = 8 and header >> format so it neatly looks like this: >> >> PID USERNAME THR PRI NICE SIZERES STATE C TIME

Re: svn commit: r333945 - head/usr.bin/top

2018-06-10 Thread Alexey Dokuchaev
On Mon, May 21, 2018 at 06:39:53AM +, Alexey Dokuchaev wrote: > I [...] have to patch top(1) locally to use namelength = 8 and header > format so it neatly looks like this: > > PID USERNAME THR PRI NICE SIZERES STATE C TIMEWCPU COMMAND > 844 danfe 2 210 114M 38836

Re: svn commit: r333945 - head/usr.bin/top

2018-05-26 Thread Bruce Evans
On Fri, 25 May 2018, Eitan Adler wrote: On 20 May 2018 at 23:39, Alexey Dokuchaev wrote: On Mon, May 21, 2018 at 10:32:30AM +1000, Bruce Evans wrote: ... if (smpmode && namelength > SMPUNAMELEN) namelength = SMPUNAMELEN; else if (namelength > UPUNAMELEN) ... what abou

Re: svn commit: r333945 - head/usr.bin/top

2018-05-25 Thread Eitan Adler
On 20 May 2018 at 23:39, Alexey Dokuchaev wrote: > On Mon, May 21, 2018 at 10:32:30AM +1000, Bruce Evans wrote: >> ... >> > if (smpmode && namelength > SMPUNAMELEN) >> > namelength = SMPUNAMELEN; >> > else if (namelength > UPUNAMELEN) >> ... what about this? commit 7d041879b4

Re: svn commit: r333945 - head/usr.bin/top

2018-05-20 Thread Alexey Dokuchaev
On Mon, May 21, 2018 at 10:32:30AM +1000, Bruce Evans wrote: > ... > > if (smpmode && namelength > SMPUNAMELEN) > > namelength = SMPUNAMELEN; > > else if (namelength > UPUNAMELEN) > > But 33 is too large. It is much larger than the hard-coded maximum limits, > so it is never u

Re: svn commit: r333945 - head/usr.bin/top

2018-05-20 Thread Bruce Evans
On Sun, 20 May 2018, Eitan Adler wrote: Log: top(1): set max username length based on system constant This changes previous behavior of calculating it at startup based on the current max username length. This is done because: - it is in theory possible for the max length to change at run-

svn commit: r333945 - head/usr.bin/top

2018-05-20 Thread Eitan Adler
Author: eadler Date: Sun May 20 23:19:09 2018 New Revision: 333945 URL: https://svnweb.freebsd.org/changeset/base/333945 Log: top(1): set max username length based on system constant This changes previous behavior of calculating it at startup based on the current max username length.