Re: svn commit: r333476 - head/sys/net

2018-05-11 Thread Rodney W. Grimes
> This booted and runs without issue, although obviously I wouldn't want > to commit it: Looks pretty close to what I did the first time. We could also wrap this in my proposed ifdef, and add a sysctl() to turn it on and off though it would probably be beter to do that in the code areas that bde p

Re: svn commit: r333476 - head/sys/net

2018-05-11 Thread Dag-Erling Smørgrav
This booted and runs without issue, although obviously I wouldn't want to commit it: Index: sys/net/if.c === --- sys/net/if.c(revision 333490) +++ sys/net/if.c(working copy) @@ -1814,6 +1814,7 @@ ifa_maintain_loopback

Re: svn commit: r333476 - head/sys/net

2018-05-10 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > "Rodney W. Grimes" writes: > > I do no need or want these routes created by this mechanism on my > > FreeBSD based routers, they only ever existed originally to use the > > MTU of the lo0 interface for things that wrongly open an IP address of > > an

Re: svn commit: r333476 - head/sys/net

2018-05-10 Thread Dag-Erling Smørgrav
"Rodney W. Grimes" writes: > I do no need or want these routes created by this mechanism on my > FreeBSD based routers, they only ever existed originally to use the > MTU of the lo0 interface for things that wrongly open an IP address of > an interface rather than 127.0.0.1. I'm not sure I unders

Re: svn commit: r333476 - head/sys/net

2018-05-10 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > "Rodney W. Grimes" writes: > > "Dag-Erling Sm?rgrav" writes: > > > In ifa_maintain_loopback_route(), don't needlessly log an error if we > > > either failed to add a route because it already existed or failed to > > > remove one because it did not.

Re: svn commit: r333476 - head/sys/net

2018-05-10 Thread Dag-Erling Smørgrav
"Rodney W. Grimes" writes: > "Dag-Erling Smørgrav" writes: > > In ifa_maintain_loopback_route(), don't needlessly log an error if we > > either failed to add a route because it already existed or failed to > > remove one because it did not. We still return an error code, though. > Those are the

Re: svn commit: r333476 - head/sys/net

2018-05-10 Thread Rodney W. Grimes
> Author: des > Date: Fri May 11 00:19:49 2018 > New Revision: 333476 > URL: https://svnweb.freebsd.org/changeset/base/333476 > > Log: > Slight cleanup of interface event logging. > > Make if_printf() use vlog() instead of vprintf(). This means it can no > longer return the number of cha

svn commit: r333476 - head/sys/net

2018-05-10 Thread Dag-Erling Smørgrav
Author: des Date: Fri May 11 00:19:49 2018 New Revision: 333476 URL: https://svnweb.freebsd.org/changeset/base/333476 Log: Slight cleanup of interface event logging. Make if_printf() use vlog() instead of vprintf(). This means it can no longer return the number of characters printed, as