Re: svn commit: r330663 - head/sys/kern

2018-03-09 Thread Ian Lepore
On Fri, 2018-03-09 at 20:50 +1100, Bruce Evans wrote: > style(9) does require this.  This is hard to see since the style > guide > has been mangled by converting it into a man page, with markup in non > C-code and lots of blank lines to separate the markup.  See > /usr/src/admin/style/style in 4.4B

Re: svn commit: r330663 - head/sys/kern

2018-03-09 Thread Mark Johnston
On Fri, Mar 09, 2018 at 03:42:05PM +1100, Bruce Evans wrote: > On Thu, 8 Mar 2018, Mark Johnston wrote: > > > Log: > > Return E2BIG if we run out of space writing a compressed kernel dump. > > E2BIG a very wrong errno. It means "Argment list too long". It is broken > as designed, with "too" en

Re: svn commit: r330663 - head/sys/kern

2018-03-09 Thread Bruce Evans
On Thu, 8 Mar 2018, Conrad Meyer wrote: On Thu, Mar 8, 2018 at 8:42 PM, Bruce Evans wrote: On Thu, 8 Mar 2018, Mark Johnston wrote: ... +++ head/sys/kern/kern_shutdown.c Thu Mar 8 17:04:36 2018 (r330663) @@ -1115,6 +1115,12 @@ dump_check_bounds(struct dumperinfo *di, off_t offset,

Re: svn commit: r330663 - head/sys/kern

2018-03-08 Thread Conrad Meyer
On Thu, Mar 8, 2018 at 8:42 PM, Bruce Evans wrote: > On Thu, 8 Mar 2018, Mark Johnston wrote: >> ... >> +++ head/sys/kern/kern_shutdown.c Thu Mar 8 17:04:36 2018 >> (r330663) >> @@ -1115,6 +1115,12 @@ dump_check_bounds(struct dumperinfo *di, off_t >> offset, >> >> if (length != 0 &&

Re: svn commit: r330663 - head/sys/kern

2018-03-08 Thread Bruce Evans
On Thu, 8 Mar 2018, Mark Johnston wrote: Log: Return E2BIG if we run out of space writing a compressed kernel dump. E2BIG a very wrong errno. It means "Argment list too long". It is broken as designed, with "too" encrypted as "2" and no indication of what is too big. EFBIG is not so wrong.

svn commit: r330663 - head/sys/kern

2018-03-08 Thread Mark Johnston
Author: markj Date: Thu Mar 8 17:04:36 2018 New Revision: 330663 URL: https://svnweb.freebsd.org/changeset/base/330663 Log: Return E2BIG if we run out of space writing a compressed kernel dump. ENOSPC causes the MD kernel dump code to retry the dump, but this is undesirable in the case w