Re: svn commit: r329077 - head/usr.bin/tftp

2018-02-10 Thread Conrad Meyer
Nah, both sets of warnings are spurious. The first set is arguably not a compiler bug, just lack of omniscience. The variables are never actually used uninitialized in the !interactive case. The second set is pure bug. Justin found the workaround (same as before this change) and has applied it.

Re: svn commit: r329077 - head/usr.bin/tftp

2018-02-10 Thread Justin Hibbits
On Sat, Feb 10, 2018 at 11:10 AM, Pedro Giffuni wrote: > > > On 02/10/18 11:13, Justin Hibbits wrote: >> >> On Fri, Feb 9, 2018 at 7:22 PM, Ed Maste wrote: >>> >>> On 9 February 2018 at 14:46, Conrad Meyer wrote: Author: cem Date: Fri Feb 9 19:46:51 2018 New Revision: 329077

Re: svn commit: r329077 - head/usr.bin/tftp

2018-02-10 Thread Pedro Giffuni
On 02/10/18 11:13, Justin Hibbits wrote: On Fri, Feb 9, 2018 at 7:22 PM, Ed Maste wrote: On 9 February 2018 at 14:46, Conrad Meyer wrote: Author: cem Date: Fri Feb 9 19:46:51 2018 New Revision: 329077 URL: https://svnweb.freebsd.org/changeset/base/329077 Log: tftp(1): Fix libedit state

Re: svn commit: r329077 - head/usr.bin/tftp

2018-02-10 Thread Justin Hibbits
On Fri, Feb 9, 2018 at 7:22 PM, Ed Maste wrote: > On 9 February 2018 at 14:46, Conrad Meyer wrote: >> Author: cem >> Date: Fri Feb 9 19:46:51 2018 >> New Revision: 329077 >> URL: https://svnweb.freebsd.org/changeset/base/329077 >> >> Log: >> tftp(1): Fix libedit state corruption involving sign

Re: svn commit: r329077 - head/usr.bin/tftp

2018-02-09 Thread Ed Maste
On 9 February 2018 at 14:46, Conrad Meyer wrote: > Author: cem > Date: Fri Feb 9 19:46:51 2018 > New Revision: 329077 > URL: https://svnweb.freebsd.org/changeset/base/329077 > > Log: > tftp(1): Fix libedit state corruption involving signals >From https://ci.freebsd.org/job/FreeBSD-head-mips-bu

svn commit: r329077 - head/usr.bin/tftp

2018-02-09 Thread Conrad Meyer
Author: cem Date: Fri Feb 9 19:46:51 2018 New Revision: 329077 URL: https://svnweb.freebsd.org/changeset/base/329077 Log: tftp(1): Fix libedit state corruption involving signals This bug was first reported 14 years ago. The problem was understood 8.5 years ago. A patch that is function