Re: svn commit: r327362 - in head/usr.bin/find: . tests

2017-12-29 Thread Oliver Pinter
On Friday, December 29, 2017, Conrad Meyer wrote: > On Fri, Dec 29, 2017 at 2:41 PM, Oliver Pinter > wrote: > > Why did you comment out these tests? > > I think unit tests are a good idea for this kind of change, which is > why I wrote them. And I run them before commit. But I'm not > interest

Re: svn commit: r327362 - in head/usr.bin/find: . tests

2017-12-29 Thread Conrad Meyer
On Fri, Dec 29, 2017 at 2:41 PM, Oliver Pinter wrote: > Why did you comment out these tests? I think unit tests are a good idea for this kind of change, which is why I wrote them. And I run them before commit. But I'm not interested in tilting at the test build infrastructure to actually enable

Re: svn commit: r327362 - in head/usr.bin/find: . tests

2017-12-29 Thread Oliver Pinter
On Friday, December 29, 2017, Conrad Meyer wrote: > Author: cem > Date: Fri Dec 29 22:08:43 2017 > New Revision: 327362 > URL: https://svnweb.freebsd.org/changeset/base/327362 > > Log: > find(1): Fix -newer and -samefile to conform to POSIX[0] > > By default, or with the -P flag, find(1) shou

svn commit: r327362 - in head/usr.bin/find: . tests

2017-12-29 Thread Conrad Meyer
Author: cem Date: Fri Dec 29 22:08:43 2017 New Revision: 327362 URL: https://svnweb.freebsd.org/changeset/base/327362 Log: find(1): Fix -newer and -samefile to conform to POSIX[0] By default, or with the -P flag, find(1) should evaluate paths "physically." For symlinks, this means using t