Re: svn commit: r324646 - in head/sys/boot/efi: boot1 libefi loader

2017-10-17 Thread Alastair Hogge
On Mon, 16 Oct 2017-10-16 03:59:12 Warner Losh wrote: > Author: imp > Date: Mon Oct 16 03:59:11 2017 > New Revision: 324646 > URL: https://svnweb.freebsd.org/changeset/base/324646 > > Log: > Unify boot1 with loader > > Refactor boot1 to use the same I/O code as /boot/loader uses. Refactor >

Re: svn commit: r324646 - in head/sys/boot/efi: boot1 libefi loader

2017-10-16 Thread Emmanuel Vadot
On Mon, 16 Oct 2017 20:08:19 +0300 Toomas Soome wrote: > > The arm (uboot) has a bit different approach on block device(s), see > efipart_hdinfo_add_filepath() in efipart.c; the code needs to check for > MEDIA_FILEPATH_DP, I think. > > rgds, > toomas I'm pretty sure that qemu doesn't use u-

Re: svn commit: r324646 - in head/sys/boot/efi: boot1 libefi loader

2017-10-16 Thread Toomas Soome
The arm (uboot) has a bit different approach on block device(s), see efipart_hdinfo_add_filepath() in efipart.c; the code needs to check for MEDIA_FILEPATH_DP, I think. rgds, toomas > On 16 Oct 2017, at 19:07, Andrew Turner wrote: > > Correct, it is aarch64. It runs a similar qemu command,

Re: svn commit: r324646 - in head/sys/boot/efi: boot1 libefi loader

2017-10-16 Thread Andrew Turner
Correct, it is aarch64. It runs a similar qemu command, however I also see it under the ARM Foundation model so it seems to not be simulator specific. Andrew > On 16 Oct 2017, at 16:56, Warner Losh wrote: > > So this is on aarch64? Is this running a standardish qemu setup as documented > on h

Re: svn commit: r324646 - in head/sys/boot/efi: boot1 libefi loader

2017-10-16 Thread Warner Losh
So this is on aarch64? Is this running a standardish qemu setup as documented on https://wiki.freebsd.org/arm64/QEMU ? Or are there tricks that we need to cope with... If we can't get good resoltuion on this today, I plan on backing out the entire change. Warner On Mon, Oct 16, 2017 at 9:38 AM,

Re: svn commit: r324646 - in head/sys/boot/efi: boot1 libefi loader

2017-10-16 Thread Andrew Turner
I have a local Jenkins setup that builds images & tries to run under various simulators. The final image is built with mkimg. I’m running it under qemu. Andrew > On 16 Oct 2017, at 13:19, Warner Losh wrote: > > I'll take a look, but I've also ccd Eric so he can figure out what went wrong > wi

Re: svn commit: r324646 - in head/sys/boot/efi: boot1 libefi loader

2017-10-16 Thread Warner Losh
I'll take a look, but I've also ccd Eric so he can figure out what went wrong with is code in your environment. What env is That? Warnee On Oct 16, 2017 3:26 AM, "Andrew Turner" wrote: > > > On 16 Oct 2017, at 04:59, Warner Losh wrote: > > > > Author: imp > > Date: Mon Oct 16 03:59:11 2017 > >

Re: svn commit: r324646 - in head/sys/boot/efi: boot1 libefi loader

2017-10-16 Thread Andrew Turner
> On 16 Oct 2017, at 04:59, Warner Losh wrote: > > Author: imp > Date: Mon Oct 16 03:59:11 2017 > New Revision: 324646 > URL: https://svnweb.freebsd.org/changeset/base/324646 > > Log: > Unify boot1 with loader > > Refactor boot1 to use the same I/O code as /boot/loader uses. Refactor > to u

svn commit: r324646 - in head/sys/boot/efi: boot1 libefi loader

2017-10-15 Thread Warner Losh
Author: imp Date: Mon Oct 16 03:59:11 2017 New Revision: 324646 URL: https://svnweb.freebsd.org/changeset/base/324646 Log: Unify boot1 with loader Refactor boot1 to use the same I/O code as /boot/loader uses. Refactor to use the common efi_main.c. Submitted by: Eric McCorkle Differ