On Thu, Sep 14, 2017 at 12:32 AM, Gleb Smirnoff wrote:
> On Mon, Sep 11, 2017 at 09:30:10AM +0200, Mateusz Guzik wrote:
> M> First, there is a bunch of counter(9) fields. I don't know the original
> M> reasoning. I would expect these counters to be statically defined in a
> M> per-cpu struct.
>
>
On Mon, Sep 11, 2017 at 09:30:10AM +0200, Mateusz Guzik wrote:
M> First, there is a bunch of counter(9) fields. I don't know the original
M> reasoning. I would expect these counters to be statically defined in a
M> per-cpu struct.
The reasoning was to remove 'struct vmmeter' from the 'struct pcpu'
On Mon, 11 Sep 2017, Mateusz Guzik wrote:
On Mon, Sep 11, 2017 at 10:24 AM, Ryan Libby wrote:
On Mon, Sep 11, 2017 at 12:30 AM, Mateusz Guzik wrote:
[...]
That said, looking now at the struct I think its use should be retired
from the kernel. It can remain in headers for userspace use.
Mo
On Mon, Sep 11, 2017 at 10:24 AM, Ryan Libby wrote:
> On Mon, Sep 11, 2017 at 12:30 AM, Mateusz Guzik wrote:
> [...]
> > That said, looking now at the struct I think its use should be retired
> > from the kernel. It can remain in headers for userspace use.
> >
> > First, there is a bunch of coun
On Mon, Sep 11, 2017 at 12:30 AM, Mateusz Guzik wrote:
[...]
> That said, looking now at the struct I think its use should be retired
> from the kernel. It can remain in headers for userspace use.
>
> First, there is a bunch of counter(9) fields. I don't know the original
> reasoning. I would expe
On Mon, Sep 11, 2017 at 11:56:21AM +1000, Bruce Evans wrote:
> On Sun, 10 Sep 2017, Mateusz Guzik wrote:
>
> > Log:
> > Move vmmeter atomic counters into dedicated cache lines
> >
> > Prior to the change they were subject to extreme false sharing.
> > In particular this change shaves about 3 sec
On Sun, 10 Sep 2017, Mateusz Guzik wrote:
Log:
Move vmmeter atomic counters into dedicated cache lines
Prior to the change they were subject to extreme false sharing.
In particular this change shaves about 3 seconds real time of -j 80
buildkernel.
Changes that small are hard to measure.
Author: mjg
Date: Sun Sep 10 19:00:38 2017
New Revision: 323393
URL: https://svnweb.freebsd.org/changeset/base/323393
Log:
Move vmmeter atomic counters into dedicated cache lines
Prior to the change they were subject to extreme false sharing.
In particular this change shaves about 3 secon
