Re: svn commit: r320277 - head/usr.bin/mkuzip

2017-06-24 Thread Ngie Cooper (yaneurabeya)
> On Jun 23, 2017, at 16:51, Glen Barber wrote: > > On Fri, Jun 23, 2017 at 03:54:35PM -0700, Conrad Meyer wrote: >>> @@ -58,12 +59,15 @@ mkuz_get_insize(struct mkuz_cfg *cfp) >>>ffd = open(statfsbuf.f_mntfromname, O_RDONLY); >>>if (ffd < 0) { >>>

Re: svn commit: r320277 - head/usr.bin/mkuzip

2017-06-23 Thread Glen Barber
On Fri, Jun 23, 2017 at 03:54:35PM -0700, Conrad Meyer wrote: > > @@ -58,12 +59,15 @@ mkuz_get_insize(struct mkuz_cfg *cfp) > > ffd = open(statfsbuf.f_mntfromname, O_RDONLY); > > if (ffd < 0) { > > warn("open(%s, O_RDONLY)", statfsbuf.f_mntfro

Re: svn commit: r320277 - head/usr.bin/mkuzip

2017-06-23 Thread Maxim Sobolev
Yeah, silly me. Thanks^2. -Max On Fri, Jun 23, 2017 at 3:54 PM, Conrad Meyer wrote: > One more nit. > > On Fri, Jun 23, 2017 at 10:39 AM, Maxim Sobolev > wrote: > > Author: sobomax > > Date: Fri Jun 23 17:39:00 2017 > > New Revision: 320277 > > URL: https://svnweb.freebsd.org/changeset/base/32

Re: svn commit: r320277 - head/usr.bin/mkuzip

2017-06-23 Thread Conrad Meyer
One more nit. On Fri, Jun 23, 2017 at 10:39 AM, Maxim Sobolev wrote: > Author: sobomax > Date: Fri Jun 23 17:39:00 2017 > New Revision: 320277 > URL: https://svnweb.freebsd.org/changeset/base/320277 > > Log: > Don't leak file descriptor in some cases. > > Reported by: cem > MFC after:6

svn commit: r320277 - head/usr.bin/mkuzip

2017-06-23 Thread Maxim Sobolev
Author: sobomax Date: Fri Jun 23 17:39:00 2017 New Revision: 320277 URL: https://svnweb.freebsd.org/changeset/base/320277 Log: Don't leak file descriptor in some cases. Reported by: cem MFC after:6 weeks Modified: head/usr.bin/mkuzip/mkuz_insize.c Modified: head/usr.bin/mkuzip/mk