Re: svn commit: r317709 - head/usr.bin/csplit

2017-05-03 Thread Pedro Giffuni
On 05/03/17 09:56, Pedro Giffuni wrote: ... Grepping for fputs in /usr/src shows too many instances to check (mostly without any error handling). The simplest filter 'if (fputs' found the dependency on the old FreeBSD behaviour in csplit and 2 other places: contrib/mdocml/main.c:if

Re: svn commit: r317709 - head/usr.bin/csplit

2017-05-03 Thread Pedro Giffuni
On 3/5/2017 01:55, Bruce Evans wrote: On Tue, 2 May 2017, Jilles Tjoelker wrote: Log: csplit: Fix check of fputs() return value, making csplit work again. As of r295638, fputs() returns the number of bytes written (if not more than INT_MAX). This broke csplit completely, since csplit ass

Re: svn commit: r317709 - head/usr.bin/csplit

2017-05-02 Thread Bruce Evans
On Tue, 2 May 2017, Jilles Tjoelker wrote: Log: csplit: Fix check of fputs() return value, making csplit work again. As of r295638, fputs() returns the number of bytes written (if not more than INT_MAX). This broke csplit completely, since csplit assumed only success only for the return val

Re: svn commit: r317709 - head/usr.bin/csplit

2017-05-02 Thread Pedro Giffuni
Very interesting ... On 2/5/2017 16:56, Jilles Tjoelker wrote: Author: jilles Date: Tue May 2 21:56:20 2017 New Revision: 317709 URL: https://svnweb.freebsd.org/changeset/base/317709 Log: csplit: Fix check of fputs() return value, making csplit work again. As of r295638, fputs() retu

svn commit: r317709 - head/usr.bin/csplit

2017-05-02 Thread Jilles Tjoelker
Author: jilles Date: Tue May 2 21:56:20 2017 New Revision: 317709 URL: https://svnweb.freebsd.org/changeset/base/317709 Log: csplit: Fix check of fputs() return value, making csplit work again. As of r295638, fputs() returns the number of bytes written (if not more than INT_MAX). This br