Re: svn commit: r315360 - head/lib/libkvm

2017-03-15 Thread Conrad Meyer
I don't have much to add. Warner is totally correct here. It is a (good) style cleanup with no functional change. Let's leave it alone. Thanks, Conrad On Wed, Mar 15, 2017 at 9:53 PM, Warner Losh wrote: > On Wed, Mar 15, 2017 at 10:44 PM, Ngie Cooper (yaneurabeya) > wrote: >> >>> On Mar 15,

Re: svn commit: r315360 - head/lib/libkvm

2017-03-15 Thread Ngie Cooper (yaneurabeya)
> On Mar 15, 2017, at 21:53, Warner Losh wrote: > > On Wed, Mar 15, 2017 at 10:44 PM, Ngie Cooper (yaneurabeya) > wrote: >> >>> On Mar 15, 2017, at 21:32, Warner Losh wrote: >>> >>> On Wed, Mar 15, 2017 at 8:31 PM, Ngie Cooper wrote: Author: ngie Date: Thu Mar 16 02:31:42 2017 >>>

Re: svn commit: r315360 - head/lib/libkvm

2017-03-15 Thread Warner Losh
On Wed, Mar 15, 2017 at 10:44 PM, Ngie Cooper (yaneurabeya) wrote: > >> On Mar 15, 2017, at 21:32, Warner Losh wrote: >> >> On Wed, Mar 15, 2017 at 8:31 PM, Ngie Cooper wrote: >>> Author: ngie >>> Date: Thu Mar 16 02:31:42 2017 >>> New Revision: 315360 >>> URL: https://svnweb.freebsd.org/changes

Re: svn commit: r315360 - head/lib/libkvm

2017-03-15 Thread Ngie Cooper (yaneurabeya)
> On Mar 15, 2017, at 21:32, Warner Losh wrote: > > On Wed, Mar 15, 2017 at 8:31 PM, Ngie Cooper wrote: >> Author: ngie >> Date: Thu Mar 16 02:31:42 2017 >> New Revision: 315360 >> URL: https://svnweb.freebsd.org/changeset/base/315360 >> >> Log: >> Return NULL instead of 0 on failure in _kvm_

Re: svn commit: r315360 - head/lib/libkvm

2017-03-15 Thread Warner Losh
On Wed, Mar 15, 2017 at 8:31 PM, Ngie Cooper wrote: > Author: ngie > Date: Thu Mar 16 02:31:42 2017 > New Revision: 315360 > URL: https://svnweb.freebsd.org/changeset/base/315360 > > Log: > Return NULL instead of 0 on failure in _kvm_open, kvm_open{,2,files} > > This is being done for the foll

svn commit: r315360 - head/lib/libkvm

2017-03-15 Thread Ngie Cooper
Author: ngie Date: Thu Mar 16 02:31:42 2017 New Revision: 315360 URL: https://svnweb.freebsd.org/changeset/base/315360 Log: Return NULL instead of 0 on failure in _kvm_open, kvm_open{,2,files} This is being done for the following reasons: - kvm_open(3), etc says they will return NULL. -