Re: svn commit: r311283 - head/sys/cam/ctl

2017-01-05 Thread Edward Tomasz Napierała
Dnia 04.01.2017 o godz. 16:38 Ryan Stone napisał(a): >> On Wed, Jan 4, 2017 at 7:50 AM, Edward Tomasz Napierala >> wrote: >> + refcount_release(&cs->cs_outstanding_ctl_pdus); > > Shouldn't the return value of refcount_release() be checked? Not in this case. The destruction of cfumass

Re: svn commit: r311283 - head/sys/cam/ctl

2017-01-04 Thread Ryan Stone
On Wed, Jan 4, 2017 at 7:50 AM, Edward Tomasz Napierala wrote: > + refcount_release(&cs->cs_outstanding_ctl_pdus); > Shouldn't the return value of refcount_release() be checked? ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/

svn commit: r311283 - head/sys/cam/ctl

2017-01-04 Thread Edward Tomasz Napierala
Author: trasz Date: Wed Jan 4 12:50:44 2017 New Revision: 311283 URL: https://svnweb.freebsd.org/changeset/base/311283 Log: Don't release the cfiscsi session refcount too early. It wasn't observed to fix any actual error, but it's the right thing to do from the correctness point of view.