Re: svn commit: r311012 - head/include

2017-01-02 Thread Pedro Giffuni
Hi Conrad; On 01/01/17 13:17, Conrad Meyer wrote: Hey Pedro, Why not just remove __nonnull and replace it with _Nonnull in the same commit? Best, Conrad The main reason is that I want to MFC this change. Introducing _Nonnull to -stable involves some complexity: It may break use of pre-exis

Re: svn commit: r311012 - head/include

2017-01-01 Thread Conrad Meyer
Hey Pedro, Why not just remove __nonnull and replace it with _Nonnull in the same commit? Best, Conrad On Sun, Jan 1, 2017 at 9:16 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Sun Jan 1 17:16:47 2017 > New Revision: 311012 > URL: https://svnweb.freebsd.org/changeset/base/311012 > > Log: >

svn commit: r311012 - head/include

2017-01-01 Thread Pedro F. Giffuni
Author: pfg Date: Sun Jan 1 17:16:47 2017 New Revision: 311012 URL: https://svnweb.freebsd.org/changeset/base/311012 Log: Remove some uses of the GCC __nonnull() attribute. While the checks are considered useful, the attribute does dangerous optimizations, removing NULL checks where they