Re: svn commit: r310045 - head/sys/ddb

2016-12-14 Thread Bruce Evans
On Wed, 14 Dec 2016, John Baldwin wrote: On Wednesday, December 14, 2016 07:24:46 PM Bruce Evans wrote: ... I don't see how initializing to 'val' can help. It still gets corrupted to unsigned, and I would expect it to make the problem much worse because the truncation gives an even smaller val

Re: svn commit: r310045 - head/sys/ddb

2016-12-14 Thread John Baldwin
On Wednesday, December 14, 2016 07:24:46 PM Bruce Evans wrote: > On Tue, 13 Dec 2016, John Baldwin wrote: > > > On Wednesday, December 14, 2016 12:18:12 AM John Baldwin wrote: > >> > >> Log: > >> Use casts to force an unsigned comparison in db_search_symbol(). > >> > >> On all of our platforms

Re: svn commit: r310045 - head/sys/ddb

2016-12-14 Thread Bruce Evans
On Wed, 14 Dec 2016, Bruce Evans wrote: I fixed printing of negative offsets from the frame pointer on i386, but this is currently broken on i386 and never worked on other arches. DB_LARGE_VALUE_MIN has the old i386 value on all arches, but this is now wrong for i386 and never worked on other ar

Re: svn commit: r310045 - head/sys/ddb

2016-12-14 Thread Bruce Evans
On Tue, 13 Dec 2016, John Baldwin wrote: On Wednesday, December 14, 2016 12:18:12 AM John Baldwin wrote: Log: Use casts to force an unsigned comparison in db_search_symbol(). On all of our platforms, db_expr_t is a signed integer while db_addr_t is an unsigned integer value. db_search_

Re: svn commit: r310045 - head/sys/ddb

2016-12-13 Thread John Baldwin
On Wednesday, December 14, 2016 12:18:12 AM John Baldwin wrote: > Author: jhb > Date: Wed Dec 14 00:18:12 2016 > New Revision: 310045 > URL: https://svnweb.freebsd.org/changeset/base/310045 > > Log: > Use casts to force an unsigned comparison in db_search_symbol(). > > On all of our platfor

svn commit: r310045 - head/sys/ddb

2016-12-13 Thread John Baldwin
Author: jhb Date: Wed Dec 14 00:18:12 2016 New Revision: 310045 URL: https://svnweb.freebsd.org/changeset/base/310045 Log: Use casts to force an unsigned comparison in db_search_symbol(). On all of our platforms, db_expr_t is a signed integer while db_addr_t is an unsigned integer value.