Re: svn commit: r303848 - head/sys/netgraph

2016-08-15 Thread Ngie Cooper
Hi Hans, > On Aug 15, 2016, at 11:20, Hans Petter Selasky wrote: ... > Hi Ngie, > > Is this problem reproducable with projects/hps_head? I never reproed the issue before.. I'd have to look at the suggested repro from the CR poster. Thanks! -Ngie

Re: svn commit: r303848 - head/sys/netgraph

2016-08-15 Thread Hans Petter Selasky
On 08/13/16 00:23, Ngie Cooper (yaneurabeya) wrote: On Aug 12, 2016, at 11:38, Gleb Smirnoff wrote: Hi! Sorry, I'm afraid this isn't a correct fix. Simply adding checks against NULL to avoid panics at race conditions isn't a solution. I can provide help with this problem. It must be relat

Re: svn commit: r303848 - head/sys/netgraph

2016-08-12 Thread Ngie Cooper (yaneurabeya)
> On Aug 12, 2016, at 11:38, Gleb Smirnoff wrote: > > Hi! > > Sorry, I'm afraid this isn't a correct fix. Simply adding checks > against NULL to avoid panics at race conditions isn't a solution. > > I can provide help with this problem. It must be related to my > callout changes, in case if

Re: svn commit: r303848 - head/sys/netgraph

2016-08-12 Thread Sean Bruno
The original problem was reported in this review, it doesn't look like an "old" problem IMO. sean https://reviews.freebsd.org/D7209 ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send an

Re: svn commit: r303848 - head/sys/netgraph

2016-08-12 Thread Gleb Smirnoff
Hi! Sorry, I'm afraid this isn't a correct fix. Simply adding checks against NULL to avoid panics at race conditions isn't a solution. I can provide help with this problem. It must be related to my callout changes, in case if this is a very recent problem. Is it a recent problem or an old on

svn commit: r303848 - head/sys/netgraph

2016-08-08 Thread Sean Bruno
Author: sbruno Date: Mon Aug 8 19:31:01 2016 New Revision: 303848 URL: https://svnweb.freebsd.org/changeset/base/303848 Log: Avoid panic from ng_uncallout when unpluggin ethernet cable with active PPTP VPN connection. Submitted by: Michael Zhilin Reviewed by: ngie MFC after:3 d