Well
The code itself I had up on machines for probably about 2 months. But then
I switched over to Gleb’s changes here just recently .. which caused me all
kinds of fun :)
I had to go back into Mercurial to pull back my changes.. I have had the
resurrected changes running on my netflix machines
On Tue, Jul 19, 2016 at 03:46:54PM +0200, Randall Stewart wrote:
> Glen:
>
> My changes work.. I have them running in NF in at least 1/2 dozen machines.
>
For how long? What are the uptimes on these machines?
This is the blocker for 11.0-BETA2, and I don't want to see more
regressions being i
Glen:
My changes work.. I have them running in NF in at least 1/2 dozen machines.
I am more than willing to commit them.. they actually are not much different
than
whats in stable 10.. though I don’t know if the async-drain was MFC’d there.. it
needs to be in for TCP.. or else you will have yet
On Tue, Jul 19, 2016 at 01:43:16PM +0200, Randall Stewart wrote:
> Gleb
>
> Ok
>
> I have now updated
>
> https://reviews.freebsd.org/D7135
>
> You can take this or not… I really don’t care either way… (you are welcome to
> own the kern_timeout.c code I hate it) :-)
>
> Basically when you went
Gleb
Ok
I have now updated
https://reviews.freebsd.org/D7135
You can take this or not… I really don’t care either way… (you are welcome to
own the kern_timeout.c code I hate it) :-)
Basically when you went off and re-factored kern_timeout.c I had worked in
parallel on fixing
the bugs you were
I have worked out a fix of this in Netflix code base (I have the same code
running there). I
will get that tested tonight I will get the fixes in to restore the behavior.
I will setup a phabricator shortly.. most likely I will update the one I already
have on the one problem your earlier patch di
Gleb:
This now leaks TCP-PCB’s since you have broken the return codes with all your
fixes that used to be in here.
It was
return 1 — You stopped the callout
return 0 — The callout could not be stopped
return -1 — The callout was not running.
The LLRef code that was crashing in in.c depended on
Author: glebius
Date: Mon Jul 18 09:29:08 2016
New Revision: 302998
URL: https://svnweb.freebsd.org/changeset/base/302998
Log:
Revert the last commit. It must get more review and testing first.
Modified:
head/sys/kern/kern_timeout.c
Modified: head/sys/kern/kern_timeout.c
