Re: svn commit: r300824 - head/lib/libmd

2016-09-29 Thread Alan Somers
On Fri, May 27, 2016 at 1:00 AM, Ed Schouten wrote: > 2016-05-27 8:50 GMT+02:00 Conrad Meyer : >> There's nothing to support — literally ignoring the keyword is an >> acceptable implementation. So it's disappointing C++ chooses to >> reject C keywords. > > Keep in mind that C++ does not reject "s

Re: svn commit: r300824 - head/lib/libmd

2016-05-27 Thread Conrad Meyer
There's nothing to support — literally ignoring the keyword is an acceptable implementation. So it's disappointing C++ chooses to reject C keywords. My take is that C++ programs shouldn't be including sys/md5.h directly at all. That's the kernel's header. If they want to use md5, they go throug

Re: svn commit: r300824 - head/lib/libmd

2016-05-27 Thread Ed Schouten
2016-05-27 8:50 GMT+02:00 Conrad Meyer : > There's nothing to support — literally ignoring the keyword is an > acceptable implementation. So it's disappointing C++ chooses to > reject C keywords. Keep in mind that C++ does not reject "static" altogether; only in this specific context. The reason

Re: svn commit: r300824 - head/lib/libmd

2016-05-26 Thread Ed Schouten
Hi Conrad, 2016-05-27 7:31 GMT+02:00 Conrad E. Meyer : > libmd: Work around C++'s inability to understand C So C++ doesn't support using 'static' within array types, right? What I personally dislike about this specific change: - Including directly still doesn't work. - If is ever going to in

svn commit: r300824 - head/lib/libmd

2016-05-26 Thread Conrad E. Meyer
Author: cem Date: Fri May 27 05:31:14 2016 New Revision: 300824 URL: https://svnweb.freebsd.org/changeset/base/300824 Log: libmd: Work around C++'s inability to understand C Reported by: antoine@ (x265) Modified: head/lib/libmd/md5.h Modified: head/lib/libmd/md5.h =