Re: svn commit: r289405 - head/sys/ufs/ffs

2015-10-16 Thread Bruce Evans
On Fri, 16 Oct 2015, Warner Losh wrote: On Oct 16, 2015, at 2:12 AM, Hans Petter Selasky wrote: On 10/16/15 08:21, Bruce Evans wrote: In addition, making the file contiguous in LBA space doesn't improve the access times from flash devices because they have no seek time. This is not exactly

Re: svn commit: r289405 - head/sys/ufs/ffs\

2015-10-16 Thread Slawa Olhovchenkov
On Fri, Oct 16, 2015 at 03:00:50PM -0600, Warner Losh wrote: > Do not relocate extents to make them contiguous if the underlying drive > can do > deletions. Ability to do deletions is a strong indication that this > optimization will not help performance. It will only generate

Re: svn commit: r289405 - head/sys/ufs/ffs

2015-10-16 Thread Warner Losh
> On Oct 16, 2015, at 2:18 PM, Slawa Olhovchenkov wrote: > > On Fri, Oct 16, 2015 at 01:22:44PM -0600, Warner Losh wrote: > >> >>> On Oct 16, 2015, at 7:19 AM, Slawa Olhovchenkov wrote: >>> >>> On Fri, Oct 16, 2015 at 03:06:02AM +, Warner Losh wrote: >>> Author: imp Date: Fri

Re: svn commit: r289405 - head/sys/ufs/ffs

2015-10-16 Thread Slawa Olhovchenkov
On Fri, Oct 16, 2015 at 01:22:44PM -0600, Warner Losh wrote: > > > On Oct 16, 2015, at 7:19 AM, Slawa Olhovchenkov wrote: > > > > On Fri, Oct 16, 2015 at 03:06:02AM +, Warner Losh wrote: > > > >> Author: imp > >> Date: Fri Oct 16 03:06:02 2015 > >> New Revision: 289405 > >> URL: https://sv

Re: svn commit: r289405 - head/sys/ufs/ffs

2015-10-16 Thread Warner Losh
> On Oct 16, 2015, at 8:03 AM, Pedro Giffuni wrote: > > > > On 10/16/15 03:53, Bruce Evans wrote: >> On Fri, 16 Oct 2015, Hans Petter Selasky wrote: >> >>> On 10/16/15 08:21, Bruce Evans wrote: [Bruce Evans didn't write:] In addition, making the file contiguous in LBA space doesn't

Re: svn commit: r289405 - head/sys/ufs/ffs

2015-10-16 Thread Warner Losh
> On Oct 16, 2015, at 7:19 AM, Slawa Olhovchenkov wrote: > > On Fri, Oct 16, 2015 at 03:06:02AM +, Warner Losh wrote: > >> Author: imp >> Date: Fri Oct 16 03:06:02 2015 >> New Revision: 289405 >> URL: https://svnweb.freebsd.org/changeset/base/289405 >> >> Log: >> Do not relocate extents t

Re: svn commit: r289405 - head/sys/ufs/ffs

2015-10-16 Thread Warner Losh
> On Oct 16, 2015, at 2:12 AM, Hans Petter Selasky wrote: > > On 10/16/15 08:21, Bruce Evans wrote: >> In addition, making the file contiguous in LBA space doesn't >> improve the access times from flash devices because they have no seek >> time. > > Hi, > > This is not exactly true, like Bruc

Re: svn commit: r289405 - head/sys/ufs/ffs

2015-10-16 Thread Pedro Giffuni
On 10/16/15 03:53, Bruce Evans wrote: On Fri, 16 Oct 2015, Hans Petter Selasky wrote: On 10/16/15 08:21, Bruce Evans wrote: [Bruce Evans didn't write:] In addition, making the file contiguous in LBA space doesn't improve the access times from flash devices because they have no seek time.

Re: svn commit: r289405 - head/sys/ufs/ffs

2015-10-16 Thread Slawa Olhovchenkov
On Fri, Oct 16, 2015 at 03:06:02AM +, Warner Losh wrote: > Author: imp > Date: Fri Oct 16 03:06:02 2015 > New Revision: 289405 > URL: https://svnweb.freebsd.org/changeset/base/289405 > > Log: > Do not relocate extents to make them contiguous if the underlying drive can > do > deletions.

Re: svn commit: r289405 - head/sys/ufs/ffs

2015-10-16 Thread Bruce Evans
On Fri, 16 Oct 2015, Hans Petter Selasky wrote: On 10/16/15 08:21, Bruce Evans wrote: [Bruce Evans didn't write:] In addition, making the file contiguous in LBA space doesn't improve the access times from flash devices because they have no seek time. This is not exactly true, like Bruce poi

Re: svn commit: r289405 - head/sys/ufs/ffs

2015-10-16 Thread Hans Petter Selasky
On 10/16/15 08:21, Bruce Evans wrote: In addition, making the file contiguous in LBA space doesn't improve the access times from flash devices because they have no seek time. Hi, This is not exactly true, like Bruce pointed out too. Maybe there should be a check, that if the block is too sm

Re: svn commit: r289405 - head/sys/ufs/ffs

2015-10-15 Thread Bruce Evans
On Fri, 16 Oct 2015, Warner Losh wrote: Log: Do not relocate extents to make them contiguous if the underlying drive can do deletions. Ability to do deletions is a strong indication that this optimization will not help performance. It will only generate extra write traffic. These devices are

svn commit: r289405 - head/sys/ufs/ffs

2015-10-15 Thread Warner Losh
Author: imp Date: Fri Oct 16 03:06:02 2015 New Revision: 289405 URL: https://svnweb.freebsd.org/changeset/base/289405 Log: Do not relocate extents to make them contiguous if the underlying drive can do deletions. Ability to do deletions is a strong indication that this optimization will not