Re: svn commit: r286268 - head/usr.bin/wall

2015-08-04 Thread Pedro Giffuni
On 08/04/15 01:12, Bruce Evans wrote: On Tue, 4 Aug 2015, Pedro F. Giffuni wrote: Log: Revert r286144 leaving the original fix to the buffer overflow. Some developers consider the new code unnecessarily obfuscated. There was also a benign off-by-one. Discussed with:bde, vangyzen, jm

Re: svn commit: r286268 - head/usr.bin/wall

2015-08-03 Thread Bruce Evans
On Tue, 4 Aug 2015, Pedro F. Giffuni wrote: Log: Revert r286144 leaving the original fix to the buffer overflow. Some developers consider the new code unnecessarily obfuscated. There was also a benign off-by-one. Discussed with:bde, vangyzen, jmallett It is this version that is u

svn commit: r286268 - head/usr.bin/wall

2015-08-03 Thread Pedro F. Giffuni
Author: pfg Date: Tue Aug 4 02:56:31 2015 New Revision: 286268 URL: https://svnweb.freebsd.org/changeset/base/286268 Log: Revert r286144 leaving the original fix to the buffer overflow. Some developers consider the new code unnecessarily obfuscated. There was also a benign off-by-one.