Re: svn commit: r278154 - head/lib/msun/src

2015-02-04 Thread Bruce Evans
On Tue, 3 Feb 2015, Steve Kargl wrote: On Wed, Feb 04, 2015 at 04:37:14AM +1100, Bruce Evans wrote: On Tue, 3 Feb 2015, Steve Kargl wrote: -#include +#include #include +#defineFLT_LARGE FLT_MAX_EXP - FLT_MIN_EXP + FLT_MANT_DIG +... This is a lot of code and bugs (missing p

Re: svn commit: r278154 - head/lib/msun/src

2015-02-03 Thread Steve Kargl
On Wed, Feb 04, 2015 at 04:37:14AM +1100, Bruce Evans wrote: > On Tue, 3 Feb 2015, Steve Kargl wrote: > > > -#include > > +#include > > #include > > > > +#defineFLT_LARGE FLT_MAX_EXP - FLT_MIN_EXP + FLT_MANT_DIG > > +#defineFLT_SMALL FLT_MIN_EXP - FLT_MAX_EXP > > +#define

Re: svn commit: r278154 - head/lib/msun/src

2015-02-03 Thread Bruce Evans
On Tue, 3 Feb 2015, Steve Kargl wrote: On Wed, Feb 04, 2015 at 02:38:40AM +1100, Bruce Evans wrote: On Tue, 3 Feb 2015, Pedro F. Giffuni wrote: Log: Reduce confusion in scalbnl() family of functions. The changes unrelated to the bug in r277948 made the code very difficult to understand to

Re: svn commit: r278154 - head/lib/msun/src

2015-02-03 Thread Bruce Evans
On Tue, 3 Feb 2015, Pedro Giffuni wrote: On 03/02/2015 10:38 a.m., Bruce Evans wrote: Please trim quotes. [... quotes truncated] You mean, take a step backwards to something that is harder to understand. Modified: head/lib/msun/src/s_scalbln.c

Re: svn commit: r278154 - head/lib/msun/src

2015-02-03 Thread Steve Kargl
On Wed, Feb 04, 2015 at 02:38:40AM +1100, Bruce Evans wrote: > On Tue, 3 Feb 2015, Pedro F. Giffuni wrote: > > > Log: > > Reduce confusion in scalbnl() family of functions. > > > > The changes unrelated to the bug in r277948 made > > the code very difficult to understand to both > > coverity a

Re: svn commit: r278154 - head/lib/msun/src

2015-02-03 Thread Pedro Giffuni
On 03/02/2015 10:38 a.m., Bruce Evans wrote: On Tue, 3 Feb 2015, Pedro F. Giffuni wrote: Log: Reduce confusion in scalbnl() family of functions. The changes unrelated to the bug in r277948 made the code very difficult to understand to both coverity and regular humans so take a step back

Re: svn commit: r278154 - head/lib/msun/src

2015-02-03 Thread Bruce Evans
On Tue, 3 Feb 2015, Pedro F. Giffuni wrote: Log: Reduce confusion in scalbnl() family of functions. The changes unrelated to the bug in r277948 made the code very difficult to understand to both coverity and regular humans so take a step back to something that is much easier to understand

svn commit: r278154 - head/lib/msun/src

2015-02-03 Thread Pedro F. Giffuni
Author: pfg Date: Tue Feb 3 14:17:29 2015 New Revision: 278154 URL: https://svnweb.freebsd.org/changeset/base/278154 Log: Reduce confusion in scalbnl() family of functions. The changes unrelated to the bug in r277948 made the code very difficult to understand to both coverity and regul