Hey Steve,
2014-12-19 0:59 GMT+01:00 Steve Kargl :
> My only hope now is that Ed will fix the comment he inserted into
> math_private.h to properly note that the functions formerly known
> as cpack[fl] were written years before the C11 macros CMPLX[FL]
> existed.
Sure thing!
Just to make sure th
On Dec 18, 2014, at 15:59, Steve Kargl
wrote:
> My only hope now is that Ed will fix the comment he inserted into
> math_private.h to properly note that the functions formerly known
> as cpack[fl] were written years before the C11 macros CMPLX[FL]
> existed.
Instead of waiting on Ed to fix a com
On Thu, Dec 18, 2014 at 02:44:47PM -0700, Warner Losh wrote:
>
> > On Dec 17, 2014, at 2:16 PM, Steve Kargl
> > wrote:
> >
> >
> > Ed's diff is ~1000 lines and touches several files. Localizing
> > the change to math_private.h would have been a ~20 line
> > diff to a single file.
>
> Then ju
On 18 December 2014 at 13:44, Warner Losh wrote:
>
>> On Dec 17, 2014, at 2:16 PM, Steve Kargl
>> wrote:
>>
>>
>> Ed's diff is ~1000 lines and touches several files. Localizing
>> the change to math_private.h would have been a ~20 line
>> diff to a single file.
>
> Then just back his change out
> On Dec 17, 2014, at 2:16 PM, Steve Kargl
> wrote:
>
>
> Ed's diff is ~1000 lines and touches several files. Localizing
> the change to math_private.h would have been a ~20 line
> diff to a single file.
Then just back his change out, put yours in and we all win. This seems like
ample “this
On Wed, Dec 17, 2014 at 12:48:37PM -0800, Garrett Cooper wrote:
> On Dec 17, 2014, at 11:12, Steve Kargl
> wrote:
>
> > On Wed, Dec 17, 2014 at 04:30:32PM +0100, Ed Schouten wrote:
>
> ?
>
> >>> This comment isn't true! These functions pre-date C11 by years.
> >>> See r151865. These function
On Dec 17, 2014, at 11:12, Steve Kargl
wrote:
> On Wed, Dec 17, 2014 at 04:30:32PM +0100, Ed Schouten wrote:
…
>>> This comment isn't true! These functions pre-date C11 by years.
>>> See r151865. These functions were designed to deal with gcc's
>>> poorly implemented I. See the paragraph ab
On Wed, Dec 17, 2014 at 02:15:48PM -0600, Mark Linimon wrote:
> On Wed, Dec 17, 2014 at 11:12:35AM -0800, Steve Kargl wrote:
> > > I'm always afraid of statements like these, as they can be brought to
> > > the table to prevent any changes from being made. The fact that
> > > someone else (be it An
On Wed, Dec 17, 2014 at 11:12:35AM -0800, Steve Kargl wrote:
> > I'm always afraid of statements like these, as they can be brought to
> > the table to prevent any changes from being made. The fact that
> > someone else (be it Android or openlibm) uses our code should not
> > limit us as a project
On 17 December 2014 at 07:30, Ed Schouten wrote:
> Steve,
>
> 2014-12-16 17:20 GMT+01:00 Steve Kargl :
>> This seems like a lot of code churn for very little benefit.
>>
>> In particular, I know that the one person working on fixing
>> problems with FreeBSD's libm has a private repo and the openli
On Wed, Dec 17, 2014 at 04:30:32PM +0100, Ed Schouten wrote:
> Steve,
>
> 2014-12-16 17:20 GMT+01:00 Steve Kargl :
> > This seems like a lot of code churn for very little benefit.
> >
> > In particular, I know that the one person working on fixing
> > problems with FreeBSD's libm has a private rep
Steve,
2014-12-16 17:20 GMT+01:00 Steve Kargl :
> This seems like a lot of code churn for very little benefit.
>
> In particular, I know that the one person working on fixing
> problems with FreeBSD's libm has a private repo and the openlibm
> and android developers base their libm off of FreeBSD'
On Tue, Dec 16, 2014 at 09:21:57AM +, Ed Schouten wrote:
> Author: ed
> Date: Tue Dec 16 09:21:56 2014
> New Revision: 275819
> URL: https://svnweb.freebsd.org/changeset/base/275819
>
> Log:
> Rename cpack*() to CMPLX*().
>
> The C11 standard introduced a set of macros (CMPLX, CMPLXF, C
On Tue, Dec 16, 2014 at 09:21:57AM +, Ed Schouten wrote:
> Author: ed
> Date: Tue Dec 16 09:21:56 2014
> New Revision: 275819
> URL: https://svnweb.freebsd.org/changeset/base/275819
>
> Log:
> Rename cpack*() to CMPLX*().
This seems like a lot of code churn for very little benefit.
In part
Author: ed
Date: Tue Dec 16 09:21:56 2014
New Revision: 275819
URL: https://svnweb.freebsd.org/changeset/base/275819
Log:
Rename cpack*() to CMPLX*().
The C11 standard introduced a set of macros (CMPLX, CMPLXF, CMPLXL) that
can be used to construct complex numbers from a pair of real and
15 matches
Mail list logo
