Re: svn commit: r272144 - head/sbin/sysctl

2014-09-25 Thread Bruce Evans
On Thu, 25 Sep 2014, Xin Li wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 09/25/14 15:40, Mateusz Guzik wrote: On Thu, Sep 25, 2014 at 10:37:28PM +, Xin LI wrote: Author: delphij Date: Thu Sep 25 22:37:27 2014 New Revision: 272144 URL: http://svnweb.freebsd.org/changeset/base/

Re: svn commit: r272144 - head/sbin/sysctl

2014-09-25 Thread Mateusz Guzik
On Thu, Sep 25, 2014 at 05:19:42PM -0700, Xin Li wrote: > - if (newval == NULL || dflag) { > + if (newvalstr == NULL || dflag) { > if ((kind & CTLTYPE) == CTLTYPE_NODE) { > if (dflag) { > i = show_var(mib, len); > @@ -288,10

Re: svn commit: r272144 - head/sbin/sysctl

2014-09-25 Thread Xin Li
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 09/25/14 15:40, Mateusz Guzik wrote: > On Thu, Sep 25, 2014 at 10:37:28PM +, Xin LI wrote: >> Author: delphij Date: Thu Sep 25 22:37:27 2014 New Revision: >> 272144 URL: http://svnweb.freebsd.org/changeset/base/272144 >> >> Log: The strtol(3)

Re: svn commit: r272144 - head/sbin/sysctl

2014-09-25 Thread Mateusz Guzik
On Thu, Sep 25, 2014 at 10:37:28PM +, Xin LI wrote: > Author: delphij > Date: Thu Sep 25 22:37:27 2014 > New Revision: 272144 > URL: http://svnweb.freebsd.org/changeset/base/272144 > > Log: > The strtol(3) family of functions would set errno when it hits one. > Check errno and handle it as

svn commit: r272144 - head/sbin/sysctl

2014-09-25 Thread Xin LI
Author: delphij Date: Thu Sep 25 22:37:27 2014 New Revision: 272144 URL: http://svnweb.freebsd.org/changeset/base/272144 Log: The strtol(3) family of functions would set errno when it hits one. Check errno and handle it as invalid input. Obtained from:HardenedBSD Submitted by: D