Re: svn commit: r268745 - in head/usr.bin: . timeout

2014-07-22 Thread Dag-Erling Smørgrav
Mateusz Guzik writes: > Baptiste Daroussin writes: > > +static sig_atomic_t sig_chld = 0; > > +static sig_atomic_t sig_term = 0; > > +static sig_atomic_t sig_alrm = 0; > > +static sig_atomic_t sig_ign = 0; > No reason to se these explicitely to 0. They do however need to be volatile. DES -- Da

Re: svn commit: r268745 - in head/usr.bin: . timeout

2014-07-16 Thread Sergey Kandaurov
On 16 July 2014 13:55, Baptiste Daroussin wrote: > Author: bapt > Date: Wed Jul 16 09:55:36 2014 > New Revision: 268745 > URL: http://svnweb.freebsd.org/changeset/base/268745 > > Log: > New BSDL timeout(1) utility compatible with GNU timeout [...] (sorry, missed this in a previous reply) > Adde

Re: svn commit: r268745 - in head/usr.bin: . timeout

2014-07-16 Thread Sergey Kandaurov
On Wed, Jul 16, 2014 at 09:55:36AM +, Baptiste Daroussin wrote: > Author: bapt > Date: Wed Jul 16 09:55:36 2014 > New Revision: 268745 > URL: http://svnweb.freebsd.org/changeset/base/268745 > > Log: > New BSDL timeout(1) utility compatible with GNU timeout The purpose of this utility is unc

Re: svn commit: r268745 - in head/usr.bin: . timeout

2014-07-16 Thread Konstantin Belousov
On Wed, Jul 16, 2014 at 01:29:14PM +0200, Baptiste Daroussin wrote: > On Wed, Jul 16, 2014 at 12:45:12PM +0200, Mateusz Guzik wrote: > > On Wed, Jul 16, 2014 at 12:34:11PM +0200, Baptiste Daroussin wrote: > > > On Wed, Jul 16, 2014 at 12:29:08PM +0200, Mateusz Guzik wrote: > > > > On Wed, Jul 16, 2

Re: svn commit: r268745 - in head/usr.bin: . timeout

2014-07-16 Thread Konstantin Belousov
On Wed, Jul 16, 2014 at 09:55:36AM +, Baptiste Daroussin wrote: > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Is this header needed ? The headers are unordered. > +#include > +#includ

Re: svn commit: r268745 - in head/usr.bin: . timeout

2014-07-16 Thread Baptiste Daroussin
On Wed, Jul 16, 2014 at 12:45:12PM +0200, Mateusz Guzik wrote: > On Wed, Jul 16, 2014 at 12:34:11PM +0200, Baptiste Daroussin wrote: > > On Wed, Jul 16, 2014 at 12:29:08PM +0200, Mateusz Guzik wrote: > > > On Wed, Jul 16, 2014 at 09:55:36AM +, Baptiste Daroussin wrote: > > > > +static void > >

Re: svn commit: r268745 - in head/usr.bin: . timeout

2014-07-16 Thread Mateusz Guzik
On Wed, Jul 16, 2014 at 12:34:11PM +0200, Baptiste Daroussin wrote: > On Wed, Jul 16, 2014 at 12:29:08PM +0200, Mateusz Guzik wrote: > > On Wed, Jul 16, 2014 at 09:55:36AM +, Baptiste Daroussin wrote: > > > +static void > > > +usage(void) > > > +{ > > > + fprintf(stderr, "Usage: %s [--signal si

Re: svn commit: r268745 - in head/usr.bin: . timeout

2014-07-16 Thread Baptiste Daroussin
On Wed, Jul 16, 2014 at 12:29:08PM +0200, Mateusz Guzik wrote: > On Wed, Jul 16, 2014 at 09:55:36AM +, Baptiste Daroussin wrote: > > Author: bapt > > Date: Wed Jul 16 09:55:36 2014 > > New Revision: 268745 > > URL: http://svnweb.freebsd.org/changeset/base/268745 > > > > Log: > > New BSDL tim

Re: svn commit: r268745 - in head/usr.bin: . timeout

2014-07-16 Thread Baptiste Daroussin
On Wed, Jul 16, 2014 at 12:25:33PM +0200, Jan Beich wrote: > Baptiste Daroussin writes: > > > Author: bapt > > Date: Wed Jul 16 09:55:36 2014 > > New Revision: 268745 > > URL: http://svnweb.freebsd.org/changeset/base/268745 > > > > Log: > > New BSDL timeout(1) utility compatible with GNU timeou

Re: svn commit: r268745 - in head/usr.bin: . timeout

2014-07-16 Thread Mateusz Guzik
On Wed, Jul 16, 2014 at 09:55:36AM +, Baptiste Daroussin wrote: > Author: bapt > Date: Wed Jul 16 09:55:36 2014 > New Revision: 268745 > URL: http://svnweb.freebsd.org/changeset/base/268745 > > Log: > New BSDL timeout(1) utility compatible with GNU timeout > > it fully passes the GNU ti

Re: svn commit: r268745 - in head/usr.bin: . timeout

2014-07-16 Thread Jan Beich
Baptiste Daroussin writes: > Author: bapt > Date: Wed Jul 16 09:55:36 2014 > New Revision: 268745 > URL: http://svnweb.freebsd.org/changeset/base/268745 > > Log: > New BSDL timeout(1) utility compatible with GNU timeout > > it fully passes the GNU timeout regression tests, it is written in

svn commit: r268745 - in head/usr.bin: . timeout

2014-07-16 Thread Baptiste Daroussin
Author: bapt Date: Wed Jul 16 09:55:36 2014 New Revision: 268745 URL: http://svnweb.freebsd.org/changeset/base/268745 Log: New BSDL timeout(1) utility compatible with GNU timeout it fully passes the GNU timeout regression tests, it is written in a mostly portable way (only signal parsing