Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-14 Thread Alfred Perlstein
On 5/13/13 12:58 PM, Will Andrews wrote: On Sun, May 12, 2013 at 12:09 AM, Alfred Perlstein wrote: Can we just admit to ourselves that tweaks to debugging macros/printing and WITNESS are our kernel developer's "bikeshed zone" and get over the fact that people's needs may diverge and changing n

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-13 Thread Will Andrews
On Sun, May 12, 2013 at 12:09 AM, Alfred Perlstein wrote: > Can we just admit to ourselves that tweaks to debugging macros/printing > and WITNESS are our kernel developer's "bikeshed zone" and get over the > fact that people's needs may diverge and changing non-default behavior in > non-critical

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-13 Thread Will Andrews
On Sun, May 12, 2013 at 7:49 PM, John Baldwin wrote: > Also, while LK_NOWITESS works fine for lockmgr's API (it already takes a > flag > argument), having that sort of thing in our other lock APIs is messier > (they > generally do not have flags). This is why a per-thread flag seemed > simpler t

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-12 Thread John Baldwin
On Saturday, May 11, 2013 10:34:50 AM Attilio Rao wrote: > On Fri, May 10, 2013 at 9:33 PM, John Baldwin wrote: > > On Friday, May 10, 2013 2:51:20 pm Marcel Moolenaar wrote: > >> On May 10, 2013, at 9:11 AM, John Baldwin wrote: > >> > On Friday, May 10, 2013 11:46:54 am Marcel Moolenaar wrote: >

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-11 Thread Alfred Perlstein
Can we just admit to ourselves that tweaks to debugging macros/printing and WITNESS are our kernel developer's "bikeshed zone" and get over the fact that people's needs may diverge and changing non-default behavior in non-critical paths is not going to be the death of the kernel as we know it?

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-11 Thread Jeff Roberson
On Thu, 9 May 2013, Marcel Moolenaar wrote: Author: marcel Date: Thu May 9 16:28:18 2013 New Revision: 250411 URL: http://svnweb.freebsd.org/changeset/base/250411 Log: Add option WITNESS_NO_VNODE to suppress printing LORs between VNODE locks. To support this, VNODE locks are created with the

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-11 Thread Attilio Rao
On Sat, May 11, 2013 at 4:34 PM, Attilio Rao wrote: > On Fri, May 10, 2013 at 9:33 PM, John Baldwin wrote: >> On Friday, May 10, 2013 2:51:20 pm Marcel Moolenaar wrote: >>> >>> On May 10, 2013, at 9:11 AM, John Baldwin wrote: >>> >>> > On Friday, May 10, 2013 11:46:54 am Marcel Moolenaar wrote:

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-11 Thread Attilio Rao
On Fri, May 10, 2013 at 9:33 PM, John Baldwin wrote: > On Friday, May 10, 2013 2:51:20 pm Marcel Moolenaar wrote: >> >> On May 10, 2013, at 9:11 AM, John Baldwin wrote: >> >> > On Friday, May 10, 2013 11:46:54 am Marcel Moolenaar wrote: >> >>> >> >>> 2) vnode locks from a local filesystem that re

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-11 Thread Attilio Rao
On Fri, May 10, 2013 at 3:52 PM, John Baldwin wrote: > On Thursday, May 09, 2013 4:56:33 pm Marcel Moolenaar wrote: >> >> On May 9, 2013, at 9:46 AM, Attilio Rao wrote: >> >> > On Thu, May 9, 2013 at 6:28 PM, Marcel Moolenaar > wrote: >> >> Author: marcel >> >> Date: Thu May 9 16:28:18 2013 >>

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-10 Thread John Baldwin
On Friday, May 10, 2013 2:51:20 pm Marcel Moolenaar wrote: > > On May 10, 2013, at 9:11 AM, John Baldwin wrote: > > > On Friday, May 10, 2013 11:46:54 am Marcel Moolenaar wrote: > >>> > >>> 2) vnode locks from a local filesystem that report a LOR with a "devfs" > >>> vnode. Typical reports ar

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-10 Thread Marcel Moolenaar
On May 10, 2013, at 9:11 AM, John Baldwin wrote: > On Friday, May 10, 2013 11:46:54 am Marcel Moolenaar wrote: >>> >>> 2) vnode locks from a local filesystem that report a LOR with a "devfs" >>> vnode. Typical reports are either "ufs" -> "devfs" or in some cases >>> "ufs" -> "devfs" -> "ufs"

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-10 Thread Alfred Perlstein
On 5/10/13 8:46 AM, Marcel Moolenaar wrote: And all I did is to allow someone (= Juniper) to not print the LOR for this well-known and mostly ignored case that is impacting our ability to keep witness enabled. And the reason I had to do that is that this is a long-standing LOR that isn't being a

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-10 Thread John Baldwin
On Friday, May 10, 2013 11:46:54 am Marcel Moolenaar wrote: > > > > 2) vnode locks from a local filesystem that report a LOR with a "devfs" > > vnode. Typical reports are either "ufs" -> "devfs" or in some cases > > "ufs" -> "devfs" -> "ufs". As with 1), I would much rather tag the > > off

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-10 Thread Marcel Moolenaar
On May 10, 2013, at 6:52 AM, John Baldwin wrote: >>> >>> The way to fix this is to implement LK_NOWITNESS on a per-lock basis >>> into lockmgr, propagate the same concept to the vn_lock() (which >>> should be basically done automatically) and finally identify the >>> false-positive case and comm

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-10 Thread John Baldwin
On Thursday, May 09, 2013 4:56:33 pm Marcel Moolenaar wrote: > > On May 9, 2013, at 9:46 AM, Attilio Rao wrote: > > > On Thu, May 9, 2013 at 6:28 PM, Marcel Moolenaar wrote: > >> Author: marcel > >> Date: Thu May 9 16:28:18 2013 > >> New Revision: 250411 > >> URL: http://svnweb.freebsd.org/ch

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-09 Thread Alfred Perlstein
On 5/9/13 3:13 PM, Attilio Rao wrote: On Thu, May 9, 2013 at 10:56 PM, Marcel Moolenaar wrote: On May 9, 2013, at 9:46 AM, Attilio Rao wrote: On Thu, May 9, 2013 at 6:28 PM, Marcel Moolenaar wrote: Author: marcel Date: Thu May 9 16:28:18 2013 New Revision: 250411 URL: http://svnweb.freebs

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-09 Thread Attilio Rao
On Thu, May 9, 2013 at 10:56 PM, Marcel Moolenaar wrote: > > On May 9, 2013, at 9:46 AM, Attilio Rao wrote: > >> On Thu, May 9, 2013 at 6:28 PM, Marcel Moolenaar wrote: >>> Author: marcel >>> Date: Thu May 9 16:28:18 2013 >>> New Revision: 250411 >>> URL: http://svnweb.freebsd.org/changeset/bas

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-09 Thread Marcel Moolenaar
On May 9, 2013, at 9:46 AM, Attilio Rao wrote: > On Thu, May 9, 2013 at 6:28 PM, Marcel Moolenaar wrote: >> Author: marcel >> Date: Thu May 9 16:28:18 2013 >> New Revision: 250411 >> URL: http://svnweb.freebsd.org/changeset/base/250411 >> >> Log: >> Add option WITNESS_NO_VNODE to suppress pr

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-09 Thread Attilio Rao
On Thu, May 9, 2013 at 6:28 PM, Marcel Moolenaar wrote: > Author: marcel > Date: Thu May 9 16:28:18 2013 > New Revision: 250411 > URL: http://svnweb.freebsd.org/changeset/base/250411 > > Log: > Add option WITNESS_NO_VNODE to suppress printing LORs between VNODE > locks. To support this, VNODE

svn commit: r250411 - in head/sys: conf kern sys

2013-05-09 Thread Marcel Moolenaar
Author: marcel Date: Thu May 9 16:28:18 2013 New Revision: 250411 URL: http://svnweb.freebsd.org/changeset/base/250411 Log: Add option WITNESS_NO_VNODE to suppress printing LORs between VNODE locks. To support this, VNODE locks are created with the LK_IS_VNODE flag. This flag is propagated