Re: svn commit: r244154 - head/bin/ps

2012-12-17 Thread Konstantin Belousov
On Mon, Dec 17, 2012 at 02:18:35PM +0100, Pawel Jakub Dawidek wrote: > On Sat, Dec 15, 2012 at 03:13:00AM +0200, Konstantin Belousov wrote: > > On Fri, Dec 14, 2012 at 10:42:47PM +0100, Pawel Jakub Dawidek wrote: > > > In that case I'd prefer to make existing kern.pid_max sysctl read-only > > > and

Re: svn commit: r244154 - head/bin/ps

2012-12-17 Thread Pawel Jakub Dawidek
On Sat, Dec 15, 2012 at 03:13:00AM +0200, Konstantin Belousov wrote: > On Fri, Dec 14, 2012 at 10:42:47PM +0100, Pawel Jakub Dawidek wrote: > > In that case I'd prefer to make existing kern.pid_max sysctl read-only > > and make it loader tunable. I don't expect there are many users of this > > sysc

Re: svn commit: r244154 - head/bin/ps

2012-12-14 Thread Bruce Evans
On Sat, 15 Dec 2012, Konstantin Belousov wrote: On Fri, Dec 14, 2012 at 10:42:47PM +0100, Pawel Jakub Dawidek wrote: On Fri, Dec 14, 2012 at 11:52:15AM -0500, John Baldwin wrote: On Thursday, December 13, 2012 6:12:44 am Pawel Jakub Dawidek wrote: On Wed, Dec 12, 2012 at 11:06:52PM +0200, Kon

Re: svn commit: r244154 - head/bin/ps

2012-12-14 Thread Konstantin Belousov
On Fri, Dec 14, 2012 at 10:42:47PM +0100, Pawel Jakub Dawidek wrote: > On Fri, Dec 14, 2012 at 11:52:15AM -0500, John Baldwin wrote: > > On Thursday, December 13, 2012 6:12:44 am Pawel Jakub Dawidek wrote: > > > On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: > > > > On Wed, De

Re: svn commit: r244154 - head/bin/ps

2012-12-14 Thread Pawel Jakub Dawidek
On Fri, Dec 14, 2012 at 11:52:15AM -0500, John Baldwin wrote: > On Thursday, December 13, 2012 6:12:44 am Pawel Jakub Dawidek wrote: > > On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: > > > On Wed, Dec 12, 2012 at 03:45:04PM +, Pawel Jakub Dawidek wrote: > > > > Author: pj

Re: svn commit: r244154 - head/bin/ps

2012-12-14 Thread John Baldwin
On Thursday, December 13, 2012 6:12:44 am Pawel Jakub Dawidek wrote: > On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: > > On Wed, Dec 12, 2012 at 03:45:04PM +, Pawel Jakub Dawidek wrote: > > > Author: pjd > > > Date: Wed Dec 12 15:45:03 2012 > > > New Revision: 244154 > >

Re: svn commit: r244154 - head/bin/ps

2012-12-13 Thread Alfred Perlstein
On 12/13/12 8:30 PM, Eitan Adler wrote: On 13 December 2012 13:16, Konstantin Belousov wrote: On Thu, Dec 13, 2012 at 05:55:41PM +0100, Pawel Jakub Dawidek wrote: On Thu, Dec 13, 2012 at 06:12:42PM +0200, Konstantin Belousov wrote: On Thu, Dec 13, 2012 at 12:12:44PM +0100, Pawel Jakub Dawidek

Re: svn commit: r244154 - head/bin/ps

2012-12-13 Thread Eitan Adler
On 13 December 2012 13:16, Konstantin Belousov wrote: > On Thu, Dec 13, 2012 at 05:55:41PM +0100, Pawel Jakub Dawidek wrote: >> On Thu, Dec 13, 2012 at 06:12:42PM +0200, Konstantin Belousov wrote: >> > On Thu, Dec 13, 2012 at 12:12:44PM +0100, Pawel Jakub Dawidek wrote: >> > > On Wed, Dec 12, 2012

Re: svn commit: r244154 - head/bin/ps

2012-12-13 Thread Bruce Evans
On Thu, 13 Dec 2012, Pawel Jakub Dawidek wrote: On Thu, Dec 13, 2012 at 08:16:21PM +0200, Konstantin Belousov wrote: On Thu, Dec 13, 2012 at 05:55:41PM +0100, Pawel Jakub Dawidek wrote: On Thu, Dec 13, 2012 at 06:12:42PM +0200, Konstantin Belousov wrote: On Thu, Dec 13, 2012 at 12:12:44PM +01

Re: svn commit: r244154 - head/bin/ps

2012-12-13 Thread Pawel Jakub Dawidek
On Thu, Dec 13, 2012 at 08:16:21PM +0200, Konstantin Belousov wrote: > On Thu, Dec 13, 2012 at 05:55:41PM +0100, Pawel Jakub Dawidek wrote: > > On Thu, Dec 13, 2012 at 06:12:42PM +0200, Konstantin Belousov wrote: > > > On Thu, Dec 13, 2012 at 12:12:44PM +0100, Pawel Jakub Dawidek wrote: > > > > On

Re: svn commit: r244154 - head/bin/ps

2012-12-13 Thread Konstantin Belousov
On Thu, Dec 13, 2012 at 05:55:41PM +0100, Pawel Jakub Dawidek wrote: > On Thu, Dec 13, 2012 at 06:12:42PM +0200, Konstantin Belousov wrote: > > On Thu, Dec 13, 2012 at 12:12:44PM +0100, Pawel Jakub Dawidek wrote: > > > On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: > > > I saw

Re: svn commit: r244154 - head/bin/ps

2012-12-13 Thread Pawel Jakub Dawidek
On Thu, Dec 13, 2012 at 06:12:42PM +0200, Konstantin Belousov wrote: > On Thu, Dec 13, 2012 at 12:12:44PM +0100, Pawel Jakub Dawidek wrote: > > On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: > > I saw CTLFLAG_TUN on the sysctl and assumed it is read-only... > > How about defin

Re: svn commit: r244154 - head/bin/ps

2012-12-13 Thread Konstantin Belousov
On Thu, Dec 13, 2012 at 12:12:44PM +0100, Pawel Jakub Dawidek wrote: > On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: > > On Wed, Dec 12, 2012 at 03:45:04PM +, Pawel Jakub Dawidek wrote: > > > Author: pjd > > > Date: Wed Dec 12 15:45:03 2012 > > > New Revision: 244154 > >

Re: svn commit: r244154 - head/bin/ps

2012-12-13 Thread Pawel Jakub Dawidek
On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: > On Wed, Dec 12, 2012 at 03:45:04PM +, Pawel Jakub Dawidek wrote: > > Author: pjd > > Date: Wed Dec 12 15:45:03 2012 > > New Revision: 244154 > > URL: http://svnweb.freebsd.org/changeset/base/244154 > > > > Log: > > Use ke

Re: svn commit: r244154 - head/bin/ps

2012-12-12 Thread Konstantin Belousov
On Wed, Dec 12, 2012 at 03:45:04PM +, Pawel Jakub Dawidek wrote: > Author: pjd > Date: Wed Dec 12 15:45:03 2012 > New Revision: 244154 > URL: http://svnweb.freebsd.org/changeset/base/244154 > > Log: > Use kern.max_pid sysctl to obtain maximum PID number instead of using local > define. It

Re: svn commit: r244154 - head/bin/ps

2012-12-12 Thread Pawel Jakub Dawidek
On Wed, Dec 12, 2012 at 11:37:00AM -0500, Eitan Adler wrote: > On 12 December 2012 10:45, Pawel Jakub Dawidek wrote: > > > + if (sysctlbyname("kern.pid_max", &pid_max, &intsize, NULL, 0) < 0) { > > + warn("unable to read kern.pid_max"); > > Silly question, when could this fai

Re: svn commit: r244154 - head/bin/ps

2012-12-12 Thread Eitan Adler
On 12 December 2012 10:45, Pawel Jakub Dawidek wrote: > + if (sysctlbyname("kern.pid_max", &pid_max, &intsize, NULL, 0) < 0) { > + warn("unable to read kern.pid_max"); Silly question, when could this fail and not be fatal? > + pid_max = 9; Why not use PID_

svn commit: r244154 - head/bin/ps

2012-12-12 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 12 15:45:03 2012 New Revision: 244154 URL: http://svnweb.freebsd.org/changeset/base/244154 Log: Use kern.max_pid sysctl to obtain maximum PID number instead of using local define. Reviewed by: jhb Modified: head/bin/ps/ps.c Modified: head/bin/ps/ps.c ===